Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/#review59845 --- This review has been submitted with commit 988f09bb051dca0437

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/ --- (Updated June 12, 2014, 5:11 a.m.) Status -- This change has been ma

Re: Review Request 118666: Simple Cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118666/ --- (Updated June 12, 2014, 12:34 a.m.) Review request for KDE Frameworks and

Review Request 118680: Reorder Tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118680/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig

Re: Plasma 5 Beta 2 tars

On Wednesday 11 of June 2014 17:07:04 Sebastian Kügler wrote: > [CC:ing frameworks-devel, hoping for additional input] > > On Friday, June 06, 2014 23:24:50 šumski wrote: > > On Friday 06 of June 2014 21:32:48 Eric Hameleers wrote: > > > On Fri, 6 Jun 2014, ?umski wrote: > > > > On Thursday 05 of

Re: Review Request 118666: Simple Cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118666/ --- (Updated June 11, 2014, 9:20 p.m.) Review request for KDE Frameworks and

Re: Review Request 118666: Simple Cleanups

> On June 11, 2014, 2:44 p.m., Aleix Pol Gonzalez wrote: > > src/core/kconfiggroup.cpp, line 205 > > > > > > shouldn't this be translated? It's an error string, should it? > On June 11, 2014, 2:44 p.m., Aleix

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/#review59828 --- Ship it! LGTM. The licence header has some extra whitespace.

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/ --- (Updated June 11, 2014, 8:54 p.m.) Review request for KDE Frameworks and

Re: Plasma 5 Beta 2 tars

[CC:ing frameworks-devel, hoping for additional input] On Friday, June 06, 2014 23:24:50 šumski wrote: > On Friday 06 of June 2014 21:32:48 Eric Hameleers wrote: > > On Fri, 6 Jun 2014, ?umski wrote: > > > On Thursday 05 of June 2014 16:47:59 Jonathan Riddell wrote: > > >> Tars are up for Plasma 5

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

> On June 7, 2014, 12:33 a.m., Matthew Dawson wrote: > > autotests/kconfigtest.cpp, line 930 > > > > > > Similarly, can you just change the config object's locale to something > > (en seems fine here) instead of

Review Request 118667: KCrash: call setgroups(0, 0) before calling setgid()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118667/ --- Review request for KDE Frameworks. Repository: kcrash Description -

Re: Review Request 118666: Simple Cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118666/#review59803 --- src/core/kconfiggroup.cpp

Review Request 118666: Simple Cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118666/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig