Re: Review Request 118639: KCMultiDialog: Fix crash when clicking OK

2014-06-10 Thread Aurélien Gâteau
> On June 10, 2014, 10:34 p.m., David Edmundson wrote: > > Is this the cause of https://bugs.kde.org/show_bug.cgi?id=334624 ? > > > > This fix looks sensible to me. I think it is, you are better at fishing bugs from bugzilla than I am :) - Aurélien --

Re: Review Request 118639: KCMultiDialog: Fix crash when clicking OK

2014-06-10 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118639/ --- (Updated June 10, 2014, 10:45 p.m.) Review request for KDE Frameworks.

Re: Review Request 118639: KCMultiDialog: Fix crash when clicking OK

2014-06-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118639/#review59723 --- Is this the cause of https://bugs.kde.org/show_bug.cgi?id=3346

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-10 Thread Aleix Pol Gonzalez
> On June 7, 2014, 1:10 p.m., David Faure wrote: > > Very nice. > > > > The question of "why not in Qt" hasn't been answered though :) > > Aurélien Gâteau wrote: > If you think this has a chance to get in, I can propose it. I think it would be accepted. I'm at Qt Contributor Summit anyway,

Review Request 118639: KCMultiDialog: Fix crash when clicking OK

2014-06-10 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118639/ --- Review request for KDE Frameworks. Repository: kcmutils Description ---

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118630/ --- (Updated June 10, 2014, 2:32 p.m.) Status -- This change has been ma

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118630/#review59697 --- This review has been submitted with commit 7eaa20924b99e3fa92

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-10 Thread David Edmundson
> On June 10, 2014, 10:34 a.m., David Edmundson wrote: > > Wait for the Qt patch if relevant > > Sebastian Kügler wrote: > It doesn't break any more without the Qt patch, so I'd rather ship this, > and have it automatically fixed once Qt is updated. My concern is that the Qt patch doesn't

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-10 Thread Aurélien Gâteau
> On June 7, 2014, 3:10 p.m., David Faure wrote: > > Very nice. > > > > The question of "why not in Qt" hasn't been answered though :) If you think this has a chance to get in, I can propose it. - Aurélien --- This is an automatically

Re: Loading Qt 5 translations

2014-06-10 Thread Aurélien Gâteau
On Sun, Jun 8, 2014, at 15:04, Albert Astals Cid wrote: > El Dimarts, 27 de maig de 2014, a les 07:08:45, Aurélien Gâteau va > escriure: > > On Mon, May 26, 2014, at 9:41, Alexander Potashev wrote: > > > 2014-05-26 18:17 GMT+04:00 Aurélien Gâteau : > > > > Not sure where we could put this. Framewor

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-10 Thread Sebastian Kügler
> On June 10, 2014, 10:34 a.m., David Edmundson wrote: > > Wait for the Qt patch if relevant It doesn't break any more without the Qt patch, so I'd rather ship this, and have it automatically fixed once Qt is updated. - Sebastian --- T

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118630/#review59659 --- Ship it! Wait for the Qt patch if relevant - David Edmundson