Review Request 118612: Fix KDirWatch's unit tests on certain file system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118612/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: [extra-cmake-modules] modules: Revert "use the NAME_PREFIX only for the test, not for the executable"

On 07/06/14 19:29, David Faure wrote: > On Friday 06 June 2014 20:55:16 Alex Merry wrote: >> I guess this depends on the purpose of the name prefix. If it's purely >> to say "go look here in the codebase for this test", which is how it was >> used in kdelibs before the splitting, just changing the

Re: Review Request 118581: Consider Super_L and Super_R as modifiers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/#review59532 --- Ship it! Looks good to me. Can you check if we need to update

Re: kdesrc-build not honoring

On Sat, Jun 7, 2014 at 10:23 PM, David Faure wrote: > On Saturday 07 June 2014 21:40:01 Mark Gaiser wrote: >> Hi, >> >> In my kdesrc-buildrc i have: >> global >> ... >> cmake-options -DKDE4_BUILD_TESTS=TRUE -DCMAKE_BUILD_TYPE=RelWithDebInfo >> ... >> end global >> >> I use that to compile fr

Re: Review Request 118603: Remove data race on boolean by removing qRegisterMetaType call altogether.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118603/#review59524 --- This review has been submitted with commit 71bf0639694cda1ee1

Re: Review Request 118603: Remove data race on boolean by removing qRegisterMetaType call altogether.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118603/ --- (Updated June 7, 2014, 8:24 p.m.) Status -- This change has been mar

Re: kdesrc-build not honoring

On Saturday 07 June 2014 21:40:01 Mark Gaiser wrote: > Hi, > > In my kdesrc-buildrc i have: > global > ... > cmake-options -DKDE4_BUILD_TESTS=TRUE -DCMAKE_BUILD_TYPE=RelWithDebInfo > ... > end global > > I use that to compile frameworks. However, every CMakeCache.txt file gets: > CMAKE_BUIL

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

> On June 6, 2014, 10:34 p.m., David Faure wrote: > > Interestingly, I had a benchmark to compare a number of data structures for > > UDSEntry (which made me turn the Qt3 QList into the Qt4 QHash). That > > benchmark is the commented-out "newApiPerformance()" method in jobtest.cpp. > > > > I j

Re: kdesrc-build not honoring

On Sat, Jun 7, 2014 at 9:40 PM, Mark Gaiser wrote: > Hi, > > In my kdesrc-buildrc i have: > global > ... > cmake-options -DKDE4_BUILD_TESTS=TRUE -DCMAKE_BUILD_TYPE=RelWithDebInfo > ... > end global > > I use that to compile frameworks. However, every CMakeCache.txt file gets: > CMAKE_BUILD_T

kdesrc-build not honoring

Hi, In my kdesrc-buildrc i have: global ... cmake-options -DKDE4_BUILD_TESTS=TRUE -DCMAKE_BUILD_TYPE=RelWithDebInfo ... end global I use that to compile frameworks. However, every CMakeCache.txt file gets: CMAKE_BUILD_TYPE:STRING=debug So it looks like the above cmake-options line is not b

Re: [extra-cmake-modules] modules: Revert "use the NAME_PREFIX only for the test, not for the executable"

On Friday 06 June 2014 20:55:16 Alex Merry wrote: > I guess this depends on the purpose of the name prefix. If it's purely > to say "go look here in the codebase for this test", which is how it was > used in kdelibs before the splitting, just changing the test name is > fine. Yes, that was the id

Re: Review Request 118603: Remove data race on boolean by removing qRegisterMetaType call altogether.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118603/#review59515 --- Ship it! Ship It! - Kevin Ottens On June 7, 2014, 3:12 p.m

Re: Jenkins build became unstable: kcoreaddons_master_qt5 #104

On June 7, 2014 04:14:20 PM Alex Merry wrote: > On 07/06/14 01:59, Matthew Dawson wrote: > > On June 6, 2014 03:36:43 PM KDE CI System wrote: > >> See > > > > I've been trying to figure out what caused this issue, but the test passes >

Re: Jenkins build became unstable: kcoreaddons_master_qt5 #104

On 07/06/14 01:59, Matthew Dawson wrote: > On June 6, 2014 03:36:43 PM KDE CI System wrote: >> See > I've been trying to figure out what caused this issue, but the test passes > perfectly on my local systems. Is there any information o

Review Request 118603: Remove data race on boolean by removing qRegisterMetaType call altogether.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118603/ --- Review request for KDE Frameworks, Kevin Ottens, Michael Pyne, and Stephen

Re: Jenkins build became unstable: ktexteditor_master_qt5 #420

On 07/06/14 16:03, Alex Merry wrote: > On 07/06/14 15:40, David Faure wrote: >> On Saturday 07 June 2014 13:51:17 KDE CI System wrote: >>> See >> >> The following tests FAILED: >> 43 - indenttest (Timeout) >> >> Not sure what happe

Re: Review Request 118499: Put kparts into a kf5/parts subdirectory of the plugins dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118499/#review59513 --- This review has been submitted with commit 9550371692571bdf39

Re: Review Request 118499: Put kparts into a kf5/parts subdirectory of the plugins dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118499/ --- (Updated June 7, 2014, 3:04 p.m.) Status -- This change has been mar

Re: Jenkins build became unstable: ktexteditor_master_qt5 #420

On 07/06/14 15:40, David Faure wrote: > On Saturday 07 June 2014 13:51:17 KDE CI System wrote: >> See > > The following tests FAILED: >43 - indenttest (Timeout) > > Not sure what happened after PASS : IndentTest::testPascal(

Locale Name Primer

Locale Names. A quick primer on Locale Names, seeing as we've had a few issues in the last couple of days. I can't claim perfect knowledge, so feel free to point out where I am wrong :-) TL;DR: * Don't use QLocale::bcp47Name(). * Use QLocale::name(), but may need to modify the results. * You usua

Re: Jenkins build became unstable: ktexteditor_master_qt5 #420

On Saturday 07 June 2014 13:51:17 KDE CI System wrote: > See The following tests FAILED: 43 - indenttest (Timeout) Not sure what happened after PASS : IndentTest::testPascal(case6) ... -- David Faure, fa...@kde.org, http:

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

> On June 6, 2014, 10:34 p.m., David Faure wrote: > > Interestingly, I had a benchmark to compare a number of data structures for > > UDSEntry (which made me turn the Qt3 QList into the Qt4 QHash). That > > benchmark is the commented-out "newApiPerformance()" method in jobtest.cpp. > > > > I j

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

> On June 6, 2014, 10:34 p.m., David Faure wrote: > > Interestingly, I had a benchmark to compare a number of data structures for > > UDSEntry (which made me turn the Qt3 QList into the Qt4 QHash). That > > benchmark is the commented-out "newApiPerformance()" method in jobtest.cpp. > > > > I j

Jenkins build became unstable: ktexteditor_master_qt5 #420

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

> On June 6, 2014, 10:34 p.m., David Faure wrote: > > Interestingly, I had a benchmark to compare a number of data structures for > > UDSEntry (which made me turn the Qt3 QList into the Qt4 QHash). That > > benchmark is the commented-out "newApiPerformance()" method in jobtest.cpp. > > > > I j

Re: Review Request 118581: Consider Super_L and Super_R as modifiers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/#review59507 --- Ship it! Ship It! - David Faure On June 6, 2014, 12:39 a.m

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/#review59506 --- Very nice. The question of "why not in Qt" hasn't been answer

Re: Review Request 118499: Put kparts into a kf5/parts subdirectory of the plugins dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118499/#review59505 --- Ship it! Ship It! - David Faure On June 3, 2014, 4:53 p.m.

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

> On June 6, 2014, 12:21 p.m., John Layt wrote: > > src/core/kconfig.cpp, line 98 > > > > > > The bcp47Name() is a complicated beast that could add lots of other > > bits on like script to use, etc. I would stic