Re: Review Request 118490: Properly mark ServiceBrowser::isRunning as deprecated.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118490/ --- (Updated June 4, 2014, 11:56 p.m.) Review request for KDE Frameworks and

Re: Review Request 118547: Expose Formats as singleton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/#review59261 --- src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp

Re: Review Request 118547: Expose Formats as singleton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/#review59256 --- Ship it! Makes sense and looks nice! - Mark Gaiser On June

Review Request 118547: Expose Formats as singleton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118538/ --- (Updated June 4, 2014, 10:43 p.m.) Review request for KDE Frameworks and

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

> On June 4, 2014, 7:30 p.m., Marco Martin wrote: > > what is a valid use case where qml needs to know where the dialog actually > > is?(not hypothetical please) > > doing the animation on the proper direction can be tracked completely > > internally > > > > also, plasmoids should never ever d

Review Request 118546: No symlink to common/ directory for documentation common files (broken, now unused, UNIX only)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118546/ --- Review request for Documentation and KDE Frameworks. Repository: kdoctool

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

> On June 4, 2014, 7:30 p.m., Marco Martin wrote: > > what is a valid use case where qml needs to know where the dialog actually > > is?(not hypothetical please) > > doing the animation on the proper direction can be tracked completely > > internally > > > > also, plasmoids should never ever d

Re: Review Request 118270: [doc] explicitly load external entities (after CVE-2014-0191)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118270/#review59243 --- This review has been submitted with commit d4fca9ffb31a238345

Re: Review Request 118270: [doc] explicitly load external entities (after CVE-2014-0191)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118270/ --- (Updated June 4, 2014, 8:40 p.m.) Status -- This change has been mar

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

> On June 4, 2014, 7:30 p.m., Marco Martin wrote: > > what is a valid use case where qml needs to know where the dialog actually > > is?(not hypothetical please) > > doing the animation on the proper direction can be tracked completely > > internally > > > > also, plasmoids should never ever d

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118538/#review59234 --- what is a valid use case where qml needs to know where the dia

Review Request 118538: Add a property containing the real edge a dialog is shown on

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118538/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Jenkins build is back to stable : kdelibs_stable #1102

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

> On June 4, 2014, 3:38 a.m., David Faure wrote: > > autotests/kdirwatch_unittest.cpp, line 523 > > > > > > The commit log doesn't mention any changes related to > > QFileSystemWatcher, only to the FAM backend.

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/ --- (Updated June 4, 2014, 1:05 p.m.) Review request for KDE Frameworks. Ch

Jenkins build is back to stable : ktexteditor_master_qt5 #417

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118526: Provide i18nd wrappers in kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: k

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/ --- (Updated June 4, 2014, 2:43 p.m.) Review request for KDE Frameworks and C

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 4, 2014, 1:52 p.m., Christoph Feck wrote: > > src/kcolumnresizer.h, line 93 > > > > > > Does it make sense to make "= 0" the default value for the column? Sounds good to me. Just did so. - Aurélien

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 4, 2014, 1:41 p.m., Dominik Haumann wrote: > > src/kcolumnresizer.cpp, line 200 > > > > > > You can use auto here, if wanted (you can use auto much more often in > > your patch, btw.): > > > >

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 4, 2014, 12:01 p.m., David Edmundson wrote: > > src/kcolumnresizer.cpp, line 214 > > > > > > Do we really want it to be critical? > > > > Sometimes widgets are loaded dynamically, we probably d

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 4, 2014, 11:41 a.m., Dominik Haumann wrote: > > What about adding something like this to Qt ? > > Christoph Feck wrote: > First, I was thinking the same. The efforts with KF5 work was to get as > much features as possible into Qt, and only keep the stuff that isn't > accepted in

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 4, 2014, 1:52 p.m., Christoph Feck wrote: > > src/kcolumnresizer.cpp, line 182 > > > > > > What would be nice is if the widget you add is actually a GroupBox > > containing a supported layout, then it

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 4, 2014, 11:41 a.m., Dominik Haumann wrote: > > What about adding something like this to Qt ? First, I was thinking the same. The efforts with KF5 work was to get as much features as possible into Qt, and only keep the stuff that isn't accepted in our libraries. But here, I am not r

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/#review59163 --- Regarding "remove" type functions, I agree we need them. Plea

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/#review59170 --- What about adding something like this to Qt ? src/kcolumnres

Jenkins build became unstable: ktexteditor_master_qt5 #416

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/#review59145 --- +++ src/kcolumnresizer.h

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/ --- (Updated June 4, 2014, 11:52 a.m.) Review request for KDE Frameworks and

Re: Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

> On June 3, 2014, 10:12 a.m., Alex Merry wrote: > > Changing the macro name is a no-brainer. Comments below; a lot of them are > > about binary compatibility issues, and these depend on how we expect this > > macro to be used. I believe that Qt5 makes all its deprecated functions > > header-o

Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidget

Re: Review Request 118490: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

> On June 3, 2014, 10:16 a.m., Alex Merry wrote: > > src/mdnsd-servicetypebrowser.cpp, line 51 > > > > > > Interesting... any idea which monday? > > Matthew Dawson wrote: > I'm assuming that is any Monday, as

Re: Review Request 118486: Put transcript plugin in kf5 subdir and simplify search logic

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/#review59138 --- This review has been submitted with commit 8bb821a959fa71c405

Re: Review Request 118486: Put transcript plugin in kf5 subdir and simplify search logic

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/ --- (Updated June 4, 2014, 9:18 a.m.) Status -- This change has been mar

Re: Review Request 118476: Move kded module to kf5/kded subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118476/ --- (Updated June 4, 2014, 9:16 a.m.) Status -- This change has been mar

Re: Review Request 118476: Move kded module to kf5/kded subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118476/#review59137 --- This review has been submitted with commit 1a8032610353a59283

Re: Review Request 118474: Move networkstatus kded module to kf5/kded subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118474/ --- (Updated June 4, 2014, 9:15 a.m.) Status -- This change has been mar

Re: Review Request 118474: Move networkstatus kded module to kf5/kded subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118474/#review59136 --- This review has been submitted with commit eb51d7f228d8b4b611

Re: Review Request 118269: Fix crash when showing the confirmation dialog for trash/delete operations

> On June 1, 2014, 3:01 p.m., David Faure wrote: > > That makes the setWindow call (as called by konq_operations.cpp) useless, > > though. > > > > This is related to the line in jobuidelegate.cpp which says > >QWidget *widget = job() ? window() : NULL; // ### job is NULL here, most > > of

Re: Review Request 118269: Fix crash when showing the confirmation dialog for trash/delete operations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118269/ --- (Updated June 4, 2014, 8:58 a.m.) Status -- This change has been dis

Re: Is plasma-framework not in tier 3?

On Wed, Jun 4, 2014, at 1:11, Marko Käning wrote: > Hi Aurélien, > > On 04 Jun 2014, at 09:15 , Aurélien Gâteau wrote: > > The name on the landing page are based on the CMake project name: this > > cause plasma-framework to be listed as "Plasma" there. > > but why does plasma and plasma-framewor

(UNINTENDED?) installation outside the configured DATA_INSTALL_DIR (was Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts)

It turns out that there are indeed a few more KF5 framework trying to install their files in “/Library/Application Support”, here’s the full list of kf5 folders found in the install environment: --- ./frameworkintegration/local-inst/opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/framewo

Re: Is plasma-framework not in tier 3?

Hi Aurélien, On 04 Jun 2014, at 09:15 , Aurélien Gâteau wrote: > The name on the landing page are based on the CMake project name: this > cause plasma-framework to be listed as "Plasma" there. but why does plasma and plasma-framework appear as separate frameworks in the dependency graph [1]? Is

Re: Review Request 118486: Put transcript plugin in kf5 subdir and simplify search logic

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/#review59127 --- Ship it! Ship It! - David Faure On June 2, 2014, 10:03 p.m

Re: Review Request 118476: Move kded module to kf5/kded subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118476/#review59126 --- Ship it! Ship It! - David Faure On June 2, 2014, 4:39 p.m.

Re: Review Request 118474: Move networkstatus kded module to kf5/kded subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118474/#review59125 --- Ship it! Ship It! - David Faure On June 2, 2014, 4:20 p.m.

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/#review59123 --- Very good to see that it brings the FAM backend to be more in

Re: Is plasma-framework not in tier 3?

On Tue, Jun 3, 2014, at 17:04, Marko Käning wrote: > I was wondering why I couldn't find plasma-framework in tier 3 on > api.kde.org not below frameworks [1] although it is actually shown as > part of tier 3 in the dependency graph in [2] ... The name on the landing page are based on the CMake pro

Re: Re: How to port KIntSpinBox::setSuffix

On Tuesday 03 June 2014 17:59:18 David Faure wrote: > PS: Martin: meanwhile Laurent committed the class (which I reviewed) to > ktextwidgets, you can use that. Laurent CC-ed me on the commit and I already adjusted the code to use it. Thanks a lot for the fast fix. Cheers Martin signature.asc D