Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

Hi folks, there is eventually unexpected SUCCESS ... (... although I didn’t manage to patch Qt's sources to handle a non-standard path ...) ... since as a work-around I have simply copied the file tree installed by kdoctools into the KDE/CI system’s “/Library/Application Support/” folder: -

Is plasma-framework not in tier 3?

I was wondering why I couldn't find plasma-framework in tier 3 on api.kde.org not below frameworks [1] although it is actually shown as part of tier 3 in the dependency graph in [2] ... What am I missing? [1] http://api.kde.org/frameworks-api/frameworks5-apidocs/ [2] http://api.kde.org/frame

Re: Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

> On June 3, 2014, 6:12 a.m., Alex Merry wrote: > > Changing the macro name is a no-brainer. Comments below; a lot of them are > > about binary compatibility issues, and these depend on how we expect this > > macro to be used. I believe that Qt5 makes all its deprecated functions > > header-on

Re: Review Request 118490: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

> On June 3, 2014, 6:16 a.m., Alex Merry wrote: > > src/mdnsd-servicetypebrowser.cpp, line 51 > > > > > > Interesting... any idea which monday? I'm assuming that is any Monday, as that used to be the day to break

Re: Keeping CI green

On 03/06/14 17:24, Kevin Ottens wrote: > I see room for improvement in what gets evaluated when (like ability to run a > patch in jenkins as part of the review process), I'm just stuck on the term > "enforcing" there, not sure what you have in mind. Neither am I, to be honest. It just feels like

Re: How to port KIntSpinBox::setSuffix

Le mardi 3 juin 2014 19:25:54 David Faure a écrit : > On Tuesday 03 June 2014 18:10:50 Kevin Ottens wrote: > > Hello, > > > > On Tuesday 03 June 2014 17:59:18 David Faure wrote: > > > On Tuesday 03 June 2014 17:53:22 Kevin Ottens wrote: > > > > I'm not sure I get the reasoning leading to that conc

Deprecation warnings not showing on CMake 3

Hi, I am building libkdegames on KF5/Qt5 using CMake 3 but I'm not getting deprecation warnings for KDELibs4Support classes (KDialog, KFileDialog etc.). However, I get all the deprecation warnings when I use CMake 2.8. Also, functions like KGlobal::dirs() do give a warning on CMake 3. Is it some c

Re: How to port KIntSpinBox::setSuffix

On Tuesday 03 June 2014 18:10:50 Kevin Ottens wrote: > Hello, > > On Tuesday 03 June 2014 17:59:18 David Faure wrote: > > On Tuesday 03 June 2014 17:53:22 Kevin Ottens wrote: > > > I'm not sure I get the reasoning leading to that conclusion. Can't be > > > done > > > upstream in Qt? > > > > This

Review Request 118499: Put kparts into a kf5/parts subdirectory of the plugins dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118499/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Re: Keeping CI green

Hello, On Thursday 22 May 2014 21:08:05 Alex Merry wrote: > There are currently four frameworks that are yellow (for between 6 hours and > 8 days). kdelibs4support has had 3 commits (not counting those by scripty) > since it broke that have done nothing to fix the issue. > > If we claim that our

Re: How to port KIntSpinBox::setSuffix

Hello, On Tuesday 03 June 2014 17:59:18 David Faure wrote: > On Tuesday 03 June 2014 17:53:22 Kevin Ottens wrote: > > I'm not sure I get the reasoning leading to that conclusion. Can't be done > > upstream in Qt? > > This is all about calling i18n() at runtime, from within the widget (when > the

Re: Themed icons on Windows

On Monday 26 May 2014 03:44:54 Aleix Pol wrote: > An alternative can be making KGuiAddons depend on a library that, Why not in KGuiAddons itself? > on windows, registers a Q_COREAPP_STARTUP_FUNCTION function that will set up > anything that's needed. Sounds like the best course of action IMO. >

Re: How to port KIntSpinBox::setSuffix

On Tuesday 03 June 2014 17:53:22 Kevin Ottens wrote: > On Sunday 01 June 2014 10:34:07 David Faure wrote: > > On Friday 30 May 2014 07:54:45 Martin Gräßlin wrote: > > > Hi all, > > > > > > while trying to get rid of kdelibs4support I stumbled [1] over > > > KIntSpinBox::setSuffix which allows to s

Re: How to port KIntSpinBox::setSuffix

On Sunday 01 June 2014 10:34:07 David Faure wrote: > On Friday 30 May 2014 07:54:45 Martin Gräßlin wrote: > > Hi all, > > > > while trying to get rid of kdelibs4support I stumbled [1] over > > KIntSpinBox::setSuffix which allows to set a plural aware suffix. The > > recommendation is to port to QS

Re: extra-cmake-modules broken "noarch" support

On 03/06/14 13:08, Daniel Vrátil wrote: > Hi, > > I noticed that in ECM, the generated file in > /usr/share/ECM/cmake/ECMConfigVersion.cmake contains an architecture check: > > # check that the installed version has the same 32/64bit-ness as the one > which > is currently searching: > if(NOT "

Review Request 118498: Make ECM language-independent again, but make the tests use C

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118498/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 118270: [doc] explicitly load external entities (after CVE-2014-0191)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118270/ --- (Updated June 3, 2014, 3:50 p.m.) Review request for Documentation, KDE F

extra-cmake-modules broken "noarch" support

Hi, I noticed that in ECM, the generated file in /usr/share/ECM/cmake/ECMConfigVersion.cmake contains an architecture check: # check that the installed version has the same 32/64bit-ness as the one which is currently searching: if(NOT "${CMAKE_SIZEOF_VOID_P}" STREQUAL "4") math(EXPR instal

Re: Review Request 118484: Move katepart into a kf5/parts subdir of plugin dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118484/#review59068 --- This review has been submitted with commit 59190f1542bbe77da0

Re: Review Request 118484: Move katepart into a kf5/parts subdir of plugin dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118484/ --- (Updated June 3, 2014, 10:19 a.m.) Status -- This change has been ma

Re: Review Request 118486: Put transcript plugin in kf5 subdir and simplify search logic

> On June 3, 2014, 7:11 a.m., Chusslove Illich wrote: > > For KF5 I don't have anything other than tests at the moment. I should soon > > adapt some of the test programs I used earlier... > > > > Could you also check how this patch relates to the commit 06fdfea5? > > It does the opposite to th

Re: Review Request 118490: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118490/#review59066 --- Ship it! The actual changes are sensible, hence the shipit, b

Re: Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118489/#review59060 --- Changing the macro name is a no-brainer. Comments below; a lot

Re: Review Request 118486: Put transcript plugin in kf5 subdir and simplify search logic

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/#review59035 --- For KF5 I don't have anything other than tests at the moment.

Review Request 118490: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118490/ --- Review request for KDE Frameworks. Repository: kdnssd Description -