Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118489/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 118484: Move katepart into a kf5/parts subdir of plugin dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118484/#review59032 --- Ship it! If that is the way to do it in KF5, I am OK ;) Thank

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

On 3 June 2014 09:08, Marko Käning wrote: > Hi Ben, > > On 01 Jun 2014, at 23:05 , Ben Cooksley wrote: >> That is caused by the patch. It assumes you have kdoctools installed >> within the sources of kconfigwidgets. This won't work. > I see. > >> The solution in this case is to ensure that Qt is

Re: KIO directory listing - CPU slows down SSD

On Mon, Jun 2, 2014 at 11:47 PM, Frank Reininghaus wrote: > Hi, > > 2014-06-02 23:39 GMT+02:00 Frank Reininghaus: >> Hi, >> >> 2014-06-02 20:54 GMT+02:00 Mark Gaiser: >>> On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: > dolphin

Re: KIO directory listing - CPU slows down SSD

On Mon, Jun 2, 2014 at 11:39 PM, Frank Reininghaus wrote: > Hi, > > 2014-06-02 20:54 GMT+02:00 Mark Gaiser: >> On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: >>> On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: dolphin on a massive folder. In fact, those that use kio::listdir for

Review Request 118486: Put transcript plugin in kf5 subdir and simplify search logic

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n

Re: KIO directory listing - CPU slows down SSD

Hi, 2014-06-02 23:39 GMT+02:00 Frank Reininghaus: > Hi, > > 2014-06-02 20:54 GMT+02:00 Mark Gaiser: >> On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: >>> On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: dolphin on a massive folder. In fact, those that use kio::listdir for lis

Re: KIO directory listing - CPU slows down SSD

Hi, 2014-06-02 20:54 GMT+02:00 Mark Gaiser: > On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: >> On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: >>> dolphin on a massive folder. In fact, those that use kio::listdir for >>> listing folders only have interfaces that become usable when al

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/#review59018 --- The high-level logic makes sense, but I would prefer for someo

Review Request 118484: Move katepart into a kf5/parts subdir of plugin dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118484/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: kte

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

Hi Ben, On 01 Jun 2014, at 23:05 , Ben Cooksley wrote: > That is caused by the patch. It assumes you have kdoctools installed > within the sources of kconfigwidgets. This won't work. I see. > The solution in this case is to ensure that Qt is made aware of > locations other than the two hardcoded

Re: KIO directory listing - CPU slows down SSD

On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: > On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: >> On Thu, May 29, 2014 at 12:21 AM, Aaron J. Seigo >> It's just a hobby for me to optimize it to levels that match raw speed >> (without any KIO). > > meaningful speed improvements would

Re: Review Request 118479: Other time_t->QDateTime porting issues

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118479/#review59008 --- This review has been submitted with commit 0996008ed3d3c6ce00

Re: Review Request 118479: Other time_t->QDateTime porting issues

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118479/ --- (Updated June 2, 2014, 5:13 p.m.) Status -- This change has been mar

Re: Review Request 118473: reset m_request.cacheTag dates in sendQuery()

> On June 2, 2014, 4:35 p.m., David Faure wrote: > > Well spotted. > > > > Porting bug (from time_t to QDateTime) in b4d30c9fab4c. > > Marco Martin wrote: > I see that it was done also in cacheParseResponseHeader and > resetSessionSettings > should be probably fixed there too? Urgh. Y

Re: KIO directory listing - CPU slows down SSD

Hi, 2014-06-02 18:42 GMT+02:00 Aaron J. Seigo: > On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: >> dolphin on a massive folder. In fact, those that use kio::listdir for >> listing folders only have interfaces that become usable when all >> entries are fetched. > > assuming these UIs receive

Review Request 118479: Other time_t->QDateTime porting issues

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118479/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 118473: reset m_request.cacheTag dates in sendQuery()

> On June 2, 2014, 4:35 p.m., David Faure wrote: > > Well spotted. > > > > Porting bug (from time_t to QDateTime) in b4d30c9fab4c. I see that it was done also in cacheParseResponseHeader and resetSessionSettings should be probably fixed there too? - Marco ---

Re: Review Request 118472: Version the kded module files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118472/#review59002 --- This review has been submitted with commit 9a3a223f4079898580

Re: Review Request 118472: Version the kded module files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118472/ --- (Updated June 2, 2014, 4:52 p.m.) Status -- This change has been mar

Re: Review Request 118472: Version the kded module files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118472/#review59001 --- Ship it! Ship It! - David Faure On June 2, 2014, 4:04 p.m.

Re: KIO directory listing - CPU slows down SSD

On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: > On Thu, May 29, 2014 at 12:21 AM, Aaron J. Seigo It's just a hobby for me to optimize it to levels that match raw speed > (without any KIO). meaningful speed improvements would be a reason to change things. if wire compatibility can be main

Re: Review Request 118473: reset m_request.cacheTag dates in sendQuery()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118473/ --- (Updated June 2, 2014, 4:41 p.m.) Status -- This change has been mar

Re: Review Request 118473: reset m_request.cacheTag dates in sendQuery()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118473/#review59000 --- This review has been submitted with commit 7eea5dcc160d7cd670

Review Request 118476: Move kded module to kf5/kded subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118476/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 118473: reset m_request.cacheTag dates in sendQuery()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118473/#review58997 --- Ship it! Well spotted. Porting bug (from time_t to QDateTime

Review Request 118474: Move networkstatus kded module to kf5/kded subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118474/ --- Review request for KDE Frameworks. Repository: kdelibs4support Descript

Re: problems in http kioslave, where to debug?

On Monday 02 June 2014, Marco Martin wrote: > Changing filecopyJob line 388 to > m_getJob = KIO::get(m_src, Reload, HideProgressInfo /* no GUI */); > > make the download work correctly, even tough is obviously wrong, since it > always disables the caches I don't know if is the right approach, but

Review Request 118473: reset m_request.cacheTag dates in sendQuery()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118473/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 118472: Version the kded module files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118472/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: problems in http kioslave, where to debug?

On Sunday 01 June 2014, David Faure wrote: > On Sunday 01 June 2014 09:58:09 David Faure wrote: > > OK, writing this email gave me an idea for a workaround, at least. Can > > you test it? (attached). > > I pushed this fix to kio so it becomes part of beta3, tagged today. with the patch, i see tha

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118128/#review58955 --- This review has been submitted with commit 60171e82ae3f63c7af

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118128/ --- (Updated June 2, 2014, 11:44 a.m.) Status -- This change has been ma

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118234/#review58954 --- This review has been submitted with commit 6210b6bb8af128c8e9

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118234/ --- (Updated June 2, 2014, 11:44 a.m.) Status -- This change has been ma

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118234/#review58953 --- Ship it! Given the only objection so far has been that maybe

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

> On June 2, 2014, 12:48 p.m., Alex Merry wrote: > > What happens with X11 on OS/X? I suspect this is a possible setup. Is it > > one we care about? it shouldn't matter as I do hope nobody uses the xcb plugin on MacOS. - Martin --- Thi

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118234/#review58947 --- What happens with X11 on OS/X? I suspect this is a possible se

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

> On May 26, 2014, 8:11 a.m., Àlex Fiestas wrote: > > src/platformtheme/CMakeLists.txt, line 4 > > > > > > This workaround is quite important for 5.3.0 and older at least, maybe > > in those cases we should make i

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

> On May 26, 2014, 10:11 a.m., Àlex Fiestas wrote: > > src/platformtheme/CMakeLists.txt, line 4 > > > > > > This workaround is quite important for 5.3.0 and older at least, maybe > > in those cases we should make

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

> On May 26, 2014, 8:11 a.m., Àlex Fiestas wrote: > > src/platformtheme/CMakeLists.txt, line 4 > > > > > > This workaround is quite important for 5.3.0 and older at least, maybe > > in those cases we should make i

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

> On May 26, 2014, 8:11 a.m., Àlex Fiestas wrote: > > src/platformtheme/CMakeLists.txt, line 4 > > > > > > This workaround is quite important for 5.3.0 and older at least, maybe > > in those cases we should make i

Re: errors during install of documentation in kio

David Faure ha scritto: > Something's not right it seems? > > -- Up-to-date: > /d/kde/inst/kde_frameworks/share/doc/HTML/en/kioslave5/data/index.docbook > failed to create symbolic link 'share/doc/HTML/en/kioslave5/data/common': No > such file or directory Almost: the symbolic link creation is

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

> On June 1, 2014, 2:41 p.m., Mark Gaiser wrote: > > A very big +1 from me! > > > > Your change is going to - heavily - conflict with my local UDSEntry changes > > which has a different approach. In that change i'm basically just storing > > all the default fields as direct class members of UD

errors during install of documentation in kio

Something's not right it seems? -- Up-to-date: /d/kde/inst/kde_frameworks/share/doc/HTML/en/kioslave5/data/index.docbook failed to create symbolic link 'share/doc/HTML/en/kioslave5/data/common': No such file or directory -- Up-to-date: /d/kde/inst/kde_frameworks/share/doc/HTML/en/kioslave5/file