Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-30 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/ --- (Updated May 30, 2014, 11:42 p.m.) Review request for KDE Frameworks, Pla

Re: Review Request 118270: [doc] explicitly load external entities (after CVE-2014-0191)

2014-05-30 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118270/ --- (Updated May 31, 2014, 2:07 a.m.) Review request for Documentation, KDE F

Jenkins build is back to normal : kross_master_qt5 #60

2014-05-30 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118403: Use correct name in KDE4_ADD_KDEINIT_EXECUTABLE compat macro

2014-05-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118403/#review58834 --- This review has been submitted with commit b7ed0b379e83af78bd

Re: Review Request 118403: Use correct name in KDE4_ADD_KDEINIT_EXECUTABLE compat macro

2014-05-30 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118403/ --- (Updated May 30, 2014, 5:55 p.m.) Status -- This change has been mar

Build failed in Jenkins: kross_master_qt5 #59

2014-05-30 Thread KDE CI System
See Changes: [hrvoje.senjan] Make sure krossqtsplugin is really treated as plugin -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACK

Re: Review Request 118404: make sure krossqtsplugin is really treated as plugin

2014-05-30 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118404/ --- (Updated May 30, 2014, 5:53 p.m.) Status -- This change has been mar

Re: Review Request 118404: make sure krossqtsplugin is really treated as plugin

2014-05-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118404/#review58833 --- This review has been submitted with commit d47bdf3eb7550bb9e9

Review Request 118425: Improve deprecated notes in KSessionManager

2014-05-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118425/ --- Review request for KDE Frameworks. Repository: kdelibs4support Descript

Re: Review Request 118404: make sure krossqtsplugin is really treated as plugin

2014-05-30 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118404/#review58791 --- Ship it! Ship It! - Alex Merry On May 29, 2014, 4:21 p.m.,

Re: Review Request 118403: Use correct name in KDE4_ADD_KDEINIT_EXECUTABLE compat macro

2014-05-30 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118403/#review58790 --- Ship it! Ship It! - Alex Merry On May 29, 2014, 4:09 p.m.,

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Bhushan Shah
> On May 30, 2014, 4:10 p.m., Christoph Feck wrote: > > Good catch, merci! Any chance this fixes bug 330845? > > Martin Klapetek wrote: > Yup, it does. I had Eike especially test this for his comment #2 on that > bug, he says this fixes the problem :) > > Bhushan Shah wrote: > This fix

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Bhushan Shah
> On May 30, 2014, 4:10 p.m., Christoph Feck wrote: > > Good catch, merci! Any chance this fixes bug 330845? > > Martin Klapetek wrote: > Yup, it does. I had Eike especially test this for his comment #2 on that > bug, he says this fixes the problem :) This fixes bug indeed but scales up ic

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118415/ --- (Updated May 30, 2014, 10:55 a.m.) Status -- This change has been ma

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118415/#review58788 --- This review has been submitted with commit aa0035d0a69e84c053

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Martin Klapetek
> On May 30, 2014, 12:45 p.m., Aleix Pol Gonzalez wrote: > > src/kicontheme.cpp, line 480 > > > > > > The iconPath call doesn't look trivial. I don't think we want the call > > twice, put it in a variable maybe?

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Martin Klapetek
> On May 30, 2014, 12:40 p.m., Christoph Feck wrote: > > Good catch, merci! Any chance this fixes bug 330845? Yup, it does. I had Eike especially test this for his comment #2 on that bug, he says this fixes the problem :) - Martin ---

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118415/#review58782 --- src/kicontheme.cpp

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118415/#review58781 --- Ship it! Good catch, merci! Any chance this fixes bug 330845?

Review Request 118415: Fix looking up icons

2014-05-30 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118415/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconth

Re: KIO directory listing - CPU slows down SSD

2014-05-30 Thread David Faure
On Wednesday 28 May 2014 19:33:42 Aaron J. Seigo wrote: >int endPoint = ds.device()->pos(); > ds.device()->seek(savePoint); > ds << 0; > ds.device()->seek(endPoint); > ds << 1337; > ++records; This could break if QDataStream decides to buffer the changes, i.e. not flush be