Re: Review Request 118158: Always set src_dir to a not-empty value ('.')

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118158/ --- (Updated May 17, 2014, 2:27 a.m.) Review request for Documentation, KDE F

Re: Review Request 118158: Always set src_dir to a not-empty value ('.')

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118158/#review58085 --- This review has been submitted with commit 759c86400e617f1b77

Re: Review Request 118158: Always set src_dir to a not-empty value ('.')

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118158/ --- (Updated May 17, 2014, 12:28 a.m.) Status -- This change has been ma

Re: Review Request 118158: Always set src_dir to a not-empty value ('.')

> On May 16, 2014, 11:34 a.m., Alex Merry wrote: > > KF5DocToolsMacros.cmake, line 96 > > > > > > Beware CMake's automatic variable expansion! If the value of ${src_dir} > > happens to be the name of a variable t

Re: Review Request 118167: Flush xcb connection after preparing KSelectionOwner::claim

> On May 16, 2014, 1:38 p.m., Thomas Lübking wrote: > > a) main.cpp, void Application::start() > > -Xcb::sync(); > > owner->claim(m_replace, true); > > +Xcb::sync(); > > Sufficient? (though it warns about a QPA crash "later") > > > > b) Qt bug (should flush once per eventcycle) or fe

Re: Review Request 118167: Flush xcb connection after preparing KSelectionOwner::claim

> On May 16, 2014, 3:38 p.m., Thomas Lübking wrote: > > a) main.cpp, void Application::start() > > -Xcb::sync(); > > owner->claim(m_replace, true); > > +Xcb::sync(); > > Sufficient? (though it warns about a QPA crash "later") > > > > b) Qt bug (should flush once per eventcycle) or fe

Re: Review Request 118167: Flush xcb connection after preparing KSelectionOwner::claim

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118167/#review58061 --- a) main.cpp, void Application::start() -Xcb::sync(); o

Review Request 118167: Flush xcb connection after preparing KSelectionOwner::claim

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118167/ --- Review request for KDE Frameworks and kwin. Bugs: 334858 https://bugs

Re: Review Request 118162: Make sure to use the absolute file path for test files.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118162/#review58053 --- This sounds like an issue that needs to be fixed in KArchive..

Review Request 118162: Make sure to use the absolute file path for test files.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118162/ --- Review request for KDE Frameworks and kdewin. Repository: karchive Desc

Re: Review Request 118158: Always set src_dir to a not-empty value ('.')

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118158/#review58047 --- KF5DocToolsMacros.cmake

Framework Localization Policy

Hi, Finally took the time to document framework localization. You can find the documentation here: http://community.kde.org/Frameworks/Frameworks_Localization_Policy . Feedback is welcome. Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-de

Re: Review Request 118158: Always set src_dir to a not-empty value ('.')

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118158/#review58045 --- Ship it! Ship It! - Aurélien Gâteau On May 16, 2014, 1:43