Re: KFileAudioPreview

On Monday 12 May 2014 22:46:08 Alex Merry wrote: > KFileAudioPreview is currently a framework that just provides a plugin. > This plugin is specifically looked for by the KFileMetaPreview class in KIO. > > Perhaps it's too late to change this, but it seems to me that this > plugin should either be

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

> On May 12, 2014, 3:18 p.m., Kevin Ottens wrote: > > Indeed looks like something which got forgotten along the way. K4About* is > > supposed to be the porting tool, so let's have this one in even if that's > > SIC. To be clear, should I remove the deprecated ctor too, or just the deprecated

Re: KFileAudioPreview

On 12/05/14 23:18, Nicolás Alvarez wrote: > 2014-05-12 18:46 GMT-03:00 Alex Merry : >> Perhaps it's too late to change this, but it seems to me that this >> plugin should either be in KIO or kio-extras. The reason it isn't in KIO >> is that it depends on Phonon. > > KIO already depends indirectly

Re: KFileAudioPreview

2014-05-12 18:46 GMT-03:00 Alex Merry : > Perhaps it's too late to change this, but it seems to me that this > plugin should either be in KIO or kio-extras. The reason it isn't in KIO > is that it depends on Phonon. KIO already depends indirectly on KNotifications which depends on Phonon. -- Nic

Re: Review Request 117987: Always return true for alphaBlending()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117987/ --- (Updated May 12, 2014, 10:06 p.m.) Status -- This change has been ma

Re: Review Request 117987: Always return true for alphaBlending()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117987/#review57829 --- This review has been submitted with commit dea31caf16b0b2891f

KFileAudioPreview

KFileAudioPreview is currently a framework that just provides a plugin. This plugin is specifically looked for by the KFileMetaPreview class in KIO. Perhaps it's too late to change this, but it seems to me that this plugin should either be in KIO or kio-extras. The reason it isn't in KIO is that i

Re: Review Request 118084: Move sonnet plugins into kf5/sonnet subdir of plugin install dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118084/ --- (Updated May 12, 2014, 8:57 p.m.) Status -- This change has been mar

Re: Review Request 118084: Move sonnet plugins into kf5/sonnet subdir of plugin install dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118084/#review57822 --- This review has been submitted with commit 5a791ebaec4b7f709b

Re: Review Request 118083: Move theme plugins to kf5/emoticonsthemes subdir of plugins dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118083/#review57821 --- This review has been submitted with commit 609e1b29d9f1c151a7

Re: Review Request 118083: Move theme plugins to kf5/emoticonsthemes subdir of plugins dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118083/ --- (Updated May 12, 2014, 8:56 p.m.) Status -- This change has been mar

Re: Review Request 118080: Move kioslaves to the "kf5/kio" subdirectory of the plugin directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118080/#review57820 --- This review has been submitted with commit 3eb24eb2e14f62539d

Re: Review Request 118080: Move kioslaves to the "kf5/kio" subdirectory of the plugin directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118080/ --- (Updated May 12, 2014, 8:56 p.m.) Status -- This change has been mar

Re: Review Request 118081: Move metainfo ioslave to kf5/kio subdirectory of plugin install dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118081/#review57819 --- This review has been submitted with commit e5cd8497dc4313fd6e

Re: Review Request 118081: Move metainfo ioslave to kf5/kio subdirectory of plugin install dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118081/ --- (Updated May 12, 2014, 8:54 p.m.) Status -- This change has been mar

Re: Review Request 118082: Remove KUrlNavigator tests for ~ and ~username

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118082/ --- (Updated May 12, 2014, 5:39 p.m.) Status -- This change has been dis

Jenkins build is back to stable : kio_master_qt5 #220

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118104: Fix tests in kio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118104/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 118102: Use all entries from a cert attribute instead of just using the first one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118102/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 118101: fixed windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118101/ --- Review request for KDE Frameworks and kdewin. Repository: kdelibs4support

Re: Review Request 118098: Guard against empty QStringLists

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118098/#review57796 --- This review has been submitted with commit 431ef9d94246ee74ec

Re: Review Request 118098: Guard against empty QStringLists

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118098/ --- (Updated May 12, 2014, 3:42 p.m.) Status -- This change has been mar

Re: Review Request 118098: Guard against empty QStringLists

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118098/#review57793 --- Ship it! Ship It! - Kevin Ottens On May 12, 2014, 2:32 p.m

Re: Review Request 118084: Move sonnet plugins into kf5/sonnet subdir of plugin install dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118084/#review57792 --- Ship it! Ship It! - Kevin Ottens On May 11, 2014, 2:48 p.m

Re: Review Request 118083: Move theme plugins to kf5/emoticonsthemes subdir of plugins dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118083/#review57791 --- Ship it! Ship It! - Kevin Ottens On May 11, 2014, 2:11 p.m

Re: Review Request 118080: Move kioslaves to the "kf5/kio" subdirectory of the plugin directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118080/#review57790 --- Ship it! Ship It! - Kevin Ottens On May 11, 2014, 2 p.m.,

Re: Review Request 118081: Move metainfo ioslave to kf5/kio subdirectory of plugin install dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118081/#review57789 --- Ship it! Ship It! - Kevin Ottens On May 11, 2014, 2:01 p.m

Re: Review Request 118057: Use CMAKE_INSTALL_FOODIR style variables for KDEInstallDirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118057/#review57788 --- Ship it! Ship It! - Kevin Ottens On May 8, 2014, 8:48 p.m.

Re: Review Request 117695: change where dynamic replace tabs is performed

> On May 7, 2014, 1:30 p.m., Sven Brauch wrote: > > Ping, any new opinions on this? Looks good to me, but I'd rather see someone more knowledgeable with ktexteditor give the ship it. - Kevin --- This is an automatically generated e-mai

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117919/#review57786 --- Ship it! Indeed looks like something which got forgotten alon

Re: Review Request 117974: Some more KArchive examples

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117974/#review57784 --- examples/bzip2gzip/main.cpp

Re: Review Request 118096: Remove unbuilt doc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118096/ --- (Updated May 12, 2014, 3:14 p.m.) Status -- This change has been mar

Re: Review Request 118096: Remove unbuilt doc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118096/#review57783 --- This review has been submitted with commit 27142754c15fa66dcd

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

> On April 12, 2014, 10:48 a.m., Alex Merry wrote: > > This is my preferred solution, and is hopefully only a temporary one. > > However, I know David Faure doesn't like it, and (I assume) would rather > > have a generic LIBEXEC variable. > > > > My view is that libexec should be used for stu

Re: Review Request 118096: Remove unbuilt doc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118096/#review57779 --- Ship it! Ship It! - Kevin Ottens On May 12, 2014, 12:35 p.

Review Request 118098: Guard against empty QStringLists

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118098/ --- Review request for KDE Frameworks. Bugs: 334650 https://bugs.kde.org/

Re: Removing Sonnet documentation?

On Mon, May 12, 2014, at 6:00, Burkhard Lück wrote: > Am Montag, 12. Mai 2014, 05:31:40 schrieb Aurélien Gâteau: > > On Mon, May 12, 2014, at 3:26, Kevin Ottens wrote: > > > Hello, > > > > > > On Monday 12 May 2014 03:15:22 Aurélien Gâteau wrote: > > > > We can either turn Sonnet into a tier 3 mod

Re: Removing Sonnet documentation?

Am Montag, 12. Mai 2014, 05:31:40 schrieb Aurélien Gâteau: > On Mon, May 12, 2014, at 3:26, Kevin Ottens wrote: > > Hello, > > > > On Monday 12 May 2014 03:15:22 Aurélien Gâteau wrote: > > > We can either turn Sonnet into a tier 3 module, remove the documentation > > > or move it somewhere else. B

Review Request 118096: Remove unbuilt doc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118096/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Re: Removing Sonnet documentation?

On Mon, May 12, 2014, at 3:26, Kevin Ottens wrote: > Hello, > > On Monday 12 May 2014 03:15:22 Aurélien Gâteau wrote: > > We can either turn Sonnet into a tier 3 module, remove the documentation > > or move it somewhere else. Bumping Sonnet from tier 1 to tier 3 sounds > > bad to me. Since the doc

Re: Review Request 118082: Remove KUrlNavigator tests for ~ and ~username

> On May 11, 2014, 2:30 p.m., Alexander Richardson wrote: > > KUrlNavigator effectively depends on kshorturifilter and kurisearchfilter, > > wouldn't it make sense to have them with kurlnavigator? > > > > see line 972 of kurlnavigator.cpp: if > > (KUriFilter::self()->filterUri(filteredData, QS

Re: Review Request 118082: Remove KUrlNavigator tests for ~ and ~username

> On May 11, 2014, 2:30 p.m., Alexander Richardson wrote: > > KUrlNavigator effectively depends on kshorturifilter and kurisearchfilter, > > wouldn't it make sense to have them with kurlnavigator? > > > > see line 972 of kurlnavigator.cpp: if > > (KUriFilter::self()->filterUri(filteredData, QS

Re: KIO directory listing - CPU slows down SSD

On Mon, May 12, 2014 at 1:09 PM, Milian Wolff wrote: > On Monday 12 May 2014 12:34:33 Mark Gaiser wrote: >> On Mon, May 12, 2014 at 10:55 AM, David Faure wrote: >> > On Sunday 11 May 2014 21:57:58 Mark Gaiser wrote: >> >> My theoretical solution (and i really hope to get feedback on this) is >> >

Re: KIO directory listing - CPU slows down SSD

On Monday 12 May 2014 12:34:33 Mark Gaiser wrote: > On Mon, May 12, 2014 at 10:55 AM, David Faure wrote: > > On Sunday 11 May 2014 21:57:58 Mark Gaiser wrote: > >> My theoretical solution (and i really hope to get feedback on this) is > >> to introduce a worker thread in slavebase.cpp. > > > > Fi

Re: KIO directory listing - CPU slows down SSD

On Mon, May 12, 2014 at 10:55 AM, David Faure wrote: > On Sunday 11 May 2014 21:57:58 Mark Gaiser wrote: >> My theoretical solution (and i really hope to get feedback on this) is >> to introduce a worker thread in slavebase.cpp. > > First feedback: threads create complexity, so I'm very wary of us

Re: Removing Sonnet documentation?

Hello, On Monday 12 May 2014 03:15:22 Aurélien Gâteau wrote: > We can either turn Sonnet into a tier 3 module, remove the documentation > or move it somewhere else. Bumping Sonnet from tier 1 to tier 3 sounds > bad to me. Since the documentation only describes the correction dialog, > I suggest re

Removing Sonnet documentation?

Hi, While working on installing translated docbooks in frameworks, I realized Sonnet comes with some documentation, but it is not installed right now because Sonnet is tier 1 and kdoctools is tier 2. That's quite a waste of translator time. We can either turn Sonnet into a tier 3 module, remove t

Re: KIO directory listing - CPU slows down SSD

On Sunday 11 May 2014 21:57:58 Mark Gaiser wrote: > My theoretical solution (and i really hope to get feedback on this) is > to introduce a worker thread in slavebase.cpp. First feedback: threads create complexity, so I'm very wary of using them unless absolutely necessary. In any case, *if* ther

Re: Review Request 118085: adapt to ecm_add_tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118085/ --- (Updated May 12, 2014, 8:53 a.m.) Status -- This change has been mar

Re: Review Request 118085: adapt to ecm_add_tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118085/#review57749 --- This review has been submitted with commit c061b75c6fd9597877

Re: Review Request 118082: Remove KUrlNavigator tests for ~ and ~username

> On May 11, 2014, 2:30 p.m., Alexander Richardson wrote: > > KUrlNavigator effectively depends on kshorturifilter and kurisearchfilter, > > wouldn't it make sense to have them with kurlnavigator? > > > > see line 972 of kurlnavigator.cpp: if > > (KUriFilter::self()->filterUri(filteredData, QS

Re: kioclient5 crashes on exit due to ~QDBusConnectionManager

On Sunday 11 May 2014 07:10:52 Thiago Macieira wrote: > My guess is a bad order of global destruction. If your sources are > equivalent to mine, qcoreapplication.cpp:1012 is the Q_Q line. That would > mean that, somehow, QCoreApplicationPrivate::q_ptr is bad. We know > QCoreApplication itself isn'