Re: Re: Writing a Frameworks book at Randa

2014-05-03 Thread Valorie Zimmerman
I know I said On Sat, May 3, 2014 at 2:14 AM, Valorie Zimmerman wrote: > Time is short, so this is the last time I'll write. Think about what > you want in your Frameworks book and commit to making it happen. > > Valorie > > 1. https://sprints.kde.org/sprint/212 but I think we have enough peopl

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/ --- (Updated May 3, 2014, 10:45 p.m.) Review request for Build System, Extra

Re: Review Request 117967: use different syntax to run the target in question instead of an executable in the path

2014-05-03 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117967/ --- (Updated May 3, 2014, 9:58 p.m.) Status -- This change has been mark

Re: Review Request 117963: Install the English fallback for license translations, simplify the installation of language-specific files

2014-05-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117963/#review57210 --- This review has been submitted with commit bd4b94d648c1c28307

Re: Review Request 117963: Install the English fallback for license translations, simplify the installation of language-specific files

2014-05-03 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117963/ --- (Updated May 3, 2014, 4:45 p.m.) Status -- This change has been mark

Re: Review Request 117963: Install the English fallback for license translations, simplify the installation of language-specific files

2014-05-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117963/#review57211 --- This review has been submitted with commit 348521ba0624ca0d13

Re: Review Request 117963: Install the English fallback for license translations, simplify the installation of language-specific files

2014-05-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117963/#review57209 --- Ship it! Ship It! - Alex Merry On May 3, 2014, 3:47 p.m.,

Re: Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-03 Thread David Rosca
> On May 3, 2014, 4:23 p.m., Mark Gaiser wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 157 > > > > > > No default? > > The Qt docs say that "AnyFile" is the default. > > http://qt-projec

Re: Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-03 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/ --- (Updated May 3, 2014, 4:38 p.m.) Review request for KDE Frameworks. Cha

Usage of ~/.config vs ~/.config/kde.org

2014-05-03 Thread Elias Probst
Currently all KF5/Workspaces configuration files end up in ~/.config. Looking at my personal ~/.config, it seems that nearly all other applications and desktop-environments make use of a subdirectory to prevent "spamming" the toplevel directory and isolate the related config files nicely. Compare

Re: Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-03 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/#review57207 --- src/platformtheme/kdeplatformfiledialoghelper.cpp

Re: Review Request 117963: Install the English fallback for license translations, simplify the installation of language-specific files

2014-05-03 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117963/ --- (Updated May 3, 2014, 5:47 p.m.) Review request for Documentation and KDE

Re: Review Request 117963: Install the English fallback for license translations, simplify the installation of language-specific files

2014-05-03 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117963/ --- (Updated May 3, 2014, 5:47 p.m.) Review request for Documentation and KDE

Re: Review Request 117963: Install the English fallback for license translations, simplify the installation of language-specific files

2014-05-03 Thread Luigi Toscano
> On May 3, 2014, 4:51 p.m., Alex Merry wrote: > > common/CMakeLists.txt, lines 14-18 > > > > > > Is there any reason why those files wouldn't exist? If not, why the > > if(EXISTS)? > > > > Also, the ind

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Alex Merry
> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > > > > > Now the comment doesn't match the code - which is correct? > > Patrick Spendrin wrote: > The

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin
> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > > > > > Now the comment doesn't match the code - which is correct? > > Patrick Spendrin wrote: > The

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/ --- (Updated May 3, 2014, 3:35 p.m.) Review request for Build System, Extra C

Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-03 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Alex Merry
> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > > > > > Now the comment doesn't match the code - which is correct? > > Patrick Spendrin wrote: > The

Review Request 117974: Some more KArchive examples

2014-05-03 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117974/ --- Review request for KDE Frameworks. Repository: karchive Description ---

Re: Review Request 117963: Install the English fallback for license translations, simplify the installation of language-specific files

2014-05-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117963/#review57202 --- common/CMakeLists.txt

Re: Fwd: Re: [kde-doc-english] Coinstallability of docbooks from kf5 and kde4

2014-05-03 Thread Burkhard Lück
Am Dienstag, 29. April 2014, 21:15:31 schrieb Burkhard Lück: > Hi, > > forwarding this to get a "more authoritative answer". > > Even with kf5 and kdelibs4 coinstability we have already these clashes: > > kdelibs4support > /docs/kcm_ssl/index.docbook Using install subdir kcontrol5 instead of k

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/#review57201 --- Ship it! Ship It! - Patrick von Reth On May 2, 2014, 10:53

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin
> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > > > > > Now the comment doesn't match the code - which is correct? > > Patrick Spendrin wrote: > The

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick von Reth
> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > > > > > Now the comment doesn't match the code - which is correct? > > Patrick Spendrin wrote: > The

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin
> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > > > > > Now the comment doesn't match the code - which is correct? The fix here is that RUNTIME_OUTPUT_DI

Re: Review Request 117823: Add ecm_install_po_files_as_qm() function

2014-05-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117823/#review57193 --- modules/ECMPoQmTools.cmake

Re: Review Request 117823: Add ecm_install_po_files_as_qm() function

2014-05-03 Thread Alex Merry
> On May 1, 2014, 9:58 a.m., Alex Merry wrote: > > modules/ECMPoQmTools.cmake, lines 25-27 > > > > > > I wonder if it would be better to actually just have this as an extra > > argument. I mean, it's easy enough

Re: Review Request 117962: forward declare specialisation

2014-05-03 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117962/#review57188 --- Ship it! Ship It! - Alexander Richardson On May 2, 2014, 1

Re: Review Request 117961: remove several warnings on mingw

2014-05-03 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117961/#review57190 --- Ship it! Ship It! - Alexander Richardson On May 2, 2014, 1

Re: Review Request 117962: forward declare specialisation

2014-05-03 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117962/#review57184 --- Ship it! Ship It! - Patrick von Reth On May 2, 2014, 9:17

Re: Review Request 117961: remove several warnings on mingw

2014-05-03 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117961/#review57183 --- Ship it! Ship It! - Patrick von Reth On May 2, 2014, 9:16

Re: Review Request 117682: Define _DARWIN_C_SOURCE when building on Mac

2014-05-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117682/#review57182 --- Ship it! Since there's been no response from Harald, and I ca

Re: Review Request 117967: use different syntax to run the target in question instead of an executable in the path

2014-05-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117967/#review57181 --- Ship it! Ship It! - Alex Merry On May 2, 2014, 11:32 p.m.,

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/#review57180 --- kde-modules/KDECMakeSettings.cmake

Re: Re: Writing a Frameworks book at Randa

2014-05-03 Thread Valorie Zimmerman
On Thu, Apr 10, 2014 at 9:23 PM, David Narvaez wrote: > On Thu, Apr 10, 2014 at 5:02 AM, Martin Gräßlin wrote: >> we might have here a chicken-egg problem. Good API documentation would >> significantly help for writing the book. That is if the API documentation is >> good someone without deep dom