Jenkins build is back to normal : kio_master_qt5 #188

2014-05-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kio_master_qt5 #187

2014-05-01 Thread KDE CI System
See Changes: [arichardson.kde] Fix build -- [...truncated 876 lines...] [ 32%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/connection.cpp.o Building CXX object src/core/CMakeFiles/KF5KIOCore.

Build failed in Jenkins: kio_master_qt5 #186

2014-05-01 Thread KDE CI System
See Changes: [arichardson.kde] Add S_IXUSR, IRUSR, etc. definitions for Windows [arichardson.kde] Add KIOPrivate::isProcessAlive() and KIOPrivate::sendTerminateSignal() [arichardson.kde] Use QFile::symLinkTarget() instead of directly callin

Re: Review Request 117078: Allow compiling kio on windows

2014-05-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117078/#review57085 --- This review has been submitted with commit b2c25711e3a1f46a5a

Re: Review Request 117078: Allow compiling kio on windows

2014-05-01 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117078/ --- (Updated May 1, 2014, 10:51 p.m.) Status -- This change has been mar

Re: Review Request 117078: Allow compiling kio on windows

2014-05-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117078/#review57086 --- This review has been submitted with commit 728bb1146db187e9c5

Re: Review Request 117799: Clean up private slots in KCompletion

2014-05-01 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117799/ --- (Updated May 1, 2014, 9:19 p.m.) Status -- This change has been mark

Re: Review Request 117799: Clean up private slots in KCompletion

2014-05-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117799/#review57084 --- This review has been submitted with commit 210ed36c1ae1e3ce33

Review Request 117935: Also set KF5_LIBEXEC_INSTALL_DIR on Windows

2014-05-01 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117935/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Jenkins build is back to stable : kdelibs4support_master_qt5 #171

2014-05-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: git repo name in review request e-mail subject

2014-05-01 Thread Sebastian Kügler
On Wednesday, April 30, 2014 14:55:55 Jeremy Whiting wrote: > In looking at frameworks e-mail each day I find it would be much > simpler if we would all add the git repo we are submitting the review > request for in the subject. e-mail with subjects like "make > documentation match new values in co

Re: Review Request 117888: Move KCurrencyCode to kdelibs4support

2014-05-01 Thread Alex Merry
> On April 30, 2014, 12:29 p.m., Alex Merry wrote: > > Well, it looks like nothing that has been ported is using it (and barely > > anything that hasn't been ported ever used it). > > > > However, it should be marked as deprecated, and the apidocs should > > indiciate how to port away from it.

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-05-01 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117148/ --- (Updated May 1, 2014, 1:29 p.m.) Status -- This change has been mark

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-05-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117148/#review57058 --- This review has been submitted with commit 0395eeb342c9b18f80

Re: Review Request 117150: use renamed kf5_entry.desktop file

2014-05-01 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117150/#review57057 --- seems this was ported away some time ago, discarding - Jonat

Re: Review Request 117150: use renamed kf5_entry.desktop file

2014-05-01 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117150/ --- (Updated May 1, 2014, 1:24 p.m.) Status -- This change has been disc

Re: Review Request 117888: Move KCurrencyCode to kdelibs4support

2014-05-01 Thread Alex Merry
> On April 30, 2014, 12:29 p.m., Alex Merry wrote: > > Well, it looks like nothing that has been ported is using it (and barely > > anything that hasn't been ported ever used it). > > > > However, it should be marked as deprecated, and the apidocs should > > indiciate how to port away from it.

Re: Review Request 117888: Move KCurrencyCode to kdelibs4support

2014-05-01 Thread John Layt
> On April 30, 2014, 1:29 p.m., Alex Merry wrote: > > Well, it looks like nothing that has been ported is using it (and barely > > anything that hasn't been ported ever used it). > > > > However, it should be marked as deprecated, and the apidocs should > > indiciate how to port away from it.

Re: Review Request 117911: ECMGeneratePriFile: prefer KF5_INCLUDE_INSTALL_DIR

2014-05-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117911/#review57050 --- Honestly? I would rather patch (well, script patching) all the

Re: Review Request 117823: Add ecm_install_po_files_as_qm() function

2014-05-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117823/#review57049 --- modules/ECMCreateQmFromPoFiles.cmake