Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-04-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/#review56243 --- Ship it! Ship It! - David Faure On April 22, 2014, 10:03 p

Re: Review Request 117682: Define _DARWIN_C_SOURCE when building on Mac

2014-04-22 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117682/ --- (Updated April 22, 2014, 11:51 p.m.) Review request for Build System, Ext

Re: KF5 Update Meeting Minutes 2014-w17

2014-04-22 Thread Nicolás Alvarez
El martes, 22 de abril de 2014, Allen Winter escribió: > On Tuesday, April 22, 2014 03:36:28 PM Jonathan Riddell wrote: > > Chair: Riddell > > Reports this week: alexmerry, agateau, apol, mck182, PovAddictW, tosky > > Observing: markg85, MJD, notmart > > > > Announcements: > > - Sprint: Thursday

Re: KF5 Update Meeting Minutes 2014-w17

2014-04-22 Thread Allen Winter
On Tuesday, April 22, 2014 03:36:28 PM Jonathan Riddell wrote: > Chair: Riddell > Reports this week: alexmerry, agateau, apol, mck182, PovAddictW, tosky > Observing: markg85, MJD, notmart > > Announcements: > - Sprint: Thursday to Monday, in Barcelona https://sprints.kde.org/sprint/224 > notes

Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-04-22 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- (Updated April 22, 2014, 10:03 p.m.) Review request for KDE Frameworks an

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-22 Thread Sven Brauch
> On April 22, 2014, 9:13 p.m., Matthew Woehlke wrote: > > If the option to reindent pasted code is enabled, does *that* still remove > > tabs? (Seems like you'd want it too in that case...) Seems it doesn't, I'll look after that. - Sven -

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-22 Thread Matthew Woehlke
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review56220 --- If the option to reindent pasted code is enabled, does *that*

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-22 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated April 22, 2014, 9:06 p.m.) Review request for KDE Frameworks and

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-22 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated April 22, 2014, 8:56 p.m.) Review request for KDE Frameworks and

RFC: KDirechainRebuild (KDirLister, KFileItem and KDirModel)

2014-04-22 Thread Mark Gaiser
Hi, I've been asked earlier this year (during the Brno PIM sprint) to put my new classes that are intended to "replace" (or supplement) KDirLister, KFileItem and KDirModel in a wiki (or somewhere else) for the documentation. Back then the classes where nowhere near usable, but that is now slowly

Jenkins build is back to stable : ktexteditor_master_qt5 #365

2014-04-22 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117688: Do not skip a language if there is no application catalog for it

2014-04-22 Thread Aurélien Gâteau
> On April 22, 2014, 3:48 p.m., Chusslove Illich wrote: > > This language skipping was originally motivated precisely because some > > people thought it bad to have apparent partial translation of an > > application. I can't point to exact discussion, it was before "my time". > > But therefore

UPDATE: Default bugzilla asignees for frameworks

2014-04-22 Thread Martin Klapetek
Hey, so as discussed previously, I went over all the BKO frameworks products and made the default assignees for respective frameworks' bugs to be the maintainers as stated in the wiki. I've also reset the assignee on opened bugs, so the current maintainers know about those bugs. The default CC a

KF5 Update Meeting Minutes 2014-w17

2014-04-22 Thread Jonathan Riddell
Chair: Riddell Reports this week: alexmerry, agateau, apol, mck182, PovAddictW, tosky Observing: markg85, MJD, notmart Announcements: - Sprint: Thursday to Monday, in Barcelona https://sprints.kde.org/sprint/224 notes page: https://notes.kde.org/p/frameworks-sprint-2014 - Beta 2, a week on Thur

Re: Review Request 117688: Do not skip a language if there is no application catalog for it

2014-04-22 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117688/#review56183 --- This language skipping was originally motivated precisely beca

Review Request 117688: Do not skip a language if there is no application catalog for it

2014-04-22 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117688/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-22 Thread Kevin Krammer
> On April 22, 2014, 9:50 a.m., Kevin Krammer wrote: > > src/lib/util/kdelibs4migration.cpp, line 97 > > > > > > Also maybe just a personal taste, but I find it better to explicitly > > use parentheses when mixin

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-22 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/#review56172 --- src/lib/util/kdelibs4migration.cpp

Re: Review Request 117629: ECMCreateQmFromPoFiles: Plural form support

2014-04-22 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117629/ --- (Updated April 22, 2014, 9:01 a.m.) Status -- This change has been m

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/ --- (Updated April 22, 2014, 9:32 a.m.) Review request for KDE Frameworks, Iv

Re: Review Request 117629: ECMCreateQmFromPoFiles: Plural form support

2014-04-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117629/#review56169 --- This review has been submitted with commit e7ca63c7c5a94279a2

Re: Why is plasma-framework using /usr/share/kde5?

2014-04-22 Thread Daniel Vrátil
On Monday 21 of April 2014 17:32:10 you wrote: > On Tuesday 15 April 2014 18:14:36 Daniel Vrátil wrote: > > Hi, > > > > I'm wondering why Plasma Framework installs it's .desktop files to > > /usr/share/kde5 by default? It causes some confusion for packagers: > > > > No other framework is using a