Re: Review Request 117531: Remove Messages.sh in kcrash, it has no GUI strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117531/ --- (Updated April 22, 2014, 4:06 a.m.) Status -- This change has been m

Re: Remnants of monolithic kdelibs.git building

2014-04-21 16:53 GMT-03:00 Nicolás Alvarez : > 2014-03-27 13:18 GMT-03:00 Alex Merry : >> On 27/03/14 15:39, Nicolás Alvarez wrote: >>> Many frameworks' top-level CMakeLists.txt still wrap their >>> find_package calls in: >>> >>> if ("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}") >>>

Re: Review Request 117680: Fix linker errors with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117680/ --- (Updated April 22, 2014, 2:09 a.m.) Status -- This change has been m

Re: Review Request 117680: Fix linker errors with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117680/#review56155 --- This review has been submitted with commit 2db1ec127ee019e39e

Re: Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

On Friday, February 14, 2014 06:49:43 PM Harald Fernengel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115752/ > --- >

Re: Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

On Friday, February 14, 2014 06:49:43 PM Harald Fernengel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115752/ > --- >

Re: Review Request 117682: Define _DARWIN_C_SOURCE when building on Mac

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117682/#review56150 --- Fine by me, but I'd like Harald to give it the OK. - Alex Mer

Re: Review Request 117682: Define _DARWIN_C_SOURCE when building on Mac

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117682/ --- (Updated April 21, 2014, 10:05 p.m.) Review request for Build System, Ext

Review Request 117682: Define _DARWIN_C_SOURCE when building on Mac

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117682/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

> On April 21, 2014, 9:42 p.m., David Faure wrote: > > Thank you so much. This was supposed to be on my todo list, but I had > > forgotten about it. And you did it much better than I would ever have done, > > with cmake-based unittests and all :-) > > > > +1 from me, giving a chance to Alex Ne

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/ --- (Updated April 21, 2014, 9:49 p.m.) Review request for Build System, Extr

Re: Review Request 117581: Remove ECMDBusAddActivationService module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117581/ --- (Updated April 21, 2014, 9:47 p.m.) Review request for Build System, Extr

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/#review56144 --- Thank you so much. This was supposed to be on my todo list, bu

Re: Review Request 117680: Fix linker errors with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117680/#review56145 --- Ship it! I only tested with MSVC 2013, so I didn't run into t

Re: Remnants of monolithic kdelibs.git building

2014-03-27 13:18 GMT-03:00 Alex Merry : > On 27/03/14 15:39, Nicolás Alvarez wrote: >> Many frameworks' top-level CMakeLists.txt still wrap their >> find_package calls in: >> >> if ("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}") >> >> That's left over from when the frameworks had to

Jenkins build is back to stable : kwindowsystem_master_qt5 » All,LINBUILDER #46

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117677: Fix libintl discovery, especially for Mac

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117677/ --- (Updated April 21, 2014, 6:59 p.m.) Status -- This change has been m

Re: Review Request 117677: Fix libintl discovery, especially for Mac

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117677/#review56136 --- This review has been submitted with commit 001b2b231f899676f3

Jenkins build is back to normal : kdelibs4support_master_qt5 #136

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117655: Move the libgcrypt search to the backend CMakeLists.txt

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117655/#review56135 --- This review has been submitted with commit 3c8bf9b7b80731c6fb

Re: Review Request 117655: Move the libgcrypt search to the backend CMakeLists.txt

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117655/ --- (Updated April 21, 2014, 6:45 p.m.) Status -- This change has been m

Re: Review Request 117655: Move the libgcrypt search to the backend CMakeLists.txt

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117655/#review56134 --- Ship it! Ship It! - Alex Merry On April 21, 2014, 6:35 p.m

Review Request 117655: Move the libgcrypt search to the backend CMakeLists.txt

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117655/ --- Review request for KDE Frameworks. Repository: kwallet Description

Review Request 117680: Fix linker errors with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117680/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 117582: Simplify D-Bus service CMake code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117582/ --- (Updated April 21, 2014, 5:07 p.m.) Status -- This change has been m

Re: Review Request 117582: Simplify D-Bus service CMake code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117582/#review56131 --- This review has been submitted with commit 5173dbb1e2deb445f9

Re: Update your copy of extra-cmake-modules

On 21/04/14 16:26, šumski wrote: > On Friday 18 of April 2014 10:37:50 Aurélien Gâteau wrote: > ... >> I made it that way intentionally because I consider it bad to have different >> code generated depending on whether you have the framework is built from a >> release tarball or from git. >> >> I u

Re: Review Request 117582: Simplify D-Bus service CMake code

> On April 21, 2014, 4:51 p.m., David Faure wrote: > > Ah, OK. I like to make things easy and high-level to simplify maintenance, > > but OK :) In general, I agree, but my view is that this macro heads into the "dark magic" area where it's very easy to screw it up, and this seems silly for som

Re: Review Request 117582: Simplify D-Bus service CMake code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117582/#review56129 --- Ship it! Ah, OK. I like to make things easy and high-level to

Re: Review Request 117677: Fix libintl discovery, especially for Mac

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117677/#review56128 --- Ship it! Well, it seems fairly clear that we should be doing

Re: Review Request 117582: Simplify D-Bus service CMake code

> On April 21, 2014, 3:12 p.m., David Faure wrote: > > This macro was upstreamed into ECM as > > modules/ECMDBusAddActivationService.cmake, why not port the code to that? Because I want to remove that from ECM (or at least deprecate it), as I consider it pointless. All it does is obfuscate two

Re: KItemModels, Solid & KJS licenses

On Monday 07 April 2014 23:18:27 šumski wrote: > I haven't checked all files, neither in kdelibs neither in kde4support. Our > legal came with the indication about src/kssl/kssl/cert_extract.cpp. Quick > grep showed me that they are only a few files in there (in src/kssl/) with > GPL-2, and they p

Review Request 117677: Fix libintl discovery, especially for Mac

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117677/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

Re: Review Request 117676: Fix libintl discovery, especially for Mac

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117676/ --- (Updated April 21, 2014, 3:56 p.m.) Status -- This change has been d

Review Request 117676: Fix libintl discovery, especially for Mac

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117676/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

Re: Why is plasma-framework using /usr/share/kde5?

On Tuesday 15 April 2014 18:14:36 Daniel Vrátil wrote: > Hi, > > I'm wondering why Plasma Framework installs it's .desktop files to > /usr/share/kde5 by default? It causes some confusion for packagers: > > No other framework is using a namespace in /usr/share, they all install into > /usr/share/$

Re: Update your copy of extra-cmake-modules

On Friday 18 of April 2014 10:37:50 Aurélien Gâteau wrote: ... > I made it that way intentionally because I consider it bad to have different > code generated depending on whether you have the framework is built from a > release tarball or from git. > > I understand this means more build dependenc

Re: Review Request 117654: Replace range-based for loop with Qt foreach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117654/ --- (Updated April 21, 2014, 3:21 p.m.) Status -- This change has been m

Re: Review Request 117654: Replace range-based for loop with Qt foreach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117654/#review56126 --- This review has been submitted with commit 749c8a691da26b26f5

Re: Review Request 117582: Simplify D-Bus service CMake code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117582/#review56125 --- This macro was upstreamed into ECM as modules/ECMDBusAddActiv

Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/#review56124 --- src/plugin/kdbusservicestarter.cpp

Re: Review Request 117654: Replace range-based for loop with Qt foreach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117654/#review56123 --- Ship it! Ship It! - David Faure On April 20, 2014, 2:55 a.

Weekly meeting tomorrow

The weekly Frameworks meeting will be tomorrow at 14:00UTC (15:00 BST, 16:00 CEST) in #kde-devel. All welcome. Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117652: Rewrite FindLibGcrypt.cmake to not use gcrypt-config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117652/ --- (Updated April 21, 2014, 2:34 p.m.) Status -- This change has been m

Re: Review Request 117652: Rewrite FindLibGcrypt.cmake to not use gcrypt-config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117652/#review56122 --- This review has been submitted with commit 7035a9f45ee74481fa

Re: Review Request 117652: Rewrite FindLibGcrypt.cmake to not use gcrypt-config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117652/#review56118 --- Ship it! Ship It! - Alex Merry On April 21, 2014, 12:06 a.

Jenkins build became unstable: ktexteditor_master_qt5 #364

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel