Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $

2014-04-20 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117012/ --- (Updated April 21, 2014, 1:59 a.m.) Review request for KDE Frameworks and

Re: Review Request 117652: Rewrite FindLibGcrypt.cmake to not use gcrypt-config

2014-04-20 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117652/ --- (Updated April 20, 2014, 9:06 p.m.) Review request for Build System and K

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

2014-04-20 Thread Andrius da Costa Ribas
> On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: > > Until now we had no problems with the data installed to bin/../share and > > this setup would make it impossible to have multiple independent kde > > setups on one system. > > Alexander Richardson wrote: > I know. The problem is

Review Request 117658: Add a stub for ECMFindModuleHelpers to the find-modules dir

2014-04-20 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117658/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 117652: Rewrite FindLibGcrypt.cmake to not use gcrypt-config

2014-04-20 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117652/#review56080 --- I think it would be good to still use libgcrypt-config if it f

Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-04-20 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- (Updated April 20, 2014, 10:22 a.m.) Review request for KDE Frameworks an