Review Request 117619: Make ecm_setup_version interact well with CMP0048

2014-04-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-17 Thread Kevin Krammer
> On April 12, 2014, 11:12 a.m., Kevin Krammer wrote: > > I wonder if this really belongs in kdecoreaddons. I.e. it is only relevant > > for KDE applications porting, right? > > IMHO this would fit best in an explicit porting framework > > David Faure wrote: > I don't want to put this in kd

Review Request 117617: New syntax for ecm_install_icons()

2014-04-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117617/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-17 Thread David Faure
> On April 12, 2014, 11:12 a.m., Kevin Krammer wrote: > > I wonder if this really belongs in kdecoreaddons. I.e. it is only relevant > > for KDE applications porting, right? > > IMHO this would fit best in an explicit porting framework > > David Faure wrote: > I don't want to put this in kd

Re: Auto-restarting of DBus Services

2014-04-17 Thread David Faure
On Wednesday 09 April 2014 19:11:03 Martin Gräßlin wrote: > Hi all, > > kglobalacceld has the following piece of code: > > // Restart on a crash > KCrash::setFlags(KCrash::AutoRestart); > > Now I'm wondering whether this is needed at all. After all it's a DBus > service and should get auto-resta

Re: Review Request 117599: Improve tests

2014-04-17 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117599/ --- (Updated April 17, 2014, 4:27 p.m.) Status -- This change has been m

Re: Review Request 117599: Improve tests

2014-04-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117599/#review55972 --- This review has been submitted with commit d488420dcbf22418da

Re: docbook issues in workspace repos

2014-04-17 Thread Aleix Pol
On Mon, Apr 14, 2014 at 12:57 PM, Burkhard Lück wrote: > Hi, > > I found a lot of docbook issues in many workspace repos, i. e. code but no > corresponding docbook in a repo and vice versa: > > kde-cli-tools: > mv plasma-desktop/doc/kcontrol/filetypes/ > kde-cli-tools/doc/kcontrol/filetypes/ > A

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #45

2014-04-17 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel