Re: Review Request 117599: Improve tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117599/#review55922 --- Ship it! Looks good, interesting work towards a more unified

Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/#review55921 --- src/plugin/kdbusservicestarter.cpp

Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Jenkins build became unstable: kdelibs_stable #1063

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117602: Remove more UPnP stuff

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117602/ --- Review request for KDE Frameworks and Àlex Fiestas. Repository: solid D

Hitting assertion in kio-trash (KF5KIOCore)

Hey, While running unit tests from kdevplatform I hit the following assert in trash/trashimpl.cpp (from workspace/kio-extras) Output of the unit test (which attempts to trash some folders): trying to create "/home/krf/.local/share/Trash/info/.trashinfo" trying to create "/home/krf/.local/shar

Re: Update your copy of extra-cmake-modules

On Wednesday 16 of April 2014 07:36:57 Aurélien Gâteau wrote: > Hi, > > I just pushed some changes to frameworks using Qt for translations which > requires a recent version of extra-cmake-modules (you need to have > 071581a3f899c881c9938efd082fd32589822b45). If you get build failures > complaining

Re: Review Request 117600: Allow ecm_create_qm_loader() to be passed the _SRCS variable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117600/ --- (Updated April 16, 2014, 4:52 p.m.) Status -- This change has been m

Review Request 117599: Improve tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117599/ --- Review request for KDE Frameworks. Repository: plasma-framework Descrip

Re: Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

> On April 16, 2014, 4:50 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 9bbdd1615b484c229657fd0896b2dbebdea9988d by Alex Merry to branch master. Oops, wrong RR number. - Alex --- This is an automatically g

Re: Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117475/#review55897 --- This review has been submitted with commit 9bbdd1615b484c2296

Re: Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117475/ --- (Updated April 16, 2014, 4:50 p.m.) Status -- This change has been m

Re: Review Request 117080: cleanup KDirModelTest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117080/ --- (Updated April 16, 2014, 6:47 p.m.) Status -- This change has been d

Re: Review Request 117376: fix kded build on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117376/#review55895 --- This review has been submitted with commit 3015d1dc2525c529f9

Re: Review Request 117376: fix kded build on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117376/ --- (Updated April 16, 2014, 4:46 p.m.) Status -- This change has been m

Re: Review Request 117600: Allow ecm_create_qm_loader() to be passed the _SRCS variable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117600/#review55894 --- Ship it! Ship It! - Aurélien Gâteau On April 16, 2014, 6:3

Review Request 117600: Allow ecm_create_qm_loader() to be passed the _SRCS variable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117600/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

Re: Review Request 117596: ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117596/ --- (Updated April 16, 2014, 3:54 p.m.) Status -- This change has been m

Re: Review Request 117596: ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117596/#review55888 --- This review has been submitted with commit f017671e5543667a69

Update your copy of extra-cmake-modules

Hi, I just pushed some changes to frameworks using Qt for translations which requires a recent version of extra-cmake-modules (you need to have 071581a3f899c881c9938efd082fd32589822b45). If you get build failures complaining about an unknown "ecm_create_qm_loader", then you need to update. Auréli

Jenkins build became unstable: kwindowsystem_master_qt5 » All,LINBUILDER #44

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117596: ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117596/#review55882 --- Ship it! Ship It! - Aurélien Gâteau On April 16, 2014, 3:4

Re: Review Request 117565: Expose the quit slot on KDBusService-enabled applications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117565/#review55881 --- This review has been submitted with commit 29e485f793ef818c83

Re: Review Request 117565: Expose the quit slot on KDBusService-enabled applications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117565/ --- (Updated April 16, 2014, 2:28 p.m.) Status -- This change has been m

Re: Review Request 117565: Expose the quit slot on KDBusService-enabled applications

> On April 15, 2014, 1:43 p.m., Àlex Fiestas wrote: > > Not sure if exporting all Slots is what we want, but I think we do want to > > have Quit exposed in dbus. there is only one slot, and we can't really change QCoreApplication at this point. - David -

Re: Review Request 117565: Expose the quit slot on KDBusService-enabled applications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117565/#review55880 --- Ship it! Ship It! - David Edmundson On April 14, 2014, 4:1

Review Request 117596: ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117596/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

Review Request 117593: ECMGeneratePriFile: Allow lib and include install dirs to be overridden

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117593/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and D

Review Request 117585: ECMFindModuleHelpers: set traditional variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117585/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Review Request 117583: Remove use of ecm_dbus_add_activation_service()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117583/ --- Review request for KDE Frameworks. Repository: kwallet Description

Review Request 117582: Simplify D-Bus service CMake code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117582/ --- Review request for KDE Frameworks. Repository: kded Description ---

Review Request 117581: Deprecate ecm_dbus_add_activation_service()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117581/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 117560: ECMCreateQmFromPoFiles: adjust API to make it usable from within trunk/l10n-kf5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117560/#review55845 --- This review has been submitted with commit 071581a3f899c881c9

Re: Review Request 117560: ECMCreateQmFromPoFiles: adjust API to make it usable from within trunk/l10n-kf5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117560/ --- (Updated April 16, 2014, 8:28 a.m.) Status -- This change has been m