Jenkins build is back to stable : kwindowsystem_master_qt5 » All,LINBUILDER #43

2014-04-14 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117495: Fix doc of KWindowInfo::clientMachine()

2014-04-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117495/#review55790 --- This review has been submitted with commit 8914ed8b75ec999edb

Re: Review Request 117495: Fix doc of KWindowInfo::clientMachine()

2014-04-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117495/ --- (Updated April 15, 2014, 5:56 a.m.) Status -- This change has been m

Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

2014-04-14 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117012/#review55788 --- I've been short of time these days, I'll update the patch by n

Re: Review Request 117125: start_kdeinit: Use capabilities instead of SUID

2014-04-14 Thread Hrvoje Senjan
> On April 11, 2014, 4:46 p.m., Commit Hook wrote: > > This review has been submitted with commit > > e898d13b430692e775060d49342181192e122fdf by Hrvoje Senjan to branch master. > > Hrvoje Senjan wrote: > i've reverted the commit now. capabilities break LD_LIBRARY_PATH, so this > is a no-g

Re: Review Request 117532: Remove rlogin docbook

2014-04-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117532/#review55774 --- This review has been submitted with commit bdc2d142c1ca0de7b2

Re: Review Request 117532: Remove rlogin docbook

2014-04-14 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117532/ --- (Updated April 14, 2014, 7:44 p.m.) Status -- This change has been m

Review Request 117565: Expose the quit slot on KDBusService-enabled applications

2014-04-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117565/ --- Review request for KDE Frameworks and Plasma. Repository: kdbusaddons D

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-14 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/ --- (Updated April 14, 2014, 4:04 p.m.) Review request for KDE Frameworks, Da

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-14 Thread Kevin Krammer
> On April 12, 2014, 11:12 a.m., Kevin Krammer wrote: > > I wonder if this really belongs in kdecoreaddons. I.e. it is only relevant > > for KDE applications porting, right? > > IMHO this would fit best in an explicit porting framework > > David Faure wrote: > I don't want to put this in kd

Re: Review Request 117489: Remove the old tutorial

2014-04-14 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117489/ --- (Updated April 14, 2014, 3:08 p.m.) Status -- This change has been m

Re: Review Request 117488: Improve Kiosk documentation

2014-04-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117488/#review55755 --- This review has been submitted with commit c5f1a84ffe6c7e502c

Re: Review Request 117490: Improve FindEGL.cmake

2014-04-14 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117490/ --- (Updated April 14, 2014, 3:14 p.m.) Status -- This change has been m

Re: Review Request 117490: Improve FindEGL.cmake

2014-04-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117490/#review55758 --- This review has been submitted with commit aeee805993a1bf5ac1

Re: Review Request 117154: Simplify the plugin lookup code

2014-04-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117154/#review55756 --- This review has been submitted with commit c6e78e17e0a3d00166

Re: Review Request 117489: Remove the old tutorial

2014-04-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117489/#review55757 --- This review has been submitted with commit ff4cf19b6bc42723e7

Re: Review Request 117154: Simplify the plugin lookup code

2014-04-14 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117154/ --- (Updated April 14, 2014, 3:07 p.m.) Status -- This change has been m

Re: Review Request 117488: Improve Kiosk documentation

2014-04-14 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117488/ --- (Updated April 14, 2014, 3:06 p.m.) Status -- This change has been m

Re: Review Request 117487: Add Kiosk documentation

2014-04-14 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117487/ --- (Updated April 14, 2014, 3:05 p.m.) Status -- This change has been m

Re: Review Request 117487: Add Kiosk documentation

2014-04-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117487/#review55753 --- This review has been submitted with commit 6c94b5bc2475e8734e

Re: Review Request 117485: Add note about Kiosk to docs

2014-04-14 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117485/ --- (Updated April 14, 2014, 3:04 p.m.) Status -- This change has been m

Re: Review Request 117485: Add note about Kiosk to docs

2014-04-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117485/#review55752 --- This review has been submitted with commit 8031c1322fca6cb43b

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-14 Thread Kevin Ottens
> On April 12, 2014, 11:12 a.m., Kevin Krammer wrote: > > I wonder if this really belongs in kdecoreaddons. I.e. it is only relevant > > for KDE applications porting, right? > > IMHO this would fit best in an explicit porting framework > > David Faure wrote: > I don't want to put this in kd

Re: Review Request 117532: Remove rlogin docbook

2014-04-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117532/#review55751 --- Ship it! Ship It! - Kevin Ottens On April 13, 2014, 9:22 a

Re: Review Request 117490: Improve FindEGL.cmake

2014-04-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117490/#review55749 --- Ship it! Looks good to me too. +1 - Aleix Pol Gonzalez On

Re: Review Request 117490: Improve FindEGL.cmake

2014-04-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117490/#review55748 --- Looks good to me, but I'd rather have someone else look at it.

Re: Review Request 117495: Fix doc of KWindowInfo::clientMachine()

2014-04-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117495/#review55746 --- Ship it! Ship It! - Kevin Ottens On April 11, 2014, 5:52 a

Re: Review Request 117489: Remove the old tutorial

2014-04-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117489/#review55745 --- Ship it! Ship It! - Kevin Ottens On April 10, 2014, 5:22 p

Re: Review Request 117488: Improve Kiosk documentation

2014-04-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117488/#review55744 --- Ship it! Ship It! - Kevin Ottens On April 10, 2014, 4:28 p

Re: Review Request 117487: Add Kiosk documentation

2014-04-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117487/#review55743 --- Ship it! Ship It! - Kevin Ottens On April 10, 2014, 4:28 p

Re: Review Request 117485: Add note about Kiosk to docs

2014-04-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117485/#review55742 --- Ship it! Ship It! - Kevin Ottens On April 10, 2014, 4:28 p

Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

2014-04-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117012/#review55741 --- Any news about that patch? - Kevin Ottens On March 24, 2014

Re: Review Request 117154: Simplify the plugin lookup code

2014-04-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117154/#review55739 --- Ship it! 2 weeks without reaction so I'll give it a shot. Not

Re: Review Request 115977: RFC: Install KArchive as Mac OS X Framework

2014-04-14 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115977/ --- (Updated April 14, 2014, 2:47 p.m.) Status -- This change has been d

Re: Review Request 117435: Import KDirSelectDialog + use it if QFileDialog requests dirs only

2014-04-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117435/#review55731 --- This review has been submitted with commit 3af23b3f8de4ba9e70

Re: Review Request 117435: Import KDirSelectDialog + use it if QFileDialog requests dirs only

2014-04-14 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117435/ --- (Updated April 14, 2014, 1:30 p.m.) Status -- This change has been m

Re: Review Request 117435: Import KDirSelectDialog + use it if QFileDialog requests dirs only

2014-04-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117435/#review55729 --- Ship it! Looks good, solve the pending issue before commit pl

Re: Review Request 117560: ECMCreateQmFromPoFiles: adjust API to make it usable from within trunk/l10n-kf5

2014-04-14 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117560/ --- (Updated April 14, 2014, 3:18 p.m.) Review request for Build System, Extr

Review Request 117560: ECMCreateQmFromPoFiles: adjust API to make it usable from within trunk-kf5

2014-04-14 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117560/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 117435: Import KDirSelectDialog + use it if QFileDialog requests dirs only

2014-04-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117435/#review55724 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 8, 2014, 4

Re: Review Request 117435: Import KDirSelectDialog + use it if QFileDialog requests dirs only

2014-04-14 Thread Martin Klapetek
> On April 14, 2014, 2:53 p.m., Aleix Pol Gonzalez wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 168 > > > > > > Don't you need to set a title or anything like that? Maybe we can set > > the

Re: Review Request 117435: Import KDirSelectDialog + use it if QFileDialog requests dirs only

2014-04-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117435/#review55716 --- src/platformtheme/kdeplatformfiledialoghelper.cpp

Re: Review Request 117435: Import KDirSelectDialog + use it if QFileDialog requests dirs only

2014-04-14 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117435/#review55714 --- Ping - Martin Klapetek On April 8, 2014, 6:14 p.m., Martin

Re: Review Request 117333: Remove Solid::Networking usage from KIO

2014-04-14 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117333/ --- (Updated April 14, 2014, 12:18 p.m.) Status -- This change has been

Re: Review Request 117333: Remove Solid::Networking usage from KIO

2014-04-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117333/#review55706 --- This review has been submitted with commit e19cf921755e7d8764

docbook issues in workspace repos

2014-04-14 Thread Burkhard Lück
Hi, I found a lot of docbook issues in many workspace repos, i. e. code but no corresponding docbook in a repo and vice versa: kde-cli-tools: mv plasma-desktop/doc/kcontrol/filetypes/ kde-cli-tools/doc/kcontrol/filetypes/ khelpcenter: mv doc/* doc/khelpcenter mv kde-runtime/doc/[onlinehelp|fund

Re: Missing kcm_ssl docbook in frameworks/kdelibs4support

2014-04-14 Thread Burkhard Lück
Am Sonntag, 13. April 2014, 12:32:09 schrieb Burkhard Lück: > XDocPath/Docbook check for repository frameworks/kdelibs4support > *.desktop/*.protocol files with X-DocPath entry: > /src/kssl/kcm/kcm_ssl.desktop X-DocPath=kcontrol/kcm_ssl/index.html > Docbook files > /docs/kf5-config/man-kf5-conf