Review Request 117529: Remove unused GNU entities

2014-04-12 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117529/ --- Review request for Documentation and KDE Frameworks. Repository: kdoctool

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-12 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/#review5 --- I agree that KCoreAddons is probably the best existing framewo

Re: Review Request 117330: Update "documentation not found" docbook

2014-04-12 Thread Luigi Toscano
> On April 12, 2014, 9:30 p.m., Burkhard Lück wrote: > > > Builds and installs, although I can't get khelpcenter to display it > > > (tried `khelpcenter help:blah`, > > > but that just displays the string "There is no documentation available > > > for /blah."). > > > > Of course "khelpcenter

Re: Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

2014-04-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117475/#review55539 --- We might not install such desktop files anymore, but I don't u

Re: Review Request 117330: Update "documentation not found" docbook

2014-04-12 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117330/#review55538 --- > Builds and installs, although I can't get khelpcenter to dis

Re: Review Request 117330: Update "documentation not found" docbook

2014-04-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117330/ --- (Updated April 12, 2014, 6:41 p.m.) Review request for KDE Frameworks, Da

Re: Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

2014-04-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117475/ --- (Updated April 12, 2014, 6:39 p.m.) Review request for KDE Frameworks and

Re: Postfixing .po that come from Qt::tr() with a _qt.po

2014-04-12 Thread Albert Astals Cid
El Divendres, 11 d'abril de 2014, a les 01:36:12, Aurélien Gâteau va escriure: > On Thu, Apr 10, 2014, at 14:17, Albert Astals Cid wrote: > > Hi, do you think it makes sense to use that postfix? > > > > We are using this currently for stuff like marble and trojita so our > > translators know they

Re: Re: Writing a Frameworks book at Randa

2014-04-12 Thread David Narvaez
On Thu, Apr 10, 2014 at 5:02 AM, Martin Gräßlin wrote: > we might have here a chicken-egg problem. Good API documentation would > significantly help for writing the book. That is if the API documentation is > good someone without deep domain knowledge will be able to write a book about > it. But i

Re: Where to put kglobalacceld?

2014-04-12 Thread David Faure
On Monday 07 April 2014 21:20:19 Ben Cooksley wrote: > On Mon, Apr 7, 2014 at 9:12 PM, Àlex Fiestas wrote: > > On Friday 04 April 2014 15:41:07 Martin Gräßlin wrote: > >> Given that kglobalaccel is only intended for the kde-workspaces anyway my > >> suggestion is to move it into plasma-workspace r

KPluginLoader move

2014-04-12 Thread Alex Merry
Just a heads up that I'm planning to move KPluginLoader, KPluginFactory and kexportplugin.h from KService to KCoreAddons this weekend, as previously discussed (it's SC, as it will involve putting KCoreAddons into the link interface of KService). I have an open review request for KPluginLoader in K

Re: APIDox for Plasma Framework

2014-04-12 Thread Alex Merry
On 12/04/14 12:48, Aleix Pol wrote: > Hi, > I just realized that we're not generating the API documentation for > Plasma Framework here [1]. > > Maybe it would be worth adding? I think it currently just grabs everything in /frameworks on project.kde.org. Alex ___

APIDox for Plasma Framework

2014-04-12 Thread Aleix Pol
Hi, I just realized that we're not generating the API documentation for Plasma Framework here [1]. Maybe it would be worth adding? Aleix [1] http://api.kde.org/frameworks-api/frameworks5-apidocs/ ___ Kde-frameworks-devel mailing list Kde-frameworks-dev

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-12 Thread David Faure
> On April 12, 2014, 11:12 a.m., Kevin Krammer wrote: > > I wonder if this really belongs in kdecoreaddons. I.e. it is only relevant > > for KDE applications porting, right? > > IMHO this would fit best in an explicit porting framework I don't want to put this in kdelibs4support because apps ar

Re: Review Request 117320: Update the kbuildsycoca5 man page

2014-04-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117320/ --- (Updated April 12, 2014, 11:17 a.m.) Status -- This change has been

Re: Review Request 117320: Update the kbuildsycoca5 man page

2014-04-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117320/#review55505 --- This review has been submitted with commit cec317d944ffb29c7d

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-12 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/#review55504 --- I wonder if this really belongs in kdecoreaddons. I.e. it is o

Re: Review Request 117320: Update the kbuildsycoca5 man page

2014-04-12 Thread David Faure
> On April 5, 2014, 8:59 p.m., David Faure wrote: > > docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook, line 280 > > > > > > LOL, that was optimistic :) > > Alex Merry wrote: > That was copied verbatim from th

Re: Review Request 117320: Update the kbuildsycoca5 man page

2014-04-12 Thread Alex Merry
> On April 5, 2014, 8:59 p.m., David Faure wrote: > > docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook, line 39 > > > > > > Users don't know KService... better talk about the "desktop file system > > configuration

Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/ --- Review request for KDE Frameworks, Ivan Čukić and Kevin Krammer. Reposito

Re: Review Request 117508: KIO metadata: resume -> range-start, resume_until -> range-end.

2014-04-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117508/ --- (Updated April 12, 2014, 10:51 a.m.) Status -- This change has been

Re: Review Request 117508: KIO metadata: resume -> range-start, resume_until -> range-end.

2014-04-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117508/#review55499 --- This review has been submitted with commit bec5d7e98f8ad5420e

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-04-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/#review55498 --- src/kcrash.cpp

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-04-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/#review55497 --- This is my preferred solution, and is hopefully only a tempora

Re: Review Request 117508: KIO metadata: resume -> range-start, resume_until -> range-end.

2014-04-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117508/#review55496 --- Ship it! OK, I'm convinced. - Alex Merry On April 12, 2014

Re: Review Request 117508: KIO metadata: resume -> range-start, resume_until -> range-end.

2014-04-12 Thread David Faure
> On April 12, 2014, 10:11 a.m., Alex Merry wrote: > > Would it not make sense to put the compatibility stuff in > > KIO::Job::addMetaData, rather than the slaves? That way it should maintain > > compatibility on both the application and slave side (for slaves shipped > > outside KIO). > > >

Re: Review Request 117508: KIO metadata: resume -> range-start, resume_until -> range-end.

2014-04-12 Thread Alex Merry
> On April 12, 2014, 10:11 a.m., Alex Merry wrote: > > Would it not make sense to put the compatibility stuff in > > KIO::Job::addMetaData, rather than the slaves? That way it should maintain > > compatibility on both the application and slave side (for slaves shipped > > outside KIO). > > >

Re: Review Request 117508: KIO metadata: resume -> range-start, resume_until -> range-end.

2014-04-12 Thread Alex Merry
> On April 12, 2014, 10:11 a.m., Alex Merry wrote: > > Would it not make sense to put the compatibility stuff in > > KIO::Job::addMetaData, rather than the slaves? That way it should maintain > > compatibility on both the application and slave side (for slaves shipped > > outside KIO). > > >

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-12 Thread David Faure
> On April 12, 2014, 9:16 a.m., David Faure wrote: > > Ship It! > > David Faure wrote: > Well, I guess the first diff minimizes the porting effort indeed. > > Also: the domain name can only be passed to QCoreApp if this is the main > aboutdata (we also have a KAboutData per plugin)

Re: Review Request 117508: KIO metadata: resume -> range-start, resume_until -> range-end.

2014-04-12 Thread David Faure
> On April 12, 2014, 10:11 a.m., Alex Merry wrote: > > Would it not make sense to put the compatibility stuff in > > KIO::Job::addMetaData, rather than the slaves? That way it should maintain > > compatibility on both the application and slave side (for slaves shipped > > outside KIO). > > >

Re: Review Request 117508: KIO metadata: resume -> range-start, resume_until -> range-end.

2014-04-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117508/#review55490 --- Would it not make sense to put the compatibility stuff in KIO

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-12 Thread Alex Merry
> On April 12, 2014, 9:16 a.m., David Faure wrote: > > Ship It! > > David Faure wrote: > Well, I guess the first diff minimizes the porting effort indeed. > > Also: the domain name can only be passed to QCoreApp if this is the main > aboutdata (we also have a KAboutData per plugin)

Review Request 117508: KIO metadata: resume -> range-start, resume_until -> range-end.

2014-04-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117508/ --- Review request for KDE Frameworks and Alex Merry. Repository: kio Descr

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-12 Thread David Faure
> On April 12, 2014, 9:16 a.m., David Faure wrote: > > Ship It! Well, I guess the first diff minimizes the porting effort indeed. Also: the domain name can only be passed to QCoreApp if this is the main aboutdata (we also have a KAboutData per plugin). But yeah, that seems to be missing in KAb

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/#review55486 --- Ship it! Ship It! - David Faure On April 1, 2014, 10:09 a.