Re: Big changes for Solid

2014-03-27 Thread Kevin Ottens
Hello, On Thursday 27 March 2014 23:50:35 Àlex Fiestas wrote: > I have done 1 commit per each removed interface and I have explained in > that commit who uses that interface + how to port it. Of course I will add > documentation of how to port existing app to alternative apis (Qt and UDev > mostl

Re: Move KDED out of frameworks?

2014-03-27 Thread Kevin Ottens
Hello, On Thursday 27 March 2014 23:25:24 Àlex Fiestas wrote: > First of all sorry for sending this email so late in the release process, > but today has been the first day in months that I have been able to work > fully concentrated on Frameworks. > > KDED is a weird framework, while it is a sol

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #203

2014-03-27 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 723 lines...] [ 44%] Building CXX object src/declarativeimports/plasmacom

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #203

2014-03-27 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 705 lines...] Linking CXX shared library libcalendarplugin.so [ 54%] Built t

Re: Finding libexec files / relocation

2014-03-27 Thread Aleix Pol
On Mon, Mar 24, 2014 at 5:29 PM, Alex Merry wrote: > Currently, paths to libexec files are hardcoded (or not... see > https://git.reviewboard.kde.org/r/117023/). This works find unless you > want to relocate anything. > > I know that relocating is something that has come up with KDE on Windows >

Review Request 117131: Implement KUser::faceIconPath on Windows.

2014-03-27 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117131/ --- Review request for KDE Frameworks and kdewin. Repository: kcoreaddons D

Re: Review Request 117087: co-installability: rename entry.desktop to kf5_entry.desktop

2014-03-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117087/#review54408 --- Again, these will go to kde4support, calling them kf5_ is weir

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-27 Thread Alex Merry
> On March 24, 2014, 3:41 p.m., Alex Merry wrote: > > The correct solution is to get drkonqi merged into kcrash (see > > http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). > > Aleix Pol Gonzalez wrote: > Agreed. If somebody has the time, it would be interesting to figure o

Re: Review Request 117052: Add ECMSetupQtTranslations

2014-03-27 Thread Alex Merry
> On March 27, 2014, 8:31 p.m., Alex Merry wrote: > > modules/ECMTrLoader.cpp.in, line 19 > > > > > > QLatin1String() when you're using + > > Aleix Pol Gonzalez wrote: > Why? That doesn't make sense on my boo

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-27 Thread Aleix Pol Gonzalez
> On March 24, 2014, 3:41 p.m., Alex Merry wrote: > > The correct solution is to get drkonqi merged into kcrash (see > > http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). > > Aleix Pol Gonzalez wrote: > Agreed. If somebody has the time, it would be interesting to figure o

Re: Review Request 117052: Add ECMSetupQtTranslations

2014-03-27 Thread Aleix Pol Gonzalez
> On March 27, 2014, 8:31 p.m., Alex Merry wrote: > > modules/ECMTrLoader.cpp.in, line 19 > > > > > > QLatin1String() when you're using + Why? That doesn't make sense on my book. - Aleix -

Re: Review Request 117123: Add manual test for KUser::faceIconPath

2014-03-27 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117123/ --- (Updated March 27, 2014, 11:12 p.m.) Status -- This change has been

Re: Review Request 117123: Add manual test for KUser::faceIconPath

2014-03-27 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117123/ --- (Updated March 27, 2014, 8:12 p.m.) Review request for KDE Frameworks.

Re: Review Request 117123: Add manual test for KUser::faceIconPath

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117123/#review54397 --- This review has been submitted with commit d664f5329d73c95d62

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

2014-03-27 Thread Jos Poortvliet
On Wednesday 26 March 2014 20:47:23 John Layt wrote: > On 26 March 2014 20:08, Kevin Ottens wrote: > > Hello, > > > > On Tuesday 25 March 2014 16:41:12 Jos Poortvliet wrote: > >> Just imagine what header would you like to see on an > >> announcement/article: > >> * Frameworks 5 To Not Include Dep

Big changes for Solid

2014-03-27 Thread Àlex Fiestas
Hi there First of all I'm really sorry for doing this now just hours before Beta but honestly I have not been able to do it before. In Solid we have a bunch of public Interfaces which represent different kind of hardware, like Battery, Block or Processor. After 6 years (all KDE4) the adoption

Jenkins build is back to stable : kcompletion_master_qt5 #68

2014-03-27 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116969: Deprecate reset() in KHistoryComboBox and substitute it for resetIndex()

2014-03-27 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116969/ --- (Updated March 27, 2014, 10:30 p.m.) Status -- This change has been

Re: Review Request 116969: Deprecate reset() in KHistoryComboBox and substitute it for resetIndex()

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116969/#review54394 --- This review has been submitted with commit 75a01d9d94a9dd1bb4

Move KDED out of frameworks?

2014-03-27 Thread Àlex Fiestas
Hi there First of all sorry for sending this email so late in the release process, but today has been the first day in months that I have been able to work fully concentrated on Frameworks. KDED is a weird framework, while it is a solution it is still really tied to what was once known as KDE,

Re: Review Request 117036: Refactor private variables and parameters in KCompletionBase and KLineEdit

2014-03-27 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117036/ --- (Updated March 27, 2014, 9:41 p.m.) Status -- This change has been m

Re: Review Request 117036: Refactor private variables and parameters in KCompletionBase and KLineEdit

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117036/#review54388 --- This review has been submitted with commit ea265156d2743ff178

Jenkins build became unstable: kcompletion_master_qt5 #66

2014-03-27 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117043: Add emission of KLineEdit::textEdited()

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117043/#review54387 --- This review has been submitted with commit 737a983febf4b44b54

Re: Review Request 117043: Add emission of KLineEdit::textEdited()

2014-03-27 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117043/ --- (Updated March 27, 2014, 9:34 p.m.) Status -- This change has been m

Re: Review Request 117104: Remove KLineEdit::clear(): it doesn't seem to modify clipboard anymore

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117104/#review54384 --- This review has been submitted with commit 8e778aceff20b5e68e

Re: Review Request 117104: Remove KLineEdit::clear(): it doesn't seem to modify clipboard anymore

2014-03-27 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117104/ --- (Updated March 27, 2014, 9:20 p.m.) Status -- This change has been m

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-27 Thread Dan Vrátil
> On March 24, 2014, 4:41 p.m., Alex Merry wrote: > > The correct solution is to get drkonqi merged into kcrash (see > > http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). > > Aleix Pol Gonzalez wrote: > Agreed. If somebody has the time, it would be interesting to figure o

Re: Review Request 117123: Add manual test for KUser::faceIconPath

2014-03-27 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117123/#review54379 --- Ship it! Ship It! - Alexander Richardson On March 27, 2014

Re: Review Request 117106: Remove support for htdig index generation from meinproc

2014-03-27 Thread Luigi Toscano
> On March 27, 2014, 5:06 p.m., Kevin Ottens wrote: > > Ship It! Committed, but I forgot to add the REVIEW: line, I apologize. Closed in kdoctools commit e44d403cd9f2e37816493cc8c2a354cfb6f071ef: http://quickgit.kde.org/?p=kdoctools.git&a=commit&h=e44d403cd9f2e37816493cc8c2a354cfb6f071ef - L

Re: Review Request 117106: Remove support for htdig index generation from meinproc

2014-03-27 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117106/ --- (Updated March 27, 2014, 9:49 p.m.) Status -- This change has been m

Re: Review Request 117125: start_kdeinit: Use capabilities instead of SUID

2014-03-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117125/#review54374 --- Can you have a look at the documentation about writing a CMake

Re: Review Request 117052: Add ECMSetupQtTranslations

2014-03-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117052/#review54369 --- modules/ECMSetupQtTranslations.cmake

Review Request 117125: start_kdeinit: Use capabilities instead of SUID

2014-03-27 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117125/ --- Review request for KDE Frameworks and David Faure. Bugs: https://bugzilla

Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984/ --- (Updated March 27, 2014, 7:41 p.m.) Status -- This change has been m

Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984/#review54363 --- This review has been submitted with commit 4758e47efc86c67a5b

Review Request 117123: Add manual test for KUser::faceIconPath

2014-03-27 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117123/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-27 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984/#review54361 --- Ship it! Seems to work - Alexander Richardson On March 22,

Review Request 117122: Cut the dependency between country files and KIO

2014-03-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117122/ --- Review request for KDE Frameworks, Albert Astals Cid and John Layt. Repos

Re: Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

2014-03-27 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116883/ --- (Updated March 27, 2014, 6:30 p.m.) Status -- This change has been m

Re: Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116883/#review54358 --- This review has been submitted with commit 6ea3839a870ee9c99c

Jenkins build is back to stable : kwindowsystem_master_qt5 » All,LINBUILDER #28

2014-03-27 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : khtml_master_qt5 #61

2014-03-27 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Build failed in Jenkins: kprintutils_master_qt5 #28

2014-03-27 Thread Alex Merry
On 27/03/14 17:30, KDE CI System wrote: > See > > Changes: > > [agateau] Add src/Messages.sh What on earth does this still exist for? kprintutils is dead... John: did you file a sysadmin request to have the repo deleted? Alex _

Re: Review Request 117107: Do not use WId in KCookieServer

2014-03-27 Thread Alexander Richardson
> On March 27, 2014, 3:42 p.m., Alexander Richardson wrote: > > qwindowdefs.h has typedef QT_PREPEND_NAMESPACE(quintptr) WId; > > uncoditionally for all platforms (apparently they changed the windows > > define from HWND to quintptr), so I guess using quintptr should be the > > correct solutio

Build failed in Jenkins: kprintutils_master_qt5 #28

2014-03-27 Thread KDE CI System
See Changes: [agateau] Add src/Messages.sh -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace

Re: Review Request 117120: Khtml: Make the khtml build again

2014-03-27 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117120/ --- (Updated March 27, 2014, 5:14 p.m.) Status -- This change has been d

Re: Review Request 117120: Khtml: Make the khtml build again

2014-03-27 Thread Antonis Tsiapaliokas
> On March 27, 2014, 5:11 p.m., Martin Gräßlin wrote: > > see https://git.reviewboard.kde.org/r/117075/ ok thank you. - Antonis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117120/#re

Re: Review Request 117114: Print module name for not found dependend component

2014-03-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117114/ --- (Updated March 27, 2014, 5:13 p.m.) Status -- This change has been m

Re: Review Request 117114: Print module name for not found dependend component

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117114/#review54347 --- This review has been submitted with commit 147a501495801282ff

Re: Review Request 117075: Fix build breakage due to change in kcookiejar dbus interface

2014-03-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117075/ --- (Updated March 27, 2014, 5:12 p.m.) Status -- This change has been m

Re: Review Request 117075: Fix build breakage due to change in kcookiejar dbus interface

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117075/#review54346 --- This review has been submitted with commit 657f074e2b6ef63ad7

Re: Review Request 117120: Khtml: Make the khtml build again

2014-03-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117120/#review54345 --- see https://git.reviewboard.kde.org/r/117075/ - Martin Gräßli

Review Request 117120: Khtml: Make the khtml build again

2014-03-27 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117120/ --- Review request for KDE Frameworks. Repository: khtml Description --

Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder

2014-03-27 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/#review54344 --- src/widgets/ktextedit.cpp

Jenkins build became unstable: kwindowsystem_master_qt5 » All,LINBUILDER #27

2014-03-27 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Remnants of monolithic kdelibs.git building

2014-03-27 Thread Alex Merry
On 27/03/14 15:39, Nicolás Alvarez wrote: > Many frameworks' top-level CMakeLists.txt still wrap their > find_package calls in: > > if ("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}") > > That's left over from when the frameworks had to build both standalone > and as part of the lar

Re: Review Request 117102: Remove unused methods from KStartupInfo

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117102/#review54341 --- This review has been submitted with commit 82f6257f12b8c3cad8

Re: Review Request 117102: Remove unused methods from KStartupInfo

2014-03-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117102/ --- (Updated March 27, 2014, 4:17 p.m.) Status -- This change has been m

Re: Review Request 117103: Remove startup notification code from K(Unique)Application

2014-03-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117103/ --- (Updated March 27, 2014, 4:15 p.m.) Status -- This change has been m

Re: Review Request 117103: Remove startup notification code from K(Unique)Application

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117103/#review54340 --- This review has been submitted with commit 52076652d129da9ea8

Re: Review Request 117072: Add autotests for KPluginLoader and KPluginFactory

2014-03-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117072/ --- (Updated March 27, 2014, 4:13 p.m.) Status -- This change has been m

Re: Review Request 117103: Remove startup notification code from K(Unique)Application

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117103/#review54339 --- Ship it! Ship It! - Kevin Ottens On March 26, 2014, 10:51

Re: Review Request 117107: Do not use WId in KCookieServer

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117107/#review54338 --- Ship it! Ship It! - Kevin Ottens On March 27, 2014, 9:59 a

Re: Review Request 117065: Remove KDE4 TODO

2014-03-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117065/ --- (Updated March 27, 2014, 4:10 p.m.) Status -- This change has been m

Re: Review Request 117065: Remove KDE4 TODO

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117065/#review54335 --- This review has been submitted with commit 3d170b4a0b9b849e14

Re: Review Request 117114: Print module name for not found dependend component

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117114/#review54337 --- Ship it! Ship It! - Kevin Ottens On March 27, 2014, 1:46 p

Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/#review54336 --- src/widgets/ktextedit.cpp

Re: Review Request 116998: Remove reference to KDE4_BUILD_TESTS CMake option

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116998/#review54332 --- This review has been submitted with commit 74d2645f2469802e26

Re: Review Request 116998: Remove reference to KDE4_BUILD_TESTS CMake option

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116998/#review54333 --- This review has been submitted with commit b4418ec4443ad98d19

Re: Review Request 116998: Remove reference to KDE4_BUILD_TESTS CMake option

2014-03-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116998/ --- (Updated March 27, 2014, 4:08 p.m.) Status -- This change has been m

Re: Review Request 116998: Remove reference to KDE4_BUILD_TESTS CMake option

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116998/#review54334 --- This review has been submitted with commit 9e9e3da7ae57e635d4

Re: Review Request 116998: Remove reference to KDE4_BUILD_TESTS CMake option

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116998/#review54331 --- This review has been submitted with commit f3026925ac94213460

Re: Review Request 117112: Make KPLuginLoader encapsulate QPluginLoader, rather than inheriting

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117112/#review54330 --- I think that's very sensible. I'd like David to get a chance t

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-27 Thread Aleix Pol Gonzalez
> On March 24, 2014, 3:41 p.m., Alex Merry wrote: > > The correct solution is to get drkonqi merged into kcrash (see > > http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). > > Aleix Pol Gonzalez wrote: > Agreed. If somebody has the time, it would be interesting to figure o

Re: Review Request 116981: Use new terminology in webkit docs.

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116981/#review54328 --- This review has been submitted with commit 5674260f892b633ca6

Re: Review Request 116981: Use new terminology in webkit docs.

2014-03-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116981/ --- (Updated March 27, 2014, 4:06 p.m.) Status -- This change has been m

Re: Review Request 117106: Remove support for htdig index generation from meinproc

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117106/#review54327 --- Ship it! Ship It! - Kevin Ottens On March 27, 2014, 12:47

Re: Review Request 117104: Remove KLineEdit::clear(): it doesn't seem to modify clipboard anymore

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117104/#review54326 --- Ship it! Ship It! - Kevin Ottens On March 26, 2014, 11:15

Re: Review Request 116969: Deprecate reset() in KHistoryComboBox and substitute it for resetIndex()

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116969/#review54325 --- Ship it! Ship It! - Kevin Ottens On March 24, 2014, 9:45 p

Re: Review Request 116980: Update the kded5 man page

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/#review54324 --- This review has been submitted with commit e5ae0f49427d301512

Re: Review Request 116980: Update the kded5 man page

2014-03-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/ --- (Updated March 27, 2014, 4:05 p.m.) Status -- This change has been m

Re: Review Request 117114: Print module name for not found dependend component

2014-03-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117114/#review54323 --- Ship it! Oops! - Alex Merry On March 27, 2014, 1:46 p.m.,

Re: Review Request 117087: co-installability: rename entry.desktop to kf5_entry.desktop

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117087/#review54321 --- Ship it! Ship It! - Kevin Ottens On March 26, 2014, 1:44 p

Re: Review Request 116998: Remove reference to KDE4_BUILD_TESTS CMake option

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116998/#review54315 --- Ship it! Ship It! - Kevin Ottens On March 25, 2014, 3:44 p

Re: Review Request 117074: KPluginFactory: remove argumented contructor and componentName()

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117074/#review54318 --- Sounds good to me but I'd like David to have a look at it. -

Re: Review Request 117075: Fix build breakage due to change in kcookiejar dbus interface

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117075/#review54320 --- Ship it! Ship It! - Kevin Ottens On March 26, 2014, 8:13 a

Re: Review Request 116044: In kstyle: Use the iconSize from mainToolbar

2014-03-27 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116044/ --- (Updated March 27, 2014, 3:48 p.m.) Status -- This change has been d

Re: Review Request 117072: Add autotests for KPluginLoader and KPluginFactory

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117072/#review54317 --- Ship it! Ship It! - Kevin Ottens On March 26, 2014, 2:22 a

Re: Review Request 117065: Remove KDE4 TODO

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117065/#review54316 --- Ship it! Ship It! - Kevin Ottens On March 25, 2014, 6:26 p

Re: Review Request 116981: Use new terminology in webkit docs.

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116981/#review54314 --- Ship it! Ship It! - Kevin Ottens On March 25, 2014, 10:39

Re: Review Request 116980: Update the kded5 man page

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/#review54313 --- Ship it! Ship It! - Kevin Ottens On March 25, 2014, 10:10

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-27 Thread Kevin Ottens
> On March 24, 2014, 3:41 p.m., Alex Merry wrote: > > The correct solution is to get drkonqi merged into kcrash (see > > http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). > > Aleix Pol Gonzalez wrote: > Agreed. If somebody has the time, it would be interesting to figure o

Re: Review Request 117043: Add emission of KLineEdit::textEdited()

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117043/#review54311 --- Ship it! Ship It! - Kevin Ottens On March 24, 2014, 11:40

Re: Review Request 117036: Refactor private variables and parameters in KCompletionBase and KLineEdit

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117036/#review54310 --- Ship it! Ship It! - Kevin Ottens On March 24, 2014, 10:15

Re: Review Request 115977: RFC: Install KArchive as Mac OS X Framework

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115977/#review54309 --- Ship it! Ship It! - Kevin Ottens On Feb. 23, 2014, 7:15 p.

Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117012/#review54308 --- src/kjsembed/CMakeLists.txt

Re: Review Request 116037: change entities to reflect new branding

2014-03-27 Thread Luigi Toscano
> On March 4, 2014, 9:48 p.m., Kevin Ottens wrote: > > Ship It! > > Kevin Ottens wrote: > Any news? Anything blocking this patch from being committed? > > T.C. Hollingsworth wrote: > Well I still need to fix the i18n issues and change up the entities a > little bit to reflect the feedb

Re: Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117010/#review54306 --- Ship it! This one should definitely be in for beta1. Please f

Remnants of monolithic kdelibs.git building

2014-03-27 Thread Nicolás Alvarez
Many frameworks' top-level CMakeLists.txt still wrap their find_package calls in: if ("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}") That's left over from when the frameworks had to build both standalone and as part of the large kdelibs.git repository. Should it be removed? -- Ni

  1   2   >