Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

> On March 23, 2014, 4:39 p.m., Aleix Pol Gonzalez wrote: > > src/colors/kcolorutils.cpp, line 38 > > > > > > Wouldn't it make more sense to use qIsNan? > > > > http://qt-project.org/doc/qt-5.0/qtcore/qtg

Re: Review Request 117042: Make KLineEdit::completionBox virtual so that konq can reimplement it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117042/#review54053 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 24, 2014,

Re: Review Request 117037: Refactor parameter names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117037/#review54052 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 24, 2014,

Re: Review Request 116955: Remove KDE 4 refs from Doxyfile.global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116955/ --- (Updated March 24, 2014, 11:55 p.m.) Status -- This change has been

Re: Review Request 116955: Remove KDE 4 refs from Doxyfile.global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116955/#review54050 --- This review has been submitted with commit bcbae14c0f7319a592

Jenkins build became unstable: kemoticons_master_qt5 #29

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116876: Add default emoticons theme to kemoticons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116876/#review54049 --- This review has been submitted with commit 17f7505d56d13e89a7

Re: Review Request 116876: Add default emoticons theme to kemoticons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116876/ --- (Updated March 24, 2014, 11:50 p.m.) Status -- This change has been

Re: Review Request 116876: Add default emoticons theme to kemoticons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116876/#review54048 --- This review has been submitted with commit 9c2397e2666a2fd058

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

> On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote: > > What about QStandardPaths::findExecutable? Actually this one should look > > into libexec too (at least the equivalent KStandardDirs::findExe used to). > > Alex Merry wrote: > I'm pretty sure QStandardPaths won't look at libexec

Review Request 117043: Add emission of KLineEdit::textEdited()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117043/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Review Request 117042: Make KLineEdit::completionBox virtual so that konq can reimplement it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117042/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Review Request 117040: Remove FIXME in KCompletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117040/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Review Request 117037: Refactor parameter names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117037/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Review Request 117036: Refactor private variables and parameters in KCompletionBase and KLineEdit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117036/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 116969: Deprecate reset() in KHistoryComboBox and substitute it for resetIndex()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116969/ --- (Updated March 24, 2014, 9:45 p.m.) Review request for KDE Frameworks.

Jenkins build is back to stable : ktexteditor_master_qt5 #323

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: ktexteditor_master_qt5 #321

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : ktexteditor_master_qt5 #320

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Allocating kde-runtime/platforms/win

On Monday 24 March 2014 19:01:14 Aleix Pol wrote: > So if nobody disagrees, we'll split it out into a KWindowsAddons repository > and hope somebody will find a use for it some day. No objection to have it as separate repository. Just to clarify though: won't be part of a KF5.0, afaict it's not so

Re: Review Request 117024: Use the KF5::kconf_update target to locate kconf_update

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117024/#review54022 --- Ship it! Ship It! - Kevin Ottens On March 24, 2014, 4:19 p

Re: Review Request 117023: Use the full path for kconf_update when running it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117023/#review54021 --- Ship it! Ship It! - Kevin Ottens On March 24, 2014, 4:19 p

Re: Review Request 117020: Tidy up KLibLoader and fix up its autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117020/#review54020 --- Ship it! Ship It! - Kevin Ottens On March 24, 2014, 2:07 p

Re: Review Request 116969: Remove private reset() and move the implementation to the public reset() in KHistoryComboBox

> On March 23, 2014, 9:38 p.m., David Faure wrote: > > I don't really get the point of this change? (it's mostly a TODO...) Indeed I don't get it either. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://gi

Re: Review Request 116930: Fix "device not open" warning messages at build time

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116930/#review54018 --- Ship it! Ship It! - Kevin Ottens On March 23, 2014, 8:12 p

Re: Review Request 117003: Remove kde3 compatibility code for "DocPath" in desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117003/#review54017 --- Ship it! Ship It! - Kevin Ottens On March 23, 2014, 5:36 p

Re: Review Request 116997: Cleanup KDE 4 references in various comments and dox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116997/#review54015 --- Ship it! Ship It! - Kevin Ottens On March 23, 2014, 3:48 p

Re: Review Request 116999: kparts: Remove/resolve old porting comments and TODOs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116999/#review54016 --- Ship it! Ship It! - Kevin Ottens On March 23, 2014, 4:33 p

Re: Review Request 116980: Update the kded5 man page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/#review54014 --- docs/kded5/man-kded5.8.docbook

Re: Review Request 116982: Remove KDE 4 refs in khtml

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116982/#review54013 --- Ship it! Ship It! - Kevin Ottens On March 22, 2014, 6:46 p

Re: Review Request 116981: Use new terminology in webkit docs.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116981/#review54012 --- src/kgraphicswebview.h

Re: Review Request 116955: Remove KDE 4 refs from Doxyfile.global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116955/#review54011 --- Ship it! Ship It! - Kevin Ottens On March 21, 2014, 4:19 p

Re: Review Request 116941: Remove deprecation for NET::timestampCompare and NET::timestampDiff

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116941/#review54009 --- Ship it! Ship It! - Kevin Ottens On March 21, 2014, 7:15 a

Re: Review Request 115977: RFC: Install KArchive as Mac OS X Framework

> On March 4, 2014, 8:28 p.m., Kevin Ottens wrote: > > src/karchive.h, line 32 > > > > > > Hm, why the change to "" for the includes? We try to stick to <> in > > public headers. > > Kevin Ottens wrote: > An

Re: Review Request 116926: Remove support for _NET_WM_TAKE_ACTIVITY

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116926/#review54008 --- Ship it! Ship It! - Kevin Ottens On March 20, 2014, 1:40 p

Re: Review Request 116848: Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116848/#review54007 --- Ship it! Ship It! - Kevin Ottens On March 19, 2014, 6:19 a

Re: Review Request 116887: Undeprecate setUrlDropsEnabled(bool) in KComboBox and KLineEdit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116887/ --- (Updated March 24, 2014, 6:43 p.m.) Status -- This change has been d

Re: Review Request 116876: Add default emoticons theme to kemoticons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116876/#review54006 --- Ship it! Ship It! - Kevin Ottens On March 18, 2014, 3:58 p

Re: Review Request 116044: In kstyle: Use the iconSize from mainToolbar

> On Feb. 25, 2014, 12:10 p.m., David Faure wrote: > > The part of the description that says "if accepted will modify kstyle as > > well" doesn't really make sense anymore (to fix if it's in your commit log > > too). > > > > The bit I'm not sure about is: using MainToolbar icon style everywher

Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

> On March 17, 2014, 4:44 p.m., Kevin Ottens wrote: > > OK, let's go for it without a test app... Anything still blocking? - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115717/

Re: Review Request 115977: RFC: Install KArchive as Mac OS X Framework

> On March 4, 2014, 8:28 p.m., Kevin Ottens wrote: > > src/karchive.h, line 32 > > > > > > Hm, why the change to "" for the includes? We try to stick to <> in > > public headers. > > Kevin Ottens wrote: > An

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

> On March 24, 2014, 12:01 p.m., Aleix Pol Gonzalez wrote: > > What about QStandardPaths::findExecutable? Actually this one should look > > into libexec too (at least the equivalent KStandardDirs::findExe used to). > > Alex Merry wrote: > I'm pretty sure QStandardPaths won't look at libexec

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

> On March 24, 2014, 4:41 p.m., Alex Merry wrote: > > The correct solution is to get drkonqi merged into kcrash (see > > http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). > > Aleix Pol Gonzalez wrote: > Agreed. If somebody has the time, it would be interesting to figure o

Re: Allocating kde-runtime/platforms/win

On Thu, Feb 20, 2014 at 6:46 PM, Aleix Pol wrote: > Hi! > I am going through the list of things where we're moving kde-runtime > components to [1] and I see that there's a platform/win directory. > > Do you agree that having it in a separate repository would be the best? > Could anybody with a wo

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

> On March 24, 2014, 3:41 p.m., Alex Merry wrote: > > The correct solution is to get drkonqi merged into kcrash (see > > http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). Agreed. If somebody has the time, it would be interesting to figure out what can be uncommented (see com

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

> On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote: > > What about QStandardPaths::findExecutable? Actually this one should look > > into libexec too (at least the equivalent KStandardDirs::findExe used to). > > Alex Merry wrote: > I'm pretty sure QStandardPaths won't look at libexec

Re: Review Request 116927: Fix kdeinit module lookup

> On March 21, 2014, 4:10 p.m., Hrvoje Senjan wrote: > > this seems to broke kded modules loading here: > > Cannot load library /usr/lib64/libkdeinit5_kio_file: > > (/usr/lib64/libkdeinit5_kio_file.so: cannot open shared object file: No > > such file or directory) > > Hrvoje Senjan wrote: >

Finding libexec files / relocation

Currently, paths to libexec files are hardcoded (or not... see https://git.reviewboard.kde.org/r/117023/). This works find unless you want to relocate anything. I know that relocating is something that has come up with KDE on Windows stuff. Is it something we want to support? If so, how would w

Review Request 117024: Use the KF5::kconf_update target to locate kconf_update

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117024/ --- Review request for KDE Frameworks. Repository: kded Description ---

Review Request 117023: Use the full path for kconf_update when running it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117023/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

> On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote: > > What about QStandardPaths::findExecutable? Actually this one should look > > into libexec too (at least the equivalent KStandardDirs::findExe used to). I'm pretty sure QStandardPaths won't look at libexec. How should it know where

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/#review53985 --- The correct solution is to get drkonqi merged into kcrash (see

Jenkins build became unstable: ktexteditor_master_qt5 #319

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117017: Remove forward headers for KTextEditor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117017/ --- (Updated March 24, 2014, 2:58 p.m.) Status -- This change has been m

Re: Review Request 117017: Remove forward headers for KTextEditor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117017/#review53981 --- This review has been submitted with commit a2f6dfd6814f75c18d

Re: Review Request 117020: Tidy up KLibLoader and fix up its autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117020/ --- (Updated March 24, 2014, 2:07 p.m.) Review request for KDE Frameworks.

Review Request 117020: Tidy up KLibLoader and fix up its autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117020/ --- Review request for KDE Frameworks. Repository: kde4support Description

Review Request 117019: Remove fake defaultMimetype entries from protocols files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117019/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 117018: Use qIsNaN() instead of isnan()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117018/ --- (Updated March 24, 2014, 1:43 p.m.) Status -- This change has been m

Re: Review Request 117018: Use qIsNaN() instead of isnan()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117018/#review53972 --- This review has been submitted with commit 95204ce1f84054fe85

Re: Review Request 117018: Use qIsNaN() instead of isnan()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117018/#review53973 --- This review has been submitted with commit 43d1f16a04a61646f9

Re: Review Request 117017: Remove forward headers for KTextEditor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117017/#review53970 --- Ship it! Ship It! - Christoph Cullmann On March 24, 2014,

Re: Review Request 117018: Use qIsNaN() instead of isnan()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117018/#review53968 --- Ship it! Less code, less ifdef's, more happiness! - Aleix Po

Review Request 117018: Use qIsNaN() instead of isnan()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117018/ --- Review request for KDE Frameworks, Aleix Pol Gonzalez and Michael Hansen.

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/ --- (Updated March 24, 2014, 1:01 p.m.) Review request for KDE Frameworks.

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

> On March 23, 2014, 11:39 p.m., Aleix Pol Gonzalez wrote: > > src/colors/kcolorutils.cpp, line 38 > > > > > > Wouldn't it make more sense to use qIsNan? > > > > http://qt-project.org/doc/qt-5.0/qtcore/qt

Re: Review Request 117004: Remove out-of-date design docs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117004/ --- (Updated March 24, 2014, 11:52 a.m.) Status -- This change has been

Re: Review Request 117004: Remove out-of-date design docs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117004/#review53963 --- This review has been submitted with commit 3889bee5d08463b521

Re: Review Request 116995: Rename the kconfig_compiler_kf5 target to kconfig_compiler

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116995/#review53961 --- This review has been submitted with commit 892e693f616297a918

Re: Review Request 116995: Rename the kconfig_compiler_kf5 target to kconfig_compiler

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116995/ --- (Updated March 24, 2014, 11:50 a.m.) Status -- This change has been

Re: Review Request 116993: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116993/#review53958 --- This review has been submitted with commit 3465b1008e41a29bb3

Re: Review Request 116993: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116993/ --- (Updated March 24, 2014, 11:47 a.m.) Status -- This change has been

Re: Review Request 116959: Remove KDE 4 references from kcmutils

> On March 23, 2014, 9:35 p.m., David Faure wrote: > > src/kcmultidialog.cpp, line 424 > > > > > > this if() isn't needed, already tested in the parent scope. Oops, worse than that. I'd replaced rootOnlyMessage

Re: Review Request 116959: Remove KDE 4 references from kcmutils

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53954 --- This review has been submitted with commit 82b15ec1d65ff7e771

Re: Review Request 116959: Remove KDE 4 references from kcmutils

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53956 --- This review has been submitted with commit 2bfb285f562115e1b8

Re: Review Request 116959: Remove KDE 4 references from kcmutils

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/ --- (Updated March 24, 2014, 11:44 a.m.) Status -- This change has been

Re: Review Request 116959: Remove KDE 4 references from kcmutils

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53953 --- This review has been submitted with commit 817f47214f94e2d766

Re: Review Request 116959: Remove KDE 4 references from kcmutils

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53955 --- This review has been submitted with commit b0f041b78f559a6682

Re: Review Request 116937: Use QLibrary instead of KLibrary in KOpenSSL

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116937/ --- (Updated March 24, 2014, 11:43 a.m.) Status -- This change has been

Re: Review Request 116937: Use QLibrary instead of KLibrary in KOpenSSL

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116937/#review53952 --- This review has been submitted with commit 16b11a28e154d7030c

Re: Review Request 117000: Rename kmimetypefactory.h to kmimetypefactory_p.h

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117000/ --- (Updated March 24, 2014, 11:34 a.m.) Status -- This change has been

Re: Review Request 117000: Rename kmimetypefactory.h to kmimetypefactory_p.h

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117000/#review53951 --- This review has been submitted with commit b1808656b35b24eb31

Re: Review Request 116936: Use QLibrary instead of KLibrary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116936/ --- (Updated March 24, 2014, 11:33 a.m.) Status -- This change has been

Re: Review Request 116936: Use QLibrary instead of KLibrary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116936/#review53950 --- This review has been submitted with commit 88f0d93edc884375a4

Re: Problems found by the CI system

On Monday, March 24, 2014 06:59:24 PM Ben Cooksley wrote: > > Baloo developers, please take a look at the failure in this log - > http://build.kde.org/view/FAILED/job/baloo_stable/80/console. When > referencing projects outside your own, it is imperative the correct > include statements are used i

Re: Review Request 116962: Clean up KDE4 references in kconfig

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116962/#review53945 --- This review has been submitted with commit 2cb32b4dc0ed9aed3a

Re: Review Request 116962: Clean up KDE4 references in kconfig

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116962/ --- (Updated March 24, 2014, 11:27 a.m.) Status -- This change has been

Re: Review Request 116962: Clean up KDE4 references in kconfig

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116962/#review53942 --- This review has been submitted with commit c018f617f1f0eff18b

Re: Review Request 116962: Clean up KDE4 references in kconfig

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116962/#review53944 --- This review has been submitted with commit 16348884c6b3632b9a

Re: Review Request 116962: Clean up KDE4 references in kconfig

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116962/#review53946 --- This review has been submitted with commit a9ac60da055e108d15

Re: Review Request 116962: Clean up KDE4 references in kconfig

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116962/#review53943 --- This review has been submitted with commit 54e96153a57c43da26

Re: Review Request 117006: Remove kde3 compatibility code and comments

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117006/#review53941 --- This review has been submitted with commit 45ec64067d032e1995

Re: Review Request 117006: Remove kde3 compatibility code and comments

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117006/ --- (Updated March 24, 2014, 11:14 a.m.) Status -- This change has been

Re: LXR

On 23/03/14 19:51, David Faure wrote: > On Sunday 23 March 2014 17:33:46 Alex Merry wrote: >> On 23/03/14 14:55, Alex Merry wrote: >>> On 20/03/14 08:13, David Faure wrote: On Thursday 20 March 2014 00:28:44 Alex Merry wrote: > LXR says the only > > users are a couple of projects

Re: Review Request 117017: Remove forward headers for KTextEditor

> On March 24, 2014, 10:57 a.m., Aleix Pol Gonzalez wrote: > > There's a slight difference, and the reason we haven't been doing this for > > most headers. From KDE4Support you can include headers prefixing KDE/ (such > > as KDE/KTextEditor/MovingRange). If you remove these that won't be possib

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/#review53939 --- What about QStandardPaths::findExecutable? Actually this one s

Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117012/#review53938 --- Then you should modify the target_include_directories INSTALL_

Re: Review Request 117017: Remove forward headers for KTextEditor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117017/#review53937 --- There's a slight difference, and the reason we haven't been do

Re: Review Request 117005: Remove KDE3 KParts compatibility code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117005/#review53936 --- This review has been submitted with commit c5db9d34fca7435a5c

Re: Review Request 117005: Remove KDE3 KParts compatibility code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117005/ --- (Updated March 24, 2014, 10:54 a.m.) Status -- This change has been

  1   2   >