Build failed in Jenkins: krunner_master_qt5 #33

2014-03-16 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspa

Re: Review Request 116845: Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

2014-03-16 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116845/#review53151 --- The unit test situation seems far from ideal, but since it fit

Re: Plasma Next - Translations KCM - What Languages?

2014-03-16 Thread Albert Astals Cid
El Diumenge, 16 de març de 2014, a les 15:49:02, Chusslove Illich va escriure: > >>> [: John Layt :] > >>> Or do we list all languages regardless of whether they are installed or > >>> not (probably way too many)? > >> > >> [: Chusslove Illich :] > >> I would rather go this way, have this finished

Re: Review Request 116087: remove usage of strlcpy

2014-03-16 Thread Alexander Richardson
> On March 16, 2014, 10:12 a.m., David Faure wrote: > > src/kcrash.cpp, line 56 > > > > > > I just realized that this requires qpa-private headers, which is a > > problem (breaks compat when upgrading Qt, too). S

how to write kded module in framework 5

2014-03-16 Thread Shivam Makkar
Hello fellow developers ! :) I am noob in kde and hacking keyboard module these days ! I tried to instantiate object of class keyboardDaemon and I got this error : In file included from /home/amourphious/kde-workspace/kcontrol/keyboard/kcm_keyboard.cpp:37:0: /home/amourphious/kde-workspace/kcont

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-16 Thread Matthew Dawson
> On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Jenkins build became unstable: kxmlgui_master_qt5 #73

2014-03-16 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116845: Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

2014-03-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116845/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig

Re: Review Request 116087: remove usage of strlcpy

2014-03-16 Thread David Faure
> On March 16, 2014, 9:12 a.m., David Faure wrote: > > src/kcrash.cpp, line 56 > > > > > > I just realized that this requires qpa-private headers, which is a > > problem (breaks compat when upgrading Qt, too). Se

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-16 Thread David Faure
> On Feb. 28, 2014, 8:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116087: remove usage of strlcpy

2014-03-16 Thread Alexander Richardson
> On March 16, 2014, 10:12 a.m., David Faure wrote: > > src/kcrash.cpp, line 56 > > > > > > I just realized that this requires qpa-private headers, which is a > > problem (breaks compat when upgrading Qt, too). S

Jenkins build became unstable: kcoreaddons_master_qt5 #39

2014-03-16 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116798: Rewrite KUser/KUserGroup Widows implementation + introduce KUserId/KGroupId

2014-03-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116798/#review53140 --- This review has been submitted with commit 43e2a658d1f1053c4c

Re: Review Request 116798: Rewrite KUser/KUserGroup Widows implementation + introduce KUserId/KGroupId

2014-03-16 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116798/ --- (Updated March 16, 2014, 9:55 p.m.) Status -- This change has been m

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-16 Thread Matthew Dawson
> On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116798: Rewrite KUser/KUserGroup Widows implementation + introduce KUserId/KGroupId

2014-03-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116798/#review53141 --- This review has been submitted with commit 1adb574a6118a19060

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-16 Thread David Faure
> On Feb. 28, 2014, 8:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-16 Thread Matthew Dawson
> On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116830: Replace use of QPA headers with optional dep on QX11Extras.

2014-03-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116830/#review53079 --- Looks good to me, but someone else has to approve - Martin Gr

Re: Review Request 116087: remove usage of strlcpy

2014-03-16 Thread Alex Merry
> On March 16, 2014, 9:12 a.m., David Faure wrote: > > src/kcrash.cpp, line 56 > > > > > > I just realized that this requires qpa-private headers, which is a > > problem (breaks compat when upgrading Qt, too). Se

Meta key and Qt (Re: kglobalaccel fixes)

2014-03-16 Thread David Faure
On Tuesday 11 March 2014 13:54:56 Sebastian Kügler wrote: > One thing is a bit puzzling, perhaps someone knows how to go about this: > The meta key behaves different now, when I edit a shortcut, it's accepted > as soon as I press the meta key, so it's not seen as a modifier, but as a > key of its

Re: reviews

2014-03-16 Thread Kevin Ottens
On Sunday 16 March 2014 10:16:17 David Faure wrote: > On Sunday 23 February 2014 16:12:58 Albert Astals Cid wrote: > I tend to agree. Initially it was a good thing because most frameworks > committers were newcomers to that code, but by now some of them know what > they are doing :-) > OTOH it work

Re: kde4support won't compile against today's qtbase-stable

2014-03-16 Thread David Faure
On Sunday 16 March 2014 14:48:34 Treeve Jelbert wrote: > kfiledialog.cpp:(.text.startup+0x47): undefined reference to > `qt_filedialog_open_filenames_hook' > kfiledialog.cpp:(.text.startup+0x54): undefined reference to > `qt_filedialog_save_filename_hook' Right. Fixed. -- David Faure, fa...@kde.

Re: Plasma Next - Translations KCM - What Languages?

2014-03-16 Thread Chusslove Illich
>>> [: John Layt :] >>> Or do we list all languages regardless of whether they are installed or >>> not (probably way too many)? >> >> [: Chusslove Illich :] >> I would rather go this way, have this finished once and for all. I would >> only try to clearly present it not as "you will get this langu

kde4support won't compile against today's qtbase-stable

2014-03-16 Thread Treeve Jelbert
src/CMakeFiles/KF5KDE4Support.dir/kio/kfiledialog.cpp.o: In function `KFileDialogQtOverride::~KFileDialogQtOverride()': kfiledialog.cpp: (.text._ZN21KFileDialogQtOverrideD2Ev[_ZN21KFileDialogQtOverrideD5Ev]+0x3): undefined reference to `qt_filedialog_existing_directory_hook' kfiledialog.cpp: (.te

Re: KF5 alpha2

2014-03-16 Thread David Faure
On Wednesday 12 March 2014 12:21:36 Christoph Cullmann wrote: > David Faure wrote: > > On Wednesday 05 March 2014 19:29:34 Michael Palimaka wrote: > > > Hi, > > > > > > KTextEditor is listed as tier 3, but is missing from this (and previous) > > > releases. > > > > It is not part of the KF 5.0 re

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-16 Thread David Faure
> On Feb. 28, 2014, 8:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689/ --- (Updated March 16, 2014, 11:03 a.m.) Status -- This change has been

Re: Frameworks book

2014-03-16 Thread Kevin Krammer
On Sunday, 2014-03-16, 11:50:26, David Faure wrote: > On Saturday 15 March 2014 02:08:52 Valorie Zimmerman wrote: > > Hello frameworks developers, > > > > It has been discussed on the KDE-Community list that some of you would > > like a Frameworks book. > > I would strongly suggest that this is n

Re: Frameworks book

2014-03-16 Thread David Faure
On Saturday 15 March 2014 02:08:52 Valorie Zimmerman wrote: > Hello frameworks developers, > > It has been discussed on the KDE-Community list that some of you would > like a Frameworks book. I would strongly suggest that this is not ONLY a paper book but also an online book where updates get pu

Re: Unknown media types

2014-03-16 Thread David Faure
On Saturday 15 March 2014 19:24:08 Michael Palimaka wrote: > Hi, > > kcoreaddons installs /usr/share/mime/packages/kde5.xml which causes the > following warnings when update-mime-database is executed: > > Unknown media type in type 'all/all' > Unknown media type in type 'all/allfiles' > Unknown m

Re: Releasing Deprecated modules and Tier 4 Definition

2014-03-16 Thread David Faure
On Saturday 15 March 2014 16:59:54 Kevin Ottens wrote: > Hello all, > > This week, Aaron brought to my attention (thx!) that we would be releasing > 5.0 with modules which would be immediately deprecated. Indeed that's a > potential maintenance and messaging problem. Do you have a list of such mo

Re: Query: Possible code contribution

2014-03-16 Thread Kevin Krammer
On Sunday, 2014-03-16, 00:16:45, Lydia Pintscher wrote: > On Fri, Mar 14, 2014 at 2:40 PM, Ganesh Kumar wrote: > > Hi. > > This is Ganesh P Kumar, doing my B.Tech in Computer Science and > > Engineering > > in IIT Madras. As part of our curriculum we must contribute code to an > > open > > source

Re: KGuiAddons Review

2014-03-16 Thread David Faure
On Tuesday 04 March 2014 18:46:53 John Layt wrote: > Hi, > > Here's my first pass through KGuiAddons, focussing on the public api. > > KColorCollection > - Should probably become a QSharedDataPointer Maybe. But OTOH it's just a QList, two QStrings and a an enum. > KWorkdWrap > - "// KDE5 TODO:

Review Request 116830: Replace use of QPA headers with optional dep on QX11Extras.

2014-03-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116830/ --- Review request for KDE Frameworks, Kevin Ottens and Martin Gräßlin. Repos

reviews

2014-03-16 Thread David Faure
On Sunday 23 February 2014 16:12:58 Albert Astals Cid wrote: > El Dissabte, 22 de febrer de 2014, a les 16:52:38, Luigi Toscano va escriure: > > Hi all, > > these are the steps of plan for bumping the default DocBook XML version to > > 4.5 while keeping the compatibility on the old 4.2-based when

Re: Review Request 116087: remove usage of strlcpy

2014-03-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116087/#review53028 --- src/kcrash.cpp

Re: kjsembed tier (Re: Build failed in Jenkins: kjsembed_master_qt5 #27)

2014-03-16 Thread David Faure
On Saturday 01 March 2014 12:49:02 Aurélien Gâteau wrote: > I had a look at the CMake code in KJSEmbed: it does not link to any > target provided by KDocTools, so CMake Graphviz code does not list it as > a dependency. You can declare the dependency manually. I documented how > to do it here: > >