Re: Review Request 116798: Rewrite KUser/KUserGroup Widows implementation + introduce KUserId/KGroupId

2014-03-15 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116798/#review53017 --- Ship it! Looks good, seems to build, install, and work here,

Re: Releasing Deprecated modules and Tier 4 Definition

2014-03-15 Thread Aleix Pol
On Sat, Mar 15, 2014 at 4:59 PM, Kevin Ottens wrote: > Hello all, > > This week, Aaron brought to my attention (thx!) that we would be releasing > 5.0 > with modules which would be immediately deprecated. Indeed that's a > potential > maintenance and messaging problem. > Also, to make things wors

Re: Default emoticons theme

2014-03-15 Thread Aleix Pol
On Sat, Mar 15, 2014 at 3:14 PM, Kevin Ottens wrote: > Hello, > > On Saturday 15 March 2014 11:30:22 Alex Merry wrote: > > - it moves to kemoticons (where it will be guaranteed to be installed), > > retains its current name, and kemoticons selects "kf5" by default. > > It has my preference, so th

Re: Review Request 116798: Rewrite KUser/KUserGroup Widows implementation + introduce KUserId/KGroupId

2014-03-15 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116798/ --- (Updated March 15, 2014, 5:02 p.m.) Review request for KDE Frameworks.

Releasing Deprecated modules and Tier 4 Definition

2014-03-15 Thread Kevin Ottens
Hello all, This week, Aaron brought to my attention (thx!) that we would be releasing 5.0 with modules which would be immediately deprecated. Indeed that's a potential maintenance and messaging problem. Also, to make things worse, it looks like it makes the definition of Tier 4 harder. I know D

Re: Review Request 116798: Rewrite KUser/KUserGroup Widows implementation + introduce KUserId/KGroupId

2014-03-15 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116798/ --- (Updated March 15, 2014, 4:52 p.m.) Review request for KDE Frameworks.

Re: RFC on framework localization

2014-03-15 Thread Albert Astals Cid
El Divendres, 14 de març de 2014, a les 03:48:49, Aurélien Gâteau va escriure: > Hi, > > I started working on ensuring frameworks can be correctly localized and > have some questions. > > # Messages.sh place > > I noticed some frameworks already have Messages.sh files in there. Most > of them ar

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-15 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/ --- (Updated March 15, 2014, 4:37 p.m.) Review request for KDE Frameworks and

Re: Review Request 116090: Use $ instead of get_target_property(... LOCATION)

2014-03-15 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116090/ --- (Updated March 15, 2014, 4:31 p.m.) Status -- This change has been d

Re: Review Request 115916: Fix MSVC build of kprintpreview_test

2014-03-15 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115916/ --- (Updated March 15, 2014, 4:31 p.m.) Status -- This change has been d

Re: Review Request 116087: remove usage of strlcpy

2014-03-15 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116087/ --- (Updated March 15, 2014, 4:31 p.m.) Review request for KDE Frameworks and

Re: Review Request 116798: Rewrite KUser/KUserGroup Widows implementation + introduce KUserId/KGroupId

2014-03-15 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116798/ --- (Updated March 15, 2014, 4:25 p.m.) Review request for KDE Frameworks.

Re: Plasma Next - Translations KCM - What Languages?

2014-03-15 Thread Albert Astals Cid
El Divendres, 14 de març de 2014, a les 22:34:27, Chusslove Illich va escriure: > > [: John Layt :] > > Or do we list all languages regardless of whether they are installed or > > not (probably way too many)? > > I would rather go this way, have this finished once and for all. I would > only try

Frameworks book

2014-03-15 Thread Valorie Zimmerman
Hello frameworks developers, It has been discussed on the KDE-Community list that some of you would like a Frameworks book. While I've co-authored a book for KDE, the Developer Guide for our GSoC students, I'm no coder. So I need co-authors. Mario has asked me to head up the book sprint at Randa

Re: Default emoticons theme

2014-03-15 Thread Kevin Ottens
Hello, On Saturday 15 March 2014 11:30:22 Alex Merry wrote: > - it moves to kemoticons (where it will be guaranteed to be installed), > retains its current name, and kemoticons selects "kf5" by default. It has my preference, so that you don't need an "obscure" (from 3rd party devs POV) dependenc

Default emoticons theme

2014-03-15 Thread Alex Merry
Currently, kde-runtime installs an emoticons theme called "kf5", and the kemoticons framework looks for a theme called "kde4" by default. I suggest that either: - the kde-runtime theme moves to the Oxygen repo, gets renamed to "oxygen", and kemoticons selects this by default, or - it moves to ke

Unknown media types

2014-03-15 Thread Michael Palimaka
Hi, kcoreaddons installs /usr/share/mime/packages/kde5.xml which causes the following warnings when update-mime-database is executed: Unknown media type in type 'all/all' Unknown media type in type 'all/allfiles' Unknown media type in type 'uri/mms' Unknown media type in type 'uri/mmst' Unknown m

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/#review52957 --- looks good to me, just a few minor nitpicks. Most is: prefer u