Re: Review Request 116798: Rewrite KUser/KUserGroup Widows implementation + introduce KUserId/KGroupId

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116798/#review52955 --- Looks OK overall. I'll admit to getting coincidentally tired r

Re: Review Request 116747: Clean up KCompletionBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/#review52953 --- Ship it! Ship It! - Alex Merry On March 14, 2014, 8:46 p.m

Re: Review Request 116799: Remove "KDE4 branch" conditional from kf5i18nuic.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116799/#review52952 --- This review has been submitted with commit 72d59765fe8548eccc

Re: Review Request 116799: Remove "KDE4 branch" conditional from kf5i18nuic.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116799/ --- (Updated March 15, 2014, 1:06 a.m.) Status -- This change has been m

Re: Review Request 116786: Make error handling more consistent and fail earlier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116786/#review52951 --- src/meinproc.cpp

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

> On March 13, 2014, 10:40 p.m., Thomas Lübking wrote: > > You'll need a drawable, clients will require XInitThreads if that is > > accessed from a different than the GUI thread, but it might be possible to > > use an internal Window and move the QObject to the GUI thread on > > construction.

Re: Plasma Next - Translations KCM - What Languages?

> [: John Layt :] > Or do we list all languages regardless of whether they are installed or > not (probably way too many)? I would rather go this way, have this finished once and for all. I would only try to clearly present it not as "you will get this language when you choose it" but as "this is

Re: Review Request 116799: Remove "KDE4 branch" conditional from kf5i18nuic.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116799/#review52948 --- Ship it! Ship It! - Chusslove Illich On March 14, 2014, 3:

Re: Review Request 116747: Clean up KCompletionBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/ --- (Updated March 14, 2014, 8:46 p.m.) Review request for KDE Frameworks.

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

> On March 13, 2014, 11:40 p.m., Thomas Lübking wrote: > > You'll need a drawable, clients will require XInitThreads if that is > > accessed from a different than the GUI thread, but it might be possible to > > use an internal Window and move the QObject to the GUI thread on > > construction.

Re: RFC on framework localization

On Fri, Mar 14, 2014, at 8:55, Aleix Pol wrote: BTW, is there everything in place for non-KI18n modules to be translated? I am currently looking into this, some CMake code needs to be written and integrated in the release tarball at some point. Following Albert advice, I am looking at how Troji

Re: RFC on framework localization

On Fri, Mar 14, 2014 at 11:48 AM, Aurélien Gâteau wrote: > Hi, > > I started working on ensuring frameworks can be correctly localized and > have some questions. > > # Messages.sh place > > I noticed some frameworks already have Messages.sh files in there. Most > of them are in src/. Some are in

Re: Review Request 116087: remove usage of strlcpy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116087/#review52938 --- src/kcrash.cpp

Review Request 116798: Rewrite KUser/KUserGroup Widows implementation + introduce KUserId/KGroupId

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116798/ --- Review request for KDE Frameworks and kdewin. Repository: kcoreaddons D

Re: Review Request 116798: Rewrite KUser/KUserGroup Widows implementation + introduce KUserId/KGroupId

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116798/#review52937 --- autotests/kusertest.cpp

Review Request 116799: Remove "KDE4 branch" conditional from kf5i18nuic.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116799/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n

Plasma Next - Translations KCM - What Languages?

Hi, I'm doing some more work on the new KCM for Translations, i.e. the KCM in Plasma Next to configure the LANGUAGE env var that startkde will export for all apps running under Plasma Next to use, including Gtk as well as Qt apps. Because this is now the workspace/desktop wide setting, and not

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

> On March 13, 2014, 10:40 p.m., Thomas Lübking wrote: > > You'll need a drawable, clients will require XInitThreads if that is > > accessed from a different than the GUI thread, but it might be possible to > > use an internal Window and move the QObject to the GUI thread on > > construction.

Re: Review Request 116087: remove usage of strlcpy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116087/ --- (Updated March 14, 2014, 1:38 p.m.) Review request for KDE Frameworks and

Re: Review Request 116786: Make error handling more consistent and fail earlier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116786/ --- (Updated March 14, 2014, 12:54 p.m.) Review request for Documentation, KD

RFC on framework localization

Hi, I started working on ensuring frameworks can be correctly localized and have some questions. # Messages.sh place I noticed some frameworks already have Messages.sh files in there. Most of them are in src/. Some are in subdirs of src/ (kio, plasma-framework, solid, kwallet, kactivities, kde4s

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/ --- (Updated March 14, 2014, 10:36 a.m.) Review request for KDE Frameworks, k

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

> On March 13, 2014, 10:31 p.m., Martin Gräßlin wrote: > > did you try to make it not use QWidget anymore? There shouldn't be a reason > > why it is QWidget. > > Aaron J. Seigo wrote: > No; I can try it as a non QWidget ... let's see how that goes. So, challenges a plenty :) First, this l

Re: Review Request 116747: Clean up KCompletionBox

> On March 14, 2014, 9:18 a.m., David Faure wrote: > > src/kcompletionbox.h, line 229 > > > > > > That two 'd's too many. Aaargh!! I added those two d's for refactoring and then I forgot to change it (actually

Re: Review Request 116747: Clean up KCompletionBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/#review52928 --- src/kcompletionbox.h

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

> On March 13, 2014, 10:31 p.m., Martin Gräßlin wrote: > > did you try to make it not use QWidget anymore? There shouldn't be a reason > > why it is QWidget. No; I can try it as a non QWidget ... let's see how that goes. - Aaron J. ---

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

> On March 13, 2014, 11:40 p.m., Thomas Lübking wrote: > > You'll need a drawable, clients will require XInitThreads if that is > > accessed from a different than the GUI thread, but it might be possible to > > use an internal Window and move the QObject to the GUI thread on > > construction.