Review Request 116792: Fix deprecation warning in KComboBox and fix all KDE_NO_DEPRECATED

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116792/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/#review52915 --- You'll need a drawable, clients will require XInitThreads if t

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/#review52914 --- did you try to make it not use QWidget anymore? There shouldn'

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

> On March 13, 2014, 3:54 p.m., Matthew Dawson wrote: > > src/core/kcoreconfigskeleton.cpp, line 990 > > > > > > Also, can you change the documentation for KCoreConfigSkeleton to > > reflect this change? Specif

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689/#review52913 --- Ship it! Ship It! - Matthew Dawson On March 13, 2014, 4:06

Re: Review Request 116747: Clean up KCompletionBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/ --- (Updated March 13, 2014, 10:13 p.m.) Review request for KDE Frameworks.

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

> On March 13, 2014, 7:54 p.m., Matthew Dawson wrote: > > src/core/kcoreconfigskeleton.cpp, line 990 > > > > > > Also, can you change the documentation for KCoreConfigSkeleton to > > reflect this change? Specif

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

> On March 13, 2014, 3:54 p.m., Matthew Dawson wrote: > > src/core/kcoreconfigskeleton.cpp, line 990 > > > > > > Also, can you change the documentation for KCoreConfigSkeleton to > > reflect this change? Specif

Re: Review Request 116786: Make error handling more consistent and fail earlier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116786/#review52907 --- src/meinproc.cpp

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689/ --- (Updated March 13, 2014, 8:06 p.m.) Review request for KDE Frameworks and

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

> On March 13, 2014, 7:54 p.m., Matthew Dawson wrote: > > src/core/kconfigini.cpp, lines 86-89 > > > > > > Is there a reason for these extra debug statements? Argh, that stupid post-review script+alias always gra

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689/#review52902 --- Looks good, just a few items below: src/core/kconfigini.cpp

Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/ --- Review request for KDE Frameworks, kwin and Martin Gräßlin. Repository: k

Review Request 116786: Make error handling more consistent and fail earlier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116786/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repos

Re: Review Request 116760: Remove kcookiescfg update scripts

> On March 12, 2014, 5:39 p.m., David Faure wrote: > > well I'm still hoping some sort of migration of the useful config data will > > happen OK, I'll leave this for now, then. - Alex --- This is an automatically generated e-mail.

Re: Review Request 116760: Remove kcookiescfg update scripts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116760/ --- (Updated March 13, 2014, 2:49 p.m.) Status -- This change has been d

Re: Review Request 116785: Unbreak bootstrapping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116785/ --- (Updated March 13, 2014, 2:09 p.m.) Status -- This change has been m

Jenkins build is back to normal : kdoctools_master_qt5 #39

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116785: Unbreak bootstrapping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116785/#review52893 --- This review has been submitted with commit 4ba9dc99782de21d9f

Re: Review Request 116785: Unbreak bootstrapping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116785/#review52892 --- Ship it! Discussed on IRC - Luigi Toscano On March 13, 201

Review Request 116785: Unbreak bootstrapping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116785/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repos

Build failed in Jenkins: kdoctools_master_qt5 #38

See Changes: [agateau] List catalog from all install dirs -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Re: Review Request 116781: List catalog from all install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116781/ --- (Updated March 13, 2014, 1:01 p.m.) Status -- This change has been m

Re: Review Request 116781: List catalog from all install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116781/#review52890 --- This review has been submitted with commit 02478b34df416862c5

Re: Review Request 116781: List catalog from all install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116781/ --- (Updated March 13, 2014, 1:47 p.m.) Review request for Documentation, KDE

Re: Review Request 116781: List catalog from all install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116781/#review52886 --- Ship it! Thank you; I can't test now but it looks sane; as a

Review Request 116781: List catalog from all install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116781/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repos

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116766/ --- (Updated March 13, 2014, 11:27 a.m.) Status -- This change has been

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

> On March 13, 2014, 8:41 a.m., David Faure wrote: > > It would have been better to just put a local copy of that desktop file > > into the kservice autotests subdir, so that it's always available to run > > the test on. > > Now we depend on konsolerun.desktop which might change in the future,

Re: Review Request 116747: Clean up KCompletionBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/#review52881 --- src/kcompletionbox.cpp

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116766/#review52874 --- It would have been better to just put a local copy of that des

Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

> On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote: > > I don't think papering over the X11-ness of kdesu like this is the right > > approach. Of course, what this framework really needs is a test app; maybe > > a simple port of the kdesu app from kde-runtime? > > Kevin Ottens wrote: > This