Build failed in Jenkins: kdelibs_stable #1038

2014-03-12 Thread KDE CI System
See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace Running Prebuild step

Re: Review Request 116685: Import documentationnotfound in kio, used by kio-help

2014-03-12 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116685/ --- (Updated March 13, 2014, 12:48 a.m.) Status -- This change has been

Re: Review Request 116685: Import documentationnotfound in kio, used by kio-help

2014-03-12 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116685/ --- (Updated March 13, 2014, 12:48 a.m.) Status -- This change has been

Re: Review Request 116685: Import documentationnotfound in kio, used by kio-help

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116685/#review52856 --- This review has been submitted with commit 83babc41d2ee44473e

Re: Review Request 116685: Import documentationnotfound in kio, used by kio-help

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116685/#review52855 --- This review has been submitted with commit 19411c1e76c7ebe915

Re: Review Request 116684: Improve API in KCompletionBase

2014-03-12 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116684/ --- (Updated March 12, 2014, 11:06 p.m.) Review request for KDE Frameworks.

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/ --- (Updated March 12, 2014, 10:57 p.m.) Review request for KDE Frameworks.

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/ --- (Updated March 12, 2014, 10:54 p.m.) Review request for KDE Frameworks.

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread David Gil Oliva
> On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote: > > src/kcompletionbox.h, line 228 > > > > > > I wouldn't leave the implementation here. Move it to the .cpp file, > > this way it can be changed in the

Re: Review Request 116037: change entities to reflect new branding

2014-03-12 Thread T.C. Hollingsworth
> On March 4, 2014, 8:48 p.m., Kevin Ottens wrote: > > Ship It! > > Kevin Ottens wrote: > Any news? Anything blocking this patch from being committed? Well I still need to fix the i18n issues and change up the entities a little bit to reflect the feedback to https://mail.kde.org/pipermail

Re: Review Request 116670: Use absolute paths to refer to entities/elements defined in kdoctools

2014-03-12 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116670/ --- (Updated March 12, 2014, 8:31 p.m.) Status -- This change has been m

Re: Review Request 116670: Use absolute paths to refer to entities/elements defined in kdoctools

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116670/#review52838 --- This review has been submitted with commit 4190d2e5dff43ef91c

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-12 Thread Stephen Kelly
> On March 4, 2014, 8:45 p.m., Kevin Ottens wrote: > > And I agree with Aurélien, a bug should be filed and Stephen involved in > > that issue. > > Stephen Kelly wrote: > Please provide a minimal testcase. The feature is unit tested in cmake. > If it's broken, it needs to be fixed soon (be

Re: Review Request 116760: Remove kcookiescfg update scripts

2014-03-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116760/#review52831 --- well I'm still hoping some sort of migration of the useful con

Re: Review Request 116768: Make our css more future-proof

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116768/#review52830 --- Ship it! Ship It! - Alex Merry On March 12, 2014, 3:49 p.m

Re: Review Request 116767: Clean up CMake code from pre-splitting

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116767/#review52829 --- This review has been submitted with commit 62ff6e79ac46d2e2e2

Re: Review Request 116767: Clean up CMake code from pre-splitting

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116767/ --- (Updated March 12, 2014, 4:58 p.m.) Status -- This change has been m

Jenkins build is back to stable : kio_master_qt5 #100

2014-03-12 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116735: Split autotests into their own directory

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116735/ --- (Updated March 12, 2014, 4:55 p.m.) Status -- This change has been m

Re: Review Request 116735: Split autotests into their own directory

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116735/#review52828 --- This review has been submitted with commit 64e14b39ad68f232cc

Re: Review Request 116759: Update kde4 references in comments and apidox

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116759/#review52827 --- This review has been submitted with commit 1527d6faeb7e9b79ad

Re: Review Request 116725: Remove out-of-date README

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116725/#review52821 --- This review has been submitted with commit f348842a676a1b22f5

Re: Review Request 116724: Replace comment that refers to removed code

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116724/ --- (Updated March 12, 2014, 4:46 p.m.) Status -- This change has been m

Re: Review Request 116759: Update kde4 references in comments and apidox

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116759/ --- (Updated March 12, 2014, 4:53 p.m.) Status -- This change has been m

Re: Review Request 116739: Update commented-out cmake code to new macros

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116739/ --- (Updated March 12, 2014, 4:52 p.m.) Status -- This change has been m

Re: Review Request 116739: Update commented-out cmake code to new macros

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116739/#review52826 --- This review has been submitted with commit 661971b0564dce5884

Re: Review Request 116728: Remove no-longer-needed magic variable

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116728/ --- (Updated March 12, 2014, 4:51 p.m.) Status -- This change has been m

Re: Review Request 116728: Remove no-longer-needed magic variable

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116728/#review52824 --- This review has been submitted with commit bdda6298b22b657a1d

Re: Review Request 116727: Remove obsolete code

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116727/ --- (Updated March 12, 2014, 4:50 p.m.) Status -- This change has been m

Re: Review Request 116727: Remove obsolete code

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116727/#review52823 --- This review has been submitted with commit 3f79b430e2b90a8c42

Re: Review Request 116726: Remove unused CMakeLists.txt file

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116726/#review52822 --- This review has been submitted with commit 7f34d1ef2f81fd0991

Re: Review Request 116726: Remove unused CMakeLists.txt file

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116726/ --- (Updated March 12, 2014, 4:49 p.m.) Status -- This change has been m

Re: Review Request 116725: Remove out-of-date README

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116725/ --- (Updated March 12, 2014, 4:48 p.m.) Status -- This change has been m

Re: Review Request 116724: Replace comment that refers to removed code

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116724/#review52820 --- This review has been submitted with commit 5e6b9bab04b572ccd3

Re: Review Request 116087: KCrash: remove usage of strlcpy

2014-03-12 Thread David Faure
> On March 1, 2014, 4:17 p.m., David Faure wrote: > > Hmm, this might be equivalent, but all it means is that the orig code was > > wrong. > > > > We should not make any memory allocations within the crash handler. > > > > So we should instead store the startup id as a const char* somewhere an

Review Request 116768: Make our css more future-proof

2014-03-12 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116768/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapido

Re: Review Request 116767: Clean up CMake code from pre-splitting

2014-03-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116767/#review52807 --- Ship it! Ship It! - Kevin Ottens On March 12, 2014, 2:57 p

Re: Review Request 116735: Split autotests into their own directory

2014-03-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116735/#review52806 --- Ship it! Ship It! - Kevin Ottens On March 12, 2014, 2:51 p

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116766/#review52804 --- Looks fine to me. - Kevin Ottens On March 12, 2014, 3:47 p.

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116766/ --- (Updated March 12, 2014, 3:47 p.m.) Review request for KDE Frameworks and

Re: Review Request 116760: Remove kcookiescfg update scripts

2014-03-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116760/#review52801 --- I think it's fine indeed. Let's see what David think about it.

Re: Review Request 116760: Remove kcookiescfg update scripts

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116760/ --- (Updated March 12, 2014, 3:44 p.m.) Review request for KDE Frameworks and

Re: Review Request 116759: Update kde4 references in comments and apidox

2014-03-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116759/#review52800 --- Ship it! Ship It! - Kevin Ottens On March 12, 2014, 12:58

Re: Review Request 116685: Import documentationnotfound in kio, used by kio-help

2014-03-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116685/#review52798 --- Ship it! Ship It! - Kevin Ottens On March 10, 2014, 5:46 p

Re: Review Request 116739: Update commented-out cmake code to new macros

2014-03-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116739/#review52797 --- Ship it! Ship It! - Kevin Ottens On March 11, 2014, 7:42 p

Re: Review Request 116728: Remove no-longer-needed magic variable

2014-03-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116728/#review52796 --- Ship it! Ship It! - Kevin Ottens On March 11, 2014, 4:50 p

Re: Review Request 116727: Remove obsolete code

2014-03-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116727/#review52795 --- Ship it! Ship It! - Kevin Ottens On March 11, 2014, 4:50 p

Re: Review Request 116726: Remove unused CMakeLists.txt file

2014-03-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116726/#review52794 --- Ship it! Ship It! - Kevin Ottens On March 11, 2014, 4:40 p

Re: Review Request 116725: Remove out-of-date README

2014-03-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116725/#review52793 --- Ship it! Ship It! - Kevin Ottens On March 11, 2014, 4:33 p

Re: Review Request 116724: Replace comment that refers to removed code

2014-03-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116724/#review52791 --- Ship it! Ship It! - Kevin Ottens On March 11, 2014, 4:28 p

Re: Review Request 116670: Use absolute paths to refer to entities/elements defined in kdoctools

2014-03-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116670/#review52788 --- Ship it! Ship It! - Kevin Ottens On March 9, 2014, 2:39 p.

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-12 Thread Kevin Ottens
> On March 4, 2014, 8:45 p.m., Kevin Ottens wrote: > > And I agree with Aurélien, a bug should be filed and Stephen involved in > > that issue. > > Stephen Kelly wrote: > Please provide a minimal testcase. The feature is unit tested in cmake. > If it's broken, it needs to be fixed soon (be

Re: Review Request 116684: Improve API in KCompletionBase

2014-03-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116684/#review52783 --- src/kcompletionbase.h

Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-03-12 Thread Kevin Ottens
> On Feb. 19, 2014, 2:07 p.m., Alex Merry wrote: > > I don't think papering over the X11-ness of kdesu like this is the right > > approach. Of course, what this framework really needs is a test app; maybe > > a simple port of the kdesu app from kde-runtime? > > Kevin Ottens wrote: > This

Re: Review Request 116037: change entities to reflect new branding

2014-03-12 Thread Kevin Ottens
> On March 4, 2014, 8:48 p.m., Kevin Ottens wrote: > > Ship It! Any news? Anything blocking this patch from being committed? - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11603

Re: Review Request 116044: In kstyle: Use the iconSize from mainToolbar

2014-03-12 Thread Kevin Ottens
> On Feb. 25, 2014, 12:10 p.m., David Faure wrote: > > The part of the description that says "if accepted will modify kstyle as > > well" doesn't really make sense anymore (to fix if it's in your commit log > > too). > > > > The bit I'm not sure about is: using MainToolbar icon style everywher

Re: Review Request 115977: RFC: Install KArchive as Mac OS X Framework

2014-03-12 Thread Kevin Ottens
> On March 4, 2014, 8:28 p.m., Kevin Ottens wrote: > > src/karchive.h, line 32 > > > > > > Hm, why the change to "" for the includes? We try to stick to <> in > > public headers. Any news? - Kevin --

Re: Review Request 115916: Fix MSVC build of kprintpreview_test

2014-03-12 Thread Kevin Ottens
> On March 4, 2014, 8:11 p.m., Kevin Ottens wrote: > > Ship It! Any news? - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115916/#review51930

Re: Review Request 116087: KCrash: remove usage of strlcpy

2014-03-12 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116087/ --- (Updated March 12, 2014, 3:26 p.m.) Review request for KDE Frameworks and

Re: Review Request 116087: KCrash: remove usage of strlcpy

2014-03-12 Thread Kevin Ottens
> On March 1, 2014, 4:17 p.m., David Faure wrote: > > Hmm, this might be equivalent, but all it means is that the orig code was > > wrong. > > > > We should not make any memory allocations within the crash handler. > > > > So we should instead store the startup id as a const char* somewhere an

Re: Review Request 116767: Clean up CMake code from pre-splitting

2014-03-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116767/#review52772 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 12, 2014,

Review Request 116767: Clean up CMake code from pre-splitting

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116767/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 116761: Remove KServiceGroup::baseGroup, deprecated since kdelibs 4.3.0

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116761/ --- (Updated March 12, 2014, 2:48 p.m.) Status -- This change has been d

Review Request 116735: Split autotests into their own directory

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116735/ --- Review request for KDE Frameworks. Repository: knewstuff Description --

Re: Review Request 116762: Remove "new in kde4" comment

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116762/ --- (Updated March 12, 2014, 2:47 p.m.) Status -- This change has been m

Re: Review Request 116762: Remove "new in kde4" comment

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116762/#review52762 --- This review has been submitted with commit 581e328460538203b5

Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116766/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 116762: Remove "new in kde4" comment

2014-03-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116762/#review52753 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 12, 2014,

Review Request 116762: Remove "new in kde4" comment

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116762/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread Alex Merry
> On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote: > > src/kcompletionbox.h, line 228 > > > > > > I wouldn't leave the implementation here. Move it to the .cpp file, > > this way it can be changed in the

Review Request 116761: Remove KServiceGroup::baseGroup, deprecated since kdelibs 4.3.0

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116761/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread Aleix Pol Gonzalez
> On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote: > > src/kcompletionbox.h, line 228 > > > > > > I wouldn't leave the implementation here. Move it to the .cpp file, > > this way it can be changed in the

Re: Review Request 116758: Remove kcfg preprocessing script

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116758/#review52746 --- This review has been submitted with commit 0e150c6112aab97db5

Re: Review Request 116758: Remove kcfg preprocessing script

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116758/ --- (Updated March 12, 2014, 1:07 p.m.) Status -- This change has been m

Review Request 116760: Remove kcookiescfg update scripts

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116760/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 116758: Remove kcfg preprocessing script

2014-03-12 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116758/#review52745 --- Ship it! Ship It! - Aurélien Gâteau On March 12, 2014, 1:4

Review Request 116759: Update kde4 references in comments and apidox

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116759/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 116758: Remove kcfg preprocessing script

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116758/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapido

Re: Review Request 116756: Remove "Class Members" link. It's broken and not useful.

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116756/#review52742 --- This review has been submitted with commit 7e57517805935d2415

Re: Review Request 116756: Remove "Class Members" link. It's broken and not useful.

2014-03-12 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116756/ --- (Updated March 12, 2014, 12:46 p.m.) Status -- This change has been

Re: Review Request 116756: Remove "Class Members" link. It's broken and not useful.

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116756/#review52741 --- Ship it! Ship It! - Alex Merry On March 12, 2014, 9:26 a.m

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/#review52740 --- Looks sensible to me, but I'll let Aleix reply. src/kcomplet

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread Alex Merry
> On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote: > > src/kcompletionbox.h, line 228 > > > > > > I wouldn't leave the implementation here. Move it to the .cpp file, > > this way it can be changed in the

Re: KF5 Update Meeting Minutes 2014-w11

2014-03-12 Thread Alex Merry
On 12/03/14 07:56, Kevin Ottens wrote: > Hello, > > On Tuesday 11 March 2014 22:19:06 David Gil Oliva wrote: >> 2014-03-11 16:33 GMT+01:00 Kevin Ottens : >> Why is that? Are we in a hurry? Is the work in all the frameworks so >> advanced that we can advance the tagging? > > It just a question of

Re: Review Request 116740: Fix kdeglobals location in apidox

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116740/#review52738 --- This review has been submitted with commit 58745952d1d2d27d5d

Re: Review Request 116740: Fix kdeglobals location in apidox

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116740/ --- (Updated March 12, 2014, 11:41 a.m.) Status -- This change has been

Re: Review Request 116699: No longer use pid_t or Q_PID

2014-03-12 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116699/#review52731 --- there is QProcess::processId() since 5.3 (replacing KProcess::

Review Request 116756: Remove "Class Members" link. It's broken and not useful.

2014-03-12 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116756/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapido

Re: Review Request 116012: Inline deprecated methods, and silence false positives in tests

2014-03-12 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116012/#review52727 --- src/karchive.h

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread David Gil Oliva
> On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote: > > src/kcompletionbox.h, line 228 > > > > > > I wouldn't leave the implementation here. Move it to the .cpp file, > > this way it can be changed in the

Re: KF5 Update Meeting Minutes 2014-w11

2014-03-12 Thread Kevin Ottens
Hello, On Tuesday 11 March 2014 22:19:06 David Gil Oliva wrote: > 2014-03-11 16:33 GMT+01:00 Kevin Ottens : > Why is that? Are we in a hurry? Is the work in all the frameworks so > advanced that we can advance the tagging? It just a question of David's availability. > BTW, is it allowed to depr

Re: Review Request 116699: No longer use pid_t or Q_PID

2014-03-12 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116699/ --- (Updated March 12, 2014, 7:36 a.m.) Review request for KDE Frameworks, Da

Re: Review Request 116685: Import documentationnotfound in kio, used by kio-help

2014-03-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116685/#review52717 --- Ship it! Ship It! - David Faure On March 10, 2014, 5:46 p.

Re: Review Request 116699: No longer use pid_t or Q_PID

2014-03-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116699/#review52716 --- Ship it! So getpid() actually exists on Windows? And it retu