Review Request 116588: Improve the README

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116588/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 116542: Fix compilation with clang 3.4.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116542/#review51851 --- >From what I can tell declaring *any* type A::B is a "qualifie

Re: Review Request 116573: Make KI18n a private dependency in KIO

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116573/ --- (Updated March 4, 2014, 12:18 a.m.) Status -- This change has been m

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116103/#review51844 --- Ok, I just realized this was being dealt with and I did a diff

Re: KUnitConversion Review

On 2 March 2014 19:58, Kevin Ottens wrote: > On Thursday 27 February 2014 17:15:56 John Layt wrote: >> * Try port away from ki18n to tr(). KUC makes extensive use of ki18nc() and >> ki18ncp(), but I need to check with Chusselove if all the plural >> translations can be handled with Qt or if any

Re: KItemModels, Solid & KJS licenses

What license are you asking for? Sorry I haven't read the back info and don't feel like digging. :) On Mar 3, 2014 2:55 PM, "šumski" wrote: > On Wednesday 19 of February 2014 21:18:31 šumski wrote: > > Hi all, > > > > i've started pushing Frameworks to openSUSE Factory (i.e. next openSUSE > > rel

Re: KItemModels, Solid & KJS licenses

I'm ok with lgpl. On Mar 3, 2014 4:29 PM, "šumski" wrote: > On Monday 03 of March 2014 16:20:20 George Staikos wrote: > > What license are you asking for? Sorry I haven't read the back info and > > don't feel like digging. :) > > > > Quote: > "kwallet-framework-4.96.0/src/runtime/kwalletd/kbette

Re: Binary incompatible changes

On Sun, Mar 2, 2014 at 5:03 AM, Albert Astals Cid wrote: > El Dissabte, 1 de març de 2014, a les 16:53:28, David Faure va escriure: >> On Saturday 01 March 2014 16:39:56 Albert Astals Cid wrote: >> > Every time someone commits to okular, which may a bit too much, no? >> >> This is not what I sugg

Re: Review Request 116539: Add README

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116539/ --- (Updated March 3, 2014, 9:46 p.m.) Status -- This change has been ma

Re: Review Request 116540: Add configuration for ReviewBoard

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116540/ --- (Updated March 3, 2014, 9:46 p.m.) Status -- This change has been ma

Re: KItemModels, Solid & KJS licenses

On Monday 03 of March 2014 16:20:20 George Staikos wrote: > What license are you asking for? Sorry I haven't read the back info and > don't feel like digging. :) > Quote: "kwallet-framework-4.96.0/src/runtime/kwalletd/kbetterthankdialog.(cpp|h) and kwallet-framework-4.96.0/src/runtime/kwalletd/k

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116103/ --- (Updated March 3, 2014, 8:59 p.m.) Status -- This change has been ma

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116103/#review51821 --- This review has been submitted with commit bf41a9aa94881db1d7

Re: KItemModels, Solid & KJS licenses

On Wednesday 19 of February 2014 21:18:31 šumski wrote: > Hi all, > > i've started pushing Frameworks to openSUSE Factory (i.e. next openSUSE > release), and our legal review found some issues[1][2][3] with mentioned > frameworks licenses. Ok, after next batch, issue came up with kwallet[1]

Re: KDNSSD merge

El Diumenge, 2 de març de 2014, a les 21:32:58, Matthew Dawson va escriure: > On March 3, 2014 12:51:10 AM Albert Astals Cid wrote: > > I wasn't following the discussion. Can anyone summarize how 4.x are > > releases affected? > > > > Thanks! > > > > Albert > > The kdnssd repository in the kdene

Re: Review Request 116573: Make KI18n a private dependency in KIO

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116573/#review51810 --- Ship it! Ship It! - David Faure On March 3, 2014, 5:21 p.m

Review Request 116573: Make KI18n a private dependency in KIO

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116573/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Build failed in Jenkins: knotifications_master_qt5 #35

See Changes: [mklapetek] Make id() and appName() public methods [mklapetek] Always pass only the KNotification object, no need for separate id [mklapetek] Change notify() method to only take KNotification object [mklapetek] Simpli

Re: Review Request 116087: KCrash: remove usage of strlcpy

> On March 1, 2014, 4:17 p.m., David Faure wrote: > > Hmm, this might be equivalent, but all it means is that the orig code was > > wrong. > > > > We should not make any memory allocations within the crash handler. > > > > So we should instead store the startup id as a const char* somewhere an

Re: Review Request 116087: KCrash: remove usage of strlcpy

> On March 1, 2014, 4:17 p.m., David Faure wrote: > > Hmm, this might be equivalent, but all it means is that the orig code was > > wrong. > > > > We should not make any memory allocations within the crash handler. > > > > So we should instead store the startup id as a const char* somewhere an

Re: Review Request 116567: Implement fuzzy image matching in readtest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116567/ --- (Updated March 3, 2014, 3:23 p.m.) Review request for KDE Frameworks. C

Re: c++ plugins with Frameworks 5

On Monday, March 3, 2014 12:35:40 Alex Merry wrote: > Could we not extend scripty to do the same for the .json files? We most problably .. but I haven’t looked at scripty so do not know how much work it would be, and I try not to interfere with i18n workflows. but yes, this should be possible.

Jenkins build is unstable: kde-baseapps_frameworks_qt5 #1

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116567: Implement fuzzy image matching in readtest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116567/#review51782 --- My understanding is that all image formats we support are supp

Re: Review Request 116568: Fixes to PIC image format handler

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116568/ --- (Updated March 3, 2014, 1:15 p.m.) Review request for KDE Frameworks and

Re: Review Request 116566: Fix warnings while running kdeinit5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116566/#review51770 --- This review has been submitted with commit 7745f1a8edfa1ce840

Re: Review Request 116566: Fix warnings while running kdeinit5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116566/ --- (Updated March 3, 2014, 1:09 p.m.) Status -- This change has been ma

Re: Review Request 116566: Fix warnings while running kdeinit5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116566/#review51769 --- Ship it! Ship It! - Alex Merry On March 3, 2014, 12:58 p.m

Review Request 116568: Fixes to PIC image format handler

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116568/ --- Review request for KDE Frameworks. Repository: kimageformats Descriptio

Review Request 116567: Implement fuzzy image matching in readtest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116567/ --- Review request for KDE Frameworks. Repository: kimageformats Descriptio

Review Request 116566: Fix warnings while running kdeinit5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116566/ --- Review request for KDE Frameworks. Repository: kinit Description --

Re: c++ plugins with Frameworks 5

On 03/03/14 11:28, Aaron J. Seigo wrote: > hello, > > over the weekend i wrote up a small tool that does what is needed for > libsprinter, which is a Qt5 library (no frameworks deps), to harvest > translations from .desktop files into .json files for inclusion in its > plugins. > > one decisio

c++ plugins with Frameworks 5

hello, over the weekend i wrote up a small tool that does what is needed for libsprinter, which is a Qt5 library (no frameworks deps), to harvest translations from .desktop files into .json files for inclusion in its plugins. one decision i made while writing this was that .desktop files are no

Re: KWindowSystem

On Monday, March 3, 2014 10:34:40 Martin Gräßlin wrote: > It's an incorrect usage caused by XLib not being thread safe. We just > couldn't use KWindowInfo in the runner thread. With the switch to xcb > that's no longer the case and it would be better to have just a QList > and fetch the data in the

Re: Re: KWindowSystem

On Monday 03 March 2014 09:56:11 Aaron J. Seigo wrote: > On Monday, March 3, 2014 08:35:16 you wrote: > > The reason to remove the default ctor was that if one used it, KWindowInfo > > would crash on first usage as it was completely broken. It was documented > > to be there for usages in container

Re: KWindowSystem

On Monday, March 3, 2014 08:35:16 you wrote: > The reason to remove the default ctor was that if one used it, KWindowInfo > would crash on first usage as it was completely broken. It was documented to > be there for usages in container classes but lxr doesn't show any usage and kde-workspace/plasm

Review Request 116561: Drop KWindowEffects::showWindowThumbnails

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116561/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/ --- (Updated March 3, 2014, 9:36 a.m.) Review request for KDE Frameworks, Pla