Binary incompatible changes

Hi all, As there still seem to be remnants of the last BIC change to Frameworks around i've now commenced a force rebuild of all Frameworks on the CI system. Apologies in advance for any noise this creates - but it is necessary for this to be fixed to allow for other Frameworks dependent projects

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

> On Feb. 26, 2014, 10:57 p.m., Albert Astals Cid wrote: > > have you tried removing the include? > > Albert Astals Cid wrote: > Ignore me, there's i18n calls in there :D > > Alex Merry wrote: > However, I wonder if those calls should really be in the header. I have > no idea what cat

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

> On Feb. 24, 2014, 9:22 p.m., Albert Astals Cid wrote: > > src/khelpclient.cpp, line 76 > > > > > > url is always help:/ isn't it? Not sure i understand the comment > > David Faure wrote: > ? Not sure I unde

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115710/#review51292 --- src/khistorycombobox.cpp

Re: kdesrc-build: stop after failure? --truly-verbose?

On Thu, February 27, 2014 11:35:16 Kevin Funk wrote: > Am Mittwoch, 26. Februar 2014, 23:27:08 schrieb Michael Pyne: > > On Wed, February 26, 2014 22:30:48 Milian Wolff wrote: > > > Also, while at it, could we get a "truly verbose" flag, which actually > > > outputs the output from whatever tool is

Re: Review Request 116037: change entities to reflect new branding

> On Feb. 25, 2014, 10:46 a.m., Burkhard Lück wrote: > > I am fine with the new entities. > > > > But the entities *must* be in all > > lang/user.entities (48) files > > as well. > > Without having the entities in all language user.entities the generation of > > language docbbooks > > using on

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

> On Feb. 26, 2014, 9:57 p.m., Albert Astals Cid wrote: > > have you tried removing the include? > > Albert Astals Cid wrote: > Ignore me, there's i18n calls in there :D > > Alex Merry wrote: > However, I wonder if those calls should really be in the header. I have > no idea what cata

Re: Review Request 116012: Inline deprecated methods, and silence false positives in tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116012/#review51274 --- This review has been submitted with commit 845ccc6ea59fdb7c44

Re: Review Request 116012: Inline deprecated methods, and silence false positives in tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116012/#review51275 --- This review has been submitted with commit e6b97bf5b3820b90cd

Re: Review Request 116012: Inline deprecated methods, and silence false positives in tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116012/ --- (Updated Feb. 28, 2014, 12:58 a.m.) Status -- This change has been m

Re: Review Request 116012: Inline deprecated methods, and silence false positives in tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116012/#review51276 --- This review has been submitted with commit a2104ae9f5ca4d8530

Re: Review Request 116012: Inline deprecated methods, and silence false positives in tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116012/ --- (Updated Feb. 28, 2014, 12:58 a.m.) Status -- This change has been m

Re: Review Request 116012: Inline deprecated methods, and silence false positives in tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116012/#review51273 --- This review has been submitted with commit 06ca03a9482fd06983

[solid] src/imports: Relicense solid "imports" files to LGPLv2.1+

Git commit 5bebd4332ea137849f2060f12a684551dbc81dc6 by Alex Merry. Committed on 28/02/2014 at 00:41. Pushed by alexmerry into branch 'master'. Relicense solid "imports" files to LGPLv2.1+ Permission granted by Ivan Čukić. CCMAIL: ivan.cu...@kde.org CCMAIL: kde-licens...@kde.org CCMAIL: kde-frame

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

> On Feb. 24, 2014, 9:22 p.m., Albert Astals Cid wrote: > > src/khelpclient.cpp, line 76 > > > > > > url is always help:/ isn't it? Not sure i understand the comment > > David Faure wrote: > ? Not sure I unde

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

> On Feb. 26, 2014, 10:57 p.m., Albert Astals Cid wrote: > > have you tried removing the include? > > Albert Astals Cid wrote: > Ignore me, there's i18n calls in there :D > > Alex Merry wrote: > However, I wonder if those calls should really be in the header. I have > no idea what cat

Re: KActivities frameworks soon to become master

El Dijous, 27 de febrer de 2014, a les 11:23:59, Ivan Čukić va escriure: > Hi all, > > Now that the 4.13 has been branched out, KActivities will stop using the > frameworks branch, and master will become the 'new black'. > > There is only a question of how to proceed. > > - Is it wiser just to a

Re: Review Request 116124: Always compile static lib with -fPIC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116124/#review51207 --- Ship it! I've seen the discussion in kde-frameworks-devel, my

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

> On Feb. 26, 2014, 9:57 p.m., Albert Astals Cid wrote: > > have you tried removing the include? > > Albert Astals Cid wrote: > Ignore me, there's i18n calls in there :D > > Alex Merry wrote: > However, I wonder if those calls should really be in the header. I have > no idea what cata

Re: Review Request 116069: Compatibility support for DocBookXML 4.2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116069/ --- (Updated Feb. 27, 2014, 10:43 p.m.) Review request for Documentation and

Re: Review Request 116068: Bump supported DocBookXML version to 4.5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116068/ --- (Updated Feb. 27, 2014, 10:40 p.m.) Review request for Documentation and

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

> On Feb. 27, 2014, 8:09 p.m., David Faure wrote: > > src/khistorycombobox.cpp, line 123 > > > > > > q->connect is a strange way to call a static method. QObject::connect > > would be usual (if a bit more verbos

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

> On Feb. 24, 2014, 9:22 p.m., Albert Astals Cid wrote: > > src/khelpclient.cpp, line 35 > > > > > > Just curious, who is doing this "call setApplicationName() with the > > name of the desktop file" thing? I know

Review Request 116462: Keep KSharedConfigPtr("kdeglobals") around in KHintSettings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116462/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: fra

Re: Review Request 116037: change entities to reflect new branding

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116037/#review51163 --- Ship it! This review can go in :) - Luigi Toscano On Feb.

Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116461/ --- Review request for KDE Frameworks and Matthew John Dawson. Repository: kc

Re: Review Request 115963: Fix interference from kdeplatformtheme into unittests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115963/ --- (Updated Feb. 27, 2014, 8:13 p.m.) Status -- This change has been ma

Re: Review Request 115963: Fix interference from kdeplatformtheme into unittests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115963/#review51128 --- This review has been submitted with commit 3eb5f0433f79f0c0fd

Re: Review Request 115963: Fix interference from kdeplatformtheme into unittests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115963/#review51126 --- Ship it! Looks good, just one minor issue and it can go in.

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115710/#review51125 --- Ship it! "Tests pass" == unittests? Did you also try playing

Re: Review Request 115963: Fix interference from kdeplatformtheme into unittests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115963/ --- (Updated Feb. 27, 2014, 8:01 p.m.) Review request for KDE Frameworks and

Re: Review Request 115960: Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config().

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115960/#review51123 --- This review has been submitted with commit eb604bc60bcc5cd943

Re: Review Request 115960: Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config().

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115960/ --- (Updated Feb. 27, 2014, 8 p.m.) Status -- This change has been marke

Re: Review Request 115963: KSharedConfig: Fix interference from kdeplatformtheme into unittests

> On Feb. 25, 2014, 3:55 p.m., Matthew John Dawson wrote: > > src/core/ksharedconfig.cpp, line 70 > > > > > > Can you also please clear GlobalSharedConfigList::mainConfig please? > > It should be reset anyways i

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

> On Feb. 26, 2014, 10:57 p.m., Albert Astals Cid wrote: > > have you tried removing the include? > > Albert Astals Cid wrote: > Ignore me, there's i18n calls in there :D > > Alex Merry wrote: > However, I wonder if those calls should really be in the header. I have > no idea what cat

KUnitConversion Review

Hi, I've been reviewing KUnitConversion (KUC for short) and doing some small clean-ups, and I'm slowly coming to the conclusion I'm not a fan of the api. However it is used in a few places, so rather than try rewrite the api in the time remaining, I'll finish up the clean-ups and we can releas

Review Request 116124: Always compile static lib with -fPIC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116124/ --- Review request for KDE Frameworks. Repository: kdoctools Description --

Re: KItemModels, Solid & KJS licenses

> other files: Ivan Čukić. Touched by me (not enough for me to hold any > copyright, though) @Shumski : to repeat my answer on IRC, you have my permission to change to LGPL On 26 February 2014 18:42, Alex Merry wrote: > On 20/02/14 11:41, Alex Merry wrote: > >> [1] https://build.opensuse.org

Re: Compile errors originating from libKF5XsltKde.a

Am Donnerstag, 27. Februar 2014, 15:24:30 schrieb Kevin Funk: > Am Donnerstag, 27. Februar 2014, 13:06:38 schrieb Kevin Funk: > > Hey, > > > > I get the following compile errors when compiling anything that depends on > > libKF5XsltKde.a from kdoctools: > > > > When compiling kio: > > > > [ 53%]

Re: Frameworks sprint: Register now!

On Thu, Feb 27, 2014 at 7:44 AM, Kevin Ottens wrote: > Hello all, > > If you didn't yet, please register for the upcoming sprint: > https://sprints.kde.org/sprint/224 > > Especially if you're not from Barcelona, it's necessary for budgeting the > sprint, booking the accommodation, etc. The guys in

Re: Compile errors originating from libKF5XsltKde.a

Am Donnerstag, 27. Februar 2014, 13:06:38 schrieb Kevin Funk: > Hey, > > I get the following compile errors when compiling anything that depends on > libKF5XsltKde.a from kdoctools: > > When compiling kio: > > [ 53%] Built target kio_file > /home/krf/bin/ld: error: /home/krf/devel/install/kf5/li

Re: kdesrc-build: stop after failure? --truly-verbose?

Am Mittwoch, 26. Februar 2014, 23:27:08 schrieb Michael Pyne: > On Wed, February 26, 2014 22:30:48 Milian Wolff wrote: > > Hey, > > > > not sure this is the right list. I noticed that kdesrc-build happily > > continues building even when a module failed to build. Is this desired? > > Yes, it's on

Compile errors originating from libKF5XsltKde.a

Hey, I get the following compile errors when compiling anything that depends on libKF5XsltKde.a from kdoctools: When compiling kio: [ 53%] Built target kio_file /home/krf/bin/ld: error: /home/krf/devel/install/kf5/lib/x86_64-linux- gnu/libKF5XsltKde.a(xslt.cpp.o): requires dynamic R_X86_64_PC32

Jenkins build became unstable: kpty_master_qt5 #18

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116049: Adjust kjsembed tier for changed ki18n tier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116049/ --- (Updated Feb. 27, 2014, 2:04 p.m.) Status -- This change has been ma

Re: Review Request 116050: Adjust kpty tier for changed ki18n tier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116050/#review51050 --- This review has been submitted with commit 96030f5fae2c7e0493

Re: Review Request 116049: Adjust kjsembed tier for changed ki18n tier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116049/#review51051 --- This review has been submitted with commit 3064544f814813e4f5

Re: Review Request 116050: Adjust kpty tier for changed ki18n tier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116050/ --- (Updated Feb. 27, 2014, 2:03 p.m.) Status -- This change has been ma

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

> On Feb. 26, 2014, 10:57 p.m., Albert Astals Cid wrote: > > have you tried removing the include? > > Albert Astals Cid wrote: > Ignore me, there's i18n calls in there :D > > Alex Merry wrote: > However, I wonder if those calls should really be in the header. I have > no idea what cat

Re: Review Request 116049: Adjust kjsembed tier for changed ki18n tier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116049/#review51048 --- Ship it! Ship It! - Aurélien Gâteau On Feb. 25, 2014, 6:25

Re: Review Request 116050: Adjust kpty tier for changed ki18n tier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116050/#review51047 --- Ship it! Ship It! - Aurélien Gâteau On Feb. 25, 2014, 6:20

Re: Review Request 116012: Inline deprecated methods, and silence false positives in tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116012/#review51046 --- Ship it! Ship It! - Aurélien Gâteau On Feb. 24, 2014, 1:12

Re: Review Request 115953: Clean up kdesu CMake files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115953/#review51044 --- This review has been submitted with commit b1d275bd2246f2b937

Re: Review Request 115953: Clean up kdesu CMake files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115953/ --- (Updated Feb. 27, 2014, 1:04 p.m.) Status -- This change has been ma

Re: Review Request 115953: Clean up kdesu CMake files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115953/#review51045 --- This review has been submitted with commit d5dc6cd3b45bdd5f13

Re: kprintutils - next steps

On 27/02/14 11:21, John Layt wrote: > On 23 February 2014 20:02, John Layt wrote: >> 2) Copy code from kprintutils to kde4support >> - Do we bother to keep the history? >> - Where do we put it? > > Alex, if you have that git magic I'd appreciate your doing it, I have > no clue what to do :-) I'm

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review51043 --- While this fix would certainly work, I think it would be good

Re: Review Request 116116: Fix build with Qt 5.3

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116116/#review51042 --- Looks good to me, but someone else must approve. Thanks for ta

Re: Review Request 115953: Clean up kdesu CMake files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115953/#review51040 --- Ship it! Ship It! - Aurélien Gâteau On Feb. 22, 2014, 6:43

Review Request 116116: Fix build with Qt 5.3

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116116/ --- Review request for KDE Frameworks. Repository: solid Description --

Re: Review Request 116088: Remove FindDBusMenuQt5.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116088/ --- (Updated Feb. 27, 2014, 1:19 p.m.) Review request for KDE Frameworks. C

Re: Review Request 115932: Add declarative plugin for KWindowSystem

> On Feb. 27, 2014, 10:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to a

Re: Review Request 115932: Add declarative plugin for KWindowSystem

> On Feb. 27, 2014, 10:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to a

Re: kprintutils - next steps

On 23 February 2014 20:02, John Layt wrote: > I believe the steps required are: > > 1) Port existing apps that are already ported to KF5 away from > KdePrint::createPrintDialog(): > - Okteta > - kfontinst > - ktexteditor > - None use KPrintPreview This has been done, all frameworks code as built

Re: Review Request 115932: Add declarative plugin for KWindowSystem

> On Feb. 27, 2014, 10:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to a

Re: Review Request 115932: Add declarative plugin for KWindowSystem

> On Feb. 27, 2014, 10:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to a

Re: Review Request 115932: Add declarative plugin for KWindowSystem

> On Feb. 27, 2014, 10:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to a

Re: Review Request 115932: Add declarative plugin for KWindowSystem

> On Feb. 27, 2014, 10:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to a

KActivities frameworks soon to become master

Hi all, Now that the 4.13 has been branched out, KActivities will stop using the frameworks branch, and master will become the 'new black'. There is only a question of how to proceed. - Is it wiser just to ask the admins to move rename the branches (removing the old master) and blacklist the fra

Re: [kde-doc-english] Core documentation repository

On 26/02/14 23:45, T.C. Hollingsworth wrote: So, perhaps we need a kde-core-docs.git or something like that to house them in? And advise distros to make sure and add runtime Requires on it from kdoctools or whereever the help: kioslave is shipped? (Alternatively we could just

Re: qt5 polkit-qt-1 and kdesrc-build

On 26/02/14 21:25, Milian Wolff wrote: > Hey all, > > I today sat down trying to finally get a KF5 & kdesrc-build setup done. After > lots of issues related to missing dependencies not listed (fixed now) on > techbase, I hit an issue with kauth, namely that it tried to build agains > tthe > _q

Re: Review Request 115932: Add declarative plugin for KWindowSystem

> On Feb. 27, 2014, 9:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to ad

Re: Review Request 115932: Add declarative plugin for KWindowSystem

> On Feb. 27, 2014, 9:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to ad

Re: Review Request 116098: Use KDEInstallDirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review51012 --- This is largely a policy decision for the maintainers: KDEInst

Re: Review Request 115932: Add declarative plugin for KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115932/#review51011 --- I think the example app needs to be more complete as I doubt t

Re: Review Request 116090: Use $ instead of get_target_property(... LOCATION)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116090/#review51010 --- The problem with doing this in support code is that it is not

Re: Review Request 116087: KCrash: remove usage of strlcpy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116087/#review51008 --- Ship it! The QByteArray clearly has the same lifetime as the

Re: Review Request 115932: Add declarative plugin for KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115932/ --- (Updated Feb. 27, 2014, 10:23 a.m.) Review request for KDE Frameworks and