Re: KDNSSD merge

2014-02-25 Thread Kevin Ottens
On Tuesday 25 February 2014 20:37:28 Alex Merry wrote: > I've had a look at the kdnssd repositoy, and it contains two related > bits of code: the zeroconf ioslave and a kded/KDirWatch module to notify > KIO about changes to available services. > > These two obviously belong together; the question

Re: KDE 5 versioning in documentation

2014-02-25 Thread Kevin Ottens
On Monday 24 February 2014 17:32:58 T.C. Hollingsworth wrote: > If we're instead going to release all applications on their own > schedules, we'll instead probably just want to drop any mention of a > KDE version in applications' documentation. (Or add "on KDE > Frameworks 5" or something like tha

Re: Re: building Solid

2014-02-25 Thread Martin Gräßlin
On Tuesday 25 February 2014 21:27:02 Dominik Haumann wrote: > On Tuesday 25 February 2014 20:34:38 Dominik Haumann wrote: > > Hi, > > > > a fresh Qt5 from stable branch, and a fresh frameworks build results in > > this error when building solid: > > > > $ make > > [ 0%] Automatic moc for target

Re: QUrl -> KUrl porting script

2014-02-25 Thread David Faure
Hi Alex, I guess you mean KUrl -> QUrl, rather :-) On Tuesday 25 February 2014 23:16:23 Alex Merry wrote: > The convert-kurl.pl script doesn't appear to actually convert any KUrl > usages or API, as the comments at the top (and the name) suggest it > should. In fact, the git history suggests it

Re: Review Request 116069: Compatibility support for DocBookXML 4.2

2014-02-25 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116069/ --- (Updated Feb. 26, 2014, 12:40 a.m.) Review request for Documentation and

Review Request 116069: Compatibility support for DocBookXML 4.2

2014-02-25 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116069/ --- Review request for Documentation and KDE Frameworks. Repository: kde4supp

Review Request 116068: Bump supported DocBookXML version to 4.5

2014-02-25 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116068/ --- Review request for Documentation and KDE Frameworks. Repository: kdoctool

QUrl -> KUrl porting script

2014-02-25 Thread Alex Merry
Hi David, The convert-kurl.pl script doesn't appear to actually convert any KUrl usages or API, as the comments at the top (and the name) suggest it should. In fact, the git history suggests it never did. Is there actually a script around to do this? Alex ___

Review Request 116064: @deprecated docs for KUrl methods that duplicate QUrl methods

2014-02-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116064/ --- Review request for KDE Frameworks. Repository: kde4support Description

Re: Review Request 115984: Implement the d-pointer in KCompletionBase as in the other classes

2014-02-25 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115984/#review50892 --- Ping? - David Gil Oliva On Feb. 24, 2014, 12:06 a.m., David

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

2014-02-25 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115710/ --- (Updated Feb. 25, 2014, 10:50 p.m.) Review request for KDE Frameworks.

Review Request 116062: Hide private slots in KCompletionBox and modify d-pointer in KCompletionMatches

2014-02-25 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116062/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Jenkins build is back to stable : khtml_master_qt5 #48

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115897/ --- (Updated Feb. 25, 2014, 9:57 p.m.) Status -- This change has been ma

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115897/#review50887 --- This review has been submitted with commit 77a796be01d597f89b

Re: KDE 5 versioning in documentation

2014-02-25 Thread Luigi Toscano
Martin Klapetek wrote: > Hey, > > On Tue, Feb 25, 2014 at 1:32 AM, T.C. Hollingsworth wrote: > Will the "KDE Software Compilation" still be a thing in the KF5 era, > complete with its own versioned releases? If that's the case, we'll > probably just want to change "KDE" to "KDE SC" in

Jenkins build is back to normal : plasma-framework_master_qt5 » NoX11,LINBUILDER #69

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kde4support_master_qt5 #67

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #69

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KDE 5 versioning in documentation

2014-02-25 Thread Martin Klapetek
Hey, On Tue, Feb 25, 2014 at 1:32 AM, T.C. Hollingsworth < tchollingswo...@gmail.com> wrote: > While reviewing some major changes I made to the Kate documentation > for Kate 5, Luigi Toscano noticed I changed "3.12 &kde; > 4.12" to "5.0 &kde; 5.0" > without thinking. > > I guess "KDE 5.0" isn't

Jenkins build is back to normal : kmediaplayer_master_qt5 #33

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kdeclarative_master_qt5 #32

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kinit_master_qt5 #34

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kdesu_master_qt5 #24

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-25 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115897/#review50885 --- Ship it! Now that the files have been properly moved to kdoct

Re: Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

2014-02-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/#review50881 --- This review has been submitted with commit 30ecb0aaf5d26a69ec

Re: Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

2014-02-25 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/ --- (Updated Feb. 25, 2014, 9:39 p.m.) Status -- This change has been ma

Re: Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

2014-02-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/#review50883 --- This review has been submitted with commit dc44080f15b0fb46d9

Re: Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

2014-02-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/#review50884 --- This review has been submitted with commit d32b88545c50ceec9c

Re: Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

2014-02-25 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/ --- (Updated Feb. 25, 2014, 9:39 p.m.) Status -- This change has been ma

Re: Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

2014-02-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/#review50882 --- This review has been submitted with commit d87c5fe9f84e927b2a

Build failed in Jenkins: kdesu_master_qt5 #23

2014-02-25 Thread KDE CI System
See -- Started by user aacid Building remotely on LinuxSlave - 1 in workspace Running Prebuild steps [kdesu_master_qt5] $ /bin/sh -xe /tmp/hudson1214582845288528

Jenkins build is back to normal : kprintutils_master_qt5 #26

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: khtml_master_qt5 #45

2014-02-25 Thread KDE CI System
See -- [...truncated 552 lines...] In file included from :128:0: cssproperties.gperf:165:61: warning: ‘__gnu_inline__’ attribute ignored [-Watt

Build failed in Jenkins: kmediaplayer_master_qt5 #32

2014-02-25 Thread KDE CI System
See -- Started by user aacid Building remotely on LinuxSlave - 3 in workspace Running Prebuild steps [kmediaplayer_master_qt5] $ /bin/sh -xe /tmp/h

Jenkins build is back to normal : kparts_master_qt5 #33

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : knotifyconfig_master_qt5 #25

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kio_master_qt5 #81

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kinit_master_qt5 #33

2014-02-25 Thread KDE CI System
See -- [...truncated 6 lines...] Preparing to perform KDE Continuous Integration build == Setting Up Sources >From git://anongit.kde.org/kinit 270b001..80cf179 master -> origin/master Branch jenkins se

Jenkins build is back to normal : kemoticons_master_qt5 #25

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdesu_master_qt5 #22

2014-02-25 Thread KDE CI System
See -- Started by user aacid Building remotely on LinuxSlave - 4 in workspace Running Prebuild steps [kdesu_master_qt5] $ /bin/sh -xe /tmp/hudson2607908503750182

Jenkins build is back to normal : kdesignerplugin_master_qt5 #30

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kded_master_qt5 #27

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdeclarative_master_qt5 #31

2014-02-25 Thread KDE CI System
See -- Started by user aacid Building remotely on LinuxSlave - 4 in workspace Running Prebuild steps [kdeclarative_master_qt5] $ /bin/sh -xe /tmp/h

Jenkins build is back to stable : kbookmarks_master_qt5 #29

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kxmlgui_master_qt5 #59

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : ktextwidgets_master_qt5 #24

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kservice_master_qt5 #54

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kiconthemes_master_qt5 #29

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kconfigwidgets_master_qt5 #27

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kglobalaccel_master_qt5 #23

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #68

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- [...truncated 613 lines...] Generating moc_panel.cpp Generating moc_scriptengine.cpp Generating moc_widget.cpp Gener

Build failed in Jenkins: kxmlgui_master_qt5 #58

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- [...truncated 381 lines...] /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/ktextwidgets/inst/lib64/libKF5TextWidgets.so.4: undefined reference to `K

Jenkins build became unstable: kservice_master_qt5 #53

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kwallet_master_qt5 #56

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- [...truncated 152 lines...] LIB_SUFFIX SIP_DEFAULT_SIP_DIR -- Build files have been written to:

Build failed in Jenkins: ktextwidgets_master_qt5 #23

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- [...truncated 39 lines...] kcoreaddons - Branch master karchive - Branch master kcodecs - Branch master kdoctools - Branch master

Build failed in Jenkins: kmediaplayer_master_qt5 #31

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- [...truncated 50 lines...] kcodecs - Branch master kdoctools - Branch master kxmlgui - Branch master kservice - Branch master cma

Build failed in Jenkins: kprintutils_master_qt5 #25

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Build failed in Jenkins: kparts_master_qt5 #32

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- [...truncated 376 lines...] /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: warning: libKF5ItemViews.so.4, needed by /srv/jenkins/i

Build failed in Jenkins: knotifyconfig_master_qt5 #24

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

KDNSSD merge

2014-02-25 Thread Alex Merry
I've had a look at the kdnssd repositoy, and it contains two related bits of code: the zeroconf ioslave and a kded/KDirWatch module to notify KIO about changes to available services. These two obviously belong together; the question is where? They can go in kdnssd-framework, making it depend on K

Build failed in Jenkins: kio_master_qt5 #80

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- [...truncated 472 lines...] Scanning dependencies of target kioslave-httpobjecttest_automoc [ 19%] Generating moc_httpauthenticationtest.cpp Automatic moc for targ

Build failed in Jenkins: kinit_master_qt5 #32

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace

Build failed in Jenkins: kiconthemes_master_qt5 #28

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- [...truncated 21 lines...] Checking out Revision ba83a5668cd3945aa0c47d4a8082690c49be5793 (refs/heads/jenkins) Run condition [File exists] enabling prebui

Build failed in Jenkins: khtml_master_qt5 #44

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- [...truncated 135 lines...] * KF5I18n (required version >= 4.96.0) * KF5CoreAddons * KF5Auth * KF5Config * KF5GuiAddons * KF5ConfigWidgets (required versio

Re: building Solid

2014-02-25 Thread Dominik Haumann
On Tuesday 25 February 2014 20:34:38 Dominik Haumann wrote: > Hi, > > a fresh Qt5 from stable branch, and a fresh frameworks build results in this > error when building solid: > > $ make > [ 0%] Automatic moc for target KF5Solid > [ 0%] Built target KF5Solid_automoc > [ 1%] Building CXX object

Build failed in Jenkins: kemoticons_master_qt5 #24

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Build failed in Jenkins: kglobalaccel_master_qt5 #22

2014-02-25 Thread KDE CI System
See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace Running Prebuild steps [kgl

Build failed in Jenkins: kdesu_master_qt5 #21

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Build failed in Jenkins: kdesignerplugin_master_qt5 #29

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Build failed in Jenkins: kdeclarative_master_qt5 #30

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace

Build failed in Jenkins: kded_master_qt5 #26

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace R

Build failed in Jenkins: kde4support_master_qt5 #66

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- [...truncated 142 lines...] -- Looking for inet_ntop -- Looking for inet_ntop - found -- Looking for getprotobyname_r -- Looking for getprotobyname_r - fou

Build failed in Jenkins: kconfigwidgets_master_qt5 #25

2014-02-25 Thread KDE CI System
See Changes: [jr] set SOVERSION to 5 -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace

Jenkins build became unstable: kbookmarks_master_qt5 #28

2014-02-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116025: Add documentation about writing find modules

2014-02-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/ --- (Updated Feb. 25, 2014, 8:11 p.m.) Review request for Build System, Extra

Re: Review Request 116056: Port to Qt5 and Kf5 of dnssd ioslave and kded module

2014-02-25 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116056/ --- (Updated Feb. 25, 2014, 9:02 p.m.) Review request for KDE Frameworks. S

Review Request 116056: Port to Qt5 and Kf5 of dssd ioslave and kded module

2014-02-25 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116056/ --- Review request for KDE Frameworks. Repository: kdnssd Description -

building Solid

2014-02-25 Thread Dominik Haumann
Hi, a fresh Qt5 from stable branch, and a fresh frameworks build results in this error when building solid: $ make [ 0%] Automatic moc for target KF5Solid [ 0%] Built target KF5Solid_automoc [ 1%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/managerbase.cpp.o In file included from /

KDE 5 versioning in documentation

2014-02-25 Thread T.C. Hollingsworth
While reviewing some major changes I made to the Kate documentation for Kate 5, Luigi Toscano noticed I changed "3.12 &kde; 4.12" to "5.0 &kde; 5.0" without thinking. I guess "KDE 5.0" isn't going to be a thing in the future, so that begs the question as to what to change this to in all our appli

Re: setting SOVERSION to 5

2014-02-25 Thread Kevin Ottens
On Monday 24 February 2014 16:13:48 Jonathan Riddell wrote: > In the tech preview release the libraries were all versioned 5.0.0 > with SOVERSION of 5. In alpha 1 that became 4.96.0 with SOVERSION of > 4. The SOVERSION will presumably go back to 5 at some point before > release. It's quite hassl

Re: setting SOVERSION to 5

2014-02-25 Thread Kevin Ottens
On Tuesday 25 February 2014 19:15:05 šumski wrote: > On Tuesday 25 of February 2014 18:45:15 Kevin Ottens wrote: > > On Tuesday 25 February 2014 17:12:37 Jonathan Riddell wrote: > > > On Tue, Feb 25, 2014 at 04:55:43PM +0100, Kevin Ottens wrote: > > > > OK, but then the said change is either in the

Re: Review Request 116051: Adjust kunitconversion tier for changed ki18n tier

2014-02-25 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116051/ --- (Updated Feb. 25, 2014, 6:16 p.m.) Status -- This change has been ma

Re: Review Request 116051: Adjust kunitconversion tier for changed ki18n tier

2014-02-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116051/#review50860 --- This review has been submitted with commit fb3a9d530ce3043fe3

Re: setting SOVERSION to 5

2014-02-25 Thread šumski
On Tuesday 25 of February 2014 18:45:15 Kevin Ottens wrote: > On Tuesday 25 February 2014 17:12:37 Jonathan Riddell wrote: > > On Tue, Feb 25, 2014 at 04:55:43PM +0100, Kevin Ottens wrote: > > > OK, but then the said change is either in the packaging or in our own > > > cmake > > > files as we'd ha

Re: Review Request 116051: Adjust kunitconversion tier for changed ki18n tier

2014-02-25 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116051/#review50858 --- Ship it! Ship It! - John Layt On Feb. 25, 2014, 5:22 p.m.,

Re: Review Request 116025: Add documentation about writing find modules

2014-02-25 Thread Alex Merry
> On Feb. 25, 2014, 3:56 p.m., Stephen Kelly wrote: > > docs/writing-find-modules.md, line 9 > > > > > > You can link to > > > > http://www.cmake.org/cmake/help/git-master/manual/cmake-packages.7.html > >

Re: KDocTools history import

2014-02-25 Thread Alex Merry
On 25/02/14 11:48, Alex Merry wrote: > On 24/02/14 22:16, Luigi Toscano wrote: >> Alex Merry wrote: >>> I screwed up the history import of the FindDocBook*.cmake files from >>> e-c-m into KDocTools, so Luigi asked me to do it again. This involves >>> removing those files, then merging in a more se

Re: setting SOVERSION to 5

2014-02-25 Thread Kevin Ottens
On Tuesday 25 February 2014 17:12:37 Jonathan Riddell wrote: > On Tue, Feb 25, 2014 at 04:55:43PM +0100, Kevin Ottens wrote: > > OK, but then the said change is either in the packaging or in our own > > cmake > > files as we'd have to drop the SOVERSION later on when our version becomes > > 5.0.0.

Re: Review Request 116049: Adjust kjsembed tier for changed ki18n tier

2014-02-25 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116049/ --- (Updated Feb. 25, 2014, 5:25 p.m.) Review request for KDE Frameworks and

Review Request 116051: Adjust kunitconversion tier for changed ki18n tier

2014-02-25 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116051/ --- Review request for KDE Frameworks, John Layt and Petri Damstén. Repositor

Review Request 116050: Adjust kpty tier for changed ki18n tier

2014-02-25 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116050/ --- Review request for KDE Frameworks. Repository: kpty Description ---

Review Request 116049: Adjust tier for changed ki18n tier

2014-02-25 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116049/ --- Review request for KDE Frameworks and Bernd Buschinski. Repository: kjsem

Re: setting SOVERSION to 5

2014-02-25 Thread Jonathan Riddell
On Tue, Feb 25, 2014 at 04:55:43PM +0100, Kevin Ottens wrote: > OK, but then the said change is either in the packaging or in our own cmake > files as we'd have to drop the SOVERSION later on when our version becomes > 5.0.0. So it's really a question of which is more error prone. No change woul

Re: Review Request 116030: Extend tests to cover getConf... calls

2014-02-25 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116030/ --- (Updated Feb. 25, 2014, 4:17 p.m.) Review request for KDE Frameworks and

Re: Review Request 115960: Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config().

2014-02-25 Thread Matthew Dawson
On February 23, 2014 11:15:47 AM David Faure wrote: > Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as > returned by config(). > I had thought that when dealing with smart pointers, one should in general always pass around the smart pointer and not the raw pointer behind it.

Re: [kde-frameworks-devel] Re: setting SOVERSION to 5

2014-02-25 Thread Kevin Ottens
Hello, On Tuesday 25 February 2014 14:32:27 Jonathan Riddell wrote: > On Tue, Feb 25, 2014 at 03:29:16PM +0100, Kevin Ottens wrote: > > Beside I still don't see a clear motive behind that change (Jonathan > > hinted at helping with packaging but it looks like not all packagers > > agree). > > It n

Re: Review Request 115960: Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config().

2014-02-25 Thread Matthew John Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115960/#review50833 --- Ship it! Ship It! - Matthew John Dawson On Feb. 23, 2014,

Re: Review Request 116025: Add documentation about writing find modules

2014-02-25 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/#review50830 --- There's nothing ecm specific here. The reason I created no suc

Re: Review Request 115963: KSharedConfig: Fix interference from kdeplatformtheme into unittests

2014-02-25 Thread Matthew John Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115963/#review50606 --- src/core/ksharedconfig.cpp

  1   2   >