Re: Mac OS X Frameworks Frameworks

2014-02-23 Thread Kevin Ottens
Hello, On Monday 24 February 2014 02:49:45 Aleix Pol wrote: > I would say that we should follow however it's done in Qt. So far we've > been trying to provide as much of a similar experience as if it was another > Qt module. Doing so here as well could be interesting too. > > The changes you prop

Re: kguiaddons uses qpa headers?

2014-02-23 Thread Kevin Ottens
On Sunday 23 February 2014 17:47:48 David Faure wrote: > On Sunday 23 February 2014 17:02:55 John Layt wrote: > > Hi, > > > > I'm building all of Frameworks from scratch for the first time, using the > > openSUSE packages for Qt 5.2, and qguiaddons fails with: > > > > [ 24%] Building CXX object >

Re: Mac OS X Frameworks Frameworks

2014-02-23 Thread Aleix Pol
On Sun, Feb 23, 2014 at 8:15 PM, Harald Fernengel wrote: > Hi, > > TL;DR > > Do we want to do build KDE Frameworks as Mac OS X Frameworks? > > Long Story: > > on Mac OS X, libraries are typically deployed as "Frameworks" (e.g. a > directory containing the shared library, headers, resources and me

Review Request 115984: Implement the d-pointer in KCompletionBase as in the other classes

2014-02-23 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115984/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

2014-02-23 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115710/ --- (Updated Feb. 23, 2014, 11:23 p.m.) Review request for KDE Frameworks.

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

2014-02-23 Thread David Gil Oliva
> On Feb. 15, 2014, 7:38 p.m., David Faure wrote: > > src/khistorycombobox.cpp, line 508 > > > > > > infinite recursion! > > > > Sounds like a unittest for reset() should be added. There are two reset()

Re: Review Request 115983: Reduce memory leaks

2014-02-23 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115983/ --- (Updated Feb. 23, 2014, 10:14 p.m.) Status -- This change has been m

Re: Review Request 115983: Reduce memory leaks

2014-02-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115983/#review50617 --- This review has been submitted with commit b0a60d0feb2dcac7af

Re: Review Request 115983: Reduce memory leaks

2014-02-23 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115983/#review50616 --- Ship it! Ship It! - Chusslove Illich On Feb. 23, 2014, 10:

Re: Review Request 115983: Reduce memory leaks

2014-02-23 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115983/#review50615 --- It is obviously not really a leak since the KTranscriptImp obj

Re: Review Request 115983: Reduce memory leaks

2014-02-23 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115983/#review50614 --- It is obviously not really a leak since the KTranscriptImp obj

Review Request 115983: Reduce memory leaks

2014-02-23 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115983/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n

Re: Mac OS X Frameworks Frameworks

2014-02-23 Thread John Layt
On 23 February 2014 20:15, Harald Fernengel wrote: > Hi, > > TL;DR > > Do we want to do build KDE Frameworks as Mac OS X Frameworks? I think so, at least for the ones we want to be viewed as proper Qt Add-ons, it would enlarge our possible user-base. From experience in Qt the hard part is keepin

Re: Mac OS X Frameworks Frameworks

2014-02-23 Thread John Layt
On 23 February 2014 20:15, Harald Fernengel wrote: > TL;DR > > Do we want to do build KDE Frameworks as Mac OS X Frameworks? I think so, at least for the ones we want to be viewed as proper Qt Add-ons, it would enlarge our possible user-base. From experience in Qt the hard part is keeping the i

Re: Review Request 115979: Cleanup after QtScript port

2014-02-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115979/#review50613 --- This review has been submitted with commit 463f76bc765e9fc927

Re: Review Request 115979: Cleanup after QtScript port

2014-02-23 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115979/ --- (Updated Feb. 23, 2014, 9:25 p.m.) Status -- This change has been ma

Re: Building frameworks: docbook problems

2014-02-23 Thread Michael Pyne
On Sun, February 23, 2014 17:45:01 John Layt wrote: > On 7 February 2014 10:01, David Faure wrote: > > On Monday 03 February 2014 22:08:20 Andriy Rysin wrote: > >> I am trying to build frameworks using > >> http://community.kde.org/Frameworks/Building on Fedora 20 and it failes > >> in several mod

Re: Review Request 115979: Cleanup after QtScript port

2014-02-23 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115979/#review50612 --- Ship it! Ship It! - Chusslove Illich On Feb. 23, 2014, 8:5

Review Request 115982: Add a tool that creates a Mac OS X icns (icon) file from a svg file

2014-02-23 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115982/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconth

Review Request 115979: Cleanup after QtScript port

2014-02-23 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115979/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n

Mac OS X Frameworks Frameworks

2014-02-23 Thread Harald Fernengel
Hi, TL;DR Do we want to do build KDE Frameworks as Mac OS X Frameworks? Long Story: on Mac OS X, libraries are typically deployed as "Frameworks" (e.g. a directory containing the shared library, headers, resources and meta data). A framework can be simply dragged&dropped to Xcode projects and i

Re: kguiaddons uses qpa headers?

2014-02-23 Thread Kevin Krammer
On Sunday, 2014-02-23, 17:02:55, John Layt wrote: > Hi, > > I'm building all of Frameworks from scratch for the first time, using the > openSUSE packages for Qt 5.2, and qguiaddons fails with: > > [ 24%] Building CXX object > src/CMakeFiles/KF5GuiAddons.dir/util/kmodifierkeyinfoprovider_x11.cpp.o

Review Request 115977: RFC: Install KArchive as Mac OS X Framework

2014-02-23 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115977/ --- Review request for KDE Frameworks. Repository: karchive Description ---

Re: Porting feedback: Hiding the Help button in KConfigDialog

2014-02-23 Thread Kevin Krammer
On Sunday, 2014-02-23, 18:41:38, David Faure wrote: > On Sunday 23 February 2014 14:17:29 Kevin Krammer wrote: > > But usage of the button box already leaks, there are two protected > > accessors to it. > > In which class? You lost me. KPageDialog, base class of KConfigDialog according to the AP

kprintutils - next steps

2014-02-23 Thread John Layt
Hi, I've just merged my clean-ups for kprintutils to remove everything not needed due to the changes in Qt5. Basically what is now left is so minimal that I see no benefit in keeping it as a framework and propose we move it to kde4support instead. There are two parts to kprintutils: 1) The K

Re: Runtime conflict with KF5Plasma and KDE 4 in same prefix

2014-02-23 Thread Martin Graesslin
On Monday 24 February 2014 05:33:37 Michael Palimaka wrote: > Hi, > > I have run into a strange issue when KDE 4 and KF5Plasma are installed > into the same prefix (I can reliably reproduce the issue by > installing/uninstalling KF5Plasma and restarting KDE). > > Simply, the vertical bar key "|"

Runtime conflict with KF5Plasma and KDE 4 in same prefix

2014-02-23 Thread Michael Palimaka
Hi, I have run into a strange issue when KDE 4 and KF5Plasma are installed into the same prefix (I can reliably reproduce the issue by installing/uninstalling KF5Plasma and restarting KDE). Simply, the vertical bar key "|" does not work - it prints nothing. If I run xev from konsole it detects th

Re: kguiaddons uses qpa headers?

2014-02-23 Thread Martin Graesslin
On Sunday 23 February 2014 17:47:48 David Faure wrote: > On Sunday 23 February 2014 17:02:55 John Layt wrote: > > Hi, > > > > I'm building all of Frameworks from scratch for the first time, using the > > openSUSE packages for Qt 5.2, and qguiaddons fails with: > > > > [ 24%] Building CXX object >

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-23 Thread Hrvoje Senjan
> On Feb. 22, 2014, 3:24 p.m., Michael Palimaka wrote: > > If this is tier 1 now, please don't forget to update the wiki and the yaml > > file. Also find_dependency(KF5JS "@KF5_VERSION@") can go away =) - Hrvoje --- This is an automati

Re: Porting feedback: Hiding the Help button in KConfigDialog

2014-02-23 Thread David Faure
On Sunday 23 February 2014 14:17:29 Kevin Krammer wrote: > But usage of the button box already leaks, there are two protected > accessors to it. In which class? You lost me. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 _

Re: Figuring out kde-runtime: localization

2014-02-23 Thread John Layt
On 23 February 2014 17:31, Albert Astals Cid wrote: > El Diumenge, 23 de febrer de 2014, a les 17:26:23, John Layt va escriure: >> >> In KF5 both KLocale and KCurrencyCode are in kde4support > > KCurrencyCode is in kunitconversion. Ah, so it is, had missed that :-) So I guess the maintainer for

Re: kguiaddons uses qpa headers?

2014-02-23 Thread David Faure
On Sunday 23 February 2014 17:02:55 John Layt wrote: > Hi, > > I'm building all of Frameworks from scratch for the first time, using the > openSUSE packages for Qt 5.2, and qguiaddons fails with: > > [ 24%] Building CXX object > src/CMakeFiles/KF5GuiAddons.dir/util/kmodifierkeyinfoprovider_x11.cp

Re: Building frameworks: docbook problems

2014-02-23 Thread John Layt
On 7 February 2014 10:01, David Faure wrote: > On Monday 03 February 2014 22:08:20 Andriy Rysin wrote: >> I am trying to build frameworks using >> http://community.kde.org/Frameworks/Building on Fedora 20 and it failes >> in several modules due to some docbook problem, e.g. in kconfigwidgets: >> >

Re: Figuring out kde-runtime: localization

2014-02-23 Thread Albert Astals Cid
El Diumenge, 23 de febrer de 2014, a les 17:26:23, John Layt va escriure: > On 21 February 2014 13:17, Aleix Pol wrote: > > Hi, > > Going through the information we have in kde-runtime [1] we found there > > are > > two subdirectories related to localization (localization and l10n) that we > > cou

Re: Figuring out kde-runtime: localization

2014-02-23 Thread John Layt
On 21 February 2014 13:17, Aleix Pol wrote: > Hi, > Going through the information we have in kde-runtime [1] we found there are > two subdirectories related to localization (localization and l10n) that we > couldn't find a correct place to move to. > > Can anybody give us a hand and help us figure

kguiaddons uses qpa headers?

2014-02-23 Thread John Layt
Hi, I'm building all of Frameworks from scratch for the first time, using the openSUSE packages for Qt 5.2, and qguiaddons fails with: [ 24%] Building CXX object src/CMakeFiles/KF5GuiAddons.dir/util/kmodifierkeyinfoprovider_x11.cpp.o /media/build/kdesrc- build/src/k5/frameworks/kguiaddons/src/u

Re: Figuring out kde-runtime: localization

2014-02-23 Thread Albert Astals Cid
El Divendres, 21 de febrer de 2014, a les 13:17:58, Aleix Pol va escriure: > Hi, > Going through the information we have in kde-runtime [1] we found there are > two subdirectories related to localization (localization and l10n) that we > couldn't find a correct place to move to. Who is we? Why ar

Re: DocBookXML 4.5, the plan

2014-02-23 Thread Albert Astals Cid
El Dissabte, 22 de febrer de 2014, a les 16:52:38, Luigi Toscano va escriure: > Hi all, > these are the steps of plan for bumping the default DocBook XML version to > 4.5 while keeping the compatibility on the old 4.2-based when kde4support > is used: > > 1) commit rename/changes of FindDocBookXML

Re: CMake error compiling kde-runtime

2014-02-23 Thread Shivam Makkar
On Sun, Feb 23, 2014 at 3:58 PM, David Faure wrote: > On Sunday 23 February 2014 11:05:16 David Gil Oliva wrote: > > CMake Error at > > /home/david/KF5/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:52 > > (find_package): > > Could not find a configuration file for package "KF5DesignerP

Re: configuration file found with version 4.96.0 but version 5.2 is required by the KF5 buld

2014-02-23 Thread Shivam Makkar
On Sat, Feb 22, 2014 at 9:01 PM, Alex Merry wrote: > On 21/02/14 16:01, Shivam Makkar wrote: > > Hi ! > > > > I was trying to build Kde-Framework 5 and got following CMake error > > while executing ./kdesrc-build. > > > > the error produces every time, for Kde-workspace and kde-rumtime, > > regar

Re: Allocating kde-runtime/platforms/win

2014-02-23 Thread Alexander Richardson
2014-02-21 1:17 GMT+01:00 Andrius da Costa Ribas : > Afaik only Alexander Richardson is currently working on KF5 on Windows, but > I think this kcm module is more related to plasma-workspace destination, > given the settings it provides (see attached image) > > Em 20/02/2014 14:47, "Aleix Pol" esc

Re: Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

2014-02-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/#review50594 --- Ship it! Ship It! - Alex Merry On Feb. 23, 2014, 3:02 p.m.

Re: Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

2014-02-23 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/ --- (Updated Feb. 23, 2014, 3:02 p.m.) Review request for Documentation and K

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-23 Thread Alex Merry
> On Feb. 22, 2014, 6:29 p.m., Luigi Toscano wrote: > > As this was already committed, can this RR be closed? > > Alex Merry wrote: > Actually, I never committed this one, since I never got a ship it. I > added the files to kdoctools, but never removed them from e-c-m. > > Luigi Toscano w

Re: Review Request 115956: More generic (renamed) KDocBookXML4.cmake

2014-02-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/#review50592 --- cmake/FindDocBookXML4.cmake

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-23 Thread Luigi Toscano
> On Feb. 22, 2014, 6:29 p.m., Luigi Toscano wrote: > > As this was already committed, can this RR be closed? > > Alex Merry wrote: > Actually, I never committed this one, since I never got a ship it. I > added the files to kdoctools, but never removed them from e-c-m. Is a shipit really

Re: Review Request 115956: More generic (renamed) KDocBookXML4.cmake

2014-02-23 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/ --- (Updated Feb. 23, 2014, 2:34 p.m.) Review request for Documentation and K

Re: WebP image plugin

2014-02-23 Thread David Faure
On Saturday 22 February 2014 10:33:44 Alex Merry wrote: > On 22/02/14 09:11, David Faure wrote: > > On Friday 21 February 2014 16:33:29 Hrvoje Senjan wrote: > >>> On Feb. 20, 2014, 12:56 p.m., Commit Hook wrote: > This review has been submitted with commit > 4fbbc75429597dc545ae8af24e870d

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

2014-02-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115875/#review50580 --- autotests/kconfigtest.cpp

Re: Porting feedback: Hiding the Help button in KConfigDialog

2014-02-23 Thread Kevin Krammer
On Sunday, 2014-02-23, 10:54:01, Kevin Ottens wrote: > On Sunday 23 February 2014 10:08:13 David Faure wrote: > > On Monday 17 February 2014 16:00:08 Eike Hein wrote: > > > Hi, > > > > > > in the KDialog-based KConfigDialog of yesteryear, it was fairly easy > > > > > > to hide the Help button: >

Re: GSoC: KioFuse

2014-02-23 Thread Mark Gaiser
On Sat, Feb 22, 2014 at 11:22 PM, Lydia Pintscher wrote: > On Wed, Feb 19, 2014 at 4:13 PM, Pali Rohár wrote: >> Hello KDE developers! >> >> I looked at KDE GSoC wiki page [1] and there is for me interesting >> project KioFuse. Did I understand it correctly, that KioFuse can be >> usefull for non

Jenkins build is back to stable : kimageformats_master_qt5 #29

2014-02-23 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115504: Only perform tests for plugins that are built

2014-02-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/ --- (Updated Feb. 23, 2014, 11:55 a.m.) Status -- This change has been m

Re: Review Request 115504: Only perform tests for plugins that are built

2014-02-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/#review50579 --- This review has been submitted with commit 6272954cc53fa39e73

Review Request 115963: KSharedConfig: Fix interference from kdeplatformtheme into unittests

2014-02-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115963/ --- Review request for KDE Frameworks and Matthew John Dawson. Repository: kc

Re: Review Request 115028: Inline deprecated KUser::fullName() method

2014-02-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115028/ --- (Updated Feb. 23, 2014, 11:53 a.m.) Status -- This change has been m

Re: Review Request 115028: Inline deprecated KUser::fullName() method

2014-02-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115028/#review50577 --- This review has been submitted with commit 88a0d9828aa5b7e108

Re: Review Request 115028: Inline deprecated KUser::fullName() method

2014-02-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115028/#review50576 --- This review has been submitted with commit fa5a6e77b6f0d70fc7

Re: Review Request 115897: Remove FindDocBook*.cmake

2014-02-23 Thread Alex Merry
> On Feb. 22, 2014, 6:29 p.m., Luigi Toscano wrote: > > As this was already committed, can this RR be closed? Actually, I never committed this one, since I never got a ship it. I added the files to kdoctools, but never removed them from e-c-m. - Alex ---

Re: Review Request 115956: More generic (renamed) KDocBookXML4.cmake

2014-02-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/#review50573 --- Generally looks good. Just a couple of things to fix. CMake

Jenkins build is back to stable : frameworkintegration_master_qt5 #43

2014-02-23 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115960: Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config().

2014-02-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115960/ --- Review request for KDE Frameworks and Matthew John Dawson. Repository: kc

Jenkins build became unstable: frameworkintegration_master_qt5 #42

2014-02-23 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-02-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/ --- (Updated Feb. 23, 2014, 11 a.m.) Review request for KDE Frameworks and Al

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-02-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/#review50567 --- src/khelpclient.h

Re: kstartupconfig5

2014-02-23 Thread David Faure
On Thursday 20 February 2014 11:22:54 Alex Merry wrote: > On 19/02/14 18:07, Jaime wrote: > > I've looked in the bin directory and there is no kstartupconfig5. > > I've done a grep in the source and it is included in kde-workspace, > > > > but aparently, it is only for BSD. > > > > if(LIBBSD_

Re: configuration file found with version 4.96.0 but version 5.2 is required by the KF5 buld

2014-02-23 Thread David Faure
On Saturday 22 February 2014 15:31:36 Alex Merry wrote: > On 21/02/14 16:01, Shivam Makkar wrote: > > Hi ! > > > > I was trying to build Kde-Framework 5 and got following CMake error > > while executing ./kdesrc-build. > > > > the error produces every time, for Kde-workspace and kde-rumtime, > >

Re: CMake error compiling kde-runtime

2014-02-23 Thread David Faure
On Sunday 23 February 2014 11:05:16 David Gil Oliva wrote: > CMake Error at > /home/david/KF5/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:52 > (find_package): > Could not find a configuration file for package "KF5DesignerPlugin" that > is > compatible with requested version "5.2". I

CMake error compiling kde-runtime

2014-02-23 Thread David Gil Oliva
Hi! I've removed the build and install folders of KF5. When running kdesrc-build, I get the following error in kde-runtime: # kdesrc-build running: 'cmake' '/home/david/devel/kf5-development/kde-runtime' '-DCMAKE_CXX_FLAGS:STRING=-pipe -DQT_STRICT_ITERATORS -DQURL_NO_CAST_FROM_STRING -DQT_NO_HTTP

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-02-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/ --- (Updated Feb. 23, 2014, 9:56 a.m.) Review request for KDE Frameworks and

Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-02-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti

Re: Porting feedback: Hiding the Help button in KConfigDialog

2014-02-23 Thread Kevin Ottens
On Sunday 23 February 2014 10:08:13 David Faure wrote: > On Monday 17 February 2014 16:00:08 Eike Hein wrote: > > Hi, > > > > in the KDialog-based KConfigDialog of yesteryear, it was fairly easy > > > > to hide the Help button: > > dialog->button(KDialog::Help)->hide(); > > > > This is useful

Re: Issues porting KGeography to KF5

2014-02-23 Thread David Faure
On Thursday 02 January 2014 19:55:42 Kevin Ottens wrote: > On Thursday 02 January 2014 19:51:17 Albert Astals Cid wrote: > > El Dijous, 2 de gener de 2014, a les 19:48:46, Kevin Ottens va escriure: > > > On Thursday 02 January 2014 19:45:36 Albert Astals Cid wrote: > > > > El Dijous, 2 de gener de

Re: Porting feedback: Hiding the Help button in KConfigDialog

2014-02-23 Thread David Faure
On Monday 17 February 2014 16:00:08 Eike Hein wrote: > Hi, > > in the KDialog-based KConfigDialog of yesteryear, it was fairly easy > to hide the Help button: > > dialog->button(KDialog::Help)->hide(); > > This is useful for apps that don't (yet) ship a handbook, since it > avoids mounting use

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115739/#review50566 --- Ship it! Thanks! tests/listjobtest.cpp

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-23 Thread David Faure
> On Feb. 15, 2014, 8:28 p.m., David Faure wrote: > > Yeah the description is wrong. Making something Q_MOVABLE means that > > inserting into the list, or the copying that happens when reallocating for > > more space, will be able to memmove() instead of copy-constructing items. > > This doesn

Re: X11 usage in kdeinit/kinit.cpp

2014-02-23 Thread David Faure
On Monday 17 February 2014 16:36:45 Martin Gräßlin wrote: > No that doesn't work as I expect that at least during the next decade we > will have both WAYLAND_DISPLAY and DISPLAY being set (DISPLAY for legacy > applications which won't have a Wayland port any time soon - e.g. Qt4). Then I don't se

Re: Review Request 115504: Only perform tests for plugins that are built

2014-02-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/#review50563 --- Ship it! Ship It! - David Faure On Feb. 20, 2014, 1:04 p.m