Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

> On Feb. 20, 2014, 12:21 p.m., Kevin Ottens wrote: > > Please address David's comments, I think this patch is interesting and > > shouldn't stay in limbo too long. Will do as soon as I can. - David --- This is an automatically generat

Re: Review Request 115901: Hide private methods and private slots behind the d-pointer in KLineEdit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115901/#review50493 --- This review has been submitted with commit 96b1ed0736d3ad4f79

Re: Review Request 115901: Hide private methods and private slots behind the d-pointer in KLineEdit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115901/ --- (Updated Feb. 21, 2014, 11:11 p.m.) Status -- This change has been m

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 21, 2014, 4:30 p.m.) Review request for KDE Frameworks and

Review Request 115936: Split ki18n ktranscript tests into one using the plugin and one instantiating/destroying the class directly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115936/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n

Re: desktoptojson and kservice

On Friday, February 21, 2014 15:45:25 Sebastian Kügler wrote: > Including the translations would mean that all translations have to be there > at compile-time, which would mean that runtime changes to translations > aren't picked up. ... are there such things as “runtime changes to translations”?

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

> On Feb. 20, 2014, 12:56 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 4fbbc75429597dc545ae8af24e870d9bac5f2f2a by Alex Merry to branch master. Seems Qt 5.3 will have it's own webp plugin (commit 4522b350e53471c2ebc6d4692736ee4708445b66 in stable branch)... - H

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

> On Feb. 21, 2014, 7:35 a.m., Kevin Ottens wrote: > > autotests/kconfigtest.cpp, line 219 > > > > > > Hm we're loosing the test mode for QStandardPaths, I don't think that's > > desirable. It is done inside te

Re: Review Request 115936: Split ki18n ktranscript tests into one using the plugin and one instantiating/destroying the class directly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115936/ --- (Updated Feb. 21, 2014, 4:58 p.m.) Review request for KDE Frameworks and

Re: Review Request 115876: More generic DocBookXML -> DocBookXML4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115876/#review50488 --- The files have been moved to kdoctools, should I open a new re

Re: Review Request 115909: Remove unused dependency from krunner

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115909/#review50475 --- Ship it! Ship It! - Sebastian Kügler On Feb. 20, 2014, 12:

Re: desktoptojson and kservice

On Friday, February 21, 2014 13:51:47 Aaron J. Seigo wrote: > Aaron J. SeigoOn Friday, February 21, 2014 13:41:29 wrote: > > What are the plans for i18n in desktoptojson? It currently does not catch > > any translations in the .desktop file. > > actually, i think it might be worse than “does not

Re: desktoptojson and kservice

On Friday, February 21, 2014 13:57:07 Kevin Krammer wrote: > If we want to be able to parse .desktop files without KConfig, we need a > desktop file parser. valuable to know, indeed. thanks for sharing your experience, saves me some effort. > The Razor-Qt and LxQt people might have one already.

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/ --- (Updated Feb. 21, 2014, 2:03 p.m.) Review request for KDE Frameworks. C

Re: desktoptojson and kservice

On Friday, 2014-02-21, 13:41:29, Aaron J. Seigo wrote: > While there are shortcomings in QSettings for parsing random INI files, I > don’t think any of these apply to the .desktop files we use. Would there be > any objection / reason against dropping the use of KConfig in desktop and > moving to Q

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115840/#review50469 --- This review has been submitted with commit 3fa7abd2309bd3c8a0

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115840/ --- (Updated Feb. 21, 2014, 12:56 p.m.) Status -- This change has been m

Re: desktoptojson and kservice

Aaron J. SeigoOn Friday, February 21, 2014 13:41:29 wrote: > What are the plans for i18n in desktoptojson? It currently does not catch > any translations in the .desktop file. actually, i think it might be worse than “does not catch any translations”: if it does what i suspect it does, it takes

Re: Review Request 115932: Add declarative plugin for KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115932/#review50468 --- the approach looks good to me, just two small requests: * make

desktoptojson and kservice

Hi ... So, the next fun thing I’ve run into is desktoptojson. Currently in Sprinter I’m just hand writing the json files for the plugins. However, in its TODO file is this: * Metadata * localization/i18n in plugin metadata (name, description) * license * author information (name, email

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/#review50466 --- src/lib/kaboutdata.h

Review Request 115932: Add declarative plugin for KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115932/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kwindow

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/ --- (Updated Feb. 21, 2014, 12:26 p.m.) Review request for KDE Frameworks.

Figuring out kde-runtime: localization

Hi, Going through the information we have in kde-runtime [1] we found there are two subdirectories related to localization (localization and l10n) that we couldn't find a correct place to move to. Can anybody give us a hand and help us figure those out? - localization: has plenty of information re

Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/#review50463 --- This review has been submitted with commit de7d80c720851a8eea

Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/ --- (Updated Feb. 21, 2014, 11:21 a.m.) Status -- This change has been m

Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/#review50465 --- This review has been submitted with commit 8fc1e5ec74d3cdb20e

Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/#review50464 --- This review has been submitted with commit ee71d477120c9d029c

Re: Review Request 115816: Remove strigi libs from kf5-frameworks-build-include

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115816/#review50462 --- This review has been submitted with commit bf6cd416d3a15fd62e

Re: Review Request 115816: Remove strigi libs from kf5-frameworks-build-include

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115816/ --- (Updated Feb. 21, 2014, 11:19 a.m.) Status -- This change has been m

Re: Review Request 115775: Defer to CMake's find_dependency macro if it exists

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115775/ --- (Updated Feb. 21, 2014, 11:17 a.m.) Status -- This change has been m

Re: Review Request 115775: Defer to CMake's find_dependency macro if it exists

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115775/#review50461 --- This review has been submitted with commit dfbbd75577d6029970

Re: Review Request 115742: KParts: Allow compilation on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115742/#review50460 --- Ship it! Ship It! - Alex Merry On Feb. 20, 2014, 4:27 p.m.

Re: Review Request 115907: Link tests with extra libraries as well

> On Feb. 20, 2014, 10:46 a.m., Alex Merry wrote: > > Can you describe the problem this fixes? Are the tests directly using > > these libraries somehow? > > Adrián Chaves Fernández wrote: > If I build with these steps: > > mkdir -p build && cd build > cmake ../kxmlgui-4.96.0 \

Re: Review Request 115908: Remove Ki18n from KCompletion dependencies in cmake.in

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115908/ --- (Updated Feb. 21, 2014, 10:28 a.m.) Status -- This change has been m

Re: Review Request 115908: Remove Ki18n from KCompletion dependencies in cmake.in

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115908/#review50457 --- This review has been submitted with commit ac1ad127c3b440ba0c

Re: Review Request 115827: Add KMainWindow::initialGeometrySet to increase SC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115827/#review50456 --- This review has been submitted with commit db21f504bacc2ca10d

Re: Review Request 115827: Add KMainWindow::initialGeometrySet to increase SC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115827/ --- (Updated Feb. 21, 2014, 10:23 a.m.) Status -- This change has been m

Re: using KDBusConnectionPool in libraries

On Friday, February 21, 2014 08:30:02 Kevin Ottens wrote: > Hello, > > On Thursday 20 February 2014 20:03:20 Aaron J. Seigo wrote: > > I ran into an interesting situation the other day with libkactivities: it > > uses KDBusConnectionPool to create connections in a thread-safe manner. > > KDBusConn

Re: Review Request 115827: Add KMainWindow::initialGeometrySet to increase SC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115827/#review50455 --- Ship it! Ship It! - Kevin Ottens On Feb. 21, 2014, 7:35 a.

Re: Review Request 115602: Rename kactivitymanagerd

> On Feb. 21, 2014, 6:29 a.m., Kevin Ottens wrote: > > I understand Ivan point of view. Now I'm wondering about something: Are we > > sure the situation will be the same in the future for a 5 to 6 transition? > > I don't think we can be 100% sure and so we might want to start versioning > > to

Re: using KDBusConnectionPool in libraries

On Friday, 2014-02-21, 08:30:02, Kevin Ottens wrote: > Hello, > > On Thursday 20 February 2014 20:03:20 Aaron J. Seigo wrote: > > I ran into an interesting situation the other day with libkactivities: it > > uses KDBusConnectionPool to create connections in a thread-safe manner. > > KDBusConnectio

Re: Review Request 115602: Rename kactivitymanagerd

> On Feb. 21, 2014, 6:29 a.m., Kevin Ottens wrote: > > I understand Ivan point of view. Now I'm wondering about something: Are we > > sure the situation will be the same in the future for a 5 to 6 transition? > > I don't think we can be 100% sure and so we might want to start versioning > > to