Re: Review Request 115827: Add KMainWindow::initialGeometrySet to increase SC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115827/ --- (Updated Feb. 21, 2014, 8:35 a.m.) Review request for KDE Frameworks. C

Re: using KDBusConnectionPool in libraries

Hello, On Thursday 20 February 2014 20:03:20 Aaron J. Seigo wrote: > I ran into an interesting situation the other day with libkactivities: it > uses KDBusConnectionPool to create connections in a thread-safe manner. > KDBusConnectionPool creates a connection in whatever thread it happens to > be

Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

> On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote: > > I don't think papering over the X11-ness of kdesu like this is the right > > approach. Of course, what this framework really needs is a test app; maybe > > a simple port of the kdesu app from kde-runtime? > > Kevin Ottens wrote: > This

Re: Review Request 115908: Remove Ki18n from KCompletion dependencies in cmake.in

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115908/#review50449 --- Ship it! Ship It! - Kevin Ottens On Feb. 20, 2014, 11:51 a

Re: Review Request 115901: Hide private methods and private slots behind the d-pointer in KLineEdit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115901/#review50448 --- Ship it! Ship It! - Kevin Ottens On Feb. 19, 2014, 10:57 p

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/#review50447 --- Way to big to properly review to be honest. That said, I agree

Re: Review Request 115827: Add KMainWindow::initialGeometrySet to increase SC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115827/#review50446 --- src/kmainwindow.h

Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

> On Feb. 19, 2014, 2:07 p.m., Alex Merry wrote: > > I don't think papering over the X11-ness of kdesu like this is the right > > approach. Of course, what this framework really needs is a test app; maybe > > a simple port of the kdesu app from kde-runtime? This kind of "papering over" can on

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

> On Feb. 3, 2014, 6:07 p.m., Raphael Kubo da Costa wrote: > > Please see the big comment below the elseif line, the link to the > > kde-core-devel and > > http://lists.kde.org/?l=kde-core-devel&m=138244424421211&w=2: the issue > > here is that if you pass -fno-exceptions to clang you need to

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

> On Jan. 27, 2014, 7:45 a.m., Kevin Ottens wrote: > > src/lib/kaboutdata.cpp, line 941 > > > > > > Not really my type of thing. It's acting on an object behind our back > > without knowing... what happens to co

Re: Review Request 115316: Add demo for KRecentFileList

> On Jan. 27, 2014, 2:23 a.m., Aleix Pol Gonzalez wrote: > > It's a test, not a demo. If you want, it's for demonstrating the developer > > that he did it right, but I wouldn't see it as documentation. > > > > I would rename it to KRecentFilesActionTest > > Kevin Ottens wrote: > Yes, defin

Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/#review50441 --- Ship it! Ship It! - Kevin Ottens On Feb. 19, 2014, 12:47 p

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115840/#review50440 --- Ship it! Ship It! - Kevin Ottens On Feb. 17, 2014, 7:04 p.

Re: Review Request 115816: Remove strigi libs from kf5-frameworks-build-include

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115816/#review50438 --- Ship it! Ship It! - Kevin Ottens On Feb. 19, 2014, 11:54 a

Re: Review Request 115876: More generic DocBookXML -> DocBookXML4

> On Feb. 18, 2014, 11:13 p.m., Alex Merry wrote: > > Does this have any other users than kdoctools? If not, it should probably > > just move to that module. Even if kde4support ends up using it, I don't > > view that as a reason to put it in ECM. > > Luigi Toscano wrote: > There are no

Re: Review Request 115879: DocBookXML has been renamed, use the new exported variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115879/#review50436 --- Ship it! Ship It! - Kevin Ottens On Feb. 18, 2014, 10:54 p

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115875/#review50435 --- autotests/kconfigtest.cpp

Re: Review Request 115602: Rename kactivitymanagerd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115602/#review50434 --- I understand Ivan point of view. Now I'm wondering about somet

Re: Review Request 115775: Defer to CMake's find_dependency macro if it exists

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115775/#review50432 --- Ship it! Ship It! - Kevin Ottens On Feb. 18, 2014, 3:49 p.

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 20, 2014, 2:36 p.m., Kevin Ottens wrote: > > Any concerns left on that patch? It'd be nice to have it in alpha 2. > > Kevin Krammer wrote: > I guess the main problem is that due to a weird JavaScriptCore internal > thing the unit test crashes on exit. > See https://bugreports.

Re: using KDBusConnectionPool in libraries

On Thu, February 20, 2014 20:03:20 Aaron J. Seigo wrote: > Either a better solution needs to be found for KDBusConnectionPool or a > warning should be placed prominently in the apidox about this “gotcha” and > perhaps it should be completely avoided in other frameworks where it is > impossible to k

Re: Review Request 115907: Link tests with extra libraries as well

> On Feb. 20, 2014, 10:46 a.m., Alex Merry wrote: > > Can you describe the problem this fixes? Are the tests directly using > > these libraries somehow? > > Adrián Chaves Fernández wrote: > If I build with these steps: > > mkdir -p build && cd build > cmake ../kxmlgui-4.96.0 \

Re: Review Request 115744: Fix projects using KDocTools on windows.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115744/#review50410 --- Ship it! Ok, even without the opinion from kde-windows, the c

Re: Review Request 115907: Link tests with extra libraries as well

> On Feb. 20, 2014, 10:46 a.m., Alex Merry wrote: > > Can you describe the problem this fixes? Are the tests directly using > > these libraries somehow? If I build with these steps: mkdir -p build && cd build cmake ../kxmlgui-4.96.0 \ -DCMAKE_INSTALL_PREFIX=/usr/bin \ -DCMAKE_BUILD_TYPE=R

Re: Undefined references to Attica

O Xoves, 20 de Febreiro de 2014 10:50:21 Alex Merry escribiu: > On 20/02/14 06:56, Adrián Chaves Fernández wrote: > > I was trying to build frameworks 4.96.0, and I run into trouble compiling > > the tests for KXmlGui, due to undefined references to Attica. I did this to > > solve it: https://git

Jenkins build is back to stable : ktexteditor_master_qt5 #217

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

using KDBusConnectionPool in libraries

Hi.. I ran into an interesting situation the other day with libkactivities: it uses KDBusConnectionPool to create connections in a thread-safe manner. KDBusConnectionPool creates a connection in whatever thread it happens to be executed from. In libkactivities this creates a problem as a single

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 20, 2014, 2:36 p.m., Kevin Ottens wrote: > > Any concerns left on that patch? It'd be nice to have it in alpha 2. I guess the main problem is that due to a weird JavaScriptCore internal thing the unit test crashes on exit. See https://bugreports.qt-project.org/browse/QTBUG-9622 for re

Allocating kde-runtime/platforms/win

Hi! I am going through the list of things where we're moving kde-runtime components to [1] and I see that there's a platform/win directory. Do you agree that having it in a separate repository would be the best? Could anybody with a working KF5 + windows system (if that exists) work on it? Thanks

Re: Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115634/#review50389 --- This review has been submitted with commit 6d3a4405fc2723f579

Re: Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115634/ --- (Updated Feb. 20, 2014, 5:15 p.m.) Status -- This change has been ma

Re: Review Request 115635: Make kconfig_compiler signals actually useful

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/ --- (Updated Feb. 20, 2014, 5:15 p.m.) Status -- This change has been ma

Re: Review Request 115635: Make kconfig_compiler signals actually useful

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/#review50390 --- This review has been submitted with commit 6d3a4405fc2723f579

Re: Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115634/#review50388 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 20, 2014, 3

Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Review Request 115916: Fix MSVC build of kprintpreview_test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115916/ --- Review request for KDE Frameworks. Repository: kprintutils Description

Re: Review Request 115742: KParts: Allow compilation on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115742/ --- (Updated Feb. 20, 2014, 5:27 p.m.) Review request for KDE Frameworks. C

Re: Review Request 115874: Fix unit tests on Windows by adding two expected failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115874/ --- (Updated Feb. 20, 2014, 4:04 p.m.) Status -- This change has been ma

Re: Review Request 115874: Fix unit tests on Windows by adding two expected failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115874/#review50382 --- This review has been submitted with commit 1f07a6af8a219e2adf

Re: Review Request 115702: Check that kconfig_compiler signals get emitted when using KConfigDialog

> On Feb. 20, 2014, 3:32 p.m., Kevin Ottens wrote: > > Ship It! Waiting for https://git.reviewboard.kde.org/r/115634/, otherwise the unit test will fail. - Alexander --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115635: Make kconfig_compiler signals actually useful

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/ --- (Updated Feb. 20, 2014, 4:57 p.m.) Review request for KDE Frameworks. C

Re: KItemModels, Solid & KJS licenses

On Thursday 20 of February 2014 11:41:48 Alex Merry wrote: ... > KItemModels > > kcheckableproxymodel.(cpp|h) is Stephen Kelly (and, for safety, David > Faure). > > modeltest.(cpp|h) were taken from Qt Concurrent, and subsequently > modified by Stephen Kelly, and touched by David Faure and Auréli

Re: Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115634/ --- (Updated Feb. 20, 2014, 4:53 p.m.) Review request for KDE Frameworks. C

Re: Review Request 115863: Improve khtml dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115863/#review50378 --- This review has been submitted with commit 0ef7d8af371ddf7697

Re: Review Request 115863: Improve khtml dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115863/ --- (Updated Feb. 20, 2014, 3:47 p.m.) Status -- This change has been ma

Re: Review Request 115863: Improve khtml dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115863/#review50377 --- Ship it! Ship It! - Alex Merry On Feb. 20, 2014, 3:01 p.m.

Re: Review Request 115863: Improve khtml dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115863/ --- (Updated Feb. 20, 2014, 3:01 p.m.) Review request for KDE Frameworks and

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review50376 --- Any concerns left on that patch? It'd be nice to have it in al

Re: Review Request 115702: Check that kconfig_compiler signals get emitted when using KConfigDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115702/#review50375 --- Ship it! Ship It! - Kevin Ottens On Feb. 16, 2014, 5:03 p.

Review Request 115913: Rename webp.xml to kf5-imagesformats-webp.xml on installation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115913/ --- Review request for KDE Frameworks and Jonathan Riddell. Repository: kimag

Re: Review Request 115829: Add clickMessage property to classes formerly inheriting from KLineEdit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115829/ --- (Updated Feb. 20, 2014, 2:08 p.m.) Status -- This change has been ma

Re: Review Request 115829: Add clickMessage property to classes formerly inheriting from KLineEdit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115829/#review50373 --- This review has been submitted with commit 930ef206d6cab99471

Re: Review Request 115826: Add KMessageBox::setDontShowAskAgainConfig as deprecated method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115826/#review50372 --- This review has been submitted with commit bab940685456e25332

Re: Review Request 115826: Add KMessageBox::setDontShowAskAgainConfig as deprecated method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115826/ --- (Updated Feb. 20, 2014, 2:06 p.m.) Status -- This change has been ma

Re: Review Request 115824: Add PtyProcess::WaitSlave as deprecated method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115824/#review50371 --- This review has been submitted with commit b2e4518bd1909da427

Re: Review Request 115824: Add PtyProcess::WaitSlave as deprecated method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115824/ --- (Updated Feb. 20, 2014, 2:05 p.m.) Status -- This change has been ma

Re: Review Request 115716: Ensure to not perform Xlib code if not on platform xcb in klauncher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115716/ --- (Updated Feb. 20, 2014, 2:04 p.m.) Status -- This change has been ma

Re: Review Request 115716: Ensure to not perform Xlib code if not on platform xcb in klauncher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115716/#review50369 --- This review has been submitted with commit a773f7166ed16b3487

Re: Review Request 115504: Only perform tests for plugins that are built

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/ --- (Updated Feb. 20, 2014, 1:04 p.m.) Review request for KDE Frameworks and

Jenkins build became unstable: kimageformats_master_qt5 #28

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- (Updated Feb. 20, 2014, 12:56 p.m.) Status -- This change has been m

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/#review50360 --- This review has been submitted with commit 331a813662e5b753bc

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/#review50359 --- This review has been submitted with commit 30cff602964dd47379

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/#review50361 --- This review has been submitted with commit 4fbbc75429597dc545

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/#review50358 --- This review has been submitted with commit 71772963359553c2da

Re: Review Request 115028: Inline deprecated KUser::fullName() method

> On Feb. 20, 2014, 12:16 p.m., Kevin Ottens wrote: > > src/lib/CMakeLists.txt, line 86 > > > > > > Not sure about that... I don't think we want the library itself to use > > deprecated methods. So knowing about

Re: Review Request 115863: Improve khtml dependencies

> On Feb. 19, 2014, 3:21 p.m., Alex Merry wrote: > > CMakeLists.txt, lines 23-32 > > > > > > KCompletion, KConfig[Widgets] and KCoreAddons are used, but never > > linked against. So there's not much point search

Re: Review Request 115504: Only perform tests for plugins that are built

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/ --- (Updated Feb. 20, 2014, 12:38 p.m.) Review request for KDE Frameworks.

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/#review50351 --- Ship it! I think it addresses all previous comments and I don

Review Request 115909: Remove unused dependency from krunner

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115909/ --- Review request for KDE Frameworks. Repository: krunner Description

Re: Review Request 115504: Only perform tests for plugins that are built

> On Feb. 20, 2014, 12:14 p.m., Kevin Ottens wrote: > > autotests/CMakeLists.txt, line 82 > > > > > > Didn't you mean if (BUILD_EPS_PLUGIN) ? This line confuses me. :-) Hmm... it is a little non-obvious, now you

Re: Review Request 115863: Improve khtml dependencies

> On Feb. 19, 2014, 3:21 p.m., Alex Merry wrote: > > CMakeLists.txt, lines 23-32 > > > > > > KCompletion, KConfig[Widgets] and KCoreAddons are used, but never > > linked against. So there's not much point search

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115710/#review50347 --- Please address David's comments, I think this patch is interes

Re: Review Request 115897: Remove FindDocBook*.cmake

> On Feb. 19, 2014, 12:52 p.m., Luigi Toscano wrote: > > Uhm, well, not sure about the non-usage in kde4support: I would like to > > make sure that the needed files (4.2) are really there, so I would like to > > call FindDocBookXML4 for that. > > Alex Merry wrote: > Oh, I see, it's going t

Re: Review Request 115863: Improve khtml dependencies

> On Feb. 19, 2014, 3:21 p.m., Alex Merry wrote: > > CMakeLists.txt, lines 23-32 > > > > > > KCompletion, KConfig[Widgets] and KCoreAddons are used, but never > > linked against. So there's not much point search

Re: Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

> On Feb. 15, 2014, 3:51 p.m., Alexander Richardson wrote: > > Same Problem on Windows: https://git.reviewboard.kde.org/r/115210/ > > Further discussion needed I guess I'd propose the discussion to be started on list then. Once the discussion is started this patch can be discarded until we reac

Re: Review Request 115028: Inline deprecated KUser::fullName() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115028/#review50343 --- src/lib/CMakeLists.txt

Re: Review Request 115504: Only perform tests for plugins that are built

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/#review50341 --- autotests/CMakeLists.txt

Re: Review Request 115863: Improve khtml dependencies

> On Feb. 19, 2014, 3:21 p.m., Alex Merry wrote: > > CMakeLists.txt, lines 23-32 > > > > > > KCompletion, KConfig[Widgets] and KCoreAddons are used, but never > > linked against. So there's not much point search

Re: Review Request 114989: kapidox and other components from frameworks should use kde5-config instead of kde4-config, remove kde4 references

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114989/ --- (Updated Feb. 20, 2014, 12:10 p.m.) Status -- This change has been d

Re: Review Request 114987: khtml and other components from frameworks should use kde5_install , remove kde4 refs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114987/ --- (Updated Feb. 20, 2014, 12:09 p.m.) Status -- This change has been d

Re: Review Request 114991: I think frameworks 5 should use kde5 based emoticons ? , though i am not sure changing it now would make any sense o_O ? would leave up to reviewers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114991/ --- (Updated Feb. 20, 2014, 12:09 p.m.) Status -- This change has been d

Re: Review Request 114990: removing kde4 references from kauth

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114990/ --- (Updated Feb. 20, 2014, 12:08 p.m.) Status -- This change has been d

Re: Review Request 114997: Improve KAuth README.md

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/ --- (Updated Feb. 20, 2014, 12:07 p.m.) Status -- This change has been m

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115137/#review50339 --- Aren't the concern raised initially on that patch addressed no

Re: Review Request 114997: Improve KAuth README.md

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/#review50337 --- This review has been submitted with commit 09df54e986e41560b1

Re: KItemModels, Solid & KJS licenses

On 20/02/14 11:47, Michael Palimaka wrote: > There are more frameworks affected too - kjs contains BSD-licensed code > for example. That's not a problem. The BSD license is compatible with the LGPL, so the whole thing can be distributed as LGPL. If you have a mix of LGPL and GPL code, though, yo

Re: Review Request 114997: Improve KAuth README.md

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/#review50335 --- Ship it! Ship It! - Kevin Ottens On Jan. 28, 2014, 11:48 a

Review Request 115908: Remove Ki18n from KCompletion dependencies in cmake.in

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115908/ --- Review request for KDE Frameworks and David Gil Oliva. Repository: kcompl

Re: KItemModels, Solid & KJS licenses

On 02/20/2014 07:18 AM, šumski wrote: > Hi all, > > i've started pushing Frameworks to openSUSE Factory (i.e. next openSUSE > release), and our legal review found some issues[1][2][3] with mentioned > frameworks licenses. > Details in the links bellow (basically, certain files are not licensed a

Re: Review Request 115863: Improve khtml dependencies

> On Feb. 19, 2014, 3:21 p.m., Alex Merry wrote: > > CMakeLists.txt, lines 23-32 > > > > > > KCompletion, KConfig[Widgets] and KCoreAddons are used, but never > > linked against. So there's not much point search

Re: KItemModels, Solid & KJS licenses

CC'd people: please can you confirm that you would be happy to have the files listed below relicensed from GPL to LGPLv2+? Thanks On 19/02/14 20:18, šumski wrote: > Hi all, > > i've started pushing Frameworks to openSUSE Factory (i.e. next openSUSE > release), and our legal review found some is

Re: Review Request 115863: Improve khtml dependencies

> On Feb. 19, 2014, 3:21 p.m., Alex Merry wrote: > > CMakeLists.txt, lines 23-32 > > > > > > KCompletion, KConfig[Widgets] and KCoreAddons are used, but never > > linked against. So there's not much point search

Re: Sprint from 24th of April until 28th

On Wednesday 19 February 2014 18:20:21 you wrote: > We finally have a date for the sprint, next step is to know how many people > need sponsoring, so please register yourself here: > > https://sprints.kde.org/sprint/224 > > I want to send the budget somewhere next week so please, hurry! > > Than

Re: kstartupconfig5

On 19/02/14 18:07, Jaime wrote: > I've looked in the bin directory and there is no kstartupconfig5. > I've done a grep in the source and it is included in kde-workspace, > but aparently, it is only for BSD. > > if(LIBBSD_FOUND) > ecm_optional_add_subdirectory( > kstartupconfig) > else() >

Re: Review Request 115863: Improve khtml dependencies

> On Feb. 19, 2014, 3:21 p.m., Alex Merry wrote: > > CMakeLists.txt, lines 23-32 > > > > > > KCompletion, KConfig[Widgets] and KCoreAddons are used, but never > > linked against. So there's not much point search

Re: Undefined references to Attica

On 20/02/14 06:56, Adrián Chaves Fernández wrote: > I was trying to build frameworks 4.96.0, and I run into trouble compiling the > tests for KXmlGui, due to undefined references to Attica. I did this to solve > it: https://git.reviewboard.kde.org/r/115907/diff/ > > Now, on the next package, KBo

Re: Review Request 115907: Link tests with extra libraries as well

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115907/#review50328 --- Can you describe the problem this fixes? Are the tests direct

Re: Review Request 115586: Improve attica tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115586/#review50327 --- This review has been submitted with commit e0ea7bedd99aef8365

Re: Review Request 115586: Improve attica tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115586/ --- (Updated Feb. 20, 2014, 10:44 a.m.) Status -- This change has been m

  1   2   >