Re: Review Request 115716: Ensure to not perform Xlib code if not on platform xcb in klauncher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115716/ --- (Updated Feb. 20, 2014, 8:14 a.m.) Review request for KDE Frameworks. C

Re: Review Request 115891: Make KFontDialog inherit from KDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115891/ --- (Updated Feb. 20, 2014, 7:07 a.m.) Status -- This change has been ma

Re: Review Request 115891: Make KFontDialog inherit from KDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115891/#review50304 --- This review has been submitted with commit 2f26d62ce159d30a1a

Re: Review Request 115829: Add clickMessage property to classes formerly inheriting from KLineEdit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115829/ --- (Updated Feb. 20, 2014, 8:07 a.m.) Review request for KDE Frameworks. C

Re: Review Request 115826: Add KMessageBox::setDontShowAskAgainConfig as deprecated method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115826/ --- (Updated Feb. 20, 2014, 8:01 a.m.) Review request for KDE Frameworks. C

Re: Review Request 115824: Add PtyProcess::WaitSlave as deprecated method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115824/ --- (Updated Feb. 20, 2014, 7:54 a.m.) Review request for KDE Frameworks. C

Re: Review Request 115756: Fix argument processing in the tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115756/ --- (Updated Feb. 20, 2014, 6:48 a.m.) Status -- This change has been ma

Re: Review Request 115756: Fix argument processing in the tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115756/#review50303 --- This review has been submitted with commit dbae8d5656055aadde

Re: Review Request 115619: Add -platform to the args and remove X specific args on non X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115619/ --- (Updated Feb. 20, 2014, 6:47 a.m.) Status -- This change has been ma

Re: Review Request 115619: Add -platform to the args and remove X specific args on non X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115619/#review50302 --- This review has been submitted with commit 6a24e8907b30c442fd

Review Request 115907: Link tests with extra libraries as well

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115907/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Re: kstartupconfig5

On Wed, February 19, 2014 19:07:58 Jaime wrote: > * Am I starting kde 5 in the right way? > * Should kstartupconfig5 be always available? > * Should startkde be modified to not fail if the return code is 127? I'm guessing kstartupconfig5 is only for BSD platforms. But I'm not sure if that means i

Re: Review Request 115818: Support more catalogs and reduce code duplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/ --- (Updated Feb. 19, 2014, 11:51 p.m.) Status -- This change has been m

Re: Review Request 115818: Support more catalogs and reduce code duplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/#review50295 --- This review has been submitted with commit 341c7f48af628a3d9d

Re: Review Request 115818: Support more catalogs and reduce code duplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/#review50294 --- This review has been submitted with commit aacda6f30012e6af1b

Re: Review Request 115897: Remove FindDocBook*.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115897/ --- (Updated Feb. 19, 2014, 11:45 p.m.) Review request for Build System, Extr

Re: Review Request 115897: Remove FindDocBook*.cmake

> On Feb. 19, 2014, 12:52 p.m., Luigi Toscano wrote: > > Uhm, well, not sure about the non-usage in kde4support: I would like to > > make sure that the needed files (4.2) are really there, so I would like to > > call FindDocBookXML4 for that. > > Alex Merry wrote: > Oh, I see, it's going t

Re: Review Request 115874: Fix unit tests on Windows by adding two expected failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115874/#review50292 --- Ship it! Ship It! - Alex Merry On Feb. 19, 2014, 7:11 p.m.

Re: Review Request 115478: Add QFileDialog unit autotest for filters (which reveals a QPA bug)

> On Feb. 4, 2014, 5:17 p.m., Alex Merry wrote: > > Has the Qt patch been submitted upstream? > > Dominik Haumann wrote: > Meanwhile yes: https://codereview.qt-project.org/#change,77390 > > Alex Merry wrote: > I don't think it's useful to have tests that fail because of upstream > issu

Re: Review Request 115744: Fix projects using KDocTools on windows.

> On Feb. 19, 2014, 10:44 p.m., Luigi Toscano wrote: > > > Fix the real issue: Since I have > > > https://git.reviewboard.kde.org/r/115210/ applied > > > locally the install path contains C:/kf5/install/../../ProgramData/share. > > > This resulted in a wrong relative path in kdex.dtd at line 10

Review Request 115901: Hide private methods and private slots behind the d-pointer in KLineEdit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115901/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Jenkins build became unstable: ktexteditor_master_qt5 #216

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115853: Remove unused definition

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115853/ --- (Updated Feb. 19, 2014, 10:10 p.m.) Status -- This change has been m

Re: Review Request 115853: Remove unused definition

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115853/#review50286 --- This review has been submitted with commit 5f33a633b71053999a

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 7:06 a.m., Aleix Pol Gonzalez wrote: > > src/notifybypopupgrowl.h, line 37 > > > > > > Is growl still the thing for MacOS X? > > Martin Klapetek wrote: > I'm not sure to be honest...I've h

Re: Review Request 115897: Remove FindDocBook*.cmake

> On Feb. 19, 2014, 12:52 p.m., Luigi Toscano wrote: > > Uhm, well, not sure about the non-usage in kde4support: I would like to > > make sure that the needed files (4.2) are really there, so I would like to > > call FindDocBookXML4 for that. > > Alex Merry wrote: > Oh, I see, it's going t

Re: Review Request 115744: Fix projects using KDocTools on windows.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115744/#review50283 --- > Fix the real issue: Since I have https://git.reviewboard.kde

KF5 at the Randa Meetings this year

Morning guys Just read and you should get the answer: http://randa-meetings.ch/2014/02/19/randa-meetings-2014-the-date-is-set- please-register/ Best regards Mario ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/ma

Jenkins build is back to normal : kross_master_qt5 #29

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115744: Fix projects using KDocTools on windows.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115744/ --- (Updated Feb. 19, 2014, 8:45 p.m.) Review request for Documentation, KDE

kstartupconfig5

Hi, Finally, I've been able to compile Qt5.2 and, using kdesrc-build compile frameworks and some programs. I've created a kdm4 session file to start the session using startkde (the environment variables are set in .profile). But when I start a session, it says: "kstartupconfig5 does not e

GSoC: KioFuse

Hello KDE developers! I looked at KDE GSoC wiki page [1] and there is for me interesting project KioFuse. Did I understand it correctly, that KioFuse can be usefull for non KIO/KDE applications which want to open file from KIO (e.g network smb/nfs/http file)? Can you describe more details about th

Re: Sprint from 24th of April until 28th

On Wed, Feb 19, 2014 at 6:20 PM, Àlex Fiestas wrote: > We finally have a date for the sprint, next step is to know how many people > need sponsoring, so please register yourself here: > > https://sprints.kde.org/sprint/224 > > I want to send the budget somewhere next week so please, hurry! > > Tha

Re: Review Request 115872: Fix KUIT markup on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115872/ --- (Updated Feb. 19, 2014, 7:12 p.m.) Status -- This change has been ma

Re: Review Request 115872: Fix KUIT markup on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115872/#review50274 --- This review has been submitted with commit c8f996b5343c017232

Re: Review Request 115874: Fix unit tests on Windows by adding two expected failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115874/ --- (Updated Feb. 19, 2014, 8:11 p.m.) Review request for KDE Frameworks. R

Re: Review Request 115826: Add KMessageBox::setDontShowAskAgainConfig as deprecated method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115826/#review50273 --- If it is just a SC compatibility stub, wouldn't it make sense

Build failed in Jenkins: kross_master_qt5 #28

See Changes: [arichardson.kde] Use QFunctionPointer instead of void* -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace

Re: Review Request 115743: Use QFunctionPointer instead of void*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115743/ --- (Updated Feb. 19, 2014, 7:04 p.m.) Status -- This change has been ma

Re: Review Request 115743: Use QFunctionPointer instead of void*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115743/#review50272 --- This review has been submitted with commit 45a24ef3044716c17f

Re: Review Request 115872: Fix KUIT markup on windows

> On Feb. 19, 2014, 4:28 p.m., Alex Merry wrote: > > Your "testing" statement is a lie: the autotest changed on all platforms. > > However, it still passes on Linux. I meant no changes in behaviour - Alexander --- This is an automatic

Re: Review Request 115742: KParts: Allow compilation on windows

> On Feb. 19, 2014, 3:44 p.m., Alex Merry wrote: > > src/readwritepart.cpp, lines 246-249 > > > > > > > > http://msdn.microsoft.com/en-us/library/windows/desktop/aa363860%28v=vs.85%29.aspx > > > > So I

Re: Review Request 115478: Add QFileDialog unit autotest for filters (which reveals a QPA bug)

> On Feb. 4, 2014, 5:17 p.m., Alex Merry wrote: > > Has the Qt patch been submitted upstream? > > Dominik Haumann wrote: > Meanwhile yes: https://codereview.qt-project.org/#change,77390 > > Alex Merry wrote: > I don't think it's useful to have tests that fail because of upstream > issu

Re: Review Request 115478: Add QFileDialog unit autotest for filters (which reveals a QPA bug)

> On Feb. 4, 2014, 5:17 p.m., Alex Merry wrote: > > Has the Qt patch been submitted upstream? > > Dominik Haumann wrote: > Meanwhile yes: https://codereview.qt-project.org/#change,77390 > > Alex Merry wrote: > I don't think it's useful to have tests that fail because of upstream > issu

Sprint from 24th of April until 28th

We finally have a date for the sprint, next step is to know how many people need sponsoring, so please register yourself here: https://sprints.kde.org/sprint/224 I want to send the budget somewhere next week so please, hurry! Thanks ! signature.asc Description: This is a digitally signed messa

Re: Review Request 115744: The WIN32 part of this if statement doesn't seem to work -> drop it

> On Feb. 19, 2014, 2:52 p.m., Alex Merry wrote: > > src/CMakeLists.txt, lines 63-67 > > > > > > This warning no longer applies, right? In that, since we no longer > > have a monolithic kdelibs, we can just use

Re: Review Request 115818: Support more catalogs and reduce code duplication

> On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote: > > Looks good. On the whole, I think this would be better as two separate > > commits (from the POV of git bisect), but I'm not going to push that. > > Luigi Toscano wrote: > Thanks; how would you break it? Do the de-duplication first (cal

Re: Review Request 115874: Fix unit tests on Windows by adding two expected failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115874/#review50262 --- autotests/kdirwatch_unittest.cpp

Re: Review Request 115872: Fix KUIT markup on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115872/#review50261 --- Ship it! Your "testing" statement is a lie: the autotest chan

Re: Review Request 115863: Improve khtml dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115863/#review50260 --- CMakeLists.txt

Re: Review Request 115853: Remove unused definition

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115853/#review50259 --- Ship it! Ship It! - Alex Merry On Feb. 17, 2014, 10:03 p.m

Re: Review Request 115829: Add clickMessage property to classes formerly inheriting from KLineEdit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115829/#review50258 --- src/klistwidgetsearchline.h

Re: Review Request 115827: Add KMainWindow::initialGeometrySet to increase SC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115827/#review50257 --- src/kmainwindow.h

Re: Review Request 115826: Add KMessageBox::setDontShowAskAgainConfig as deprecated method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115826/#review50255 --- src/kmessagebox.h

Re: Review Request 115824: Add PtyProcess::WaitSlave as deprecated method

> On Feb. 19, 2014, 3:10 p.m., Alex Merry wrote: > > Just resolve the issues, and then push. Actually, one more thing: would it not be better to make it inline? - Alex --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 115824: Add PtyProcess::WaitSlave as deprecated method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115824/#review50253 --- Ship it! Just resolve the issues, and then push. src/ptypro

Re: Review Request 115818: Support more catalogs and reduce code duplication

> On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote: > > Looks good. On the whole, I think this would be better as two separate > > commits (from the POV of git bisect), but I'm not going to push that. Thanks; how would you break it? - Luigi

Re: Review Request 115818: Support more catalogs and reduce code duplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/#review50252 --- Ship it! Looks good. On the whole, I think this would be bet

Re: Review Request 115744: The WIN32 part of this if statement doesn't seem to work -> drop it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115744/#review50247 --- src/CMakeLists.txt

Re: Review Request 115624: Rename kross man page to match renamed binary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115624/#review50250 --- Ship it! Ship It! - Alex Merry On Feb. 16, 2014, 7:05 p.m.

Re: Review Request 115744: The WIN32 part of this if statement doesn't seem to work -> drop it

> On Feb. 19, 2014, 2:52 p.m., Alex Merry wrote: > > src/CMakeLists.txt, lines 63-67 > > > > > > This warning no longer applies, right? In that, since we no longer > > have a monolithic kdelibs, we can just use

Re: Review Request 115756: Fix argument processing in the tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115756/#review50248 --- Ship it! Although a better fix would be to use QCommandLinePa

Re: Review Request 115742: KParts: Allow compilation on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115742/#review50246 --- src/readwritepart.cpp

Re: Review Request 115893: Move KRunner to after plasma-framework in kf5 build includes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115893/#review50244 --- kf5-workspace-build-include

Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115717/#review50240 --- I don't think papering over the X11-ness of kdesu like this is

Re: Review Request 115716: Ensure to not perform Xlib code if not on platform xcb in klauncher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115716/#review50237 --- src/klauncher/klauncher.cpp

Re: Review Request 115619: Add -platform to the args and remove X specific args on non X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115619/#review50234 --- Ship it! Ship It! - Alex Merry On Feb. 10, 2014, 10:26 a.m

Re: Review Request 115586: Improve attica tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115586/#review50233 --- I suggest not removing the broken parser test for now, but jus

Re: Review Request 115478: Add QFileDialog unit autotest for filters (which reveals a QPA bug)

> On Feb. 4, 2014, 5:17 p.m., Alex Merry wrote: > > Has the Qt patch been submitted upstream? > > Dominik Haumann wrote: > Meanwhile yes: https://codereview.qt-project.org/#change,77390 I don't think it's useful to have tests that fail because of upstream issues in the repo, at least not i

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

> On Feb. 3, 2014, 6:07 p.m., Raphael Kubo da Costa wrote: > > Please see the big comment below the elseif line, the link to the > > kde-core-devel and > > http://lists.kde.org/?l=kde-core-devel&m=138244424421211&w=2: the issue > > here is that if you pass -fno-exceptions to clang you need to

Re: Review Request 114260: Port mouse dataengine

> On Feb. 2, 2014, 11:42 a.m., Bhushan Shah wrote: > > Please test it with plasmaengineexplorer in my testing it shows no sources. Any progress on this? - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.

Re: Review Request 115897: Remove FindDocBook*.cmake

> On Feb. 19, 2014, 12:52 p.m., Luigi Toscano wrote: > > Uhm, well, not sure about the non-usage in kde4support: I would like to > > make sure that the needed files (4.2) are really there, so I would like to > > call FindDocBookXML4 for that. > > Alex Merry wrote: > Oh, I see, it's going t

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

> On Jan. 27, 2014, 7:45 a.m., Kevin Ottens wrote: > > src/lib/kaboutdata.cpp, line 941 > > > > > > Not really my type of thing. It's acting on an object behind our back > > without knowing... what happens to co

Re: Review Request 115316: Add demo for KRecentFileList

> On Jan. 27, 2014, 2:23 a.m., Aleix Pol Gonzalez wrote: > > It's a test, not a demo. If you want, it's for demonstrating the developer > > that he did it right, but I wouldn't see it as documentation. > > > > I would rename it to KRecentFilesActionTest > > Kevin Ottens wrote: > Yes, defin

Re: Review Request 115897: Remove FindDocBook*.cmake

> On Feb. 19, 2014, 12:52 p.m., Luigi Toscano wrote: > > Uhm, well, not sure about the non-usage in kde4support: I would like to > > make sure that the needed files (4.2) are really there, so I would like to > > call FindDocBookXML4 for that. Oh, I see, it's going to look for a different versi

Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

> On Feb. 19, 2014, 12:52 p.m., Luigi Toscano wrote: > > Sorry for the low cmake-fu, but does that change in CMakeLists.txt mean > > that they are going to exported? No, it's just to allow CMake to find them when it's configuring kdoctools. - Alex ---

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 11:06 a.m., Aleix Pol Gonzalez wrote: > > src/knotificationmanager.cpp, line 180 > > > > > > ? > > Martin Klapetek wrote: > Yet once again the description xD - "it's full of ... FIXMEs to

Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/#review50219 --- Sorry for the low cmake-fu, but does that change in CMakeLists

Re: Review Request 115897: Remove FindDocBook*.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115897/#review50220 --- Uhm, well, not sure about the non-usage in kde4support: I woul

Review Request 115897: Remove FindDocBook*.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115897/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and L

Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repos

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 10:06 a.m., Aleix Pol Gonzalez wrote: > > src/knotificationmanager.cpp, line 180 > > > > > > ? > > Martin Klapetek wrote: > Yet once again the description xD - "it's full of ... FIXMEs to

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

> On Feb. 17, 2014, 7:21 p.m., Martin Gräßlin wrote: > > my personal opinion: it's still the development platform and I personally > > find development platform in that context better. Especially in the about > > application dialog. The old one tells me what it is, but what are > > "frameworks

Re: Review Request 115816: Remove strigi libs from kf5-frameworks-build-include

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115816/ --- (Updated Feb. 19, 2014, 11:54 a.m.) Review request for Build System, KDE

Review Request 115893: Move KRunner to after plasma-framework in kf5 build includes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115893/ --- Review request for Build System and KDE Frameworks. Repository: kdesrc-bu

Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #38

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kmediaplayer_master_qt5 #29

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kmediaplayer_master_qt5 #28

See Changes: [kde] Include ECMPackageConfigHelpers.cmake -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 11:06 a.m., Aleix Pol Gonzalez wrote: > > src/knotificationmanager.cpp, line 66 > > > > > > This will be done in the future? Maybe it would be better to commit > > when there are no regression

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 11:06 a.m., Aleix Pol Gonzalez wrote: > > src/knotification.cpp, line 333 > > > > > > remove qDebugs? As the description says - "and for now it's full of QDebugs, that will all be removed" -

Re: Review Request 115891: Make KFontDialog inherit from KDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115891/#review50198 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 19, 2014, 8

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/#review50197 --- src/knotification.cpp

Re: Review Request 115743: Use QFunctionPointer instead of void*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115743/#review50195 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 14, 2014, 1

Re: Review Request 115658: Also port KWindowSystem::windowInfo to the flags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115658/#review50193 --- This review has been submitted with commit c86bed18731f771cea

Re: Review Request 115658: Also port KWindowSystem::windowInfo to the flags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115658/ --- (Updated Feb. 19, 2014, 8:27 a.m.) Status -- This change has been ma

Review Request 115891: Make KFontDialog inherit from KDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115891/ --- Review request for KDE Frameworks. Repository: kde4support Description