Re: Review Request 115610: Hide private method behind the d-pointer in KLineEdit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115610/#review50128 --- Ship it! Ship It! - David Faure On Feb. 9, 2014, 11:07 p.m

Re: Review Request 115584: Remove kfileaudiopreview transitive dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115584/#review50127 --- Ship it! Ship It! - David Faure On Feb. 8, 2014, 6:52 p.m.

Re: Re: X11 usage in kdeinit/kinit.cpp

On Monday 17 February 2014 23:30:07 Christoph Cullmann wrote: > - Ursprüngliche Mail - > > > > > wrapper.cpp assumes there is a DISPLAY env variable and even if not > > > > it's > > > > set to ":0". > > > > > > Can't we detect that we're not on X11 simply from the fact that DISPLAY > > >

Re: Review Request 115832: Print the diff to stdout on comparison failure

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115832/#review50120 --- Ship it! Looks good, thanks! - Matthew John Dawson On Feb.

Re: Review Request 115635: Make kconfig_compiler signals actually useful

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/#review50119 --- Ship it! Everything looks good here, I just have a quick coup

Re: Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

> On Feb. 17, 2014, 1:39 a.m., Matthew John Dawson wrote: > > autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp, line 153 > > > > > > As this appears to preform the same check as the function below, I

Re: Review Request 115853: Remove unused definition

> On Feb. 18, 2014, 1:27 a.m., Alexander Richardson wrote: > > src/ioslaves/help/config-help.h.cmake, line 3 > > > > > > It is used on Windows: > > src/xslt.cpp:148: > > replaceURLList[QLatin1String("h

Re: Review Request 115853: Remove unused definition

> On Feb. 18, 2014, 12:27 a.m., Alexander Richardson wrote: > > src/ioslaves/help/config-help.h.cmake, line 3 > > > > > > It is used on Windows: > > src/xslt.cpp:148: > > replaceURLList[QLatin1String("

Re: Review Request 115853: Remove unused definition

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115853/#review50115 --- src/ioslaves/help/config-help.h.cmake

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

> On Feb. 17, 2014, 7:21 p.m., Martin Gräßlin wrote: > > my personal opinion: it's still the development platform and I personally > > find development platform in that context better. Especially in the about > > application dialog. The old one tells me what it is, but what are > > "frameworks

Re: X11 usage in kdeinit/kinit.cpp

- Ursprüngliche Mail - > > > wrapper.cpp assumes there is a DISPLAY env variable and even if not it's > > > set to ":0". > > > > Can't we detect that we're not on X11 simply from the fact that DISPLAY is > > not set? > > No that doesn't work as I expect that at least during the next decad

Review Request 115853: Remove unused definition

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115853/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 115832: Print the diff to stdout on comparison failure

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115832/ --- (Updated Feb. 17, 2014, 10:18 p.m.) Review request for KDE Frameworks.

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115840/#review50091 --- my personal opinion: it's still the development platform and I

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115840/ --- (Updated Feb. 17, 2014, 7:04 p.m.) Review request for KDE Frameworks. C

Review Request 115840: Rename Platform to Frameworks in both about dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115840/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Re: Review Request 115839: Remove kio transitive dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115839/ --- (Updated Feb. 17, 2014, 6:11 p.m.) Status -- This change has been ma

Re: Review Request 115839: Remove kio transitive dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115839/#review50088 --- This review has been submitted with commit a873093a9fb36fbe6b

Re: Review Request 115839: Remove kio transitive dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115839/#review50084 --- Ship it! Ship It! - David Faure On Feb. 17, 2014, 5:41 p.m

Review Request 115839: Remove kio transitive dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115839/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 115832: Print the diff to stdout on comparison failure

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115832/#review50058 --- autotests/kconfig_compiler/kconfigcompiler_test.cpp

Re: Frameworks sprint in Barcelona

On Wed, Jan 29, 2014 at 5:58 PM, Mark Gaiser wrote: > On Wed, Jan 29, 2014 at 5:43 PM, Àlex Fiestas wrote: >> Hi there ! >> >> It is time we decide when to organize the Frameworks sprint, the main >> objective of this sprint is "Making it releseable". >> >> The Doodle contains only Thursdays from

Review Request 115832: Print the diff to stdout on comparison failure

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115832/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 115635: Make kconfig_compiler signals actually useful

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/ --- (Updated Feb. 17, 2014, 4:44 p.m.) Review request for KDE Frameworks. C

Re: Review Request 115635: Make kconfig_compiler signals actually useful

> On Feb. 17, 2014, 7:39 a.m., Matthew John Dawson wrote: > > src/kconfig_compiler/kconfig_compiler.cpp, line 1218 > > > > > > Coding style: please leave the braces for this if statement. I initially made this

Re: Re: X11 usage in kdeinit/kinit.cpp

On Saturday 15 February 2014 20:49:39 David Faure wrote: > On Thursday 13 February 2014 09:29:40 Martin Gräßlin wrote: > > Hi, > > > > on my quest to ensure that we can run all applications with -platform > > wayland if compiled with X11 support I stumbled over > > kinit/kdeinit/kinit.cpp which ge

Re: Review Request 115825: Add a kdefakes.h to increase SC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115825/ --- (Updated Feb. 17, 2014, 3:20 p.m.) Status -- This change has been ma

Re: Review Request 115825: Add a kdefakes.h to increase SC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115825/#review50051 --- This review has been submitted with commit c8e98c76335c5c7bc7

Re: Review Request 115825: Add a kdefakes.h to increase SC

> On Feb. 17, 2014, 4:12 p.m., David Faure wrote: > > To help the person doing the porting, this could actually list all of the > > functions that kdefakes.h was providing. Or tell people to go look it up. > > But that's not a reason for me to veto this which is already an improvement > > -> s

Re: Review Request 115825: Add a kdefakes.h to increase SC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115825/#review50048 --- Ship it! To help the person doing the porting, this could act

Re: Review Request 115825: Add a kdefakes.h to increase SC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115825/ --- (Updated Feb. 17, 2014, 4:10 p.m.) Review request for KDE Frameworks. C

Re: Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

> On Feb. 17, 2014, 7:39 a.m., Matthew John Dawson wrote: > > autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp, line 26 > > > > > > Is this a copy + paste error? Yes, leftover from old version of this

Review Request 115829: Add clickMessage property to classes formerly inheriting from KLineEdit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115829/ --- Review request for KDE Frameworks. Repository: kitemviews Description -

Porting feedback: Hiding the Help button in KConfigDialog

Hi, in the KDialog-based KConfigDialog of yesteryear, it was fairly easy to hide the Help button: dialog->button(KDialog::Help)->hide(); This is useful for apps that don't (yet) ship a handbook, since it avoids mounting user frustration when a click on Help actually re- sults in a nasty error

Re: Review Request 115658: Also port KWindowSystem::windowInfo to the flags

> On Feb. 11, 2014, 7:13 p.m., Bhushan Shah wrote: > > I can not give you Ship it! but +1 from me.. :) ping - Bhushan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115658/#review49551

Re: Review Request 115825: Add a kdefakes.h to increase SC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115825/#review50038 --- Wow I hadn't realized it was so much used in the apps sr

Review Request 115827: Add KMainWindow::initialGeometrySet to increase SC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115827/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Review Request 115826: Add KMessageBox::setDontShowAskAgainConfig as deprecated method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115826/ --- Review request for KDE Frameworks. Repository: kwidgetsaddons Descripti

Review Request 115825: Add a kdefakes.h to increase SC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115825/ --- Review request for KDE Frameworks. Repository: kde4support Description

Re: Review Request 115721: Reduce usage of HAVE_X11 in KRun and make it usable on non-X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115721/ --- (Updated Feb. 17, 2014, 9:09 a.m.) Status -- This change has been ma

Re: Review Request 115721: Reduce usage of HAVE_X11 in KRun and make it usable on non-X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115721/#review50024 --- This review has been submitted with commit b0df340288405dea21

Re: Review Request 115822: Bring back KMimeType::iconNameForUrl as a deprecated method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115822/#review50023 --- This review has been submitted with commit 6dfa201b9c709f5ed8

Re: Review Request 115822: Bring back KMimeType::iconNameForUrl as a deprecated method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115822/ --- (Updated Feb. 17, 2014, 9:08 a.m.) Status -- This change has been ma

Review Request 115824: Add PtyProcess::WaitSlave as deprecated method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115824/ --- Review request for KDE Frameworks. Repository: kdesu Description --

Re: Review Request 115822: Bring back KMimeType::iconNameForUrl as a deprecated method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115822/#review50019 --- Ship it! Good idea (had to be removed while moving stuff arou

Re: Review Request 115721: Reduce usage of HAVE_X11 in KRun and make it usable on non-X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115721/#review50017 --- Ship it! Ship It! - David Faure On Feb. 17, 2014, 8:15 a.m

Review Request 115822: Bring back KMimeType::iconNameForUrl as a deprecated method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115822/ --- Review request for KDE Frameworks. Repository: kde4support Description

Re: Review Request 115721: Reduce usage of HAVE_X11 in KRun and make it usable on non-X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115721/ --- (Updated Feb. 17, 2014, 9:15 a.m.) Review request for KDE Frameworks. C