Re: [error] Snapshot for krunner extracted successfully, but failed to complete initrepo.sh

On Sat, February 15, 2014 20:35:28 David Faure wrote: > On Thursday 13 February 2014 17:41:26 Michael Pyne wrote: > > In the meantime I will fix kdesrc-build to fallback automatically to > > git-clone like it's supposed to. > > There's two cases: > > - snapshot exists, but is broken. This is the

Re: Review Request 115766: Use the new ecm_generate_headers() syntax

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115766/#review49888 --- Ship it! Ship It! - David Faure On Feb. 15, 2014, 5:42 p.m

Re: Review Request 115767: Use the new syntax for ecm_generate_headers()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115767/#review49887 --- Ship it! Ship It! - David Faure On Feb. 15, 2014, 5:42 p.m

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/#review49881 --- Looks good to me. Just some minor comments. src/imageformats

Re: Review Request 115421: Clean up the CMakeLists.txt files

On Friday 07 February 2014 13:59:06 Alex Merry wrote: > On 07/02/14 08:58, David Faure wrote: > > On Saturday 01 February 2014 13:27:49 Alex Merry wrote: > >> - KStyle can once again be built standalone > > > > Is there any reason for this? > > > > I ask because I noticed that this was another pl

Re: Review Request 115741: Fix MSVC of kinit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115741/#review49874 --- src/kdeinit/kinit_win.cpp

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115739/#review49873 --- Yeah the description is wrong. Making something Q_MOVABLE mean

Re: Review Request 115724: Drop version check for Qt at least being 4.7

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115724/#review49871 --- Ship it! Ship It! - David Faure On Feb. 13, 2014, 1:09 p.m

Re: Review Request 115721: Reduce usage of HAVE_X11 in KRun and make it usable on non-X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115721/#review49870 --- Overloading KProcessRunner constructors with and without start

Re: Review Request 115719: Move kio zlib dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115719/#review49869 --- Ship it! Ship It! - David Faure On Feb. 13, 2014, 11:53 a.

Re: X11 usage in kdeinit/kinit.cpp

On Thursday 13 February 2014 09:29:40 Martin Gräßlin wrote: > Hi, > > on my quest to ensure that we can run all applications with -platform > wayland if compiled with X11 support I stumbled over > kinit/kdeinit/kinit.cpp which gets compiled into the kdeinit5 binary. To > quote the code: > > // Ca

Re: Review Request 115714: Only use xtest code if we are on platform X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115714/#review49868 --- Ship it! Ship It! - David Faure On Feb. 13, 2014, 7:09 a.m

Re: Review Request 115711: Introduce a config-kstyle.h.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115711/#review49867 --- Ship it! Ship It! - David Faure On Feb. 13, 2014, 6:33 a.m

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115710/#review49866 --- src/khistorycombobox.cpp

Re: [error] Snapshot for krunner extracted successfully, but failed to complete initrepo.sh

On Thursday 13 February 2014 17:41:26 Michael Pyne wrote: > In the meantime I will fix kdesrc-build to fallback automatically to > git-clone like it's supposed to. There's two cases: - no snapshot to download (as is the case initially for new frameworks) (kdesrc-build should indeed fallback i

Re: Review Request 115702: Check that kconfig_compiler signals get emitted when using KConfigDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115702/#review49863 --- autotests/CMakeLists.txt

Re: Review Request 115701: Improve build without X11 support in kde4support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115701/#review49862 --- Ship it! Ship It! - David Faure On Feb. 12, 2014, 4:01 p.m

Re: Review Request 115700: Remove unused frameworkintegration dependencies

> On Feb. 15, 2014, 7:24 p.m., David Faure wrote: > > Ship It! Actually the feature_summary line should be removed. More stuff in kstyle/CMakeLists.txt should be cleaned up, there's no reason to build it standalone. - David --- This i

Re: Review Request 115700: Remove unused frameworkintegration dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115700/#review49860 --- Ship it! Ship It! - David Faure On Feb. 12, 2014, 3:38 p.m

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115684/ --- (Updated Feb. 15, 2014, 7:22 p.m.) Status -- This change has been di

Re: Review Request 115765: Improve the ECMGenerateHeaders API with a variable for generated files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115765/#review49858 --- Ship it! Thanks! Very nice. I can write a porting script tom

Re: Review Request 115686: Fix mimetype declarations in json files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115686/#review49857 --- Ship it! Ship It! - David Faure On Feb. 15, 2014, 6:49 p.m

Re: Review Request 115686: Fix mimetype declarations in json files

> On Feb. 15, 2014, 5:20 p.m., David Faure wrote: > > XV is the grand-father of image viewers, I didn't know it had an image > > format though. It's completely missing from shared-mime-info. > > I have the very strong feeling that this should be removed, it's completely > > obsolete :) > > > >

Re: Review Request 115686: Fix mimetype declarations in json files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115686/ --- (Updated Feb. 15, 2014, 6:49 p.m.) Review request for KDE Frameworks. C

Re: Review Request 115768: Remove the xv image format plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115768/#review49854 --- This review has been submitted with commit 3eafdc861af37cfacd

Re: Review Request 115768: Remove the xv image format plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115768/ --- (Updated Feb. 15, 2014, 6:47 p.m.) Status -- This change has been ma

Re: Review Request 115768: Remove the xv image format plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115768/#review49852 --- Ship it! Ship It! - David Faure On Feb. 15, 2014, 5:49 p.m

Review Request 115768: Remove the xv image format plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115768/ --- Review request for KDE Frameworks and David Faure. Repository: kimageform

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

> On Feb. 14, 2014, 3:26 p.m., Alex Merry wrote: > > OK, I'll be honest, something about this whole module interface rubs me up > > the wrong way. There's either too much or not enough magic: code that > > calls ecm_generate_headers needs to know things about the implementation > > and use th

Review Request 115767: Use the new syntax for ecm_generate_headers()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115767/ --- Review request for KDE Frameworks and David Faure. Repository: kcoreaddon

Review Request 115766: Use the new ecm_generate_headers() syntax

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115766/ --- Review request for KDE Frameworks and David Faure. Repository: kparts D

Review Request 115765: Improve the ECMGenerateHeaders API with a variable for generated files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115765/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and D

Re: Review Request 115686: Fix mimetype declarations in json files

> On Feb. 15, 2014, 5:20 p.m., David Faure wrote: > > XV is the grand-father of image viewers, I didn't know it had an image > > format though. It's completely missing from shared-mime-info. > > I have the very strong feeling that this should be removed, it's completely > > obsolete :) > > > >

Re: Review Request 115686: Fix mimetype declarations in json files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115686/#review49844 --- XV is the grand-father of image viewers, I didn't know it had

Re: Review Request 115749: Use FindShareMimeInfo.cmake from extra-cmake-modules

> On Feb. 15, 2014, 12:13 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 3d931552b72972adb0cefe79cc4d9586671d5224 by Alex Merry to branch master. Oops, I got confused between this and https://git.reviewboard.kde.org/r/115748/, and committed that one instead. - Al

Re: Review Request 115749: Use FindShareMimeInfo.cmake from extra-cmake-modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115749/#review49841 --- This review has been submitted with commit 0064d8e68996d78ef8

Re: Review Request 115748: Add a cleaned up version of FindSharedMimeInfo.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115748/ --- (Updated Feb. 15, 2014, 4:49 p.m.) Status -- This change has been ma

Re: Review Request 115748: Add a cleaned up version of FindSharedMimeInfo.cmake

> On Feb. 15, 2014, 3:49 p.m., Alexander Richardson wrote: > > Ship It! Oops, I got confused between this one and https://git.reviewboard.kde.org/r/115749/, so I already committed it. - Alex --- This is an automatically generated e-mai

Re: Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115752/#review49837 --- Same Problem on Windows: https://git.reviewboard.kde.org/r/115

Re: Review Request 115748: Add a cleaned up version of FindSharedMimeInfo.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115748/#review49836 --- Ship it! Ship It! - Alexander Richardson On Feb. 14, 2014,

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 5, 2014, 4:51 p.m., Aurélien Gâteau wrote: > > Wow, great work! I attempted doing this some time ago, and all I managed to > > produce was two unit tests :). Looks good to me and works fine here. Just > > two (really minor) nitpicks. > > Kevin Krammer wrote: > Thanks :) > Goo

Re: Review Request 115715: Remove X11 dependency from kprintutils

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115715/#review49828 --- Ship it! Ship It! - John Layt On Feb. 15, 2014, 12:37 p.m.

Re: Review Request 115715: Remove X11 dependency from kprintutils

> On Feb. 14, 2014, 1:58 p.m., John Layt wrote: > > I'd prefer for now that you just replace the HAVE_X11 with "#defined > > Q_OS_UNIX && !defined Q_OS_MAC" which should produce the same effect. No > > point in compiling the CUPS code if we're never going to use it. Once Qt > > feature freez

Re: Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115496/ --- (Updated Feb. 15, 2014, 12:51 p.m.) Review request for Build System, Extr

Re: Review Request 115715: Remove X11 dependency from kprintutils

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115715/ --- (Updated Feb. 15, 2014, 1:37 p.m.) Review request for KDE Frameworks, kde

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

> On Feb. 14, 2014, 3:26 p.m., Alex Merry wrote: > > OK, I'll be honest, something about this whole module interface rubs me up > > the wrong way. There's either too much or not enough magic: code that > > calls ecm_generate_headers needs to know things about the implementation > > and use th

Re: Review Request 115713: Remove #if HAVE_X11 blocks from kstatusnotifieritem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115713/ --- (Updated Feb. 15, 2014, 12:23 p.m.) Status -- This change has been m

Re: Review Request 115713: Remove #if HAVE_X11 blocks from kstatusnotifieritem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115713/#review49817 --- This review has been submitted with commit f76af8d1305d990795

Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115723/#review49816 --- This review has been submitted with commit b4180cb753910b3ba2

Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115723/ --- (Updated Feb. 15, 2014, 12:21 p.m.) Status -- This change has been m

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

> On Feb. 14, 2014, 3:26 p.m., Alex Merry wrote: > > OK, I'll be honest, something about this whole module interface rubs me up > > the wrong way. There's either too much or not enough magic: code that > > calls ecm_generate_headers needs to know things about the implementation > > and use th

Review Request 115756: Fix argument processing in the tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115756/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Review Request 115755: Fix loading of khtmlplart plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115755/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Re: Review Request 115749: Use FindShareMimeInfo.cmake from extra-cmake-modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115749/#review49814 --- This review has been submitted with commit 3d931552b72972adb0

Re: Review Request 115749: Use FindShareMimeInfo.cmake from extra-cmake-modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115749/ --- (Updated Feb. 15, 2014, 12:13 p.m.) Status -- This change has been m