Re: [error] Snapshot for krunner extracted successfully, but failed to complete initrepo.sh

On Sat, February 15, 2014 04:22:39 Shivam Makkar wrote: > Can you please tell me what is going wrong ! > I would really appreciate any sort of help ! :) > Thanking you ! I'm not actually running 'frameworks' myself yet (ssh, don't tell the other devs). So I'm not sure what the issue would be off-

Re: Review Request 115744: The WIN32 part of this if statement doesn't seem to work -> drop it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115744/#review49805 --- This is something where the opinion of the kde-windows team is

Re: [error] Snapshot for krunner extracted successfully, but failed to complete initrepo.sh

On Fri, Feb 14, 2014 at 4:11 AM, Michael Pyne wrote: > On Thu, February 13, 2014 02:29:21 Shivam Makkar wrote: > > Hi > > > > I'm not able to build framework 5 due to some update error in Krunner, is > > there any manual method to build it ? > > You can pass --no-snapshots to the kdesrc-build com

Re: Review Request 115749: Use FindShareMimeInfo.cmake from extra-cmake-modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115749/#review49802 --- Ship it! Code and testing look good to me. I was surprised to

Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115752/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

> On Feb. 14, 2014, 3:26 p.m., Alex Merry wrote: > > OK, I'll be honest, something about this whole module interface rubs me up > > the wrong way. There's either too much or not enough magic: code that > > calls ecm_generate_headers needs to know things about the implementation > > and use th

Re: Review Request 115748: Add a cleaned up version of FindSharedMimeInfo.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115748/ --- (Updated Feb. 14, 2014, 3:38 p.m.) Review request for Build System, Extra

Re: Review Request 115748: Add a cleaned up version of FindSharedMimeInfo.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115748/ --- (Updated Feb. 14, 2014, 3:36 p.m.) Review request for Build System, Extra

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115684/#review49787 --- OK, I'll be honest, something about this whole module interfac

Re: Review Request 115748: Add a cleaned up version of FindSharedMimeInfo.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115748/#review49791 --- find-modules/FindSharedMimeInfo.cmake

Re: Review Request 115715: Remove X11 dependency from kprintutils

> On Feb. 14, 2014, 10:58 a.m., John Layt wrote: > > I'd prefer for now that you just replace the HAVE_X11 with "#defined > > Q_OS_UNIX && !defined Q_OS_MAC" which should produce the same effect. No > > point in compiling the CUPS code if we're never going to use it. Once Qt > > feature free

Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

> On Feb. 13, 2014, 11:27 p.m., Alexander Richardson wrote: > > src/core/kprotocolmanager.cpp, line 690 > > > > > > Maybe move the Q_OS_MAC up as the first check, then there is no need > > for !defined(Q_OS_DARW

Re: Review Request 115683: Install app desktop files to share/applications, not in a kde5 subdir

> On Feb. 13, 2014, 4:28 a.m., Rex Dieter wrote: > > fyi, http://standards.freedesktop.org/menu-spec/menu-spec-latest.html , > > supporting vendor prefixes are not only a good idea, but is strongly > > encouraged. "... it is recommended that providers of desktop-files ensure > > that all des

Re: Review Request 115725: Switch from yapgvb to Graphviz Python bindings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115725/ --- (Updated Feb. 14, 2014, 2:20 p.m.) Status -- This change has been ma

Re: Review Request 115725: Switch from yapgvb to Graphviz Python bindings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115725/#review49785 --- This review has been submitted with commit ff1475fe9b64de8a79

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- (Updated Feb. 14, 2014, 2:10 p.m.) Review request for KDE Frameworks. C

Review Request 115748: Add a cleaned up version of FindSharedMimeInfo.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115748/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Review Request 115749: Use FindShareMimeInfo.cmake from extra-cmake-modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115749/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 115715: Remove X11 dependency from kprintutils

> On Feb. 14, 2014, 1:58 p.m., John Layt wrote: > > I'd prefer for now that you just replace the HAVE_X11 with "#defined > > Q_OS_UNIX && !defined Q_OS_MAC" which should produce the same effect. No > > point in compiling the CUPS code if we're never going to use it. Once Qt > > feature freez

Re: Review Request 115715: Remove X11 dependency from kprintutils

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115715/#review49783 --- I'd prefer for now that you just replace the HAVE_X11 with "#d

Re: Review Request 115725: Switch from yapgvb to Graphviz Python bindings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115725/#review49782 --- Ship it! Looks good, and works fine for me (both with and wit

Re: Review Request 115488: Improve docs for kde modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115488/ --- (Updated Feb. 14, 2014, 1:24 p.m.) Status -- This change has been ma

Re: Review Request 115488: Improve docs for kde modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115488/#review49778 --- This review has been submitted with commit 7fcc57a2055f04ca1a

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

> On Feb. 14, 2014, 12:26 a.m., Alexander Richardson wrote: > > cmake/FindSharedMimeInfo.cmake, line 1 > > > > > > This file is also needed by kcoreaddons (and I would also need it for > > okteta, currently the mi

Re: Review Request 115683: Install app desktop files to share/applications, not in a kde5 subdir

> On Feb. 13, 2014, 4:28 a.m., Rex Dieter wrote: > > fyi, http://standards.freedesktop.org/menu-spec/menu-spec-latest.html , > > supporting vendor prefixes are not only a good idea, but is strongly > > encouraged. "... it is recommended that providers of desktop-files ensure > > that all des