Review Request 115715: Remove X11 dependency from kprintutils

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115715/ --- Review request for KDE Frameworks, kdewin and John Layt. Repository: kpri

Re: Review Request 115704: Comment out kio OpenSSL dependency checks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115704/#review49697 --- Ship it! Ship It! - David Faure On Feb. 12, 2014, 5:54 p.m

Review Request 115714: Only use xtest code if we are on platform X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115714/ --- Review request for KDE Frameworks. Repository: knotifications Descripti

Review Request 115713: Remove #if HAVE_X11 blocks from kstatusnotifieritem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115713/ --- Review request for KDE Frameworks, kdewin and Marco Martin. Repository: k

Re: Review Request 115708: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115708/ --- (Updated Feb. 13, 2014, 6:51 a.m.) Status -- This change has been di

Re: Review Request 115209: Fix KDoctools build on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49691 --- I locally fixed the 'if (WIN32)' issue in CMakeLists.txt and i

Review Request 115711: Introduce a config-kstyle.h.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115711/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Re: [error] Snapshot for krunner extracted successfully, but failed to complete initrepo.sh

On Thursday 13 February 2014 02:29:21 Shivam Makkar wrote: > Hi > > I'm not able to build framework 5 due to some update error in Krunner, is > there any manual method to build it ? Yes, I hit the same problem yesterday when compiling with kdesrc-build. Steps to fix: 1. cd frameworks (src direct

Re: Review Request 115683: Install app desktop files to share/applications, not in a kde5 subdir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115683/#review49689 --- fyi, http://standards.freedesktop.org/menu-spec/menu-spec-late

Re: Review Request 115526: Refactor private class member variables of KCompletionBase for readability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115526/ --- (Updated Feb. 12, 2014, 11:46 p.m.) Status -- This change has been m

Re: Review Request 115526: Refactor private class member variables of KCompletionBase for readability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115526/#review49686 --- This review has been submitted with commit 5aa5871b06e8781f88

Re: Review Request 115526: Refactor private class member variables of KCompletionBase for readability

> On Feb. 12, 2014, 7:26 a.m., David Faure wrote: > > I kind of like the m_ prefix even in Private classes, for the readability > > of methods in that class. But no big deal, won't veto this since Qt doesn't > > use m_. I'm more a Qt-ish kind of man ;-) But I'm glad to know that there are peop

Re: Review Request 115610: Hide private method behind the d-pointer in KLineEdit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115610/#review49684 --- Ping? Should I send this patch differently or something? - Da

Re: Review Request 115708: Build on Mac OS X

> On Feb. 12, 2014, 9:48 p.m., Harald Fernengel wrote: > > src/CMakeLists.txt, line 149 > > > > > > Note - cmake is documented to replace the COMMAND by the actual > > command, as we added it with "add_executabl

Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115710/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 115708: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115708/#review49682 --- Ship it! It seems to work correctly, so ship it from my side.

[error] Snapshot for krunner extracted successfully, but failed to complete initrepo.sh

Hi I'm not able to build framework 5 due to some update error in Krunner, is there any manual method to build it ? I'm also getting Cmake error while installing kwallet, the error seems to be like some git conflict in cmaketext in kwallet. Am I the only one facing these problems ? :P Please help

Re: Review Request 115708: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115708/#review49680 --- src/CMakeLists.txt

Review Request 115708: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115708/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repos

Re: let's get ready for Google Summer of Code 2014

On Tue, Feb 11, 2014 at 12:36 PM, Sebastian Kügler wrote: > On Tuesday, February 11, 2014 11:03:39 Myriam Schweingruber wrote: ... >> And no, it is not enough to be able to guide, you also need people >> available who can review code. I was able to mentor twice in the past >> because I was around

Re: let's get ready for Google Summer of Code 2014

Hi all, On Tue, Feb 11, 2014 at 10:56 AM, Sebastian Kügler wrote: > On Monday, February 10, 2014 16:21:34 Mark Gaiser wrote: >> On Mon, Feb 10, 2014 at 4:13 PM, Vishesh Handa wrote: >> > On Monday, February 10, 2014 01:54:36 PM Mark Gaiser wrote: >> >> Done: >> >> http://community.kde.org/GSoC/2

Review Request 115704: Comment out kio OpenSSL dependency checks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115704/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Review Request 115702: Check that kconfig_compiler signals get emitted when using KConfigDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115702/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti

Jenkins build is back to normal : krunner_master_qt5 #8

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115701: Improve build without X11 support in kde4support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115701/ --- Review request for KDE Frameworks. Repository: kde4support Description

Build failed in Jenkins: krunner_master_qt5 #7

See Changes: [agateau] Unused include-- -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- (Updated Feb. 12, 2014, 4:54 p.m.) Review request for kde-workspace, KDE

Re: Frameworkification of kactivities and plasma-framework

On Wed, Feb 12, 2014, at 0:10, Ben Cooksley wrote: > Hi all, > > Can someone please frameworkify KActivities? The CI system needs this > due to a dependency loop. > > The new KRunner framework depends on, among others plasma-framework, > which in turn depends on kactivities. > > Previously both

Review Request 115700: Remove unused frameworkintegration dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115700/ --- Review request for KDE Frameworks and Àlex Fiestas. Repository: framework

Re: Review Request 115699: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115699/#review49658 --- This review has been submitted with commit 38b85f15ef83083f35

Re: Review Request 115699: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115699/ --- (Updated Feb. 12, 2014, 3:02 p.m.) Status -- This change has been ma

Build failed in Jenkins: krunner_master_qt5 #6

See -- Started by user gateau Building remotely on LinuxSlave - 4 in workspace Running Prebuild steps [krunner_master_qt5] $ /bin/sh -xe /tmp/hudson1351629884

Jenkins build is back to normal : plasma-framework_master_qt5 #1167

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115648: Remove kdewebkit transitive dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115648/#review49656 --- This review has been submitted with commit d2b7271cd517832fa1

Re: Review Request 115648: Remove kdewebkit transitive dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115648/ --- (Updated Feb. 12, 2014, 2:24 p.m.) Status -- This change has been ma

Build failed in Jenkins: plasma-framework_master_qt5 #1166

See -- Started by user gateau Building remotely on LinuxSlave - 3 in workspace Running Prebuild steps [plasma-framework_master_qt5] $ /bi

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

> On Feb. 12, 2014, 12:20 a.m., Aleix Pol Gonzalez wrote: > > Makes sense to me, I most certainly didn't consider it as a problem. > > > > This could break compilation on some projects other than KParts, will you > > be able to try the rest of the modules? > > > > Thanks for figuring it out! >

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115684/#review49655 --- Ship it! Ship It! - Harald Fernengel On Feb. 11, 2014, 10:

Build failed in Jenkins: plasma-framework_master_qt5 #1165

See Changes: [agateau] Do not rely on KF5Umbrella -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Build failed in Jenkins: krunner_master_qt5 #5

See Changes: [agateau] Frameworks must not use the find_package(KF5 ...) [agateau] Fix clean build (could not find plasma/querymatch.h) -- Started by remote host 127.0.0.1 with note: Triggered by com

Build failed in Jenkins: krunner_master_qt5 #4

See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace Running Prebuild steps [krunner_master

Build failed in Jenkins: krunner_master_qt5 #3

See -- Started by user gateau Building remotely on LinuxSlave - 4 in workspace Running Prebuild steps [krunner_master_qt5] $ /bin/sh -xe /tmp/hudson4586571370

Re: Review Request 115699: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115699/#review49653 --- Ship it! yeah Atom is an XLib data type. I plan to make all

Review Request 115699: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115699/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kde4sup

Build failed in Jenkins: plasma-framework_master_qt5 #1164

See Changes: [notmart] hide remove action for desktop containments -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/#review49650 --- src/notifybypopup.cpp

Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- Review request for kde-workspace, KDE Frameworks, Plasma, and Sune Vuorela.

Jenkins build is back to normal : kio_master_qt5 #66

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

> On Feb. 12, 2014, 12:20 a.m., Aleix Pol Gonzalez wrote: > > Makes sense to me, I most certainly didn't consider it as a problem. > > > > This could break compilation on some projects other than KParts, will you > > be able to try the rest of the modules? > > > > Thanks for figuring it out! >

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- (Updated Feb. 12, 2014, 11:03 a.m.) Review request for KDE Frameworks.

Re: alpha1 release

On Wednesday 12 February 2014 10:11:48 David Gil Oliva wrote: > El 12/02/2014 09:46, "Kevin Ottens" escribió: > > On Tuesday 11 February 2014 23:19:39 David Faure wrote: > > > On Thursday 06 February 2014 23:30:25 David Faure wrote: > > > > I have packaged up KF5 alpha 1 and uploaded it for packag

Re: kde5 in [app .desktop file install] path

On Tue, Feb 11, 2014 at 09:29:24PM +, Alex Merry wrote: > > Thinking out loud: with the current efforts in making things > > co-installable, I > > wonder... it'll make .desktop files clash between kde4 and kde5. > > Already solved for kdelibs4 (by renaming the two desktop files in KF5's > >

Jenkins build is back to normal : kbookmarks_master_qt5 #24

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115683: Install app desktop files to share/applications, not in a kde5 subdir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115683/ --- (Updated Feb. 12, 2014, 10:37 a.m.) Status -- This change has been m

Re: Review Request 115683: Install app desktop files to share/applications, not in a kde5 subdir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115683/#review49647 --- This review has been submitted with commit 2ec165030b2947e6a4

Build failed in Jenkins: krunner_master_qt5 #2

See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace Running Prebuild steps [krunner_master

Build failed in Jenkins: kio_master_qt5 #65

See Changes: [adawit] Changed OpenWith dialog from Qt::ApplicationModal to Qt::WindowModal. [adawit] Changed dialogs from Qt::ApplicationModal (default) to Qt::WindowModal. -- [...truncated 800 lines...

Re: Frameworkification of kactivities and plasma-framework

> The new KRunner framework depends on, among others plasma-framework, > which in turn depends on kactivities. It is already under works, thanks to dfaure and marco. Cheers -- Make your code readable. Pretend the next person who looks at your code is a psychopath and they know where you live.

Build failed in Jenkins: kbookmarks_master_qt5 #23

See Changes: [adawit] When a user creates a new bookmark folder make that the current item. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 i

Re: alpha1 release

El 12/02/2014 09:46, "Kevin Ottens" escribió: > > On Tuesday 11 February 2014 23:19:39 David Faure wrote: > > On Thursday 06 February 2014 23:30:25 David Faure wrote: > > > I have packaged up KF5 alpha 1 and uploaded it for packagers. > > > > And alpha1 is now public ! > > > > (tarballs published,

Re: Review Request 115541: Build fix for Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115541/ --- (Updated Feb. 12, 2014, 9:05 a.m.) Status -- This change has been di

Re: kde5 in [app .desktop file install] path

On Tuesday 11 February 2014 21:29:24 Alex Merry wrote: > On 11/02/14 20:09, David Faure wrote: > > On Monday 10 February 2014 11:30:46 Alex Merry wrote: > >> On 09/02/14 23:55, Nicolas Lécureuil wrote: > >>> ./kde-modules/KDEInstallDirs.cmake:_set_fancy(XDG_APPS_INSTALL_DIR > >>> "${SHARE_INSTALL_P

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

> On Feb. 12, 2014, 12:20 a.m., Aleix Pol Gonzalez wrote: > > Makes sense to me, I most certainly didn't consider it as a problem. > > > > This could break compilation on some projects other than KParts, will you > > be able to try the rest of the modules? > > > > Thanks for figuring it out!

Re: alpha1 release

On Tuesday 11 February 2014 23:19:39 David Faure wrote: > On Thursday 06 February 2014 23:30:25 David Faure wrote: > > I have packaged up KF5 alpha 1 and uploaded it for packagers. > > And alpha1 is now public ! > > (tarballs published, git tags pushed) Woohoo! Thanks! Reminder: Alpha 2 in 17 d

Frameworkification of kactivities and plasma-framework

Hi all, Can someone please frameworkify KActivities? The CI system needs this due to a dependency loop. The new KRunner framework depends on, among others plasma-framework, which in turn depends on kactivities. Previously both these two escaped the need to be fully fledged frameworks, however as