Review Request 115613: Drop platform name from default user agent string

2014-02-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 115527: Remove not needed HAVE_X11

2014-02-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115527/#review49412 --- This review has been submitted with commit 3daf0a4900aff9d16b

Re: Review Request 115517: Do not crash if there is no QMimeData in decodeIsCutSelection

2014-02-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115517/ --- (Updated Feb. 10, 2014, 6:59 a.m.) Status -- This change has been ma

Re: Review Request 115527: Remove not needed HAVE_X11

2014-02-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115527/ --- (Updated Feb. 10, 2014, 6:59 a.m.) Status -- This change has been ma

Re: Review Request 115517: Do not crash if there is no QMimeData in decodeIsCutSelection

2014-02-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115517/#review49411 --- This review has been submitted with commit 7ce81bd9a1bf95a581

Re: Review Request 115530: Find Qt5::X11Extras only if X11 is found

2014-02-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115530/#review49408 --- This review has been submitted with commit 757fc25af49a5cdd19

Re: Review Request 115531: Only build kx(utils|errorhandler).cpp if we HAVE_X11

2014-02-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115531/#review49410 --- This review has been submitted with commit bc473053b1fe3b78b1

Re: Review Request 115531: Only build kx(utils|errorhandler).cpp if we HAVE_X11

2014-02-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115531/ --- (Updated Feb. 10, 2014, 6:56 a.m.) Status -- This change has been ma

Re: Review Request 115528: Suppress warnings if built without X11 support

2014-02-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115528/ --- (Updated Feb. 10, 2014, 6:56 a.m.) Status -- This change has been ma

Re: Review Request 115530: Find Qt5::X11Extras only if X11 is found

2014-02-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115530/ --- (Updated Feb. 10, 2014, 6:56 a.m.) Status -- This change has been ma

Re: Review Request 115528: Suppress warnings if built without X11 support

2014-02-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115528/#review49409 --- This review has been submitted with commit 0cceeaeda740adf8d5

Re: let's get ready for Google Summer of Code 2014

2014-02-09 Thread Mark Gaiser
On Mon, Feb 10, 2014 at 12:51 AM, Aleix Pol wrote: > On Sun, Feb 9, 2014 at 8:57 PM, Mark Gaiser wrote: >> >> On Sun, Feb 9, 2014 at 1:37 PM, Lydia Pintscher wrote: >> > On Tue, Feb 4, 2014 at 9:24 AM, Lydia Pintscher wrote: >> >> Hey everyone :) >> >> >> >> It is time to get ready for GSoC 201

Re: let's get ready for Google Summer of Code 2014

2014-02-09 Thread Aleix Pol
On Sun, Feb 9, 2014 at 8:57 PM, Mark Gaiser wrote: > On Sun, Feb 9, 2014 at 1:37 PM, Lydia Pintscher wrote: > > On Tue, Feb 4, 2014 at 9:24 AM, Lydia Pintscher wrote: > >> Hey everyone :) > >> > >> It is time to get ready for GSoC 2014. It's another great chance to > >> get some large projects

Review Request 115610: Hide private method behind the d-pointer in KLineEdit

2014-02-09 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115610/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Ivan Čukić
> On Feb. 9, 2014, 7:12 p.m., Ivan Čukić wrote: > > This is not something I'd give a green light for. > > > > ActivityManager/KF5 is a drop-in replacement for the current one. They > > should *not* be installed side-by-side. > > > > > > Michael Palimaka wrote: > kactivitymanagerd might be

Review Request 115606: Ommit ontologies/ dir from installing

2014-02-09 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115606/ --- Review request for KDE Frameworks and Ivan Čukić. Repository: kactivities

Re: let's get ready for Google Summer of Code 2014

2014-02-09 Thread Mark Gaiser
On Sun, Feb 9, 2014 at 1:37 PM, Lydia Pintscher wrote: > On Tue, Feb 4, 2014 at 9:24 AM, Lydia Pintscher wrote: >> Hey everyone :) >> >> It is time to get ready for GSoC 2014. It's another great chance to >> get some large projects done this year and welcome new enthusiastic >> people to KDE. I a

Re: Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Hrvoje Senjan
> On Feb. 9, 2014, 7:12 p.m., Ivan Čukić wrote: > > This is not something I'd give a green light for. > > > > ActivityManager/KF5 is a drop-in replacement for the current one. They > > should *not* be installed side-by-side. > > > > > > Michael Palimaka wrote: > kactivitymanagerd might be

Review Request 115605: Rename plasmapkg

2014-02-09 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/ --- Review request for KDE Frameworks, Plasma and Sebastian Kügler. Repositor

Re: Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Michael Palimaka
> On Feb. 9, 2014, 7:12 p.m., Ivan Čukić wrote: > > This is not something I'd give a green light for. > > > > ActivityManager/KF5 is a drop-in replacement for the current one. They > > should *not* be installed side-by-side. > > > > > > Michael Palimaka wrote: > kactivitymanagerd might be

Re: Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Ivan Čukić
> On Feb. 9, 2014, 7:12 p.m., Ivan Čukić wrote: > > This is not something I'd give a green light for. > > > > ActivityManager/KF5 is a drop-in replacement for the current one. They > > should *not* be installed side-by-side. > > > > > > Michael Palimaka wrote: > kactivitymanagerd might be

Re: Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Michael Palimaka
> On Feb. 9, 2014, 7:12 p.m., Ivan Čukić wrote: > > This is not something I'd give a green light for. > > > > ActivityManager/KF5 is a drop-in replacement for the current one. They > > should *not* be installed side-by-side. > > > > kactivitymanagerd might be drop in, but the rest of the fram

Re: Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115602/#review49377 --- This is not something I'd give a green light for. ActivityMan

Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115602/ --- Review request for KDE Frameworks and Ivan Čukić. Repository: kactivities

Review Request 115597: Move customization directory from ksgmltools2 to kdoctools5

2014-02-09 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115597/ --- Review request for Documentation and KDE Frameworks. Repository: kdoctool

Re: Review Request 115586: Improve attica tests

2014-02-09 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115586/ --- (Updated Feb. 9, 2014, 2:49 p.m.) Review request for KDE Frameworks and M

Re: Review Request 115586: Improve attica tests

2014-02-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115586/#review49343 --- All looks good, but I'm not sure about removing the broken Pri

Re: Review Request 115541: Build fix for Mac OS X

2014-02-09 Thread David Faure
> On Feb. 8, 2014, 10:07 a.m., David Faure wrote: > > Urgh, we were hoping this wouldn't be an issue. > > > > This commit would break #include , so it cannot go in. > > > > All "namespaced" frameworks do it this way already btw, see kparts for > > instance: > > > > -- Up-to-date: > > /d/kde/

Re: let's get ready for Google Summer of Code 2014

2014-02-09 Thread Lydia Pintscher
On Tue, Feb 4, 2014 at 9:24 AM, Lydia Pintscher wrote: > Hey everyone :) > > It is time to get ready for GSoC 2014. It's another great chance to > get some large projects done this year and welcome new enthusiastic > people to KDE. I am working on our application. > I have started our ideas page a