Re: HAVE_X11 usage in KIO/core

2014-02-07 Thread Albert Astals Cid
El Divendres, 7 de febrer de 2014, a les 15:25:42, Kevin Krammer va escriure: > On Friday, 2014-02-07, 09:51:27, Martin Gräßlin wrote: > > On Friday 07 February 2014 09:38:41 Kevin Krammer wrote: > > > On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote: > > > > I'm wondering what to do about it.

Repository rename and consequences

2014-02-07 Thread Ben Cooksley
Hello all, Sysadmin has received a request to rename the repository "kwallet" (currently located at kde/kdeutils) to "kwalletmanager" in order to free this name up. Once that has been completed, the repository "kwallet-framework" (located at frameworks/) will be renamed to "kwallet". This will h

Re: Review Request 115525: Deprecate slots in KCompletion and convert into slots the methods they call

2014-02-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115525/#review49223 --- This review has been submitted with commit dd549ccab603ec0df4

Re: Review Request 115525: Deprecate slots in KCompletion and convert into slots the methods they call

2014-02-07 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115525/ --- (Updated Feb. 7, 2014, 8:44 p.m.) Status -- This change has been mar

Review Request 115541: Build fix for Mac OS X

2014-02-07 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115541/ --- Review request for KDE Frameworks. Repository: attica Description -

Jenkins build is back to normal : plasma-framework_master_qt5 #1136

2014-02-07 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #1135

2014-02-07 Thread KDE CI System
See Changes: [kde] Fix spelling in comment [kde] Set paneltoolbox properties on construction -- [...truncated 669 lines...] [ 35%] [ 35%] Building CXX object src/plasma/CMakeFiles/KF5Pla

Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them

2014-02-07 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/ --- (Updated Feb. 7, 2014, 4:54 p.m.) Review request for KDE Frameworks and I

Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them

2014-02-07 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/ --- Review request for KDE Frameworks. Repository: qca Description ---

Re: Review Request 115495: Make kgenframeworksapidox generate dependency diagrams

2014-02-07 Thread Aurélien Gâteau
> On Feb. 6, 2014, 1:56 p.m., Alex Merry wrote: > > Instant issue: the README.md claims that yapgvb is only needed to generate > > the diagrams, but not having it installed causes kgenframeworksapidocs to > > fail with an ImportError (it imports depdiagram, which imports yapgvb). > > You need

Re: Review Request 115495: Make kgenframeworksapidox generate dependency diagrams

2014-02-07 Thread Alex Merry
> On Feb. 6, 2014, 12:56 p.m., Alex Merry wrote: > > Instant issue: the README.md claims that yapgvb is only needed to generate > > the diagrams, but not having it installed causes kgenframeworksapidocs to > > fail with an ImportError (it imports depdiagram, which imports yapgvb). > > You nee

Re: alpha1 release

2014-02-07 Thread Martin Klapetek
On Fri, Feb 7, 2014 at 7:20 AM, Kevin Ottens wrote: > > No chance to aim it for alpha 2? That'd be the preferred option. > Alpha 2 seems ok actually. I'm about 80% done. Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list

Re: Review Request 115528: Suppress warnings if built without X11 support

2014-02-07 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115528/#review49201 --- Ship it! Ship It! - Aurélien Gâteau On Feb. 7, 2014, 9:30

Re: Review Request 115527: Remove not needed HAVE_X11

2014-02-07 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115527/#review49202 --- Ship it! Ship It! - Aurélien Gâteau On Feb. 7, 2014, 9:01

Re: HAVE_X11 usage in KIO/core

2014-02-07 Thread Kevin Krammer
On Friday, 2014-02-07, 09:51:27, Martin Gräßlin wrote: > On Friday 07 February 2014 09:38:41 Kevin Krammer wrote: > > On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote: > > > I'm wondering what to do about it. The best would be to use > > > QGuiApplication::platformName, but it's a core app. A

Re: HAVE_X11 usage in KIO/core

2014-02-07 Thread Alex Merry
On 07/02/14 11:45, Aleix Pol wrote: > On Fri, Feb 7, 2014 at 9:51 AM, Martin Gräßlin > wrote: > > On Friday 07 February 2014 09:38:41 Kevin Krammer wrote: > > On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote: > > > Hi, > > > > > > I found some H

Re: Review Request 115421: Clean up the CMakeLists.txt files

2014-02-07 Thread Alex Merry
On 07/02/14 08:58, David Faure wrote: > On Saturday 01 February 2014 13:27:49 Alex Merry wrote: >> - KStyle can once again be built standalone > > Is there any reason for this? > > I ask because I noticed that this was another place where the KF5 version had > to be updated at release time, the

Re: Review Request 115421: Clean up the CMakeLists.txt files

2014-02-07 Thread David Faure
On Saturday 01 February 2014 13:27:49 Alex Merry wrote: > - KStyle can once again be built standalone Is there any reason for this? I ask because I noticed that this was another place where the KF5 version had to be updated at release time, the only one that is not in frameworks/*/CMakeLists.tx

Re: Building frameworks: docbook problems

2014-02-07 Thread David Faure
On Monday 03 February 2014 22:08:20 Andriy Rysin wrote: > I am trying to build frameworks using > http://community.kde.org/Frameworks/Building on Fedora 20 and it failes > in several modules due to some docbook problem, e.g. in kconfigwidgets: > > Scanning dependencies of target kstandardactiontes

Re: Review Request 115398: rename dbus interface to prevent clashes with khtml from kdelibs4

2014-02-07 Thread David Faure
On Thursday 30 January 2014 12:38:15 Jonathan Riddell wrote: > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115398/ > --- > > Rev

Re: Re: Re: HAVE_X11 usage in KIO/core

2014-02-07 Thread Martin Gräßlin
On Friday 07 February 2014 12:45:47 Aleix Pol wrote: > On Fri, Feb 7, 2014 at 9:51 AM, Martin Gräßlin wrote: > > On Friday 07 February 2014 09:38:41 Kevin Krammer wrote: > > > On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote: > > > > Hi, > > > > > > > > I found some HAVE_X11 not defined warn

Re: Review Request 115531: Only build kx(utils|errorhandler).cpp if we HAVE_X11

2014-02-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115531/#review49178 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 7, 2014, 8:

Re: Review Request 115530: Find Qt5::X11Extras only if X11 is found

2014-02-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115530/#review49177 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 7, 2014, 8:

Re: Re: HAVE_X11 usage in KIO/core

2014-02-07 Thread Aleix Pol
On Fri, Feb 7, 2014 at 9:51 AM, Martin Gräßlin wrote: > On Friday 07 February 2014 09:38:41 Kevin Krammer wrote: > > On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote: > > > Hi, > > > > > > I found some HAVE_X11 not defined warnings in KIO and had a look at > them. > > > One of them is in cor

Re: alpha1 release

2014-02-07 Thread Alex Merry
On 07/02/14 05:25, Martin Klapetek wrote: > Hey, > > On Thu, Feb 6, 2014 at 11:30 PM, David Faure > wrote: > > I have packaged up KF5 alpha 1 and uploaded it for packagers. > > Can we consider KF5 frozen all of tomorrow (Friday 7) ? > > > I have quite some extens

Re: Taking over maintainer role for KConfig/KDNSSD

2014-02-07 Thread Alex Merry
On 06/02/14 17:12, Matthew Dawson wrote: > On February 6, 2014 12:12:18 PM Alex Merry wrote: >> Does that mean that someone else will need to take on the bulk of the >> work of merging the kdnssd repositories? >> > I assume this merging the frameworks repository with the one from network > module?

Re: Re: HAVE_X11 usage in KIO/core

2014-02-07 Thread Martin Gräßlin
On Friday 07 February 2014 09:38:41 Kevin Krammer wrote: > On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote: > > Hi, > > > > I found some HAVE_X11 not defined warnings in KIO and had a look at them. > > One of them is in core/kprotocolmanager.cpp in the following snippet. > > > > // This is

Review Request 115531: Only build kx(utils|errorhandler).cpp if we HAVE_X11

2014-02-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115531/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Review Request 115530: Find Qt5::X11Extras only if X11 is found

2014-02-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115530/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: HAVE_X11 usage in KIO/core

2014-02-07 Thread Kevin Krammer
On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote: > Hi, > > I found some HAVE_X11 not defined warnings in KIO and had a look at them. > One of them is in core/kprotocolmanager.cpp in the following snippet. > > // This is not the OS, but the windowing system, e.g. X11 on Unix/Linux. > static

Review Request 115528: Suppress warnings if built without X11 support

2014-02-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115528/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Review Request 115527: Remove not needed HAVE_X11

2014-02-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115527/ --- Review request for KDE Frameworks. Repository: kio Description ---

HAVE_X11 usage in KIO/core

2014-02-07 Thread Martin Gräßlin
Hi, I found some HAVE_X11 not defined warnings in KIO and had a look at them. One of them is in core/kprotocolmanager.cpp in the following snippet. // This is not the OS, but the windowing system, e.g. X11 on Unix/Linux. static QString platform() { #if HAVE_X11 return QL1S("X11"); #elif defi