Re: Find dependencies quietly?

On 02/02/2014 12:45 AM, Alex Merry wrote: > On 01/02/14 20:21, Stephen Kelly wrote: >> On 02/01/2014 08:22 PM, Alex Merry wrote: >>> So, I think that find_dependency should pass QUIET to find_package >>> whether or not the parent package is being found quietly. >>> >>> Do other people agree? >> I a

Build failed in Jenkins: kxmlgui_master_qt5 #35

See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace Running Prebuild steps [kxmlgui_maste

Review Request 115430: Add simple autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115430/ --- Review request for KDE Frameworks. Repository: kimageformats Descriptio

Re: Find dependencies quietly?

On 01/02/14 20:21, Stephen Kelly wrote: > On 02/01/2014 08:22 PM, Alex Merry wrote: >> So, I think that find_dependency should pass QUIET to find_package >> whether or not the parent package is being found quietly. >> >> Do other people agree? > > I agree with the problem statement, but not the so

Re: Find dependencies quietly?

On 02/01/2014 08:22 PM, Alex Merry wrote: > (CC'ing Stephen because this is relevant to the version of > find_dependency in CMake master) > > Currently, the find_dependency() macro does not pass the QUIET argument > to find_package unless the parent package was being found quietly. This > means th

Re: Review Request 115424: Improve kparts dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115424/#review48754 --- Build checked with 2.8.12.0, but see below. autotests/CMakeL

Re: Review Request 115426: Remove transitive dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115426/#review48753 --- Ship it! Works with CMake 2.8.12.0 - Alex Merry On Feb. 1,

Find dependencies quietly?

(CC'ing Stephen because this is relevant to the version of find_dependency in CMake master) Currently, the find_dependency() macro does not pass the QUIET argument to find_package unless the parent package was being found quietly. This means that feature_summary() prints out all the transitive de

Review Request 115426: Remove transitive dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115426/ --- Review request for KDE Frameworks and John Layt. Repository: kprintutils

Review Request 115424: Improve kparts dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115424/ --- Review request for KDE Frameworks and David Faure. Repository: kparts D

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

> On Feb. 1, 2014, 3:52 p.m., David Faure wrote: > > This is the only framework that installs a config-foo.h file, yes. And yes, > > that is a hack, it would be much better not to do that in the first place... I'll try to get rid of it. IIRC it's only kwindowsystem.h and that usage looked to m

Re: Review Request 115423: Move license information to its proper locations

> On Feb. 1, 2014, 5:42 p.m., Michael Palimaka wrote: > > > > Michael Palimaka wrote: > Note that the listed license, and the actual file licenses are a little > bit murky in this (and most other frameworks). Here, we have some files that > are LGPL-2 or later, some are LGPL-2.1 or later,

Re: Review Request 115423: Move license information to its proper locations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115423/ --- (Updated Feb. 1, 2014, 5:55 p.m.) Review request for KDE Frameworks, Kevi

Re: Review Request 115423: Move license information to its proper locations

> On Feb. 1, 2014, 5:42 p.m., Michael Palimaka wrote: > > > > Michael Palimaka wrote: > Note that the listed license, and the actual file licenses are a little > bit murky in this (and most other frameworks). Here, we have some files that > are LGPL-2 or later, some are LGPL-2.1 or later,

Re: Review Request 115423: Move license information to its proper locations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115423/ --- (Updated Feb. 1, 2014, 5:52 p.m.) Review request for KDE Frameworks and A

Re: Review Request 115423: Move license information to its proper locations

> On Feb. 1, 2014, 5:42 p.m., Michael Palimaka wrote: > > Note that the listed license, and the actual file licenses are a little bit murky in this (and most other frameworks). Here, we have some files that are LGPL-2 or later, some are LGPL-2.1 or later, and some that just say LGPL without a

Re: Review Request 115423: Move license information to its proper locations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115423/#review48748 --- README.md

Review Request 115423: Move license information to its proper locations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115423/ --- Review request for KDE Frameworks, Kevin Ottens and Jonathan Riddell. Rep

Re: Review Request 115416: Improve knewstuff dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115416/#review48747 --- This review has been submitted with commit 25ed1fe9aec5c40188

Re: Review Request 115416: Improve knewstuff dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115416/ --- (Updated Feb. 1, 2014, 3:35 p.m.) Status -- This change has been mar

Re: Review Request 115415: Allow kpac_proxyscout to be built again

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115415/ --- (Updated Feb. 1, 2014, 3:18 p.m.) Status -- This change has been mar

Re: Review Request 115415: Allow kpac_proxyscout to be built again

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115415/#review48746 --- This review has been submitted with commit 9f333919ac2cc4ed4f

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115148/#review48745 --- This is the only framework that installs a config-foo.h file,

Re: Tier status of attica & kwallet

On Wednesday 22 January 2014 17:35:50 Jonathan Riddell wrote: > On Thu, Jan 23, 2014 at 04:24:37AM +1100, Michael Palimaka wrote: > > attica seems to have been absorbed as a framework, but does not appear > > to have been assigned a tier. Based on its dependencies, it looks like > > it would fit in

Re: Tier status of attica & kwallet

On Friday 24 January 2014 20:33:14 Valentin Rusu wrote: > On Saturday, January 25, 2014 01:49:51 AM Michael Palimaka wrote: > > On 01/24/2014 09:21 AM, Alex Merry wrote: > > > On 23/01/14 21:50, Valentin Rusu wrote: > > >> On Thursday, January 23, 2014 11:18:02 PM Michael Palimaka wrote: > > >>> On

Review Request 115421: Clean up the CMakeLists.txt files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115421/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Re: Review Request 115419: Split KCompletionMatches declaration from kcompletion.h into own header file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115419/#review48744 --- If this is going to be split, I think the KCompletionMatches i

Re: Review Request 115325: Improve documentation of KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115325/#review48743 --- Ship it! Looks good, other than the one issue below: src/kw

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/#review48742 --- Ship it! Ship It! - Alex Merry On Feb. 1, 2014, 7:40 a.m.,

Re: Review Request 115419: Split KCompletionMatches declaration from kcompletion.h into own header file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115419/ --- (Updated Feb. 1, 2014, 11:02 a.m.) Review request for KDE Frameworks. C

Re: Review Request 115419: Split KCompletionMatches declaration from kcompletion.h into own header file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115419/ --- (Updated Feb. 1, 2014, 11 a.m.) Review request for KDE Frameworks. Chan

Re: Review Request 115415: Allow kpac_proxyscout to be built again

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115415/#review48737 --- Ship it! Oops, well spotted. - David Faure On Jan. 31, 201

Re: Review Request 114260: Port mouse dataengine

> On Dec. 8, 2013, 1:08 p.m., Bhushan Shah wrote: > > plasma/generic/dataengines/mouse/mouseengine.cpp, line 34 > > > > > > You should call init() here. Have a look at > > http://community.kde.org/Plasma/PortingT

Re: Review Request 115325: Improve documentation of KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115325/ --- (Updated Feb. 1, 2014, 9:30 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/ --- (Updated Feb. 1, 2014, 8:03 a.m.) Status -- This change has been mar

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/#review48735 --- This review has been submitted with commit 2bcd51e65f143d995a