Re: Review Request 115347: Remove Qt5Xml dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115347/#review48448 --- Ship it! "grep -irn xml *" gives me nothing, looks unused -

Review Request 115347: Remove Qt5Xml dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115347/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 115209: Fix KDoctools build on Windows

> On Jan. 27, 2014, 11:57 p.m., Luigi Toscano wrote: > > src/CMakeLists.txt, line 150 > > > > > > I think you swapped the code for the two conditions (the part with 'cmd > > /k' should be inside if (WIN32) I gue

Re: Review Request 115345: Fix kimageformats build with MSVC

> On Jan. 27, 2014, 11:36 p.m., Alex Merry wrote: > > Just ran a quick test, using the imageconverter tool in the tests/ > > directory. I created orig.pcx and orig.pic before applying the patch, with > > ./imageconverter /some/image.bmp orig.pcx > > ./imageconverter /some/image.bmp orig.pic > >

Re: Review Request 115345: Fix kimageformats build with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/ --- (Updated Jan. 28, 2014, 12:40 a.m.) Review request for KDE Frameworks and

Re: Review Request 115345: Fix kimageformats build with MSVC

> On Jan. 27, 2014, 11:29 p.m., Christoph Feck wrote: > > src/imageformats/pic_write.cpp, line 54 > > > > > > Missing ? > > > > (Question mark, because I am unsure, I did not look at either of the > > f

Re: Review Request 115209: Fix KDoctools build on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review48427 --- src/CMakeLists.txt

Re: Review Request 115337: Add --logfile-dir option

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115337/#review48426 --- This review has been submitted with commit ca32e85f2c5dcedff7

Re: Review Request 115337: Add --logfile-dir option

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115337/ --- (Updated Jan. 27, 2014, 10:49 p.m.) Status -- This change has been m

Re: Review Request 115337: Add --logfile-dir option

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115337/#review48424 --- Ship it! Ship It! - Allen Winter On Jan. 27, 2014, 6:10 p.

Re: Review Request 115345: Fix kimageformats build with MSVC

> On Jan. 27, 2014, 10:36 p.m., Alex Merry wrote: > > Just ran a quick test, using the imageconverter tool in the tests/ > > directory. I created orig.pcx and orig.pic before applying the patch, with > > ./imageconverter /some/image.bmp orig.pcx > > ./imageconverter /some/image.bmp orig.pic > >

Re: Review Request 115345: Fix kimageformats build with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/#review48422 --- Just ran a quick test, using the imageconverter tool in the te

Re: Review Request 115345: Fix kimageformats build with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/#review48421 --- src/imageformats/pic_write.cpp

Re: Review Request 115344: With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/ --- (Updated Jan. 27, 2014, 11:22 p.m.) Review request for KDE Frameworks.

Review Request 115345: Fix kimageformats build with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/ --- Review request for KDE Frameworks, kdewin and Alex Merry. Repository: kim

Re: Review Request 115344: With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/#review48418 --- We use to do so in the CMake files (as more than one source fi

Review Request 115344: With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/ --- Review request for KDE Frameworks and kdewin. Repository: kunitconversion

Review Request 115343: Fix msvc build of solid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115343/ --- Review request for KDE Frameworks. Repository: solid Description --

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

> On Jan. 27, 2014, 12:20 p.m., Alex Merry wrote: > > src/kcompletion.h, line 831 > > > > > > Does doxygen properly generate a link for this without the leading > > KCompletion::? Yes, it does. I've checked in

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/#review48411 --- This review has been submitted with commit 5074495472c51c5139

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- (Updated Jan. 27, 2014, 7:14 p.m.) Status -- This change has been ma

Re: Review Request 115316: Add demo for KRecentFileList

> On Jan. 27, 2014, 2:23 a.m., Aleix Pol Gonzalez wrote: > > It's a test, not a demo. If you want, it's for demonstrating the developer > > that he did it right, but I wouldn't see it as documentation. > > > > I would rename it to KRecentFilesActionTest > > Kevin Ottens wrote: > Yes, defin

Review Request 115337: Add --logfile-dir option

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115337/ --- Review request for KDE Frameworks, Aurélien Gâteau and Allen Winter. Repo

Re: Review Request 115332: Add a --quiet option

> On Jan. 27, 2014, 5:37 p.m., Aurélien Gâteau wrote: > > Looks good, but I would suggest using Python logging module instead of > > writing our own. Basic usage should be as simple as: > > > > # setup > > import logging > > > > ... parse args... > > > > if args.quiet: > > minlevel = logg

Re: Review Request 115332: Add a --quiet option

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115332/#review48402 --- Looks good, but I would suggest using Python logging module in

Review Request 115336: Change syntax of kservice_desktop_to_json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115336/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 115268: Replace the KDE_ENABLE_EXCEPTIONS variable with a pair of functions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115268/ --- (Updated Jan. 27, 2014, 4:31 p.m.) Status -- This change has been ma

Review Request 115332: Add a --quiet option

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115332/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapido

Re: Review Request 115218: rename dbus interface file on install for kwallet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115218/ --- (Updated Jan. 27, 2014, 4:10 p.m.) Status -- This change has been ma

Re: Review Request 115218: rename dbus interface file on install for kwallet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115218/#review48391 --- This review has been submitted with commit 38913b952073bbeb87

Re: Splitting kde-workspace and kde-runtime proposal

There is an existing page about slitting runtime here: http://community.kde.org/Frameworks/Epics/New_Runtime_Organization linked to from http://community.kde.org/Frameworks/Epics Alex's wiki page looks far more populated. We should make sure we avoid wiki duplication. David _

Re: Review Request 115330: Deprecate KWindowSystem::transientFor and ::groupLeader

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115330/ --- (Updated Jan. 27, 2014, 2:57 p.m.) Review request for KDE Frameworks. C

Review Request 115330: Deprecate KWindowSystem::transientFor and ::groupLeader

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115330/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115148/ --- (Updated Jan. 27, 2014, 12:30 p.m.) Status -- This change has been m

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115148/#review48377 --- This review has been submitted with commit 20081dcf2e0cc6f4a4

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/ --- (Updated Jan. 27, 2014, 12:26 p.m.) Status -- This change has been m

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/#review48375 --- This review has been submitted with commit b2083df231dd7c6cdb

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/#review48374 --- Ship it! Just one more thing to check, then go ahead and comm

Re: Review Request 115296: Do not set CMAKE_REQUIRED_DEFINES

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115296/ --- (Updated Jan. 27, 2014, 12:05 p.m.) Status -- This change has been m

Re: Review Request 115296: Do not set CMAKE_REQUIRED_DEFINES

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115296/#review48373 --- This review has been submitted with commit 9a737f3d38ec2733f3

Re: Review Request 115295: Do not set CMAKE_REQUIRED_DEFINES

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115295/#review48372 --- This review has been submitted with commit 69334feaa5f0e8c451

Re: Review Request 115295: Do not set CMAKE_REQUIRED_DEFINES

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115295/ --- (Updated Jan. 27, 2014, 12:04 p.m.) Status -- This change has been m

Re: Review Request 115294: Add system API feature macros to CMAKE_REQUIRED_DEFINES

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115294/ --- (Updated Jan. 27, 2014, 12:03 p.m.) Status -- This change has been m

Re: Review Request 115294: Add system API feature macros to CMAKE_REQUIRED_DEFINES

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115294/#review48371 --- This review has been submitted with commit 5067d2151e6e2924e1

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

> On Jan. 27, 2014, 7:36 a.m., Kevin Ottens wrote: > > Why not... makes me want to ask the same for the other HAVE_FOO we have in > > the other frameworks. You might have opened the pandora box. :-) > > Martin Gräßlin wrote: > yes the same reasoning applies to all frameworks. Though one cou

Build failed in Jenkins: kde4support_master_qt5 #39

See -- [...truncated 625 lines...] Generating moc_kmenubar.cpp Generating moc_kmessageboxmessagehandler.cpp Generating moc_knumvalidator.cpp Generating moc_kpassivepopupmessagehandler.cpp Generating moc_k

Re: Review Request 115120: Clean up the CMake files (and a couple of other bits)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115120/ --- (Updated Jan. 27, 2014, 11:43 a.m.) Status -- This change has been m

Re: Review Request 115120: Clean up the CMake files (and a couple of other bits)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115120/#review48367 --- This review has been submitted with commit 0ee3ffb368943b8bbf

Re: Review Request 115266: Split up Mainpage.dox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115266/ --- (Updated Jan. 27, 2014, 11:42 a.m.) Status -- This change has been m

Re: Review Request 115266: Split up Mainpage.dox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115266/#review48366 --- This review has been submitted with commit fd4f980e40c9be160f

Re: Review Request 115264: Split up Mainpage.dox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115264/ --- (Updated Jan. 27, 2014, 11:41 a.m.) Status -- This change has been m

Re: Review Request 115264: Split up Mainpage.dox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115264/#review48365 --- This review has been submitted with commit c13da52f40f597dd95

Review Request 115325: Improve documentation of KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115325/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 115285: Pass the KDE_COLOR_SCHEME_PATH application property to toplevel windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115285/ --- (Updated Jan. 27, 2014, 9:06 a.m.) Status -- This change has been ma

Re: Review Request 115285: Pass the KDE_COLOR_SCHEME_PATH application property to toplevel windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115285/#review48360 --- This review has been submitted with commit 4e217314d854ef1a6a

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115230/ --- (Updated Jan. 27, 2014, 9:54 a.m.) Review request for KDE Frameworks. C

Re: Review Request 115248: Add runtime detection to KXMessages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115248/ --- (Updated Jan. 27, 2014, 9:43 a.m.) Review request for KDE Frameworks. C

Re: Review Request 115255: Add x11 platform detection to kkeyserver_x11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115255/ --- (Updated Jan. 27, 2014, 9:37 a.m.) Review request for KDE Frameworks. C

Build failed in Jenkins: kde4support_master_qt5 #38

See -- [...truncated 636 lines...] Generating moc_kvbox.cpp Generating moc_kdatatool.cpp Generating moc_kfileitemactionplugin.cpp Generating moc_kfilewriteplugin.cpp Generating moc_kscan.cpp Generating mo

Re: Review Request 115190: Add unit test for KWindowInfo on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115190/ --- (Updated Jan. 27, 2014, 8:14 a.m.) Status -- This change has been ma

Re: Review Request 115190: Add unit test for KWindowInfo on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115190/#review48357 --- This review has been submitted with commit 4814be040deecfe370

Re: Review Request 115316: Add demo for KRecentFileList

> On Jan. 27, 2014, 2:23 a.m., Aleix Pol Gonzalez wrote: > > It's a test, not a demo. If you want, it's for demonstrating the developer > > that he did it right, but I wouldn't see it as documentation. > > > > I would rename it to KRecentFilesActionTest Yes, definitely a manual test (otherwise