Re: Review Request 115285: Pass the KDE_COLOR_SCHEME_PATH application property to toplevel windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115285/#review48355 --- Ship it! Ship It! - Kevin Ottens On Jan. 24, 2014, 9:36 a.

Re: Review Request 115255: Add x11 platform detection to kkeyserver_x11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115255/#review48354 --- src/kkeyserver_x11.cpp

Re: Review Request 115248: Add runtime detection to KXMessages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115248/#review48353 --- src/kxmessages.cpp

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115230/#review48352 --- src/kselectionowner.h

Re: Review Request 115203: Allow compiling with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115203/#review48351 --- Looks good to me, opinion of someone from kdewin would be welc

Re: Review Request 115209: Fix KDoctools build on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review48350 --- Looks good to me, would be nice to have the opinion of someone

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

> On Jan. 27, 2014, 8:36 a.m., Kevin Ottens wrote: > > Why not... makes me want to ask the same for the other HAVE_FOO we have in > > the other frameworks. You might have opened the pandora box. :-) yes the same reasoning applies to all frameworks. Though one could also say that using a HAVE_F

Re: Review Request 115190: Add unit test for KWindowInfo on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115190/#review48348 --- Looks good to me, can likely go in once it's running on build.

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/#review48347 --- src/lib/kaboutdata.cpp

Re: Review Request 114989: kapidox and other components from frameworks should use kde5-config instead of kde4-config, remove kde4 references

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114989/#review48344 --- src/doxygen-preprocess-kcfg.sh

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115148/#review48343 --- Ship it! Why not... makes me want to ask the same for the oth

Re: Review Request 114997: Improve KAuth README.md

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/#review48342 --- README.md

Re: Review Request 115028: Allow the building of deprecated code to be disabled

> On Jan. 27, 2014, 2:14 a.m., Aleix Pol Gonzalez wrote: > > Shouldn't we maybe just remove these? Especially considerign they already > > are deprecated in kdelibs 4. > > > > I don't really like disabling compilation of deprecated symbols, especially > > in this case we're not winning that mu

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/ --- (Updated Jan. 27, 2014, 8:31 a.m.) Review request for KDE Frameworks. C

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/#review48339 --- Ship it! Ship It! - Kevin Ottens On Jan. 19, 2014, 3:49 p.

Re: Review Request 115268: Replace the KDE_ENABLE_EXCEPTIONS variable with a pair of functions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115268/#review48338 --- Ship it! Ship It! - Kevin Ottens On Jan. 23, 2014, 6:18 p.

Re: Review Request 115295: Do not set CMAKE_REQUIRED_DEFINES

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115295/#review48336 --- Ship it! Ship It! - Kevin Ottens On Jan. 24, 2014, 2:45 p.

Re: Review Request 115296: Do not set CMAKE_REQUIRED_DEFINES

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115296/#review48337 --- Ship it! Ship It! - Kevin Ottens On Jan. 24, 2014, 2:45 p.

Re: Review Request 115249: Add runtime detection to KUserTimestamp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115249/ --- (Updated Jan. 27, 2014, 7:25 a.m.) Status -- This change has been ma

Re: Review Request 115294: Add system API feature macros to CMAKE_REQUIRED_DEFINES

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115294/#review48334 --- Ship it! Ship It! - Kevin Ottens On Jan. 24, 2014, 2:45 p.

Re: Review Request 115249: Add runtime detection to KUserTimestamp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115249/#review48335 --- This review has been submitted with commit f14651c0ae62a90c8b

Re: Review Request 115266: Split up Mainpage.dox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115266/#review48333 --- Ship it! Ship It! - Kevin Ottens On Jan. 23, 2014, 4:43 p.

Re: Review Request 115264: Split up Mainpage.dox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115264/#review48332 --- Ship it! Ship It! - Kevin Ottens On Jan. 23, 2014, 4:15 p.

Re: Review Request 115120: Clean up the CMake files (and a couple of other bits)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115120/#review48331 --- Ship it! Ship It! - Kevin Ottens On Jan. 19, 2014, 12:23 p

Re: Schedule

Hello, On Monday 27 January 2014 00:28:25 Alex Merry wrote: > Is there a schedule anywhere? I think I wasn't the only one taken by > surprise by Kévin's announcement about the alpha last week. It was in my email about governance. > http://community.kde.org/Frameworks should either host the sch

KF5 Update Meeting 2014-w5 Reminder

Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed mes

Re: Review Request 115316: Add demo for KRecentFileList

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115316/#review48327 --- It's a test, not a demo. If you want, it's for demonstrating t

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115148/#review48326 --- Ship it! Makes sense to me. - Aleix Pol Gonzalez On Jan. 2

Re: Review Request 114997: Improve KAuth README.md

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/#review48325 --- README.md

Re: Review Request 115028: Allow the building of deprecated code to be disabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115028/#review48324 --- Shouldn't we maybe just remove these? Especially considerign t

Re: Schedule

On Mon, Jan 27, 2014 at 1:28 AM, Alex Merry wrote: > Speaking of alphas and releases... > > Is there a schedule anywhere? I think I wasn't the only one taken by > surprise by Kévin's announcement about the alpha last week. > > http://community.kde.org/Frameworks should either host the schedule o

Schedule

Speaking of alphas and releases... Is there a schedule anywhere? I think I wasn't the only one taken by surprise by Kévin's announcement about the alpha last week. http://community.kde.org/Frameworks should either host the schedule or contain a link to it. Alex _

KDECompilerSettings

A quick warning: since the alpha is looming close, and we want these changes to have the maximum testing possible, I'm going to commit the various changes to KDECompilerSettings that I have queued up tomorrow. This includes the changes currently on reviewboard, as well as a broad reorganisation of

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

> On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: > > src/kcompletion.h, line 501 > > > > > > One sentence: "This signal is emitted by makeCompletion() when a match > > is found. > > David Gil Oliva wrote: >

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- (Updated Jan. 26, 2014, 10:46 p.m.) Review request for KDE Frameworks.

Re: add test for QFileDialog::getExistingDirectory / bug?

With another addition to qfiledialogtest in frameworks/frameworkintegration another potential bug can be exposed: Calling $ ./qfiledialogtest --nameFilter "c (*.cpp)" --nameFilter "h (*.h)" --selectNameFilter "h (*.h)" does not select the second filter. Can this be confirmed or maybe I am using

Jenkins build is back to normal : frameworkintegration_master_qt5 #23

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/#review48307 --- I'll commit this if there are no objections in the next couple

Re: Review Request 115028: Allow the building of deprecated code to be disabled

Bump; does anyone have any comments on this idea? Alex On 15/01/14 13:56, Alex Merry wrote: > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115028/ > > > Review request for KDE Frameworks. > By Alex Merry. > *Repository: * kcoreaddons > > >

Re: Review Request 114997: Improve KAuth README.md

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/ --- (Updated Jan. 26, 2014, 5:39 p.m.) Review request for KDE Frameworks and

Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115148/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 115300: Fix KKeySequence shortcut types flags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115300/#review48304 --- This review has been submitted with commit d52c0bc09ec1da30dd

Re: Review Request 115300: Fix KKeySequence shortcut types flags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115300/ --- (Updated Jan. 26, 2014, 5:24 p.m.) Status -- This change has been ma

Re: Review Request 115289: Search for LibIntl, not all platforms include it in libc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/ --- (Updated Jan. 26, 2014, 5:33 p.m.) Status -- This change has been ma

add test for QFileDialog::getExistingDirectory / bug?

Hi, with 2c1ee08a21a1f16f9c2523718224598de8fc0d4f I added a test for QFileDialog::getExistingDirectory. When I execute ./qfiledialogtest --staticFunction getExistingDirectory then a dialog opens that lets the user select files but not directories. This seems to be a bug. Greetings Gregor ___

Re: Review Request 115289: Search for LibIntl, not all platforms include it in libc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/#review48298 --- Ship it! Looks good! - Alex Merry On Jan. 26, 2014, 3:54 p

Re: Review Request 115289: Search for LibIntl, not all platforms include it in libc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/ --- (Updated Jan. 26, 2014, 4:54 p.m.) Review request for KDE Frameworks and

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

> On Jan. 24, 2014, 9:09 p.m., Alex Merry wrote: > > cmake/FindLibIntl.cmake, line 26 > > > > > > Why not check if a libintl symbol exists without linking against any > > special libraries? > > Alexander Richard

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

> On Jan. 26, 2014, 7:22 a.m., István Kapcsándi wrote: > > src/CMakeLists.txt, line 17 > > > > > > maybe I'm wrong but my logic says that this should be > > install(FILES ${kglobalaccel_component_xml} DESTINA