Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

> On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: > > src/kcompletion.h, line 501 > > > > > > One sentence: "This signal is emitted by makeCompletion() when a match > > is found. Since more methods emit this si

Re: Review Request 115238: Bug in KDEPlatformFileDialogHelper(?) causes selectFile not to work in QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115238/ --- (Updated Jan. 22, 2014, 10:43 p.m.) Status -- This change has been m

Re: Review Request 115238: Bug in KDEPlatformFileDialogHelper(?) causes selectFile not to work in QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115238/#review48087 --- This review has been submitted with commit ea8f3f4a63880c5a38

Jenkins build is back to stable : ktexteditor_master_qt5 #123

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115238: Bug in KDEPlatformFileDialogHelper(?) causes selectFile not to work in QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115238/#review48086 --- Ship it! tests/qfiledialogtest.cpp

Jenkins build became unstable: ktexteditor_master_qt5 #122

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115238: Bug in KDEPlatformFileDialogHelper(?) causes selectFile not to work in QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115238/ --- (Updated Jan. 22, 2014, 10:26 p.m.) Review request for KDE Frameworks and

Review Request 115238: Bug in KDEPlatformFileDialogHelper(?) causes selectFile not to work in QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115238/ --- Review request for KDE Frameworks and David Faure. Repository: frameworki

Jenkins build is back to stable : ktexteditor_master_qt5 #121

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115239: Relocate KDE4_CREATE_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115239/#review48084 --- Ship it! As I wrote in the original review request, fine with

Re: Review Request 115237: Relocate KDE4_CREATE_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237/#review48082 --- Ship it! As I wrote in the original review request, fine with

Re: Tier status of attica & kwallet

On Wednesday 22 January 2014 22:21:47 Valentin Rusu wrote: > On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: > > Hi, > > > > attica seems to have been absorbed as a framework, but does not appear > > to have been assigned a tier. Based on its dependencies, it looks like > > it wo

Re: Review Request 115218: rename dbus interface file on install for kwallet

> On Jan. 22, 2014, 9:27 p.m., Valentin Rusu wrote: > > src/api/KWallet/CMakeLists.txt, line 100 > > > > > > The interface will be strictly the same. New features will be added to > > secret service. That's why

Jenkins build became unstable: ktexteditor_master_qt5 #120

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115239: Relocate KDE4_CREATE_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115239/ --- Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctool

Re: Review Request 115237: Relocate KDE4_CREATE_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237/ --- (Updated Jan. 22, 2014, 9:28 p.m.) Review request for KDE Frameworks and

Re: Review Request 115218: rename dbus interface file on install for kwallet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115218/#review48079 --- src/api/KWallet/CMakeLists.txt

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

> On Jan. 22, 2014, 9:08 a.m., Alex Merry wrote: > > This seems sensible to me; however, I do wonder if ECM should also provide > > an ecm_mark_gui_executable function as well (I'm thinking of the case where > > most of the tests should be non-gui, but a handful want to display widgets). > > A

Re: Tier status of attica & kwallet

On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: > Hi, > > attica seems to have been absorbed as a framework, but does not appear > to have been assigned a tier. Based on its dependencies, it looks like > it would fit in tier 1? > > kwallet is in tier 2, but since b60582640d99e0e

Review Request 115237: Relocate KDE4_CREATE_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237/ --- Review request for KDE Frameworks and Luigi Toscano. Repository: kde4supp

Review Request 115236: Get closer to compiling KIO on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 115225: Add runtime platform support to KWindowInfo

> On Jan. 22, 2014, 4:32 p.m., David Edmundson wrote: > > src/kwindowinfo.cpp, line 191 > > > > > > This seems wrong. > > > > KWindowInfo cheese; > > cheese.state(); //CRASH > > I kept the ctor as i

Re: Review Request 115225: Add runtime platform support to KWindowInfo

> On Jan. 22, 2014, 4:22 p.m., Aaron J. Seigo wrote: > > Looks quite nice, other than the missing win/mac support which you can do > > little about at this point. > > > > Use of the explicitly shared pointer approach is a simple and nice > > performance booster when passing these objects aroun

Re: kate (frameworks) build failure

Hi, On Wednesday 22 January 2014 19:12:17 Christoph Cullmann wrote: > Hi, > > in ktexteditor/document.h is: > > > // our main baseclass of the KTextEditor::Document > #include > > perhaps you need to cleanup your local include dirs ;) you're right, I knew it was my fault. Pardon me for not h

Re: kate (frameworks) build failure

Hi, in ktexteditor/document.h is: // our main baseclass of the KTextEditor::Document #include perhaps you need to cleanup your local include dirs ;) Greetings Christoph - Ursprüngliche Mail - > Hello, > > looks like building kate (frameworks branch) fails: > > In file included from

Re: Review Request 115212: Fix windows build + 1 compiler warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/ --- (Updated Jan. 22, 2014, 7:01 p.m.) Review request for KDE Frameworks. C

kate (frameworks) build failure

Hello, looks like building kate (frameworks branch) fails: In file included from /home/stefano/pkgbuild/kf5/kate- git/src/kate/kwrite/kwrite.h:25:0, from /home/stefano/pkgbuild/kf5/kate- git/src/kate/kwrite/main.cpp:21: /opt/kf5/include/KF5/KTextEditor/ktexteditor/document.h:122:

Re: Authors, maintainers and licenses in apidox

On Wed, Jan 22, 2014 at 12:27:29PM +, Alex Merry wrote: > I would be tempted to ditch the current LICENSE files (all three of > them), and add (summary) license info to README.md, as The COPYING{.LIB,.DOC} files can't go away as there must be a full copy of the licence text included with any c

Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Tier status of attica & kwallet

On Wednesday, 2014-01-22, 17:35:50, Jonathan Riddell wrote: > On Thu, Jan 23, 2014 at 04:24:37AM +1100, Michael Palimaka wrote: > > attica seems to have been absorbed as a framework, but does not appear > > to have been assigned a tier. Based on its dependencies, it looks like > > it would fit in t

Re: Tier status of attica & kwallet

On Thu, Jan 23, 2014 at 04:24:37AM +1100, Michael Palimaka wrote: > attica seems to have been absorbed as a framework, but does not appear > to have been assigned a tier. Based on its dependencies, it looks like > it would fit in tier 1? The library was renamed to KF5Attica in the expectation it c

Re: Authors, maintainers and licenses in apidox

Hello, On Wednesday 22 January 2014 12:27:29 Alex Merry wrote: > On 22/01/14 06:33, Kevin Ottens wrote: > > On Tuesday 21 January 2014 17:18:36 Alex Merry wrote: > >> Traditionally, the front pages of our apidox has included a list of > >> authors, the maintainer(s) and the license. This is obvio

Tier status of attica & kwallet

Hi, attica seems to have been absorbed as a framework, but does not appear to have been assigned a tier. Based on its dependencies, it looks like it would fit in tier 1? kwallet is in tier 2, but since b60582640d99e0ef603bf4e02df974793fb5ad27 it includes kwalletd which depends on higher tier fram

Re: Splitting kde-workspace and kde-runtime proposal

On Tuesday 21 January 2014 12:05:26 Antonis Tsiapaliokas wrote: > > 1) Create two different groups named plasma-workspace and > > plasma-desktop like frameworks > > 2) Split out every component into individual repos > > 3) Assign repos to the related group. > > > > Advantages: > > > > 1) Easy to

Re: Review Request 115202: Allow building KConfigWidgets on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 22, 2014, 6:20 p.m.) Status -- This change has been di

kjs framework build failure

Hello, In trying to build frameworks on arch here I'm getting a build error in kjs/src/kjs/operations.cpp I'm not sure what I may be missing here, others report it builds fine on other distros. The offending _isnan seems to be in the original commit also, but I haven't tried to build since the fra

Re: Review Request 115212: Fix windows build + 1 compiler warning

> On Jan. 22, 2014, 4:28 p.m., Alex Merry wrote: > > src/kgesture.cpp, lines 382-385 > > > > > > This should probably have a comment, or some helpful person will come > > along and change it back :-) Actually,

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/ --- (Updated Jan. 22, 2014, 4:43 p.m.) Status -- This change has been ma

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review48059 --- This review has been submitted with commit fa347de2f5c5954393

Re: Review Request 115221: Allow to co-install kjs devel files along with kde4 devel files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115221/ --- (Updated Jan. 22, 2014, 4:23 p.m.) Status -- This change has been di

Re: Review Request 115212: Fix windows build + 1 compiler warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/#review48056 --- Ship it! Just one more thing, then feel free to commit. src

Re: Review Request 115221: Allow to co-install kjs devel files along with kde4 devel files

> On Jan. 22, 2014, 3:20 p.m., Michael Palimaka wrote: > > This is already handled by extra-cmake-modules, or am I missing something? > > Nicolas Lécureuil wrote: > maybe this is me that miss something, but i am using last ecm. Here is the change, and it should be part of 0.0.9: http://qui

Re: Review Request 115221: Allow to co-install kjs devel files along with kde4 devel files

> On Jan. 22, 2014, 3:20 p.m., Michael Palimaka wrote: > > This is already handled by extra-cmake-modules, or am I missing something? maybe this is me that miss something, but i am using last ecm. - Nicolas --- This is an automatically

Re: Review Request 115164: Keep tests together

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/ --- (Updated Jan. 22, 2014, 3:57 p.m.) Review request for KDE Frameworks and

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

> On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: > > Until now we had no problems with the data installed to bin/../share and > > this setup would make it impossible to have multiple independent kde > > setups on one system. > > Alexander Richardson wrote: > I know. The problem is

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/#review48048 --- QSharedData code looks right to me. Thanks. src/kwindowinfo.

Re: Review Request 115209: Fix KDoctools build on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Jan. 22, 2014, 4:12 p.m.) Review request for Documentation, KDE

Re: Review Request 115225: Add runtime platform support to KWindowInfo

> On Jan. 22, 2014, 3:22 p.m., Aaron J. Seigo wrote: > > Looks quite nice, other than the missing win/mac support which you can do > > little about at this point. > > > > Use of the explicitly shared pointer approach is a simple and nice > > performance booster when passing these objects aroun

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/#review48044 --- Looks quite nice, other than the missing win/mac support which

Re: Review Request 115203: Allow compiling with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115203/ --- (Updated Jan. 22, 2014, 4:13 p.m.) Review request for KDE Frameworks and

Re: Review Request 115221: Allow to co-install kjs devel files along with kde4 devel files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115221/#review48043 --- This is already handled by extra-cmake-modules, or am I missin

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

> On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: > > Until now we had no problems with the data installed to bin/../share and > > this setup would make it impossible to have multiple independent kde > > setups on one system. > > Alexander Richardson wrote: > I know. The problem is

Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115230/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

> On Jan. 22, 2014, 9:22 a.m., Patrick von Reth wrote: > > Until now we had no problems with the data installed to bin/../share and > > this setup would make it impossible to have multiple independent kde > > setups on one system. > > Alexander Richardson wrote: > I know. The problem is

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

> On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: > > Until now we had no problems with the data installed to bin/../share and > > this setup would make it impossible to have multiple independent kde > > setups on one system. > > Alexander Richardson wrote: > I know. The problem is

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review48036 --- This review has been submitted with commit 7cf3afc38e03d52d76

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

> On Jan. 22, 2014, 9:22 a.m., Patrick von Reth wrote: > > Until now we had no problems with the data installed to bin/../share and > > this setup would make it impossible to have multiple independent kde > > setups on one system. > > Alexander Richardson wrote: > I know. The problem is

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/ --- (Updated Jan. 22, 2014, 2:54 p.m.) Status -- This change has been ma

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115210/ --- (Updated Jan. 22, 2014, 3:53 p.m.) Status -- This change has been di

Re: Review Request 115212: Fix windows build + 1 compiler warning

> On Jan. 22, 2014, 11:52 a.m., Alex Merry wrote: > > src/systeminformation_p.h, lines 30-101 > > > > > > This seems like it belongs in conditionally-compiled source files > > (systeminformation_win.cpp and syste

Re: Review Request 115212: Fix windows build + 1 compiler warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/ --- (Updated Jan. 22, 2014, 3:49 p.m.) Review request for KDE Frameworks. R

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

> On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: > > Until now we had no problems with the data installed to bin/../share and > > this setup would make it impossible to have multiple independent kde > > setups on one system. > > Alexander Richardson wrote: > I know. The problem is

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

> On Jan. 22, 2014, 9:22 a.m., Patrick von Reth wrote: > > Until now we had no problems with the data installed to bin/../share and > > this setup would make it impossible to have multiple independent kde > > setups on one system. I know. The problem is QStandardPaths with QStandardPaths::Ge

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/ --- (Updated Jan. 22, 2014, 3:03 p.m.) Review request for KDE Frameworks and

Re: Review Request 115225: Add runtime platform support to KWindowInfo

> On Jan. 22, 2014, 2:39 p.m., David Edmundson wrote: > > src/kwindowinfo_p.h, line 80 > > > > > > Why are we ref counting ourselves instead of just using > > QExplicitlySharedDataPointer? because it was that wa

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/#review48024 --- src/kwindowinfo_p.h

Re: Review Request 115189: rename dbus interface files for kstatusnotifier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115189/#review48023 --- This review has been submitted with commit 2ff1ae73f5fab73071

Re: Review Request 115189: rename dbus interface files for kstatusnotifier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115189/ --- (Updated Jan. 22, 2014, 1:35 p.m.) Status -- This change has been ma

Re: Review Request 115222: use renamed kjscmd5 in examples

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115222/#review48021 --- This review has been submitted with commit b7673c40ffd361daee

Re: Review Request 115222: use renamed kjscmd5 in examples

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115222/ --- (Updated Jan. 22, 2014, 1:33 p.m.) Status -- This change has been ma

Jenkins build is back to stable : ktexteditor_master_qt5 #114

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115222: use renamed kjscmd5 in examples

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115222/#review48018 --- Ship it! Ship It! - Hrvoje Senjan On Jan. 22, 2014, 12:42

Re: Review Request 115222: use renamed kjscmd5 in examples

> On Jan. 22, 2014, 1:18 p.m., Hrvoje Senjan wrote: > > Ship It! Thanks, i somehow missed those :/ - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115222/#review48018 --

Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/ --- Review request for KDE Frameworks and kdewin. Repository: kwindowsystem

Re: Review Request 115189: rename dbus interface files for kstatusnotifier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115189/#review48016 --- Ship it! Ship It! - Martin Klapetek On Jan. 21, 2014, 6:40

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

> On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: > > This seems sensible to me; however, I do wonder if ECM should also provide > > an ecm_mark_gui_executable function as well (I'm thinking of the case where > > most of the tests should be non-gui, but a handful want to display widgets). > >

Re: Review Request 115185: Integrate kf5dot

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115185/#review48014 --- This review has been submitted with commit a651b7df17e42b896a

Re: Review Request 115185: Integrate kf5dot

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115185/ --- (Updated Jan. 22, 2014, 12:51 p.m.) Status -- This change has been m

Review Request 115222: use renamed kjscmd5 in examples

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115222/ --- Review request for KDE Frameworks and Hrvoje Senjan. Repository: kjsembed

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

> On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: > > This seems sensible to me; however, I do wonder if ECM should also provide > > an ecm_mark_gui_executable function as well (I'm thinking of the case where > > most of the tests should be non-gui, but a handful want to display widgets). > >

Re: Review Request 115221: Allow to co-install kjs devel files along with kde4 devel files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115221/ --- (Updated Jan. 22, 2014, 12:32 p.m.) Review request for Build System, KDE

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

> On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: > > This seems sensible to me; however, I do wonder if ECM should also provide > > an ecm_mark_gui_executable function as well (I'm thinking of the case where > > most of the tests should be non-gui, but a handful want to display widgets). > >

Re: Authors, maintainers and licenses in apidox

On 22/01/14 06:33, Kevin Ottens wrote: > On Tuesday 21 January 2014 17:18:36 Alex Merry wrote: >> Traditionally, the front pages of our apidox has included a list of >> authors, the maintainer(s) and the license. This is obviously >> duplicating/summarising information stored elsewhere, and is eas

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

> On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: > > This seems sensible to me; however, I do wonder if ECM should also provide > > an ecm_mark_gui_executable function as well (I'm thinking of the case where > > most of the tests should be non-gui, but a handful want to display widgets). Well

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review48009 --- Ship it! This seems sensible to me; however, I do wonder if E

Re: Review Request 115099: This file provides the function ecm_generate_pri_file(). Make ECMSetupVersion set PROJECT_VERSION_*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115099/#review48008 --- Ship it! Ship It! - Alex Merry On Jan. 22, 2014, 9:21 a.m.

Re: Review Request 115099: This file provides the function ecm_generate_pri_file(). Make ECMSetupVersion set PROJECT_VERSION_*

> On Jan. 21, 2014, 11:02 p.m., Alex Merry wrote: > > modules/ECMGeneratePriFile.cmake, line 13 > > > > > > I feel DEPS should really be a list, but CMake apparently doesn't have > > a join function, for some biz

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review48006 --- Well, I wouldn't expect many users in frameworks, but I can't

Re: Review Request 115185: Integrate kf5dot

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115185/#review48005 --- Ship it! Providing that you then rename it something sensible

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review48004 --- Ship it! Ship It! - Luigi Toscano On Jan. 22, 2014, 7:01 a

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

> On Jan. 22, 2014, 11:32 a.m., Aleix Pol Gonzalez wrote: > > Well, but frameworks are not only for frameworks. They're all ported > > because I ported them. > > > > OTOH, there will be non-ported applications, that's why we provide this > > warning. > > Luigi Toscano wrote: > You ported

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review48003 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 22, 2014, 7

Re: Review Request 115185: Integrate kf5dot

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115185/ --- (Updated Jan. 22, 2014, 12:42 p.m.) Review request for KDE Frameworks and

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

> On Jan. 22, 2014, 11:32 a.m., Aleix Pol Gonzalez wrote: > > Well, but frameworks are not only for frameworks. They're all ported > > because I ported them. > > > > OTOH, there will be non-ported applications, that's why we provide this > > warning. You ported KDE4_CREATE_HANDBOOK, which is

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

> On Jan. 22, 2014, 11:32 a.m., Aleix Pol Gonzalez wrote: > > Well, but frameworks are not only for frameworks. They're all ported > > because I ported them. > > > > OTOH, there will be non-ported applications, that's why we provide this > > warning. > > Luigi Toscano wrote: > You ported

Re: Review Request 115198: Fix KDE4Support compilation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115198/ --- (Updated Jan. 22, 2014, 11:40 a.m.) Status -- This change has been d

Re: Review Request 115209: Fix KDoctools build on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review47997 --- Would it be possible to unify the two "add_custom_command" by

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review47996 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 22, 2014, 1

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review47995 --- Well, but frameworks are not only for frameworks. They're all

Review Request 115218: rename dbus interface file on install for kwallet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115218/ --- Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet-

  1   2   >