Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/#review47660 --- The patch looks ago, I have two remarks: - I think that kde5op

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

> On Jan. 18, 2014, 7:46 p.m., Christoph Feck wrote: > > Hm, how does KMessageWidget behave, if you "post" the next message without > > waiting for the animation to finish? I somehow feel that the queuing should > > be done inside KMessageWidget. KMessageWidget has no post function at all. It

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/#review47655 --- Hm, how does KMessageWidget behave, if you "post" the next mes

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

> On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: > > KF5DocToolsMacros.cmake, lines 166-172 > > > > > > These should *not* be renamed, as they are compatibility macros. > > However, they should probably be move

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

> On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote: > > this would break my workflow given that I install kde4 and kf5 to different > > prefixes. I think this needs a different approach, but please don't ask me > > for it. I'm lacking ideas how we could solve this upstream. What about just re

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/ --- (Updated Jan. 18, 2014, 6:13 p.m.) Review request for KDE Frameworks, Alb

Re: Review Request 115100: Rename kmailservice/ktelnetservice binaries to kmailservice5/ktelnetservice5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115100/ --- (Updated Jan. 18, 2014, 5:49 p.m.) Review request for KDE Frameworks and

Re: Review Request 115100: Rename kmailservice/ktelnetservice binaries to kmailservice5/ktelnetservice5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115100/ --- (Updated Jan. 18, 2014, 5:48 p.m.) Review request for KDE Frameworks and

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/ --- (Updated Jan. 18, 2014, 5:47 p.m.) Review request for KDE Frameworks, Alb

Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/ --- Review request for KDE Frameworks, Albert Astals Cid and Aurélien Gâteau.

Review Request 115100: Rename kmailservice binary to kmailservice5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115100/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 115098: Adapt KParts compat-forwarding headers to new one-header-per-class policy in KParts

> On Jan. 18, 2014, 8:58 a.m., David Faure wrote: > > Why does this remove some forwarding headers? Because they are installed from the KParts module itself already, with the same forwarding include path. So no need to duplicate them in KDE4Support, or? (Only difference is those from KParts ha

Re: Review Request 115099: Add function ecm_generate_pri_file() to provide qmake support. Make ECMSetupVersion set PROJECT_VERSION_*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115099/#review47642 --- modules/ECMGeneratePriFile.cmake

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

> On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: > > KF5DocToolsMacros.cmake, lines 166-172 > > > > > > These should *not* be renamed, as they are compatibility macros. > > However, they should probably be move

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/ --- (Updated Jan. 18, 2014, 1:16 p.m.) Review request for Documentation, KDE

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

> On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: > > KF5DocToolsMacros.cmake, lines 166-172 > > > > > > These should *not* be renamed, as they are compatibility macros. > > However, they should probably be move

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

> On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: > > KF5DocToolsMacros.cmake, lines 166-172 > > > > > > These should *not* be renamed, as they are compatibility macros. > > However, they should probably be move

Review Request 115099: Add function ecm_generate_pri_file() to provide qmake support. Make ECMSetupVersion set PROJECT_VERSION_*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115099/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 115024: Remove check for X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115024/#review47629 --- This review has been submitted with commit d4ecd4c9689724476a

Re: Review Request 115024: Remove check for X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115024/ --- (Updated Jan. 18, 2014, 9:40 a.m.) Status -- This change has been ma

Re: Review Request 115024: Remove check for X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115024/#review47628 --- Ship it! Windows says "Ctrl Alt" too, so this seems correct t

Re: Review Request 115098: Adapt KParts compat-forwarding headers to new one-header-per-class policy in KParts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115098/#review47627 --- Why does this remove some forwarding headers? - David Faure

Re: Review Request 115097: KParts: Move each class into its own header/source file pair

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115097/#review47626 --- Ship it! Good work, thanks. I agree with the small SC break f