Review Request 115098: Adapt KParts compat-forwarding headers to new one-header-per-class policy in KParts

2014-01-17 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115098/ --- Review request for KDE Frameworks and David Faure. Repository: kde4suppor

Review Request 115097: KParts: Move each class into its own header/source file pair

2014-01-17 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115097/ --- Review request for KDE Frameworks and David Faure. Repository: kparts D

Review Request 115093: Add setup.py

2014-01-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115093/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapido

Re: Review Request 115087: Adapt to new attica name

2014-01-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115087/#review47616 --- This review has been submitted with commit 4464daac6e487e2fdf

Re: Review Request 115087: Adapt to new attica name

2014-01-17 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115087/ --- (Updated Jan. 17, 2014, 8:57 p.m.) Status -- This change has been ma

Re: Review Request 115087: Adapt to new attica name

2014-01-17 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115087/#review47615 --- Ship it! Ship It! - Christophe Giboudeaux On Jan. 17, 2014

Review Request 115087: Adapt to new attica name

2014-01-17 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115087/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47614 --- this would break my workflow given that I install kde4 and kf5

Re: Review Request 115086: Adapt to new attica name

2014-01-17 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115086/ --- (Updated Jan. 17, 2014, 8:23 p.m.) Status -- This change has been ma

Re: Review Request 115086: Adapt to new attica name

2014-01-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115086/#review47609 --- This review has been submitted with commit 1ffc383d0e32651e2f

Re: Review Request 115083: Python3 support

2014-01-17 Thread Alex Turbov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115083/ --- (Updated Jan. 17, 2014, 8:21 p.m.) Status -- This change has been ma

Re: Review Request 115083: Python3 support

2014-01-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115083/#review47608 --- This review has been submitted with commit 2b22c9e46afcdd6a80

Re: Review Request 115086: Adapt to new attica name

2014-01-17 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115086/#review47607 --- Ship it! Ship It! - Christophe Giboudeaux On Jan. 17, 2014

Review Request 115086: Adapt to new attica name

2014-01-17 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115086/ --- Review request for KDE Frameworks. Repository: knewstuff Description --

Re: Review Request 115083: Python3 support

2014-01-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115083/#review47594 --- Ship it! Ah, I made too many changes since I last tested with

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/#review47592 --- KF5DocToolsMacros.cmake

Jenkins build is back to normal : plasma-framework_master_qt5 #1078

2014-01-17 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #1077

2014-01-17 Thread KDE CI System
See Changes: [notmart] fix some crashes [notmart] panels in multiscreen is broken, add a todo -- [...truncated 2 lines...] Running Prebuild steps [plasma-framework_master_qt5] $ /bin/sh -

Review Request 115083: Python3 support

2014-01-17 Thread Alex Turbov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115083/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapido

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-17 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47587 --- and what if kdelibs (really, not kde-runtime?) from SC4 is not

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-17 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/ --- (Updated Jan. 17, 2014, 4:48 p.m.) Review request for Documentation, KDE

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-17 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47583 --- https://git.reviewboard.kde.org/r/115079/ is matching part in

Re: Review Request 115063: Created missing manpage for desktoptojson binary

2014-01-17 Thread Scarlett Clark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115063/ --- (Updated Jan. 17, 2014, 8:10 a.m.) Review request for Documentation, KDE

kjsembed should install variant_binding.h

2014-01-17 Thread Treeve Jelbert
kde-workspaces references variant_binding,h, which is not installed plasma/generic/dataengines/share/shareprovider.cpp: #include #include ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-f

Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-17 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobal

Re: kjsembed should install variant_binding.h

2014-01-17 Thread Aleix Pol
On Fri, Jan 17, 2014 at 4:33 PM, Treeve Jelbert wrote: > kde-workspaces references variant_binding,h, which is not installed > > > plasma/generic/dataengines/share/shareprovider.cpp: > > > #include > #include > > ___ > Kde-frameworks-devel mailing lis

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-17 Thread Scarlett Clark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/#review47582 --- docs/qt5options/CMakeLists.txt

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-17 Thread Scarlett Clark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/#review47581 --- docs/kde5options/CMakeLists.txt

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-17 Thread Scarlett Clark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/#review47580 --- docs/checkXML5/CMakeLists.txt

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-17 Thread Scarlett Clark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/#review47579 --- Correct, the CMakefiles in the manpages subdirectories need to

Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-17 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/ --- Review request for Documentation and KDE Frameworks. Repository: kdoctool

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-17 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/#review47577 --- Got this after applying this patch: [...] Linking CXX executa

Re: Review Request 115063: Created missing manpage for desktoptojson binary

2014-01-17 Thread Burkhard Lück
> On Jan. 17, 2014, 10:46 a.m., Sebastian Kügler wrote: > > Hi Scarlett, > > > > Congrats to your first patch (that I see coming by)! I think it's a useful > > contribution and as far as I can judge, almost good to go in. I've put a > > comment inline how the explanation could be further impro

Re: Review Request 114971: Remove unused common files and do not install any of them

2014-01-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114971/#review47568 --- This review has been submitted with commit eafc35d3a02fb6b0f5

Re: Review Request 114971: Remove unused common files and do not install any of them

2014-01-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114971/ --- (Updated Jan. 17, 2014, 12:35 p.m.) Status -- This change has been m

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-17 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/ --- (Updated Jan. 17, 2014, 11:30 a.m.) Review request for Documentation, KDE

Re: Review Request 114973: Remove spurious image files

2014-01-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114973/#review47564 --- This review has been submitted with commit 1db8547e62d528705a

Re: Review Request 114969: Add common files required for documentation generation

2014-01-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114969/#review47566 --- This review has been submitted with commit 655520848e85381556

Re: Review Request 114969: Add common files required for documentation generation

2014-01-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114969/ --- (Updated Jan. 17, 2014, 11:08 a.m.) Status -- This change has been m

Re: Review Request 114979: Do not install licenses

2014-01-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114979/#review47565 --- This review has been submitted with commit 43eec02513ab92b465

Re: Review Request 114972: Trim default settings from Doxyfile.global

2014-01-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114972/#review47563 --- This review has been submitted with commit 8a7650c12de04486af

Re: Review Request 115063: Created missing manpage for desktoptojson binary

2014-01-17 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115063/#review47561 --- Hi Scarlett, Congrats to your first patch (that I see coming

Re: Git merge checking

2014-01-17 Thread Alex Merry
On 16/01/14 23:53, Luigi Toscano wrote: > I can retrieve the full history using grafts. Only two details: > - flat.css, kde.css and print.css are part of the doxygen stuff, they should > be in the other repository; Good catch. > - mainfooter.html and mainheader.html have been removed from both >

Re: Q: Rules on inclusion of own headers? how to provide header inclusion kde4-compat? (was: Re: Extending ecm_generate_headers to create cross-forwarding headers?)

2014-01-17 Thread David Faure
On Thursday 16 January 2014 17:57:51 Friedrich W. H. Kossebau wrote: > Am Mittwoch, 15. Januar 2014, 12:14:59 schrieb David Faure: > > On Wednesday 15 January 2014 11:01:55 Friedrich W. H. Kossebau wrote: > > > Guess you already started to tackle that? :) Or should I give it a try > > > tonight? >

Re: Review Request 115050: Declare the correct Qt version in QCA pkg-config file.

2014-01-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115050/#review47555 --- This review has been submitted with commit 9537815da5c59032b4

Re: Review Request 115050: Declare the correct Qt version in QCA pkg-config file.

2014-01-17 Thread Uwe L. Korn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115050/ --- (Updated Jan. 17, 2014, 7:59 a.m.) Status -- This change has been ma