Re: Review Request 115050: Declare the correct Qt version in QCA pkg-config file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115050/#review47554 --- Ship it! I will commit this. - Ivan Romanov On Jan. 17, 20

Re: Review Request 114922: Add runtime windowing system platform support to KWindowEffects

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114922/#review47552 --- This review has been submitted with commit 5a7b25c93c8b97dc95

Re: Review Request 114922: Add runtime windowing system platform support to KWindowEffects

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114922/ --- (Updated Jan. 17, 2014, 7:19 a.m.) Status -- This change has been ma

Re: Review Request 114922: Add runtime windowing system platform support to KWindowEffects

> On Jan. 9, 2014, 8:24 p.m., Alex Merry wrote: > > src/kwindoweffects_dummy.cpp, line 52 > > > > > > Sort of orthogonal to the change, but is it worth doing > > windowSizes.reserve(ids.count()) here? not really

Review Request 115063: Created missing manpage for desktoptojson binary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115063/ --- Review request for Documentation, KDE Frameworks, Jonathan Riddell, and Se

Re: Review Request 115050: Declare the correct Qt version in QCA pkg-config file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115050/ --- (Updated Jan. 17, 2014, 1:03 a.m.) Review request for KDE Frameworks and

Re: Git merge checking

Alex Merry wrote: > I've done some git magic to copy the common/ directory (or, at least, > the relevant parts) from kapidox to kdoctools (where those files should > be located) in a history-preserving manner (for > https://git.reviewboard.kde.org/r/114969/). Thanks for the effort! > This can be

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115047/#review47547 --- This review has been submitted with commit da83418b559f9a3f8d

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115047/ --- (Updated Jan. 16, 2014, 11:39 p.m.) Status -- This change has been m

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115047/#review47546 --- Ship it! Much obliged :) - Chusslove Illich On Jan. 17, 20

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115047/ --- (Updated Jan. 16, 2014, 11:26 p.m.) Review request for KDE Frameworks and

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

> On Jan. 17, 2014, 12:13 a.m., Chusslove Illich wrote: > > autotests/klocalizedstringtest.cpp, line 272 > > > > > > It works for me, though I see where it should fail. Maybe I got it > > compiled with -DNDEBUG.

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

> On Jan. 17, 2014, 12:13 a.m., Chusslove Illich wrote: > > autotests/klocalizedstringtest.cpp, line 272 > > > > > > It works for me, though I see where it should fail. Maybe I got it > > compiled with -DNDEBUG.

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115047/#review47543 --- autotests/klocalizedstringtest.cpp

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115047/ --- (Updated Jan. 16, 2014, 10:57 p.m.) Review request for KDE Frameworks and

Re: Review Request 115050: Declare the correct Qt version in QCA pkg-config file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115050/#review47541 --- Patch is good. But only one issue. All Qt version specific cod

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115047/#review47540 --- The patterns worked as-is in kdelibs4, because there the order

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115047/#review47539 --- Looks fine to me, but I'll leave Chusslove to give the ship it

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115047/#review47538 --- Looks fine to me, but I'll leave Chusslove to give the ship it

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115047/ --- (Updated Jan. 16, 2014, 9:37 p.m.) Review request for KDE Frameworks and

Jenkins build is back to normal : kmediaplayer_master_qt5 #15

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kmediaplayer_master_qt5 #14

See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace Running Prebuild steps [kme

Build failed in Jenkins: kjsembed_master_qt5 #10

See -- Started by user Ben Cooksley Building remotely on LinuxSlave - 3 in workspace Running Prebuild steps [kjsembed_master_qt5] $ /bin/sh -xe /tmp/hudson

Build failed in Jenkins: kmediaplayer_master_qt5 #13

See Changes: [kde] Move contents of src/kmediaplayer into src/ -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Re: Review Request 114699: Use enums instead of ints in method types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114699/#review47536 --- This review has been submitted with commit 4196e074a92787e59e

Re: Review Request 114699: Use enums instead of ints in method types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114699/ --- (Updated Jan. 16, 2014, 7:04 p.m.) Status -- This change has been ma

Re: Review Request 115030: Install public headers for KJsEmbed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115030/ --- (Updated Jan. 16, 2014, 6:30 p.m.) Status -- This change has been ma

Build failed in Jenkins: kjsembed_master_qt5 #9

See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace Running Prebuild steps [kjsembed_mas

Re: Review Request 115030: Install public headers for KJsEmbed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115030/#review47534 --- This review has been submitted with commit abb9ac7fe0759e1d9f

Re: Review Request 114699: Use enums instead of ints in method types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114699/#review47533 --- Ship it! Seems like a good idea :) Potentially breaks the so

Re: kapidox: Add support for dependency diagrams

On 16/01/14 16:58, Aurélien Gâteau wrote: > Hi Alex, > > This patch adds support for including dependency diagrams to > kgenapidox.py. It applies on top of > kde:clones/kapidox/alexmerry/kapidox, using the frameworks branch. > > The way it works is as follow: > > Start kgenapidox.py with the --d

Re: Review Request 115030: Install public headers for KJsEmbed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115030/#review47516 --- Ship it! Still not ideal, but -- in the absence of an enthusi

Re: Review Request 115030: Install public headers for KJsEmbed

> On Jan. 16, 2014, 3:48 p.m., Alex Merry wrote: > > Still not ideal, but -- in the absence of an enthusiastic maintainer -- > > that's unlikely to change any time soon. At least this makes it usable, > > and the names shouldn't clash. :) that's the spirit! Anyway, without installing headers

Re: Review Request 115022: Remove unused dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115022/ --- (Updated Jan. 16, 2014, 3:49 p.m.) Status -- This change has been ma

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

> On Jan. 16, 2014, 2:20 p.m., Alex Merry wrote: > > Ship It! > > Alex Merry wrote: > Aurélien: you put the wrong REVIEW: line in. You'll have to close this > manually. Ohoh, the fail :( - Aurélien --- This is an automatically ge

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115049/ --- (Updated Jan. 16, 2014, 6:02 p.m.) Status -- This change has been ma

Re: Review Request 115022: Remove unused dependency

> On Jan. 16, 2014, 2:33 p.m., Commit Hook wrote: > > This review has been submitted with commit > > a61ed9a6e9751983de41c5f00fa057180a78ef6d by Aurélien Gâteau to branch > > master. > > Michael Palimaka wrote: > Where is this committed? I don't see it in the repo. > > Alex Merry wrote: >

Q: Rules on inclusion of own headers? how to provide header inclusion kde4-compat? (was: Re: Extending ecm_generate_headers to create cross-forwarding headers?)

Am Mittwoch, 15. Januar 2014, 12:14:59 schrieb David Faure: > On Wednesday 15 January 2014 11:01:55 Friedrich W. H. Kossebau wrote: > > Guess you already started to tackle that? :) Or should I give it a try > > tonight? > > Go ahead :) Some questions while I go ahead: 1. How should own headers b

kapidox: Add support for dependency diagrams

Hi Alex, This patch adds support for including dependency diagrams to kgenapidox.py. It applies on top of kde:clones/kapidox/alexmerry/kapidox, using the frameworks branch. The way it works is as follow: Start kgenapidox.py with the --dependency-diagram-dir option. It should point to a dir which

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

> On Jan. 16, 2014, 1:20 p.m., Alex Merry wrote: > > Ship It! Aurélien: you put the wrong REVIEW: line in. You'll have to close this manually. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewbo

Re: Review Request 115022: Remove unused dependency

> On Jan. 16, 2014, 1:33 p.m., Commit Hook wrote: > > This review has been submitted with commit > > a61ed9a6e9751983de41c5f00fa057180a78ef6d by Aurélien Gâteau to branch > > master. > > Michael Palimaka wrote: > Where is this committed? I don't see it in the repo. Aurélien added the wron

Re: Review Request 115022: Remove unused dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115022/#review47517 --- This review has been submitted with commit 5e4482cbbdae91e436

Re: Review Request 115030: Install public headers for KJsEmbed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115030/ --- (Updated Jan. 16, 2014, 2:33 p.m.) Review request for KDE Frameworks. C

Re: Review Request 115022: Remove unused dependency

> On Jan. 16, 2014, 1:33 p.m., Commit Hook wrote: > > This review has been submitted with commit > > a61ed9a6e9751983de41c5f00fa057180a78ef6d by Aurélien Gâteau to branch > > master. Where is this committed? I don't see it in the repo. - Michael

Re: Review Request 115030: Install public headers for KJsEmbed

> On Jan. 16, 2014, 1:52 p.m., Alex Merry wrote: > > src/kjsembed/CMakeLists.txt, lines 38-39 > > > > > > These don't look like public headers; are they really needed? > > > > Pointer isn't even namespace

Re: Review Request 115030: Install public headers for KJsEmbed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115030/#review47503 --- src/kjsembed/CMakeLists.txt

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115047/#review47502 --- Can we get a unit test for this, please? - Alex Merry On Ja

Re: Review Request 115022: Remove unused dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115022/ --- (Updated Jan. 16, 2014, 1:33 p.m.) Status -- This change has been ma

Re: Review Request 115022: Remove unused dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115022/#review47501 --- This review has been submitted with commit a61ed9a6e9751983de

Re: Review Request 115022: Remove unused dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115022/#review47500 --- Ship it! Looks good to me. - Aurélien Gâteau On Jan. 15, 2

Re: Review Request 114699: Use enums instead of ints in method types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114699/ --- (Updated Jan. 16, 2014, 1:28 p.m.) Review request for KDE Frameworks and

Re: Review Request 115026: Remove commented out code for QX11EmbedContainer/WhatsThis

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115026/ --- (Updated Jan. 16, 2014, 1:21 p.m.) Status -- This change has been ma

Re: Review Request 115026: Remove commented out code for QX11EmbedContainer/WhatsThis

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115026/#review47499 --- This review has been submitted with commit 81ce5b6c9bfd4c6032

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115049/#review47498 --- Ship it! Ship It! - Alex Merry On Jan. 16, 2014, 12:58 p.m

Re: Review Request 115026: Remove commented out code for QX11EmbedContainer/WhatsThis

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115026/#review47497 --- Ship it! Lets keep the X11Embed Pandora box closed :) - Auré

Review Request 115050: Declare the correct Qt version in QCA pkg-config file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115050/ --- Review request for KDE Frameworks and Ivan Romanov. Repository: qca Des

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

> On Jan. 16, 2014, 12:11 p.m., Aleix Pol Gonzalez wrote: > > autotests/ktranscripttest.cpp, line 52 > > > > > > This limits the cwd. Maybe you can pass it as a preprocess definition? > > aka with add_definiti

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115049/ --- (Updated Jan. 16, 2014, 1:58 p.m.) Review request for KDE Frameworks and

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

> On Jan. 16, 2014, 11:11 a.m., Aleix Pol Gonzalez wrote: > > autotests/ktranscripttest.cpp, line 52 > > > > > > This limits the cwd. Maybe you can pass it as a preprocess definition? > > aka with add_definiti

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

> On Jan. 16, 2014, 12:11 p.m., Aleix Pol Gonzalez wrote: > > autotests/ktranscripttest.cpp, line 52 > > > > > > This limits the cwd. Maybe you can pass it as a preprocess definition? > > aka with add_definiti

Git merge checking

I've done some git magic to copy the common/ directory (or, at least, the relevant parts) from kapidox to kdoctools (where those files should be located) in a history-preserving manner (for https://git.reviewboard.kde.org/r/114969/). This can be found at kde:clones/kdoctools/alexmerry/kapidox-merg

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115049/#review47490 --- autotests/ktranscripttest.cpp

Review Request 115049: Do not require ktranscript to be installed for the test to run

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115049/ --- Review request for KDE Frameworks and Chusslove Illich. Bugs: 329994

Re: Review Request 115016: Make KJob usable from QML

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115016/#review47489 --- This review has been submitted with commit 08f24ddc85bd6c6409

Re: Review Request 115016: Make KJob usable from QML

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115016/ --- (Updated Jan. 16, 2014, 11:06 a.m.) Status -- This change has been m

Re: Review Request 115016: Make KJob usable from QML

On Wed, Jan 15, 2014, at 4:43, Kevin Krammer wrote: > On Tuesday, 2014-01-14, 23:12:56, Aurélien Gâteau wrote: > > > On Jan. 14, 2014, 9:20 p.m., Alex Merry wrote: > > > > src/lib/jobs/kjob.h, line 92 > > > > > > > line92>>