Re: Review Request 114962: Improve dependency specifications

2014-01-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/#review47231 --- Ship it! This should be using QT_REQUIRED_VERSION everywhere.

Re: Review Request 114961: Improve dependency specifications

2014-01-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114961/#review47230 --- Ship it! Just one issue, then it can go in. autotests/CMake

Review Request 114973: Remove spurious image files

2014-01-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114973/ --- Review request for KDE Frameworks. Repository: kapidox Description

Review Request 114972: Trim default settings from Doxyfile.global

2014-01-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114972/ --- Review request for KDE Frameworks. Repository: kapidox Description

Re: Review Request 114971: Remove unused common files and do not install any of them

2014-01-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114971/ --- (Updated Jan. 11, 2014, 6:49 p.m.) Review request for KDE Frameworks. R

Re: Review Request 114969: Add common files required for documentation generation

2014-01-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114969/ --- (Updated Jan. 11, 2014, 6:41 p.m.) Review request for KDE Frameworks. C

Review Request 114971: Remove unused common files and do not install any of them

2014-01-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114971/ --- Review request for KDE Frameworks. Repository: kapidox Description

Review Request 114969: Add common files required for documentation generation

2014-01-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114969/ --- Review request for KDE Frameworks. Repository: kdoctools Description --

Re: KF5Config - module config won't get right include path

2014-01-11 Thread Valentin Rusu
On 01/11/2014 01:26 PM, Alex Merry wrote: > On 11/01/14 09:32, Valentin Rusu wrote: >> /home/kde5/src/frameworks/kwallet-framework/src/runtime/kwalletd/main.cpp:24:19: >> fatal error: KConfig: No such file or directory >> #include > > My local copy looks fine, and all the other frameworks that d

Jenkins build became unstable: ktexteditor_master_qt5 #12

2014-01-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : ktexteditor_master_qt5 #11

2014-01-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KF5Config - module config won't get right include path

2014-01-11 Thread Alex Merry
On 11/01/14 09:32, Valentin Rusu wrote: > cd /home/kde5/build/frameworks/kwallet-framework/src/runtime/kwalletd && > /usr/bin/c++ -DKCOREADDONS_LIB -DKDE_DEFAULT_DEBUG_AREA=285 > -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_CAST_FROM_ASCII > -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII > -DQT_NO_SIGNA

Review Request 114962: Improve dependency specifications

2014-01-11 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 114960: Fix build without X

2014-01-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114960/#review47185 --- This review has been submitted with commit 8abcad6de5017ad5de

Re: Review Request 114960: Fix build without X

2014-01-11 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114960/ --- (Updated Jan. 11, 2014, 10:40 a.m.) Status -- This change has been m

Re: Review Request 114960: Fix build without X

2014-01-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114960/#review47183 --- Ship it! Ship It! - Martin Gräßlin On Jan. 11, 2014, 3:21

KF5Config - module config won't get right include path

2014-01-11 Thread Valentin Rusu
Hello List, While porting kwalletd to KF5, and still working on getting used to the new build system, I encounter a problem with KF5Config include paths. I have the following line in my CMakeLists.txt : find_package(KF5Config CONFIG REQUIRED) However, when compiling, it won't add the -I directiv