Re: Review Request 114917: KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114917/ --- (Updated Jan. 8, 2014, 11:23 p.m.) Status -- This change has been ma

Re: Review Request 114917: KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114917/#review47090 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 8, 2014, 10

Re: KTextEditor & Frameworks question

On 08/01/14 22:24, Kevin Ottens wrote: > I also modified a bit one of the policies: > http://community.kde.org/Frameworks/Policies#Frameworks_buildsystem_is_consistent > (was saying "installation rules" but it's really more about style of the > buildsystem, we might want to reference aurélien's te

Re: Review Request 114917: KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114917/ --- (Updated Jan. 8, 2014, 10:57 p.m.) Review request for KDE Frameworks. C

Re: Review Request 114917: KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114917/#review47089 --- I'll leave someone who knows this better (David Faure?) to say

Re: KTextEditor & Frameworks question

On Tuesday 07 January 2014 20:48:39 David Faure wrote: > The checklist for new frameworks can be extracted from > http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation > which gives: > > * make new repo using script (done, in your case) > * run astyle-kdelibs (requires some patching,

Review Request 114917: KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114917/ --- Review request for KDE Frameworks. Repository: kconfig Description

Build failed in Jenkins: sonnet_master_qt5 #7

See Changes: [martin.sandsmark] Start adding back language detection from SVN branch. [martin.sandsmark] Add trigrams. [martin.sandsmark] Add the TextBreaks class. [martin.sandsmark] Add support for finding paragraph breaks to TextBreaks.

Re: KDE Frameworks: Moving toward 5.0 final and Governance

On Wednesday 08 January 2014 12:21:10 John Layt wrote: > it may > be better moved to KDE4Support, along with KPrintPreview, leaving an > empty repo. If that's the conclusion, then an option is just to leave everything in the current repo, and mark the whole repo (and its individual classes) as

Re: [PATCH] Fail early if libsm is not installed

Le dimanche 29 décembre 2013 14:42:53 David Faure a écrit : > On Thursday 19 December 2013 18:10:11 Aurélien Gâteau wrote: > > Hi, > > > > Attached patch causes cmake to fail early if libsm is not installed, > > rather > > than waiting until we try to build code using it. > > > > This patch also

Re: Review Request 114888: Avoid "//" in path in generated headers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114888/#review47048 --- modules/ECMGenerateHeaders.cmake

Re: Review Request 114895: Guard against null QX11Info::connection()

> On Jan. 7, 2014, 3:14 p.m., Martin Gräßlin wrote: > > checking obviously makes sense, though it shouldn't be needed. There must > > be something else which is wrong here, too. > > > > Could you try what the value of WId is in these cases? I wouldn't be > > surprised if it were 0. > > > > Oh

Reviewboard and maintainers

Just a note that if you are the maintainer of a framework, you may want to add the following line to the .reviewboardrc file of the git repo: TARGET_PEOPLE = 'kde_username' For example, I would put TARGET_PEOPLE = 'alexmerry' This means that you get CC'd on every review request posted using RBT

Re: Review Request 114888: Avoid "//" in path in generated headers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114888/ --- (Updated Jan. 8, 2014, 1:22 p.m.) Review request for Extra Cmake Modules

Jenkins build is back to stable : kwindowsystem_master_qt5 #12

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114895: Guard against null QX11Info::connection()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114895/ --- (Updated Jan. 8, 2014, 12:18 p.m.) Status -- This change has been ma

Re: Review Request 114895: Guard against null QX11Info::connection()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114895/#review47047 --- This review has been submitted with commit 11775f9351b9fe944d

Re: Review Request 114895: Guard against null QX11Info::connection()

> On Jan. 7, 2014, 2:14 p.m., Martin Gräßlin wrote: > > checking obviously makes sense, though it shouldn't be needed. There must > > be something else which is wrong here, too. > > > > Could you try what the value of WId is in these cases? I wouldn't be > > surprised if it were 0. > > > > Oh

Re: KDE Frameworks: Moving toward 5.0 final and Governance

On 7 January 2014 23:52, Alex Merry wrote: > If these additions are something that applications would need to be > aware of, I see no issue with creating a wrapper class or some such > as-and-when we find a use for one. > > If they are something that would be hidden to applications, would you > c

Re: KDE Frameworks: Moving toward 5.0 final and Governance

On Wednesday 08 January 2014 10:56:41 John Layt wrote: > On 8 January 2014 07:17, Kevin Ottens wrote: > > For the record, if that depends on QtPrintSupport it can't make it to > > KGuiAddons (which should depend only on QtCore and QtGui). > > Good point :-) > > > I'm fine keeping it even if it's

Jenkins build is unstable: ktexteditor_master_qt5 #1

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

add_compile_options [was Re: Review Request 114885: Remove custom build types]

On 07/01/14 15:36, Stephen Kelly wrote: > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114885/ > > > I didn't follow this discussion closely enough. I'll see if I can catch up > with it later. > > > kde-modules/KDECompilerSettings.cmake >

Re: Review Request 114895: Guard against null QX11Info::connection()

> On Jan. 7, 2014, 3:14 p.m., Martin Gräßlin wrote: > > checking obviously makes sense, though it shouldn't be needed. There must > > be something else which is wrong here, too. > > > > Could you try what the value of WId is in these cases? I wouldn't be > > surprised if it were 0. > > > > Oh

Re: KDE Frameworks: Moving toward 5.0 final and Governance

On 8 January 2014 07:17, Kevin Ottens wrote: > For the record, if that depends on QtPrintSupport it can't make it to > KGuiAddons (which should depend only on QtCore and QtGui). Good point :-) > I'm fine keeping it even if it's small. OK, I'll take the chainsaw to it this weekend and see what

Re: KDE Frameworks: Moving toward 5.0 final and Governance

On 7 January 2014 23:30, Michal Humpula wrote: > If I may post a little input here. I've implemented print preview in kate > (KF5) with QPrintPreviewDialog, mainly for the reasons mentioned above. But > what I'm missing is ability to add custom configuration tabs as in > KdePrint::createPrintDial