Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS => KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Aurélien Gâteau
> On Dec. 16, 2013, 11:05 p.m., Nicolás Alvarez wrote: > > This gets rid of the annoying "ignoring unknown option '-fexceptions'" I > > kept getting when compiling threadweaver with MSVC. That's a bit surprising: flags should be the same. I suspect you have not applied the matching ECM patch f

Re: Review Request 114501: Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/#review45836 --- This review has been submitted with commit d4424389fa9f7605bd8

Re: Review Request 114501: Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/ --- (Updated Dec. 17, 2013, 7:43 a.m.) Status -- This change has been mar

Re: KF5 Update Meeting 2013-w51 Reminder

2013-12-16 Thread Aleix Pol
On Tue, Dec 17, 2013 at 2:30 AM, Àlex Fiestas wrote: > Hi there ! > > Since nobody said anything against it, let's have the last meeting of the > year, as always it will happen on #kde-devel today (Tuesday) at 4pm > Barcelona (CET / UTC+1) time. > > If you want me to do any announcement today in

KF5 Update Meeting 2013-w51 Reminder

2013-12-16 Thread Àlex Fiestas
Hi there ! Since nobody said anything against it, let's have the last meeting of the year, as always it will happen on #kde-devel today (Tuesday) at 4pm Barcelona (CET / UTC+1) time. If you want me to do any announcement today in the meeting just when the meeting starts either send it as a rep

Re: Let's get in release mode!

2013-12-16 Thread Ben Cooksley
On Tue, Dec 17, 2013 at 1:04 PM, Ben Cooksley wrote: > On Mon, Dec 16, 2013 at 10:18 AM, Kevin Ottens wrote: > >> On Sunday 15 December 2013 10:58:35 Alex Merry wrote: >> > On 14/12/13 19:30, Kevin Ottens wrote: >> > > Now we're really getting there! Epics and review board are clean, >> thanks >

Re: Let's get in release mode!

2013-12-16 Thread Ben Cooksley
On Mon, Dec 16, 2013 at 10:18 AM, Kevin Ottens wrote: > On Sunday 15 December 2013 10:58:35 Alex Merry wrote: > > On 14/12/13 19:30, Kevin Ottens wrote: > > > Now we're really getting there! Epics and review board are clean, > thanks > > > to > > > everyone who helped to get there. Now it's the t

Re: Where's kf5_add_ui_files ?

2013-12-16 Thread Aleix Pol
On Mon, Dec 16, 2013 at 10:35 PM, Chusslove Illich wrote: > > [: Albert Astals Cid :] > > This works. > > And it actually looks like things done in some other modules, so I > committed > it. Thanks for the checks. > > -- > Chusslove Illich (Часлав Илић) > >

Re: Tracking bugs in Frameworks

2013-12-16 Thread Christoph Feck
My two cents from a bug triager's point of view: 1. General * If new products/components are added, it would be nice if one of the maintainers is the default assignee, or - if the generic "kdelibs- bugs" assignee stays - they are automatically added to the CC list. In case a component is unmain

Re: Fwd: Tracking bugs in Frameworks

2013-12-16 Thread Sebastian Kügler
On Monday, December 16, 2013 19:30:25 Martin Graesslin wrote: > On Monday 16 December 2013 19:01:25 David Edmundson wrote: > > On Mon, Dec 16, 2013 at 6:08 PM, Martin Graesslin > > > On Monday 16 December 2013 11:58:35 David Edmundson wrote: > > >> I think if we did that it would be a good idea t

Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS => KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/#review45830 --- This gets rid of the annoying "ignoring unknown option '-fexcep

Re: Where's kf5_add_ui_files ?

2013-12-16 Thread Chusslove Illich
> [: Albert Astals Cid :] > This works. And it actually looks like things done in some other modules, so I committed it. Thanks for the checks. -- Chusslove Illich (Часлав Илић) signature.asc Description: This is a digitally signed message part. ___

Re: Where's kf5_add_ui_files ?

2013-12-16 Thread Albert Astals Cid
El Dilluns, 16 de desembre de 2013, a les 22:07:39, Chusslove Illich va escriure: > > [: Albert Astals Cid :] > > No, that doesn't help > > > > [ 51%] Generating ui_kgamethemeselector.h > > CMake Error: Error processing file: > > /home/frameworks/libkdegames/kf5i18nuic.cmake > How about thi

Review Request 114512: Move Qt imageformat .desktop files to kde4support

2013-12-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114512/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 114496: Rename kdewidgets to kf5designerplugin

2013-12-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114496/ --- (Updated Dec. 16, 2013, 9:06 p.m.) Review request for KDE Frameworks. Ch

Re: Where's kf5_add_ui_files ?

2013-12-16 Thread Chusslove Illich
> [: Albert Astals Cid :] > No, that doesn't help > > [ 51%] Generating ui_kgamethemeselector.h > CMake Error: Error processing file: > /home/frameworks/libkdegames/kf5i18nuic.cmake How about this instead? -- Chusslove Illich (Часлав Илић) diff --git a/tier2/ki18n/KF5I18nConfig.cmake.in b/t

Re: Review Request 114496: Rename kdewidgets to kf5designerplugin

2013-12-16 Thread Alex Merry
> On Dec. 16, 2013, 8:30 p.m., Kevin Ottens wrote: > > Shouldn't KDEWidgetsMacros.cmake be renamed too? It has been. Unless there's another file called KDEWidgetsMacros.cmake that I've missed. - Alex --- This is an automatically gener

Re: Review Request 114496: Rename kdewidgets to kf5designerplugin

2013-12-16 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114496/#review45813 --- Shouldn't KDEWidgetsMacros.cmake be renamed too? tier3/CMakeL

Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS => KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/#review45812 --- Ship it! Ship It! - Kevin Ottens On Dec. 16, 2013, 5:10 p.m

Re: Review Request 114501: Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/#review45811 --- Ship it! Ship It! - Kevin Ottens On Dec. 16, 2013, 5:10 p.m

Re: Where's kf5_add_ui_files ?

2013-12-16 Thread Albert Astals Cid
El Dilluns, 16 de desembre de 2013, a les 19:46:51, Chusslove Illich va escriure: > > [: Albert Astals Cid :] > > ki18n_wrap_ui doesn't seem to be usable outside kdelibs. > > > > [ 51%] Generating ui_kgamethemeselector.h > > CMake Error: Error processing file: /kf5i18nuic.cmake > > I guess t

Re: Review Request 114496: Rename kdewidgets to kf5designerplugin

2013-12-16 Thread Alex Merry
> On Dec. 16, 2013, 2:23 p.m., Aurélien Gâteau wrote: > > Looks good. Just replace kdewidgets with kf5designerplugin in > > superbuild/CMakeLists.txt. SuperBuild is likely going away soon, but it is > > still useful for the remaining days before the split. Yeah, I noticed that when I tried bui

Re: Can't use DNSSD

2013-12-16 Thread Albert Astals Cid
El Dilluns, 16 de desembre de 2013, a les 10:36:07, Martin Klapetek va escriure: > On Sun, Dec 15, 2013 at 11:18 PM, Albert Astals Cid wrote: > > Any reason i hage to use KF5::KF5DNSSD instead of KF5::DNSSD in > > target_link_libraries like it would seem logical due to the other > > frameworks >

Re: Where's kf5_add_ui_files ?

2013-12-16 Thread Chusslove Illich
> [: Albert Astals Cid :] > ki18n_wrap_ui doesn't seem to be usable outside kdelibs. > > [ 51%] Generating ui_kgamethemeselector.h > CMake Error: Error processing file: /kf5i18nuic.cmake I guess the proper fix is largely a matter of convention, which I don't know what it is. But does the attac

Re: Fwd: Tracking bugs in Frameworks

2013-12-16 Thread Martin Graesslin
On Monday 16 December 2013 19:01:25 David Edmundson wrote: > On Mon, Dec 16, 2013 at 6:08 PM, Martin Graesslin wrote: > > On Monday 16 December 2013 11:58:35 David Edmundson wrote: > >> I think if we did that it would be a good idea to prefix the names > >> with a common element like > >> "framew

Re: Fwd: Tracking bugs in Frameworks

2013-12-16 Thread David Edmundson
On Mon, Dec 16, 2013 at 6:08 PM, Martin Graesslin wrote: > On Monday 16 December 2013 11:58:35 David Edmundson wrote: >> I think if we did that it would be a good idea to prefix the names >> with a common element like >> "frameworks-coreaddons" "frameworks-kio" etc. > I don't think it needs the pr

Re: Review Request 114501: Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/#review45802 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 16, 2013, 5:

Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS => KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/#review45801 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Dec. 16,

Re: Let's get in release mode!

2013-12-16 Thread Kevin Ottens
Hello, On Monday 16 December 2013 15:16:42 Aurélien Gâteau wrote: > Do you want us to add ourselves as contacts in the table or do you plan to > fill it later? If the former, I would assign myself to "Get the dependency > graph generator script ready", "Have the frameworks on api.kde.org" (already

Re: Review Request 114501: Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/ --- (Updated Dec. 16, 2013, 6:10 p.m.) Review request for Build System and KDE

Review Request 114502: KDE4_ENABLE_EXCEPTIONS => KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/ --- Review request for Build System and KDE Frameworks. Repository: kdelibs

Re: Fwd: Tracking bugs in Frameworks

2013-12-16 Thread Martin Graesslin
On Monday 16 December 2013 11:58:35 David Edmundson wrote: > I think if we did that it would be a good idea to prefix the names > with a common element like > "frameworks-coreaddons" "frameworks-kio" etc. I don't think it needs the prefix. For a description, we have the product description in bugz

Review Request 114501: Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/ --- Review request for Build System and KDE Frameworks. Repository: extra-cmak

Re: Review Request 113805: Do not change the build types available with cmake

2013-12-16 Thread Aurélien Gâteau
> On Nov. 12, 2013, 8:24 p.m., Alexander Neundorf wrote: > > IMO the patch as it is is not good. > > > > Several things: > > 1) This file, is not mandatory at all with KDE frameworks. > > You can build applications using KDE frameworks libraries without it. You > > (the developer of the applica

Re: Tracking bugs in Frameworks

2013-12-16 Thread Nicolás Alvarez
El lunes, 16 de diciembre de 2013, Martin Klapetek escribió: > On Mon, Dec 16, 2013 at 11:58 AM, David Edmundson < > da...@davidedmundson.co.uk 'da...@davidedmundson.co.uk');>> wrote: > >> >> I think if we did that it would be a good idea to prefix the names >> with a common element like >> "fram

Re: Review Request 114496: Rename kdewidgets to kf5designerplugin

2013-12-16 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114496/#review45782 --- Looks good. Just replace kdewidgets with kf5designerplugin in

Re: Let's get in release mode!

2013-12-16 Thread Aurélien Gâteau
Le samedi 14 décembre 2013 20:30:14 Kevin Ottens a écrit : > Hello everyone, > > Now we're really getting there! Epics and review board are clean, thanks to > everyone who helped to get there. Now it's the time to go for the last push. > For that I opened what will be the last epic for the 5.0 rel

Review Request 114496: Rename kdewidgets to kf5designerplugin

2013-12-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114496/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Do we want to have a meeting Tomorrow Tuesday?

2013-12-16 Thread Sebastian Kügler
On Monday, December 16, 2013 12:34:11 Àlex Fiestas wrote: > I haven't seen that much action in Frameworks since it is kinda frozen and > getting prepare for splitting. > > Do we still want to hold a meeting tomorrow? I think it can be a short one, to conclude the year (and let those who do the

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1863

2013-12-16 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kdelibs_frameworks_qt5 #1862

2013-12-16 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Tracking bugs in Frameworks

2013-12-16 Thread Martin Klapetek
On Mon, Dec 16, 2013 at 11:58 AM, David Edmundson < da...@davidedmundson.co.uk> wrote: > > I think if we did that it would be a good idea to prefix the names > with a common element like > "frameworks-coreaddons" "frameworks-kio" etc. > +1. However I'd propose shorter prefix - "kf-foo" maybe? Ch

Do we want to have a meeting Tomorrow Tuesday?

2013-12-16 Thread Àlex Fiestas
I haven't seen that much action in Frameworks since it is kinda frozen and getting prepare for splitting. Do we still want to hold a meeting tomorrow? Cheers. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailm

Re: Let's get in release mode!

2013-12-16 Thread Alex Merry
On 15/12/13 21:18, Kevin Ottens wrote: > On Sunday 15 December 2013 10:58:35 Alex Merry wrote: >> I'd like to rename the makekdewidgets executable to something like >> kgendesignerplugin, to be more descriptive; this should be SC providing >> we keep the old CMake variables around, but should proba

Fwd: Tracking bugs in Frameworks

2013-12-16 Thread David Edmundson
On Sat, Dec 14, 2013 at 7:00 PM, Frank Reininghaus wrote: > Hi, > > 2013/12/14 David Edmundson: >> As we gear Frameworks up for release we need a way to track bugs that >> exist in the new Frameworks. >> >> We have two options; either we copy all the bugs in kdelibs, triaging, >> testing and movin

Re: Tracking bugs in Frameworks

2013-12-16 Thread David Faure
On Saturday 14 December 2013 19:00:04 Frank Reininghaus wrote: > IMHO, it would be much more transparent for bug triagers, developers, > and users if there was a nice 1:1 correspondence between the split > repositories/frameworks and the bugzilla products. One could argue > that each repository cou

Re: Can't use DNSSD

2013-12-16 Thread Martin Klapetek
On Sun, Dec 15, 2013 at 11:18 PM, Albert Astals Cid wrote: > > Any reason i hage to use KF5::KF5DNSSD instead of KF5::DNSSD in > target_link_libraries like it would seem logical due to the other > frameworks > naming? > This was a porting bug, sorry. I've pushed a fix, now you can use KF5:DNSSD