Re: Review Request 114363: Rename tier3 libs (not all)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114363/#review45524 --- For the record: these changes have *not* been submitted. They w

Review Request 114396: Fix KWindowSystem_X11 changeWindow signal emitting

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114396/ --- Review request for KDE Frameworks and Plasma. Repository: kdelibs Descri

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45522 --- This review has been submitted with commit 728309ac2a80cab8feb

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Dec. 11, 2013, 1:45 a.m.) Status -- This change has been mar

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45520 --- Ship it! - Aleix Pol Gonzalez On Dec. 10, 2013, 6:51 p.m., M

Re: Using KCompressionDevice with QSaveFile

On Tuesday 10 December 2013 23:31:33 David Faure wrote: > On Tuesday 10 December 2013 21:48:09 Dominik Haumann wrote: > > However, here it comes: Changing > > -KCompressionDevice device(&file, false, > > KCompressionDevice::GZip); > > +KCompressionDevice device(&file, false, > > KCo

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1841

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Using KCompressionDevice with QSaveFile

On Tuesday 10 December 2013 21:48:09 Dominik Haumann wrote: > However, here it comes: Changing > -KCompressionDevice device(&file, false, KCompressionDevice::GZip); > +KCompressionDevice device(&file, false, KCompressionDevice::None); > will run into this issue. Great. A unittest p

Re: Review Request 114187: KFormat - Add new KFormat class

> On Dec. 4, 2013, 7:32 p.m., Kevin Ottens wrote: > > Any chance for an update addressing the comments raised? > > Kevin Ottens wrote: > John, please update ASAP, it's one of the patch we're waiting for to > split. > > Alex Merry wrote: > If John is unavailable, I can take over this. >

Review Request 114394: KFormat - Add new KFormat class (take 2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114394/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository: kdeli

[Important] Breaking change - Changing framworks lib and package names

Hi all, all frameworks in tier1-tier3 now have been renamed to have KF5 prefix. This is a breaking change and you must update your projects using KF5 (I'll take care of workspace, runtime, konsole and kactivities, help with the rest is welcomed). It's ready to be pushed and I'll push it tomorrow m

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114182/ --- (Updated Dec. 10, 2013, 10:18 p.m.) Status -- This change has been ma

Re: Review Request 114363: Rename tier3 libs (not all)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114363/ --- (Updated Dec. 10, 2013, 10:18 p.m.) Status -- This change has been ma

Re: Review Request 114208: Rest of frameworks adapted to tier1 renamings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114208/#review45514 --- This review has been submitted with commit 65c3f2f569418bc6f5a

Re: Review Request 114208: Rest of frameworks adapted to tier1 renamings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114208/ --- (Updated Dec. 10, 2013, 10:18 p.m.) Status -- This change has been ma

Re: Review Request 114333: Add KF5 prefix for tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114333/#review45515 --- This review has been submitted with commit a9483bff68d44f03340

Re: Review Request 114333: Add KF5 prefix for tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114333/ --- (Updated Dec. 10, 2013, 10:18 p.m.) Status -- This change has been ma

Re: Review Request 114363: Rename tier3 libs (not all)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114363/#review45513 --- This review has been submitted with commit e8339bcbeb6aa28a9c5

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114182/#review45512 --- This review has been submitted with commit 067f1650b81302ca4f7

Re: Review Request 114389: Add KF5 prefix to Plasma and PlasmaQuick libs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114389/#review45508 --- Ship it! Ship It! - Kevin Ottens On Dec. 10, 2013, 4:51 p.m

Re: Review Request 114187: KFormat - Add new KFormat class

> On Dec. 4, 2013, 7:32 p.m., Kevin Ottens wrote: > > Any chance for an update addressing the comments raised? > > Kevin Ottens wrote: > John, please update ASAP, it's one of the patch we're waiting for to > split. > > Alex Merry wrote: > If John is unavailable, I can take over this.

Re: Using KCompressionDevice with QSaveFile

Hi David, On Wednesday 04 December 2013 14:42:19 David Faure wrote: > On Monday 02 December 2013 22:31:43 Dominik Haumann wrote: > > Hi, > > > > porting KSaveFile to QSaveFile, I stumbled into the following: > > > > // This method has been made private so that it cannot be called, > > // in orde

Re: KF5 Update Meeting Minutes 2013-w50

On 10/12/13 15:50, Àlex Fiestas wrote: > *apol: Jhon Layt has gone AWOL and he has the " KLocale API for KF5 on time > formatting and byte size formatting" working, no patches are known though. Does "he" in this sentence refer to apol or jlayt? ie: am I supposed to read this as apol simply stati

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Dec. 10, 2013, 6:51 p.m.) Review request for KDE Runtime and KDE

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

> On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote: > > kioslave/smb/kio_smb_auth.cpp, line 76 > > > > > > A > > > > xD > > Maybe we can just remove this one? > > Mark Gaiser wrote: >

Re: Review Request 114389: Add KF5 prefix to Plasma and PlasmaQuick libs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114389/#review45489 --- Ship it! Ship It! - Sebastian Kügler On Dec. 10, 2013, 4:51

Jenkins build became unstable: kdelibs_frameworks_qt5 #1840

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

> On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote: > > kioslave/smb/kio_smb_internal.cpp, line 68 > > > > > > Does it really need QDir::separator()? It seems to me like everything > > should be '/'. "could"

Review Request 114389: Add KF5 prefix to Plasma and PlasmaQuick libs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114389/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45466 --- kioslave/smb/CMakeLists.txt

KF5 Update Meeting Minutes 2013-w50

These are the minutes of Week 50 KF5 meeting. As usual it has been held on #kde-devel at 4pm (CET / UTC+1) time. Present on the meeting: dMaggot, Sho_, markg85, d_ed, vHanda, teo- mck182, apol, agateau, mgrasslin, sebas, afiestas Announcements: -By popular demand Tuesday meeting is now

Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

> On Dec. 10, 2013, 3:37 p.m., Aleix Pol Gonzalez wrote: > > tier1/kglobalaccel/KF5GlobalAccelConfig.cmake.in, line 1 > > > > > > Shouldn't that file be called KGlobalAccelConfig.cmake.in? > > > > We're not

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45467 --- If there are further objections/feedback, please share them. If

Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/#review45465 --- tier1/kglobalaccel/KF5GlobalAccelConfig.cmake.in

Re: Review Request 114377: Refresh apidox README

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/ --- (Updated Dec. 10, 2013, 2:15 p.m.) Status -- This change has been mar

Re: Review Request 114377: Refresh apidox README

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/#review45458 --- This review has been submitted with commit 3c9112c46a87d40a584

Re: Review Request 114377: Refresh apidox README

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/#review45457 --- Ship it! you have my Ship It on this. and appreciation. than

Re: Review Request 114377: Refresh apidox README

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/ --- (Updated Dec. 10, 2013, 1:56 p.m.) Status -- This change has been dis

Re: Review Request 114377: Refresh apidox README

> On Dec. 10, 2013, 1:51 p.m., Alex Merry wrote: > > Can this wait until after the split? If we keep accumulating new patches, > > it'll never happen. It definitely can wait, just wanted Adriaan and Allen to be aware I started working on apidox. Discarding it for now. - Aurélien -

Re: Review Request 114187: KFormat - Add new KFormat class

> On Dec. 4, 2013, 7:32 p.m., Kevin Ottens wrote: > > Any chance for an update addressing the comments raised? > > Kevin Ottens wrote: > John, please update ASAP, it's one of the patch we're waiting for to > split. If John is unavailable, I can take over this. - Alex --

Re: Review Request 114377: Refresh apidox README

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/#review45453 --- Can this wait until after the split? If we keep accumulating n

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

Bump.. Ok to push it? On Fri, Dec 6, 2013 at 12:44 AM, Mark Gaiser wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112463/ > Review request for KDE Runtime and KDE Frameworks. > By Mark Gaiser. > > *Updated Dec. 5, 2013, 11:44 p.m.* >

Was Installing headers in include/KF5, how to?

Le mardi 10 décembre 2013 10:09:59 Stephen Kelly a écrit : > Aurélien Gâteau wrote: > > Le lundi 9 décembre 2013 21:59:58 Stephen Kelly a écrit : > >> Aurélien Gâteau wrote: > >> > +set(INCLUDE_INSTALL_DIR ${INCLUDE_INSTALL_DIR}/KF5) > >> > >> Don't you instead want to install to ${INCLUDE_INSTAL

Re: Review Request 114336: Install all includes in a KF5 dir

Le mardi 10 décembre 2013 11:07:17 Stephen Kelly a écrit : > Aurélien Gâteau wrote: > >> when CMake 3.0.0 is depended on. > > > > Sounds good, we will be able to simplify the macro at this point then. > > The two threads on this is causing confusion. Agreed, let's continue in the newer thread.

KF5 Update Meeting 2013-w50 Reminder

Hi there ! Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel today (Tuesday) at 4pm Barcelona (CET / UTC+1) time. If you want me to do any announcement today in the meeting just when the meeting starts either send it as a reply here, or contact me in any way. See you

Re: Review Request 114336: Install all includes in a KF5 dir

Aurélien Gâteau wrote: >> when CMake 3.0.0 is depended on. > > Sounds good, we will be able to simplify the macro at this point then. The two threads on this is causing confusion. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-

Re: Missing FindCarbon.cmake

Le lundi 9 décembre 2013 21:46:19 Nicolás Alvarez a écrit : > I'm trying to build KF5 on OS X. KIdleTime, KWindowSystem and KWallet > depend on the Carbon library; they have a find_package(Carbon). > However, they all fail to find FindCarbon.cmake. It's currently > present in kde4support and in the

Re: Review Request 114336: Install all includes in a KF5 dir

Le mardi 10 décembre 2013 10:02:18 Stephen Kelly a écrit : > Aurélien Gâteau wrote: > > Le lundi 9 décembre 2013 21:56:52 Stephen Kelly a écrit : > >> Aurélien Gâteau wrote: > >> > target_include_directories(${library} INTERFACE > >> > "$ >> > ${CMAKE_INSTALL_PREFIX}/${${library}_INCLUDE_INSTALL_DI

Re: Installing headers in include/KF5, how to?

Aurélien Gâteau wrote: > Le lundi 9 décembre 2013 21:59:58 Stephen Kelly a écrit : >> Aurélien Gâteau wrote: >> > +set(INCLUDE_INSTALL_DIR ${INCLUDE_INSTALL_DIR}/KF5) >> >> Don't you instead want to install to ${INCLUDE_INSTALL_DIR}/KF5/$Name ? > > Not for all frameworks. For frameworks where a

Review Request 114377: Refresh apidox README

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114377/ --- Review request for KDE Frameworks, Adriaan de Groot and Allen Winter. Repo

Re: Review Request 114336: Install all includes in a KF5 dir

Aurélien Gâteau wrote: > Le lundi 9 décembre 2013 21:56:52 Stephen Kelly a écrit : >> Aurélien Gâteau wrote: >> > target_include_directories(${library} INTERFACE >> > "$> > ${CMAKE_INSTALL_PREFIX}/${${library}_INCLUDE_INSTALL_DIR}>" >> > ) >> >> Note that this makes the resulting package non-relo

Re: Installing headers in include/KF5, how to?

Le lundi 9 décembre 2013 21:59:58 Stephen Kelly a écrit : > Aurélien Gâteau wrote: > > +set(INCLUDE_INSTALL_DIR ${INCLUDE_INSTALL_DIR}/KF5) > > Don't you instead want to install to ${INCLUDE_INSTALL_DIR}/KF5/$Name ? Not for all frameworks. For frameworks where all headers are prefixed with 'k',

Re: Review Request 114336: Install all includes in a KF5 dir

Le lundi 9 décembre 2013 21:56:52 Stephen Kelly a écrit : > Aurélien Gâteau wrote: > > target_include_directories(${library} INTERFACE > > "$ > ${CMAKE_INSTALL_PREFIX}/${${library}_INCLUDE_INSTALL_DIR}>" > > ) > > Note that this makes the resulting package non-relocatable. If using CMake > 3.0.0,