Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/#review45449 --- This review has been submitted with commit 919fdf39a324eda79eb

Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/ --- (Updated Dec. 10, 2013, 6:41 a.m.) Status -- This change has been mar

Missing FindCarbon.cmake

I'm trying to build KF5 on OS X. KIdleTime, KWindowSystem and KWallet depend on the Carbon library; they have a find_package(Carbon). However, they all fail to find FindCarbon.cmake. It's currently present in kde4support and in the ecm 'attic' directory. Should it be installed by ecm, or copied int

Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/#review45435 --- Ship it! Ship It! - Kevin Ottens On Dec. 9, 2013, 3 p.m., M

Re: Review Request 114363: Rename tier3 libs (not all)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114363/#review45434 --- Ship it! Ship It! - Kevin Ottens On Dec. 9, 2013, 2:05 p.m.

Re: Preparing for the split

On Monday 09 December 2013 12:23:47 Martin Klapetek wrote: > On Mon, Dec 9, 2013 at 12:22 PM, Martin Klapetek > > wrote: > > In tier3 there are some frameworks with "KDE" prefix (kded, kdewebkit, > > kdewidgets), what should happend with these? I'd change it for kf5 for > > webkit and widgets -->

Re: Preparing for the split

On Monday 09 December 2013 12:22:17 Martin Klapetek wrote: > On Sun, Dec 8, 2013 at 7:03 PM, Kevin Ottens wrote: > > Hello everyone, > > > > It is now really time to gear up toward the split. So from now on please > > don't > > create any new patches for the frameworks branch of kdelibs and put a

Re: Installing headers in include/KF5, how to?

Aurélien Gâteau wrote: > +set(INCLUDE_INSTALL_DIR ${INCLUDE_INSTALL_DIR}/KF5) Don't you instead want to install to ${INCLUDE_INSTALL_DIR}/KF5/$Name ? What does _set_fancy do? Should it be removed? INCLUDE_INSTALL_DIR is set by _set_fancy in ecm. Thanks, Steve. _

Re: Review Request 114336: Install all includes in a KF5 dir

Aurélien Gâteau wrote: > target_include_directories(${library} INTERFACE > "$ ${CMAKE_INSTALL_PREFIX}/${${library}_INCLUDE_INSTALL_DIR}>" > ) Note that this makes the resulting package non-relocatable. If using CMake 3.0.0, you can specify a relative path here. With 2.8.12, you should use $ ins

Re: Review Request 114336: Install all includes in a KF5 dir

Le samedi 7 décembre 2013 14:51:33 Stephen Kelly a écrit : > Aurélien Gâteau wrote: > >> On Dec. 6, 2013, 5:15 p.m., Alexander Richardson wrote: > >> > Just wondering, should include/KF5 also be the include dir for > >> > applications that install headers e.g. for writing plugins? Since I > >> > gu

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1833

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Installing headers in include/KF5, how to?

Hi, I resumed working on setting up the header install policy discussed a few weeks ago since some of the changes are going to be simpler to do before the split. First task is: use ${CMAKE_INSTALL_PREFIX}/include/KF5 as the base header install dir instead of ${CMAKE_INSTALL_PREFIX}/include. My

Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/ --- (Updated Dec. 9, 2013, 4 p.m.) Review request for KDE Frameworks and Marti

Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/#review45390 --- Looking good as far as renaming goes, three small issues below

Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/ --- (Updated Dec. 9, 2013, 3:24 p.m.) Review request for KDE Frameworks and Ma

Review Request 114363: Rename tier3 libs (not all)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114363/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Preparing for the split

On Mon, Dec 9, 2013 at 12:22 PM, Martin Klapetek wrote: > > In tier3 there are some frameworks with "KDE" prefix (kded, kdewebkit, > kdewidgets), what should happend with these? I'd change it for kf5 for > webkit and widgets --> kf5webkit and kf5widgets, not sure about kded. > There's also KCMUtil

Re: Preparing for the split

On Sun, Dec 8, 2013 at 7:03 PM, Kevin Ottens wrote: > Hello everyone, > > It is now really time to gear up toward the split. So from now on please > don't > create any new patches for the frameworks branch of kdelibs and put all > effort > and priority toward getting the existing open patches in

Re: Review Request 114333: Add KF5 prefix for tier2

> On Dec. 8, 2013, 6:06 p.m., Kevin Ottens wrote: > > Ship It! Thanks. I'll finish tier3 (should be quick) and then merge all three at once (plus the adapting). - Martin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/#review45373 --- Imo this should be submitted renamed already, there's no advant